sr-dev October 2013

sr-dev@lists.kamailio.org

33 participants
254 discussions

git:4.0: core: resolve down to A/AAAA records when no naptr records
by Daniel-Constantin Mierla 02 Oct '13

02 Oct '13

Module: sip-router Branch: 4.0 Commit: 3253fcb7e7ef628727799a92ca68739dba3d10ca URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3253fcb… Author: Øyvind Kolbu <oyvind.kolbu(a)usit.uio.no> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Sep 30 11:15:13 2013 +0200 core: resolve down to A/AAAA records when no naptr records - try all protocols, not only UDP (cherry picked from commit b50888cf447ea3a3315e665c97f71a07bb687337) --- dns_cache.c | 10 +++++++++- resolve.c | 27 +++++++++++---------------- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/dns_cache.c b/dns_cache.c index 1243c92..5690cb6 100644 --- a/dns_cache.c +++ b/dns_cache.c @@ -2857,8 +2857,10 @@ struct hostent* dns_naptr_sip_resolvehost(str* name, unsigned short* port, naptr_bmp_t tried_bmp; struct dns_hash_entry* e; char n_proto; + char origproto; str srv_name; + origproto=*proto; he=0; if (dns_hash==0){ /* not init => use normal, non-cached version */ LOG(L_WARN, "WARNING: dns_sip_resolvehost: called before dns cache" @@ -2903,7 +2905,13 @@ struct hostent* dns_naptr_sip_resolvehost(str* name, unsigned short* port, dns_hash_put(e); } naptr_not_found: - return no_naptr_srv_sip_resolvehost(name,port,proto); + *proto = origproto; + he = no_naptr_srv_sip_resolvehost(name,port,proto); + /* fallback all the way down to A/AAAA */ + if (he==0) { + he=dns_get_he(name,dns_flags); + } + return he; } #endif /* USE_NAPTR */ diff --git a/resolve.c b/resolve.c index e739f4b..e29e189 100644 --- a/resolve.c +++ b/resolve.c @@ -1519,20 +1519,7 @@ struct hostent* no_naptr_srv_sip_resolvehost(str* name, unsigned short* port, ch } if (default_order){ for (i=0; i<list_len;i++) { - switch ( srv_proto_list[i].proto) { - case PROTO_UDP: - srv_proto_list[i].proto_pref=4; - break; - case PROTO_TCP: - srv_proto_list[i].proto_pref=3; - break; - case PROTO_TLS: - srv_proto_list[i].proto_pref=2; - break; - case PROTO_SCTP: - srv_proto_list[i].proto_pref=1; - break; - } + srv_proto_list[i].proto_pref=proto_pref_score(i);; } } @@ -1592,6 +1579,9 @@ struct hostent* no_naptr_srv_sip_resolvehost(str* name, unsigned short* port, ch if ((port)&&(*port==0)){ *port=(srv_proto_list[i].proto==PROTO_TLS)?SIPS_PORT:SIP_PORT; /* just in case we don't find another */ } + if ((proto)&&(*proto==0)){ + *proto = PROTO_UDP; + } srv_name.s=tmp_srv; srv_name.len=len; #ifdef USE_DNS_CACHE @@ -1632,9 +1622,9 @@ struct hostent* naptr_sip_resolvehost(str* name, unsigned short* port, char n_proto; str srv_name; naptr_bmp_t tried_bmp; /* tried bitmap */ + char origproto; - - + origproto = *proto; naptr_head=0; he=0; if (name->len >= MAX_DNS_NAME) { @@ -1673,7 +1663,12 @@ struct hostent* naptr_sip_resolvehost(str* name, unsigned short* port, #endif } /* fallback to srv lookup */ + *proto = origproto; he=no_naptr_srv_sip_resolvehost(name,port,proto); + /* fallback all the way down to A/AAAA */ + if (he==0) { + he=dns_get_he(name,dns_flags); + } end: if (naptr_head) free_rdata_list(naptr_head);

1 0

git:4.0: presence_xml: updated docs about integrated_xcap_server
by Daniel-Constantin Mierla 02 Oct '13

02 Oct '13

Module: sip-router Branch: 4.0 Commit: 82a23f22c1bba400304a7f44523e8db8b09ae295 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=82a23f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 26 13:23:46 2013 +0200 presence_xml: updated docs about integrated_xcap_server (cherry picked from commit 8e35cef8716bbd0caa406a5080e93acb3c881c41) --- modules/presence_xml/README | 30 +++++++++++----------- modules/presence_xml/doc/presence_xml_admin.xml | 3 +- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/modules/presence_xml/README b/modules/presence_xml/README index e42dbed..55e4b80 100644 --- a/modules/presence_xml/README +++ b/modules/presence_xml/README @@ -8,7 +8,7 @@ Edited by Anca-Maria Vamanu - Copyright © 2007 Voice Sistem SRL + Copyright � 2007 Voice Sistem SRL __________________________________________________________________ Table of Contents @@ -144,7 +144,7 @@ Chapter 1. Admin Guide The database URL. - Default value is “mysql://openser:openserrw@localhost/openser”. + Default value is "mysql://kamailio:kamailiorw@localhost/kamailio". Example 1.1. Set db_url parameter ... @@ -155,7 +155,7 @@ modparam("presence_xml", "db_url", "dbdriver://username:password@dbhost/dbname") The name of the database table where XCAP documents are stored. - Default value is “xcap”. + Default value is "xcap". Example 1.2. Set xcap_table parameter ... @@ -166,7 +166,7 @@ modparam("presence_xml", "xcap_table", "xcaps") Set this parameter to disable the handling of the "presence" event. - Default value: “0”. + Default value: "0". Example 1.3. Set disable_presence parameter ... @@ -178,7 +178,7 @@ modparam("presence_xml", "disable_presence", 1) Set this parameter to disable the handling of the "presence.winfo" event. - Default value: “0”. + Default value: "0". Example 1.4. Set disable_winfo parameter ... @@ -189,7 +189,7 @@ modparam("presence_xml", "disable_winfo", 1) Set this parameter to disable the handling of the "dialog;sla" event. - Default value: “1” (0 - enabled, 1 - disabled). + Default value: "1" (0 - enabled, 1 - disabled). Example 1.5. Set disable_bla parameter ... @@ -209,7 +209,7 @@ modparam("presence_xml", "disable_bla", 1) Note: When switching from one value to another, the watchers table must be emptied. - Default value is “0”. + Default value is "0". Example 1.6. Set force_active parameter ... @@ -229,9 +229,9 @@ modparam("presence_xml", "force_active", 1) database and, if needed, send NOTIFY updates. Otherwise, it uses xcap_client module to fetch documents from the XCAP - servers with HTTP requests. This mode is currently not supported. + servers with HTTP requests. - Default value is “0”. + Default value is "0". Example 1.7. Set integrated_xcap_server parameter ... @@ -257,7 +257,7 @@ modparam("presence_xml", "xcap_server", "xcap_server.ag.org") no connection to database. Useful when needing only to use $xml(...) pseudoc-variable. - Default value: “0” (0 - active mode, 1 - passive mode). + Default value: "0" (0 - active mode, 1 - passive mode). Example 1.9. Set passive_mode parameter ... @@ -274,7 +274,7 @@ modparam("presence_xml", "passive_mode", 1) ones defined by the RFC 3265, this parameter offers the possibility for the admin to decide which one he wishes to use. - Default value: “probation” . Since probation also accepts a retry-after + Default value: "probation" . Since probation also accepts a retry-after parameter to specify after at least how may seconds the client should reattempt to resubscribe, you can include this in the parameter also. @@ -289,7 +289,7 @@ modparam("presence_xml", "xcapauth_userdel_reason", "rejected") 4.1. pres_check_basic(presentity_uri, status) 4.2. pres_check_activities(presentity_uri, activity) -4.1. pres_check_basic(presentity_uri, status) +4.1. pres_check_basic(presentity_uri, status) Checks the /presence/tuple/status/basic nodes in the presentity for presentity_uri against the value in status. @@ -312,7 +312,7 @@ modparam("presence_xml", "xcapauth_userdel_reason", "rejected") } ... -4.2. pres_check_activities(presentity_uri, activity) +4.2. pres_check_activities(presentity_uri, activity) Checks whether a /presence/person/activities/activity node exists in the presentity for presentity_uri. @@ -339,7 +339,7 @@ modparam("presence_xml", "xcapauth_userdel_reason", "rejected") 5. Installation - The module requires one table in Kamailio database: “xcap”. The SQL + The module requires one table in Kamailio database: "xcap". The SQL syntax to create it can be found in presence-create.sql script in the database directories in the kamailio/scripts folder. You can also find the complete database documentation on the project webpage, @@ -350,7 +350,7 @@ modparam("presence_xml", "xcapauth_userdel_reason", "rejected") * $xml(name=>spec) Exported pseudo-variables are documented at - http://www.kamailio.org/dokuwiki/. + http://www.kamailio.org/wiki/. Chapter 2. Developer Guide diff --git a/modules/presence_xml/doc/presence_xml_admin.xml b/modules/presence_xml/doc/presence_xml_admin.xml index 57b4f26..840628e 100644 --- a/modules/presence_xml/doc/presence_xml_admin.xml +++ b/modules/presence_xml/doc/presence_xml_admin.xml @@ -235,8 +235,7 @@ modparam("presence_xml", "force_active", 1) </para> <para> Otherwise, it uses xcap_client module to fetch documents - from the XCAP servers with HTTP requests. This mode is - currently not supported.</para> + from the XCAP servers with HTTP requests.</para> <para> <emphasis>Default value is <quote>0</quote>. </emphasis>

1 0

Planing to release v4..0.4
by Daniel-Constantin Mierla 02 Oct '13

02 Oct '13

Hello, I am planing to release Kamailio v4.0.4 this week on Wednesday, Sep 2. If anyone has patching to push in branch 4.0, do it before noon GMT in that day. Also, if any developer is preferring another release day, just present the option on the mailing lists. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Trainings - Berlin, Nov 25-28; Miami, Nov 18-20, 2013 - more details about Kamailio trainings at http://www.asipto.com -

1 1

git:tteras/mohqueue: mohqueue: new module
by Timo Teras 02 Oct '13

02 Oct '13

Module: sip-router Branch: tteras/mohqueue Commit: 93af236644058b4e97162eae689f9b32b8076691 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=93af236… Author: Timo Teräs <timo.teras(a)iki.fi> Committer: Timo Teräs <timo.teras(a)iki.fi> Date: Wed Oct 2 09:05:22 2013 +0300 mohqueue: new module module to queue up calls in music-on-hold and then retrieve them imported from https://github.com/rdboisvert/mohqueue commit f796f259ed1728e19adb31d76af5f6c3f548f021 excluding LICENSE which is redundant now that the module is part of the kamailio source tree. --- modules/mohqueue/Makefile | 18 + modules/mohqueue/NOTES | 11 + modules/mohqueue/doc/Makefile | 4 + modules/mohqueue/doc/mohqueue.xml | 31 + modules/mohqueue/doc/mohqueue_admin.xml | 512 ++++++ modules/mohqueue/mohq.c | 473 +++++ modules/mohqueue/mohq.h | 135 ++ modules/mohqueue/mohq_common.h | 102 ++ modules/mohqueue/mohq_db.c | 626 +++++++ modules/mohqueue/mohq_db.h | 66 + modules/mohqueue/mohq_funcs.c | 2858 +++++++++++++++++++++++++++++++ modules/mohqueue/mohq_funcs.h | 40 + modules/mohqueue/mohq_locks.c | 199 +++ modules/mohqueue/mohq_locks.h | 49 + modules/mohqueue/mohqueue.sql | 23 + 15 files changed, 5147 insertions(+), 0 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=93a…

1 0

git:master: modules/websocket: tidied up MI commands
by Peter Dunkley 02 Oct '13

02 Oct '13

Module: sip-router Branch: master Commit: 6c7a0f3cdaee5ea0300d014f07e4d68f45c6e20b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6c7a0f3… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Committer: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Wed Oct 2 01:29:45 2013 +0100 modules/websocket: tidied up MI commands - Fixed leak in error situations - Improved error responses --- modules/websocket/ws_conn.c | 21 +++++++++++++++++---- modules/websocket/ws_frame.c | 19 +++++++++++++++---- 2 files changed, 32 insertions(+), 8 deletions(-) diff --git a/modules/websocket/ws_conn.c b/modules/websocket/ws_conn.c index 27a9968..263b49f 100644 --- a/modules/websocket/ws_conn.c +++ b/modules/websocket/ws_conn.c @@ -440,10 +440,7 @@ struct mi_root *ws_mi_dump(struct mi_root *cmd, void *param) int h, connections = 0, truncated = 0, order = 0, found = 0; ws_connection_t *wsc; struct mi_node *node = NULL; - struct mi_root *rpl_tree = init_mi_tree(200, MI_OK_S, MI_OK_LEN); - - if (!rpl_tree) - return 0; + struct mi_root *rpl_tree; node = cmd->node.kids; if (node != NULL) @@ -476,6 +473,10 @@ struct mi_root *ws_mi_dump(struct mi_root *cmd, void *param) } } + rpl_tree = init_mi_tree(200, MI_OK_S, MI_OK_LEN); + if (rpl_tree == NULL) + return 0; + WSCONN_LOCK; if (order == 0) { @@ -485,7 +486,10 @@ struct mi_root *ws_mi_dump(struct mi_root *cmd, void *param) while(wsc) { if ((found = add_node(rpl_tree, wsc)) < 0) + { + free_mi_tree(rpl_tree); return 0; + } connections += found; @@ -508,7 +512,10 @@ struct mi_root *ws_mi_dump(struct mi_root *cmd, void *param) while (wsc) { if ((found = add_node(rpl_tree, wsc)) < 0) + { + free_mi_tree(rpl_tree); return 0; + } connections += found; if (connections >= MAX_WS_CONNS_DUMP) @@ -526,7 +533,10 @@ struct mi_root *ws_mi_dump(struct mi_root *cmd, void *param) while (wsc) { if ((found = add_node(rpl_tree, wsc)) < 0) + { + free_mi_tree(rpl_tree); return 0; + } connections += found; if (connections >= MAX_WS_CONNS_DUMP) @@ -544,7 +554,10 @@ struct mi_root *ws_mi_dump(struct mi_root *cmd, void *param) "%d WebSocket connection%s found%s", connections, connections == 1 ? "" : "s", truncated == 1 ? "(truncated)" : "") == 0) + { + free_mi_tree(rpl_tree); return 0; + } return rpl_tree; } diff --git a/modules/websocket/ws_frame.c b/modules/websocket/ws_frame.c index 086cf79..503722e 100644 --- a/modules/websocket/ws_frame.c +++ b/modules/websocket/ws_frame.c @@ -125,6 +125,7 @@ static str str_status_too_many_params = str_init("Too many parameters"); static str str_status_bad_param = str_init("Bad connection ID parameter"); static str str_status_error_closing = str_init("Error closing connection"); static str str_status_error_sending = str_init("Error sending frame"); +static str str_status_string_error = str_init("Error converting string to int"); static int encode_and_send_ws_frame(ws_frame_t *frame, conn_close_t conn_close) { @@ -726,7 +727,11 @@ struct mi_root *ws_mi_close(struct mi_root *cmd, void *param) node = cmd->node.kids; if (node == NULL) - return 0; + { + LM_WARN("no connection ID parameter\n"); + return init_mi_tree(400, str_status_empty_param.s, + str_status_empty_param.len); + } if (node->value.s == NULL || node->value.len == 0) { LM_WARN("empty connection ID parameter\n"); @@ -736,7 +741,8 @@ struct mi_root *ws_mi_close(struct mi_root *cmd, void *param) if (str2int(&node->value, &id) < 0) { LM_ERR("converting string to int\n"); - return 0; + return init_mi_tree(400, str_status_string_error.s, + str_status_string_error.len); } if (node->next != NULL) { @@ -772,7 +778,11 @@ static struct mi_root *mi_ping_pong(struct mi_root *cmd, void *param, node = cmd->node.kids; if (node == NULL) - return 0; + { + LM_WARN("no connection ID parameter\n"); + return init_mi_tree(400, str_status_empty_param.s, + str_status_empty_param.len); + } if (node->value.s == NULL || node->value.len == 0) { LM_WARN("empty connection ID parameter\n"); @@ -782,7 +792,8 @@ static struct mi_root *mi_ping_pong(struct mi_root *cmd, void *param, if (str2int(&node->value, &id) < 0) { LM_ERR("converting string to int\n"); - return 0; + return init_mi_tree(400, str_status_string_error.s, + str_status_string_error.len); } if (node->next != NULL) {

1 0

git:master: registrar: fix compile warning after previous patch
by Daniel-Constantin Mierla 01 Oct '13

01 Oct '13

Module: sip-router Branch: master Commit: 2934e46a18d9cfba05e657bc1dbbaa559a31b103 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2934e46… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Oct 1 23:03:32 2013 +0200 registrar: fix compile warning after previous patch --- modules/registrar/save.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/registrar/save.c b/modules/registrar/save.c index cbc28c4..5cc4627 100644 --- a/modules/registrar/save.c +++ b/modules/registrar/save.c @@ -144,7 +144,7 @@ static struct socket_info *get_sock_val(struct sip_msg *msg) str hosts; int port; int proto; - char c; + char c = 0; if(sock_hdr_name.len>0) { if (parse_headers( msg, HDR_EOH_F, 0) == -1) { @@ -185,7 +185,7 @@ static struct socket_info *get_sock_val(struct sip_msg *msg) socks.len, socks.s); return 0; } - if(sock_hdr_name.len>0) { + if(sock_hdr_name.len>0 && c!=0) { socks.s[socks.len] = c; } sock = grep_sock_info(&hosts,(unsigned short)port,(unsigned short)proto);

1 0

New commits on branch 4.0
by Andrew Mortensen 01 Oct '13

01 Oct '13

URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b49899f… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Thu Sep 19 13:49:24 2013 -0400 modules/sca: fix return value of sca_call_info_uri_update() - return value of 0 can bubble up as return value of sca_call_info_update(), causing early script termination (exported function returning 0 in script is equivalent to "exit") - report and patch from Timo Teräs (cherry picked from commit 844c398bba30452f0b136895b9f928cc17e5c80b) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c9551e5… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Tue Aug 20 15:54:17 2013 -0400 modules/sca: AoR should not be treated as SCA if there are no subscribers. (cherry picked from commit a8fb905e8bf27093dcf86866ae946431ed441a41) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2226894… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Tue Aug 20 15:14:26 2013 -0400 modules/sca: improved handling of host-only Contact URIs (cherry picked from commit bf747c2d65aeaa74d1cea4e0a531607415e8d17d) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1672b92… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Jul 22 00:48:46 2013 -0400 modules/sca: restore missing prototype. sca_subscription_aor_has_subscribers (cherry picked from commit 7bf7e9f858faab2329e5edf3d988bef76ac2c804) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=92c6c3b… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Jul 22 00:42:18 2013 -0400 modules/sca: detect when an AoR is no longer SCA. Don't, for example, create an appearance for callees that do not send a Call-Info header, and whose AoR also has no subscribers. (cherry picked from commit 3464f62565dd153cb87af71a71df5db2306d74a1) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2f767f2… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Jul 22 00:37:32 2013 -0400 modules/sca: Clear stale line-seize appearances via timer. Some badly behaved/buggy UAs don't know when to say when. (cherry picked from commit 8416a1c65d26ac81b71e08274f9292a7f7713fff) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b15a586… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Thu Jun 13 16:06:10 2013 -0400 modules/sca: fix regression: restore purge expired timer (cherry picked from commit d5f259f7ce04b012f7704ba433f167d034548e09) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b1faa93… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Thu Jun 13 15:34:00 2013 -0400 modules/sca: clear appearance on receipt of out-of-dialog SUBSCRIBE - If a call-info SUBSCRIBE with no To-tag arrives from a subscriber with an active subscription, release any appearances owned by the subscriber, on the assumption that the subscriber has lost track of SCA (reboot, power/network loss). (cherry picked from commit c6280e2eb9c2e1243d5d4ab78b8b683c8239a4b9) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0d0a6c2… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Thu Jun 13 15:30:40 2013 -0400 modules/sca: detect and clear orphaned appearances caused by answer glare - set appearance state created by SCA callee answer to ACTIVE_PENDING, and promote to ACTIVE on ACK from caller. If no ACK from caller is received within 30 seconds (enough time for retransmission to fail), the ACTIVE_PENDING appearance will be cleared by the sca_appearance_purge_stale timer. (cherry picked from commit a9014c2b9edd200cf0032fdb30405710afc97c0b) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=67bd5d6… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Wed May 15 16:13:23 2013 -0400 modules/sca: reconcile Contact and From URIs in ACK callback. - fix Music-on-Hold in Polycoms when SCA caller has MoH enabled and SCA callee does SCA hold/pickup with identical To & From URIs. Previously, module would end up looking up an appearance for callee in ACK callback instead of caller. (cherry picked from commit ba2f749d4a894f6890601ce3d2ff3697b78c5b73) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=68898fd… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Tue May 14 16:25:06 2013 -0400 modules/sca: improved BYE handling. - Clear appearances for both legs on BYE request if possible. (cherry picked from commit 71f012de15bd4fecce006c35b9452854818f03af) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b765ed2… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Tue May 14 16:23:46 2013 -0400 modules/sca: free previous appearance owner, callee, dialog if non-NULL. (cherry picked from commit 6a126232767256a2495c846184acaec788576591) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=87daab4… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Thu May 2 15:12:16 2013 -0400 modules/sca: change logging level for failed lookup by appearance-index. - appearance-index won't be found yet if SCA callee is answering, logging at WARN is misleading. (cherry picked from commit 95b38c4d239f0098e94eafb1c3ddc8834fc767e0) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f547e09… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Tue Apr 30 23:31:12 2013 -0400 modules/sca: space-separate dialog tags in sca.all_appearances output (cherry picked from commit 16243261d7cc6dc3e03db9c589209b534d6dab74) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d16ee1a… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Tue Apr 30 23:10:10 2013 -0400 modules/sca: track appearance times. Include time of last state chance in sca.all_appearances output. (cherry picked from commit da3f7cbd955311309665ab0e6958e009f183f795) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8693055… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Wed Apr 24 11:30:35 2013 -0400 modules/sca: add sca.subscription_count to rpc exports list. (cherry picked from commit 1d361c70b5ed87e0808bc446be327f21d8725a3f) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b1bd972… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Wed Apr 24 01:18:27 2013 -0400 modules/sca: RPC: fix sca.show_subscription, add sca.subscription_count - sca.subscription_count will eventually be subsumed by sca.stats. (cherry picked from commit f156eb0f82bb729e773027e44f1e7f930418dc93) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5ca4e8e… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Thu Apr 18 13:52:10 2013 -0400 modules/sca: fall back to tag lookup if lookup by index fails. - Fix appearance tracking for SCA implementations with inconsistent Call-Info header inclusion. (cherry picked from commit c41806685483546d00324d351ca72143a2a6c787) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f4169c4… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Apr 15 20:16:36 2013 -0400 modules/sca: add SCA_DB_DEFAULT_FETCH_ROW_COUNT (cherry picked from commit 2292666bf234a168120b1c1504bea86300a440ea) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e57b740… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Apr 15 20:11:08 2013 -0400 modules/sca: use DB fetch queries when restoring subscribers from database. - Previously used standard query, exhausting pkg memory when subscriber count is high. (cherry picked from commit c9f47e608f655b3558e7c0c319f32b189732cf34) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4f7b9ac… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Apr 15 20:09:01 2013 -0400 modules/sca: only check if callee is SCA if callee_aor has a value. (cherry picked from commit d1ef3000b9db99c51d5c37134af2c679ce017a82) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8c790ae… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Apr 15 17:17:05 2013 -0400 modules/sca: add check for empty AoR in lock_shared_appearance calls. - Sanity checking (cherry picked from commit 8ce54ef9b33ef533b3f4474b2c68c9ae454db458) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=940d60d… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Thu Apr 11 22:34:10 2013 -0400 modules/sca: clear appearance on t_reply with error after receiving 18x. - Receiving a 18x provisional reply triggers line-seize subscription termination. Releasing the seized appearance while processing a t_reply with an error status *after* getting a 18x would fail because sca_subscription_terminate could not find a matching line-seize subscription. In that case, look up appearance by tags and release it. (cherry picked from commit aa0c84475140dc44186c68e9c544367553c891c2) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d220cdb… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Apr 8 15:01:41 2013 -0400 modules/sca: reduce verbosity of RPC sca.all_subscriptions output - accommodate more subscriptions without hitting kamcmd buffer limits. (cherry picked from commit a9e555e6e41271e015c47d29ba85276673d3b7b6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2a072ee… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Wed Apr 3 14:54:36 2013 -0400 modules/sca: ensure line-seize sub update uses index from request - lazy removal of line-seize subscriptions that were not used for a call could lead to failure to release expired seized appearance. Client must have a lingering, expired line-seize subscription that hasn't yet been purged by the timer, and indices must not match. Fix ensures that the appearance-index from the new line-seize subscription overwrites the index left over from the expired one. (cherry picked from commit 43cc6015e8604e309672da4d754b5022d1e256c9) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=47aeade… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Wed Apr 3 14:46:27 2013 -0400 modules/sca: fix SCA_CALL_INFO_EMPTY macro - test should be a logical OR, not AND. (cherry picked from commit 3339e7a5bd205599fed63f82536626732b3f23d9) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bbd4f9e… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Fri Mar 15 17:01:23 2013 -0400 modules/sca: process BYE without Call-Info from shared line. - Ciscos & Aastras don't seem include Call-Info header in BYE. Look up dialog by tags and release associated appearance-index. (cherry picked from commit 287cccf2af17e5f2f8fe09c41025b4d27bb4fda9) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=eb13042… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Fri Mar 15 10:22:26 2013 -0400 sca: reduce log level to DBG when replacing RURI when retrieving held call. (cherry picked from commit a51bc822f70f4185b55455456dc147205cbbbdc7) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=489fd1b… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Fri Mar 1 16:33:59 2013 -0500 sca: fix private hold handling - private hold call-info was being ignored in hold reINVITEs, causing inaccurate "active" notifications to go to subscribers. (cherry picked from commit 81b5473f5a191a5aa81295acf0d96a22160f7f31) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=888ea02… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Mon Mar 4 23:13:53 2013 -0500 sca: fix regression dropping Expires header from SUBSCRIBE replies. - extra_headers.len lacked Expires header length after snprintf. (cherry picked from commit 3b557293a33f6f3003fdd62a45e02cf8736b534e) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=18593c1… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Sun Mar 3 17:01:53 2013 -0500 sca: move SUBSCRIBE response handling to sca_subscription_reply - create necessary headers, pass to newly generic sca_reply function. (cherry picked from commit d528c27b6fa69530bfde4a6ce83c5d4dcc6499a5) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=08b6b18… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Sun Mar 3 17:00:44 2013 -0500 sca: reject out-of-dialog attempts to seize privately held call. - per spec, reject with 403 Forbidden. (cherry picked from commit e565748048d7a6b6fda0a28959e092380c5bc26a) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5f01771… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Sun Mar 3 16:59:23 2013 -0500 sca: make sca_reply a generic reply function. - take a pre-filled extra_headers parameter instead, add with add_lump_rpl. (cherry picked from commit d6d71b0e217226fe43491a0e9ba75ec0a6649cd5) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8972be2… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Thu Feb 14 16:55:36 2013 -0500 sca: fix race condition when two endpoints seize same index simultaneously - return 480 Temporarily Unavailable to loser of race. (cherry picked from commit 522d06e75bf3c549af007701332f7db53a1b5ab6)

1 0

[tracker] Comment added: Invalide tel INVITE crashes 4.0.3
by sip-router 01 Oct '13

01 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#348 - Invalide tel INVITE crashes 4.0.3 User who did this - Daniel-Constantin Mierla (miconda) ---------- What files have you attached? There is none associated with your last comment. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=348#comment1103 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: uac_redirect not honoring q-value for max_total = 1
by sip-router 01 Oct '13

01 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#349 - uac_redirect not honoring q-value for max_total = 1 User who did this - Daniel-Constantin Mierla (miconda) ---------- I will look into the code when I get a chance, meanwhile, maybe it works with: <code>get_redirects("*");</code> then use <code>t_load_contacts() and t_next_contacts()</code> from tm module to get serialization of branches based on q and do forwarding only once. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=349#comment1102 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.0: core: fix TCP connection leak
by Peter Dunkley 01 Oct '13

01 Oct '13

Module: sip-router Branch: 4.0 Commit: e2642ea25cc19344d6e3e7f71e9df1cd7ef2532d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e2642ea… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Committer: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Tue Oct 1 10:52:01 2013 +0100 core: fix TCP connection leak - patch provided by Vitally Aleksandrov (cherry picked from commit 6cfd13cbddd1869ffbc947fdecd77d18a3fcb886) --- msg_translator.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/msg_translator.c b/msg_translator.c index 5783b7e..fa7834f 100644 --- a/msg_translator.c +++ b/msg_translator.c @@ -2505,9 +2505,11 @@ char* via_builder( unsigned int *len, } else if (con->rcv.proto==PROTO_WSS) { memcpy(line_buf+MY_VIA_LEN-4, "WSS ", 4); } else { + tcpconn_put(con); LOG(L_CRIT, "BUG: via_builder: unknown proto %d\n", con->rcv.proto); return 0; } + tcpconn_put(con); }else if (send_info->proto==PROTO_WSS){ memcpy(line_buf+MY_VIA_LEN-4, "WSS ", 4); }else{

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2013