sr-dev January 2013

sr-dev@lists.kamailio.org

46 participants
325 discussions

Using t_suspend()/t_continue() multiple times on the same transaction

by Peter Dunkley

Hi, I am trying to use t_suspend()/t_continue() multiple times on the same transaction. Calling t_suspend() more than once works, but the second time I call t_continue() the transaction is killed and a 500 response is sent. It is the "if (branch == t->nr_of_outgoings)" check from the code fragment below (from t_suspend.c:t_continue()) that results in the transaction being killed - you can see the debug/error line I added to determine this in the fragment. Is using t_suspend()/t_continue() multiple times something that should work? Thanks, Peter if (t->uas.status < 200) { /* No final reply has been sent yet. * Check whether or not there is any pending branch. */ for ( branch = 0; branch < t->nr_of_outgoings; branch++ ) { if ((t->uac[branch].request.buffer != NULL) && (t->uac[branch].last_received < 200) ) break; } if (branch == t->nr_of_outgoings) { /* There is not any open branch so there is * no chance that a final response will be received. */ ret = 0; LM_ERR("branch == t->nr_of_outgoings\n"); goto kill_trans; } } -- Peter Dunkley Technical Director Crocodile RCS Ltd

10 years, 5 months

default config: do loose_route() for in-dialog NOTIFY as per new RFC 6665

by Iñaki Baz Castillo

Hi, the new RFC 6665 mandates that the subscription dialog is made *after* the first NOTIFY from the UAS (rather than after the 200 to the initial SUBSCRIBE). This means that the UAC MUST take the route set from the *first* received NOTIFY (instead of taking it from the 200 to the initial SUBSCRIBE). Therefore a proxy compliant with RFC 6665 MUST always add RR to in-dialog NOTIFY requests and thus, I propose that the default SR script file implements it. Regards. -- Iñaki Baz Castillo <ibc(a)aliax.net>

10 years, 10 months

git:master: modules_k/uac: uac_replace_from/to AUTO mode with dialog module

by Anca Vamanu

Module: sip-router Branch: master Commit: 0f702f6e236eb0cbb238bf83a0c4ae94d7b3cad8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0f702f6… Author: Anca Vamanu <anca.vamanu(a)1and1.ro> Committer: Anca Vamanu <anca.vamanu(a)1and1.ro> Date: Thu Jul 19 17:49:13 2012 +0300 modules_k/uac: uac_replace_from/to AUTO mode with dialog module Added a implementation for uac_replace_from/to() that uses the dialog module for AUTO mode. In this mode the URIs are stored as dialog variables. The change in tm module fixes a bug: if uac_replace_to() was called, the URI was not changed accordingly in Cancel. --- modules/tm/t_cancel.c | 5 +- modules_k/dialog/dialog.c | 2 + modules_k/dialog/dlg_load.h | 6 + modules_k/uac/README | 111 +++++++++++----- modules_k/uac/doc/uac_admin.xml | 68 +++++++++- modules_k/uac/replace.c | 292 ++++++++++++++++++++++++++++++--------- modules_k/uac/uac.c | 17 ++- 7 files changed, 393 insertions(+), 108 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0f7…

11 years, 5 months

git:master: modules/rtpproxy: rtpproxy_manage can now add ice relay candidates

by Juha Heinanen

Module: sip-router Branch: master Commit: 75fde552f1c4cdea736baa72ff1aa36e527e0215 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=75fde55… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Jan 2 13:00:31 2013 +0200 modules/rtpproxy: rtpproxy_manage can now add ice relay candidates - The feature is activated by defining ice_candidate_priority_avp module parameter. --- modules/rtpproxy/README | 149 ++++++++++++++++++------------- modules/rtpproxy/doc/rtpproxy_admin.xml | 28 ++++++ modules/rtpproxy/rtpproxy.c | 139 ++++++++++++++++++++++++++++- 3 files changed, 250 insertions(+), 66 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=75f…

11 years, 10 months

[PATCH] Clean up code formatting

by Paul Belanger

>From my understand, patches are submitted to the mailing list. -- Paul Belanger | PolyBeacon, Inc. Jabber: paul.belanger(a)polybeacon.com | IRC: pabelanger (Freenode) Github: https://github.com/pabelanger | Twitter: https://twitter.com/pabelanger

11 years, 10 months

Set NOTIFY messages from presence module to DEBUG LEVEL

by Victor Seva

Hi, I'm using the presence module and I'm quite annoying about the flood of messages from the module. This is a trivial patch just for set the level of that message to debug. Thanks in advance, Víctor

11 years, 10 months

Notes from TLS tests

by Olle E. Johansson

Hi! Yesterday I tested the TLS module and noticed a few things: - Kamailio compiled on OS/X refuse to connect to a kamailio server running a CAcert class 3 certificate. So does Counterpath Bria and Blink. I need to figure out the difference between their class 1 and class3 certs, unless someone here already knows. - Even though verification is turned off (default) Kamailio refuses to use the self-signed cert created by the install unless you have the selfsigned cert in the ca-list pem file. This is propably a bug. - If you only want to use Kamailio as a TLS client, connecting to other servers you have to add a listen port and a server certificate. Always. This is propably the design. To set up a connection, we base it on an existing listen port. If that doesn't exist, Kamailio refuse to connect. - I can't find any way to check the server certificate for the server we connect to in the routing script. I guess the ONSEND route runs after we've selected server and transport, but before we're actually connected (in first transaction). The TLS module selects claim we have no TLS transport, even though ONSEND claims we have TLS transport... The tls.peer selects seems to be designed for inbound connections, not outbound. This is not yet a bug report, just notes for comments and for the archives :-) /O

11 years, 10 months

AVPops README

by Olle E. Johansson

"A tutorial providing more information (detailed explanations and commented examples) can be found on the SIP-router web site." I do remember a tutorial years ago. Is it still around, should we update it or remove this sentence? /O

11 years, 10 months

[tracker] Task opened: Crash on call of m_dump() - msilio module.

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Stoyan Mihaylov (stoyan) Attached to Project - sip-router Summary - Crash on call of m_dump() - msilio module. Task Type - Bug Report Category - Modules kamailio Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - My whole configuration is: User client <-> Kamailio <-> Asterisk. Calls and messages are going from user, to Kamailio then to Asterisk server (one or more), back to Kamailio and then to user. When both clients are connected, then there are no problems with messages. When I am sending message to client who is not connected, then messages are stored. When client try to get stored messages, Kamailio crashes. Currently, I cannot send logs, because I found problem, and I solved it on my servers - and I offer potential patch: diff --git a/modules/msilo/msilo.c b/modules/msilo/msilo.c index 209b309..4bda8fa 100644 --- a/modules/msilo/msilo.c +++ b/modules/msilo/msilo.c @@ -1125,8 +1125,16 @@ static int m_dump(struct sip_msg* msg, str* owner_s) memcpy(tmp_extra_hdrs.s, extra_hdrs_str.s, extra_hdrs_str.len); memcpy(tmp_extra_hdrs.s+extra_hdrs_str.len, str_vals[4].s, str_vals[4].len); } else { - tmp_extra_hdrs.len = 0; - tmp_extra_hdrs.s = ""; + tmp_extra_hdrs.len = 0; + if ((tmp_extra_hdrs.s = pkg_malloc(1)) == NULL) + { + LM_ERR("Out of pkg memory"); + if (msilo_dbf.free_result(db_con, db_res) < 0) + LM_ERR("failed to free the query result\n"); + msg_list_set_flag(ml, mid, MS_MSG_ERRO); + goto error; + } + tmp_extra_hdrs.s[0]='\x0'; } hdr_str.len = 1024; if(m_build_headers(&hdr_str, str_vals[3] /*ctype*/, Problem appear when we attempt to free tmp_extra_hdrs.s - in case when we assigned "" to it. Although I allocate (in patch) 1 byte, I set tmp_extra_hdrs.len = 0; to avoid adding wrong headers. When I set tmp_extra_hdrs.len = 1; - I got errors processing message (but no crash of Kamailio). This problem and patch is found in version 3.3.3 and in development version also. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=267 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 10 months

[PATCH] Clean up code formatting

by Paul Belanger

A simple patch to make the code look more consistent Signed-off-by: Paul Belanger <paul.belanger(a)polybeacon.com> --- etc/kamailio.cfg | 115 +++++++++++++++++++++++++----------------------------- 1 file changed, 54 insertions(+), 61 deletions(-) diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index 0c90f5d..63e5ca2 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -461,8 +461,7 @@ request_route { route(NATDETECT); # CANCEL processing - if (is_method("CANCEL")) - { + if (is_method("CANCEL")) { if (t_check_trans()) { route(RELAY); } @@ -482,12 +481,12 @@ request_route { # record routing for dialog forming requests (in case they are routed) # - remove preloaded route headers remove_hf("Route"); - if (is_method("INVITE|SUBSCRIBE")) + if (is_method("INVITE|SUBSCRIBE")) { record_route(); + } # account only INVITEs - if (is_method("INVITE")) - { + if (is_method("INVITE")) { setflag(FLT_ACC); # do accounting } @@ -502,8 +501,7 @@ request_route { # handle registrations route(REGISTRAR); - if ($rU==$null) - { + if ($rU==$null) { # request with no Username in RURI sl_send_reply("484","Address Incomplete"); exit; @@ -530,7 +528,6 @@ route[RELAY] { if (is_method("INVITE")) { if(!t_is_set("failure_route")) t_on_failure("MANAGE_FAILURE"); } - if (!t_relay()) { sl_reply_error(); } @@ -543,16 +540,13 @@ route[REQINIT] { # flood dection from same IP and traffic ban for a while # be sure you exclude checking trusted peers, such as pstn gateways # - local host excluded (e.g., loop to self) - if(src_ip!=myself) - { - if($sht(ipban=>$si)!=$null) - { + if (src_ip!=myself) { + if ($sht(ipban=>$si)!=$null) { # ip is already blocked xdbg("request from blocked IP - $rm from $fu (IP:$si:$sp)\n"); exit; } - if (!pike_check_req()) - { + if (!pike_check_req()) { xlog("L_ALERT","ALERT: pike blocking $rm from $fu (IP:$si:$sp)\n"); $sht(ipban=>$si) = 1; exit; @@ -565,8 +559,7 @@ route[REQINIT] { exit; } - if(!sanity_check("1511", "7")) - { + if (!sanity_check("1511", "7")) { xlog("Malformed SIP message from $si:$sp\n"); exit; } @@ -583,11 +576,11 @@ route[WITHINDLG] { setflag(FLT_ACC); # do accounting ... setflag(FLT_ACCFAILED); # ... even if the transaction fails } - else if ( is_method("ACK") ) { + else if (is_method("ACK")) { # ACK is forwarded statelessy route(NATMANAGE); } - else if ( is_method("NOTIFY") ) { + else if (is_method("NOTIFY")) { # Add Record-Route for in-dialog NOTIFY as per RFC 6665. record_route(); } @@ -598,8 +591,8 @@ route[WITHINDLG] { route(PRESENCE); exit; } - if ( is_method("ACK") ) { - if ( t_check_trans() ) { + if (is_method("ACK")) { + if (t_check_trans()) { # no loose-route, but stateful ACK; # must be an ACK after a 487 # or e.g. 404 from upstream server @@ -618,17 +611,15 @@ route[WITHINDLG] { # Handle SIP registrations route[REGISTRAR] { - if (is_method("REGISTER")) - { - if(isflagset(FLT_NATS)) - { + if (is_method("REGISTER")) { + if (isflagset(FLT_NATS)) { setbflag(FLB_NATB); # uncomment next line to do SIP NAT pinging ## setbflag(FLB_NATSIPPING); } - if (!save("location")) + if (!save("location")) { sl_reply_error(); - + } exit; } } @@ -638,15 +629,18 @@ route[LOCATION] { #!ifdef WITH_SPEEDIAL # search for short dialing - 2-digit extension - if($rU=~"^[0-9][0-9]$") - if(sd_lookup("speed_dial")) + if ($rU=~"^[0-9][0-9]$") { + if (sd_lookup("speed_dial")) { route(SIPOUT); + } + } #!endif #!ifdef WITH_ALIASDB # search in DB-based aliases - if(alias_db_lookup("dbaliases")) + if (alias_db_lookup("dbaliases")) { route(SIPOUT); + } #!endif $avp(oexten) = $rU; @@ -666,8 +660,7 @@ route[LOCATION] { } # when routing via usrloc, log the missed calls also - if (is_method("INVITE")) - { + if (is_method("INVITE")) { setflag(FLT_ACCMISSED); } @@ -677,24 +670,22 @@ route[LOCATION] { # Presence server route route[PRESENCE] { - if(!is_method("PUBLISH|SUBSCRIBE")) + if (!is_method("PUBLISH|SUBSCRIBE")) { return; + } #!ifdef WITH_PRESENCE - if (!t_newtran()) - { + if (!t_newtran()) { sl_reply_error(); exit; }; - if(is_method("PUBLISH")) - { + if (is_method("PUBLISH")) { handle_publish(); t_release(); - } + } else - if( is_method("SUBSCRIBE")) - { + if (is_method("SUBSCRIBE")) { handle_subscribe(); t_release(); } @@ -702,8 +693,7 @@ route[PRESENCE] { #!endif # if presence enabled, this part will not be executed - if (is_method("PUBLISH") || $rU==$null) - { + if (is_method("PUBLISH") || $rU==$null) { sl_send_reply("404", "Not here"); exit; } @@ -715,28 +705,26 @@ route[AUTH] { #!ifdef WITH_AUTH #!ifdef WITH_IPAUTH - if((!is_method("REGISTER")) && allow_source_address()) - { + if ((!is_method("REGISTER")) && allow_source_address()) { # source IP allowed return; } #!endif - if (is_method("REGISTER") || from_uri==myself) - { + if (is_method("REGISTER") || from_uri==myself) { # authenticate requests if (!auth_check("$fd", "subscriber", "1")) { auth_challenge("$fd", "0"); exit; } # user authenticated - remove auth header - if(!is_method("REGISTER|PUBLISH")) + if (!is_method("REGISTER|PUBLISH")) { consume_credentials(); + } } # if caller is not local subscriber, then check if it calls # a local destination, otherwise deny, not an open relay here - if (from_uri!=myself && uri!=myself) - { + if (from_uri!=myself && uri!=myself) { sl_send_reply("403","Not relaying"); exit; } @@ -765,14 +753,15 @@ route[NATDETECT] { route[NATMANAGE] { #!ifdef WITH_NAT if (is_request()) { - if(has_totag()) { - if(check_route_param("nat=yes")) { + if (has_totag()) { + if (check_route_param("nat=yes")) { setbflag(FLB_NATB); } } } - if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) + if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) { return; + } rtpproxy_manage(); @@ -782,7 +771,7 @@ route[NATMANAGE] { } } if (is_reply()) { - if(isbflagset(FLB_NATB)) { + if (isbflagset(FLB_NATB)) { add_contact_alias(); } } @@ -793,7 +782,7 @@ route[NATMANAGE] { # URI update for dialog requests route[DLGURI] { #!ifdef WITH_NAT - if(!isdsturiset()) { + if (!isdsturiset()) { handle_ruri_alias(); } #!endif @@ -802,8 +791,7 @@ route[DLGURI] { # Routing to foreign domains route[SIPOUT] { - if (!uri==myself) - { + if (!uri==myself) { append_hf("P-hint: outbound\r\n"); route(RELAY); } @@ -821,11 +809,12 @@ route[PSTN] { # route to PSTN dialed numbers starting with '+' or '00' # (international format) # - update the condition to match your dialing rules for PSTN routing - if(!($rU=~"^(\+|00)[1-9][0-9]{3,20}$")) + if (!($rU=~"^(\+|00)[1-9][0-9]{3,20}$")) { return; + } # only local users allowed to call - if(from_uri!=myself) { + if (from_uri!=myself) { sl_send_reply("403", "Not Allowed"); exit; } @@ -852,8 +841,9 @@ route[XMLRPC] { && (src_ip==127.0.0.1)) { # close connection only for xmlrpclib user agents (there is a bug in # xmlrpclib: it waits for EOF before interpreting the response). - if ($hdr(User-Agent) =~ "xmlrpclib") + if ($hdr(User-Agent) =~ "xmlrpclib") { set_reply_close(); + } set_reply_no_connect(); dispatch_rpc(); exit; @@ -866,16 +856,18 @@ route[XMLRPC] { # route to voicemail server route[TOVOICEMAIL] { #!ifdef WITH_VOICEMAIL - if(!is_method("INVITE")) + if (!is_method("INVITE")) { return; + } # check if VoiceMail server IP is defined if (strempty($sel(cfg_get.voicemail.srv_ip))) { xlog("SCRIPT: VoiceMail rotuing enabled but IP not defined\n"); return; } - if($avp(oexten)==$null) + if ($avp(oexten)==$null) { return; + } $ru = "sip:" + $avp(oexten) + "@" + $sel(cfg_get.voicemail.srv_ip) + ":" + $sel(cfg_get.voicemail.srv_port); @@ -895,8 +887,9 @@ branch_route[MANAGE_BRANCH] { # manage incoming replies onreply_route[MANAGE_REPLY] { xdbg("incoming reply\n"); - if(status=~"[12][0-9][0-9]") + if (status=~"[12][0-9][0-9]") { route(NATMANAGE); + } } # manage failure routing cases -- 1.7.9.5

11 years, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2013