sr-dev August 2012

sr-dev@lists.kamailio.org

30 participants
169 discussions

git:master: kamctl/dbcassandra: Updated schema for cassandra location table

by Anca Vamanu

Module: sip-router Branch: master Commit: ae7047e05a7ff05a1707446286e2837fa49671dc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ae7047e… Author: Anca Vamanu <anca.vamanu(a)1and1.ro> Committer: Anca Vamanu <anca.vamanu(a)1and1.ro> Date: Wed Aug 29 19:33:51 2012 +0300 kamctl/dbcassandra: Updated schema for cassandra location table --- utils/kamctl/dbcassandra/openser/location | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utils/kamctl/dbcassandra/openser/location b/utils/kamctl/dbcassandra/openser/location index 555aee3..acfcc97 100644 --- a/utils/kamctl/dbcassandra/openser/location +++ b/utils/kamctl/dbcassandra/openser/location @@ -1,3 +1,3 @@ -callid(string) cflags(int) contact(string) cseq(int) expires(timestamp) flags(int) last_modified(int) methods(int) path(string) q(double) received(string) socket(string) user_agent(string) username(string) +callid(string) cflags(int) contact(string) cseq(int) expires(timestamp) flags(int) last_modified(int) methods(int) path(string) q(double) received(string) socket(string) user_agent(string) username(string) ruid(string) instance(string) reg_id(int) username contact

11 years, 7 months

git:master: ndb_redis: add some error checks in redisc_exec function.

by Vicente Hernando

Module: sip-router Branch: master Commit: 4b60f510b3fe4ac8ff8fa2721cc40b18b93ed5d1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4b60f51… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Aug 27 16:22:35 2012 -0400 ndb_redis: add some error checks in redisc_exec function. --- modules/ndb_redis/redis_client.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c index 72354a6..0bf2c37 100644 --- a/modules/ndb_redis/redis_client.c +++ b/modules/ndb_redis/redis_client.c @@ -326,6 +326,11 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) LM_ERR("invalid parameters"); goto error_exec; } + if(srv->len==0 || res->len==0 || cmd->len==0) + { + LM_ERR("invalid parameters"); + goto error_exec; + } if(rsrv==NULL) { LM_ERR("no redis server found: %.*s\n", srv->len, srv->s); @@ -354,6 +359,10 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) if(rpl->rplRedis == NULL) { /* null reply, reconnect and try again */ + if(rsrv->ctxRedis->err) + { + LM_ERR("Redis error: %s\n", rsrv->ctxRedis->errstr); + } if(redisc_reconnect_server(rsrv)==0) { rpl->rplRedis = redisvCommand(rsrv->ctxRedis, cmd->s, ap);

11 years, 8 months

git:master: ndb_redis: add goto error_exec instead of return

by Vicente Hernando

Module: sip-router Branch: master Commit: 57b5efa329ee50cfee361fe10204b37ca8a8e039 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=57b5efa… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: Mon Aug 27 07:01:18 2012 -0400 ndb_redis: add goto error_exec instead of return --- modules/ndb_redis/redis_client.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c index 84e9e9e..72354a6 100644 --- a/modules/ndb_redis/redis_client.c +++ b/modules/ndb_redis/redis_client.c @@ -334,7 +334,7 @@ int redisc_exec(str *srv, str *res, str *cmd, ...) if(rsrv->ctxRedis==NULL) { LM_ERR("no redis context for server: %.*s\n", srv->len, srv->s); - return -1; + goto error_exec; } rpl = redisc_get_reply(res); if(rpl==NULL)

11 years, 8 months

git:master: pkg/deb Set Standards version to 3.9.3

by Jon Bonilla

Module: sip-router Branch: master Commit: 2bd8309a9e1af15dc3b5dafdfc84b97fc8338c98 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2bd8309… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Committer: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Mon Aug 27 12:49:07 2012 +0200 pkg/deb Set Standards version to 3.9.3 --- pkg/kamailio/deb/debian/control | 2 +- pkg/kamailio/deb/lenny/control | 2 +- pkg/kamailio/deb/lucid/control | 2 +- pkg/kamailio/deb/precise/control | 2 +- pkg/kamailio/deb/squeeze/control | 2 +- pkg/kamailio/deb/wheezy/control | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/kamailio/deb/debian/control b/pkg/kamailio/deb/debian/control index 9b1eba5..b4f7c89 100644 --- a/pkg/kamailio/deb/debian/control +++ b/pkg/kamailio/deb/debian/control @@ -39,7 +39,7 @@ Build-Depends: bison, unixodbc-dev, xsltproc, zlib1g-dev -Standards-Version: 3.8.0 +Standards-Version: 3.9.3 Homepage: http://www.kamailio.org/ Package: kamailio diff --git a/pkg/kamailio/deb/lenny/control b/pkg/kamailio/deb/lenny/control index 8c249e7..d3885ad 100644 --- a/pkg/kamailio/deb/lenny/control +++ b/pkg/kamailio/deb/lenny/control @@ -34,7 +34,7 @@ Build-Depends: bison, unixodbc-dev, xsltproc, zlib1g-dev -Standards-Version: 3.8.0 +Standards-Version: 3.9.3 Homepage: http://www.kamailio.org/ Package: kamailio diff --git a/pkg/kamailio/deb/lucid/control b/pkg/kamailio/deb/lucid/control index 6e14db3..6e0ddcf 100644 --- a/pkg/kamailio/deb/lucid/control +++ b/pkg/kamailio/deb/lucid/control @@ -35,7 +35,7 @@ Build-Depends: bison, unixodbc-dev, xsltproc, zlib1g-dev -Standards-Version: 3.8.0 +Standards-Version: 3.9.3 Homepage: http://www.kamailio.org/ Package: kamailio diff --git a/pkg/kamailio/deb/precise/control b/pkg/kamailio/deb/precise/control index 1a06a97..1cc2a55 100644 --- a/pkg/kamailio/deb/precise/control +++ b/pkg/kamailio/deb/precise/control @@ -39,7 +39,7 @@ Build-Depends: bison, unixodbc-dev, xsltproc, zlib1g-dev -Standards-Version: 3.8.0 +Standards-Version: 3.9.3 Homepage: http://www.kamailio.org/ Package: kamailio diff --git a/pkg/kamailio/deb/squeeze/control b/pkg/kamailio/deb/squeeze/control index 76e81e7..dbd5860 100644 --- a/pkg/kamailio/deb/squeeze/control +++ b/pkg/kamailio/deb/squeeze/control @@ -36,7 +36,7 @@ Build-Depends: bison, unixodbc-dev, xsltproc, zlib1g-dev -Standards-Version: 3.8.0 +Standards-Version: 3.9.3 Homepage: http://www.kamailio.org/ Package: kamailio diff --git a/pkg/kamailio/deb/wheezy/control b/pkg/kamailio/deb/wheezy/control index df9d83d..979bb05 100644 --- a/pkg/kamailio/deb/wheezy/control +++ b/pkg/kamailio/deb/wheezy/control @@ -38,7 +38,7 @@ Build-Depends: bison, unixodbc-dev, xsltproc, zlib1g-dev -Standards-Version: 3.8.0 +Standards-Version: 3.9.3 Homepage: http://www.kamailio.org/ Package: kamailio

11 years, 8 months

git:3.3: pkg/deb: Wrap and sort

by Jon Bonilla

Module: sip-router Branch: 3.3 Commit: db68eb7863263785f1fbf13be092f05f484c9171 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=db68eb7… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Committer: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Mon Aug 27 12:26:59 2012 +0200 pkg/deb: Wrap and sort Use wrap-and-sort command Credits to Michael Prokop <mprokop(a)sipwise.com> --- pkg/kamailio/deb/debian/control | 184 ++++++++++++++++++++++++++-------- pkg/kamailio/deb/lenny/control | 193 +++++++++++++++++++++++------------- pkg/kamailio/deb/lucid/control | 188 +++++++++++++++++++++++----------- pkg/kamailio/deb/precise/control | 188 ++++++++++++++++++++++++++--------- pkg/kamailio/deb/squeeze/control | 206 ++++++++++++++++++++++++-------------- pkg/kamailio/deb/wheezy/control | 192 +++++++++++++++++++++++++---------- 6 files changed, 807 insertions(+), 344 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=db6…

11 years, 8 months

git:3.3: pkg/deb Don't conflict with -dbg any more

by Jon Bonilla

Module: sip-router Branch: 3.3 Commit: 8604b9b40464793153f871e3334da7c81589de44 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8604b9b… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Committer: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Mon Aug 27 11:38:47 2012 +0200 pkg/deb Don't conflict with -dbg any more --- pkg/kamailio/deb/debian/control | 2 +- pkg/kamailio/deb/lenny/control | 2 +- pkg/kamailio/deb/lucid/control | 2 +- pkg/kamailio/deb/precise/control | 2 +- pkg/kamailio/deb/squeeze/control | 2 +- pkg/kamailio/deb/wheezy/control | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/kamailio/deb/debian/control b/pkg/kamailio/deb/debian/control index 9209f41..43c19a7 100644 --- a/pkg/kamailio/deb/debian/control +++ b/pkg/kamailio/deb/debian/control @@ -9,7 +9,7 @@ Homepage: http://www.kamailio.org/ Package: kamailio Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, adduser -Conflicts: kamailio-regex-modules, kamailio-dbg +Conflicts: kamailio-regex-modules Suggests: kamailio-mysql-modules, kamailio-postgres-modules, kamailio-unixodbc-modules, kamailio-tls-modules, kamailio-cpl-modules, kamailio-radius-modules, kamailio-presence-modules, kamailio-xml-modules, kamailio-perl-modules, kamailio-snmpstats-modules, kamailio-xmpp-modules, kamailio-carrierroute-modules, kamailio-berkeley-modules, kamailio-ldap-modules, kamailio-lua-modules, kamailio-python-modules, kamailio-mono-modules, kamailio-dbg Description: very fast and configurable SIP proxy Kamailio is a very fast and flexible SIP (RFC3261) diff --git a/pkg/kamailio/deb/lenny/control b/pkg/kamailio/deb/lenny/control index 04f8870..5b54ab3 100644 --- a/pkg/kamailio/deb/lenny/control +++ b/pkg/kamailio/deb/lenny/control @@ -9,7 +9,7 @@ Homepage: http://www.kamailio.org/ Package: kamailio Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, adduser -Conflicts: kamailio-regex-modules, kamailio-dbg +Conflicts: kamailio-regex-modules Suggests: kamailio-mysql-modules, kamailio-postgres-modules, kamailio-unixodbc-modules, kamailio-tls-modules, kamailio-cpl-modules, kamailio-radius-modules, kamailio-presence-modules, kamailio-xml-modules, kamailio-perl-modules, kamailio-snmpstats-modules, kamailio-xmpp-modules, kamailio-carrierroute-modules, kamailio-berkeley-modules, kamailio-ldap-modules, kamailio-lua-modules, kamailio-python-modules, kamailio-dbg Description: very fast and configurable SIP proxy Kamailio is a very fast and flexible SIP (RFC3261) diff --git a/pkg/kamailio/deb/lucid/control b/pkg/kamailio/deb/lucid/control index 463ff7f..fa26964 100644 --- a/pkg/kamailio/deb/lucid/control +++ b/pkg/kamailio/deb/lucid/control @@ -9,7 +9,7 @@ Homepage: http://www.kamailio.org/ Package: kamailio Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, adduser -Conflicts: kamailio-regex-modules, kamailio-dbg +Conflicts: kamailio-regex-modules Suggests: kamailio-mysql-modules, kamailio-postgres-modules, kamailio-unixodbc-modules, kamailio-tls-modules, kamailio-cpl-modules, kamailio-radius-modules, kamailio-presence-modules, kamailio-xml-modules, kamailio-perl-modules, kamailio-snmpstats-modules, kamailio-xmpp-modules, kamailio-carrierroute-modules, kamailio-berkeley-modules, kamailio-ldap-modules, kamailio-lua-modules, kamailio-python-modules, kamailio-dbg Description: very fast and configurable SIP proxy Kamailio is a very fast and flexible SIP (RFC3261) diff --git a/pkg/kamailio/deb/precise/control b/pkg/kamailio/deb/precise/control index c30a80f..899a77e 100644 --- a/pkg/kamailio/deb/precise/control +++ b/pkg/kamailio/deb/precise/control @@ -9,7 +9,7 @@ Homepage: http://www.kamailio.org/ Package: kamailio Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, adduser -Conflicts: kamailio-regex-modules, kamailio-dbg +Conflicts: kamailio-regex-modules Suggests: kamailio-mysql-modules, kamailio-postgres-modules, kamailio-unixodbc-modules, kamailio-tls-modules, kamailio-cpl-modules, kamailio-radius-modules, kamailio-presence-modules, kamailio-xml-modules, kamailio-perl-modules, kamailio-snmpstats-modules, kamailio-xmpp-modules, kamailio-carrierroute-modules, kamailio-berkeley-modules, kamailio-ldap-modules, kamailio-lua-modules, kamailio-python-modules, kamailio-mono-modules, kamailio-dbg Description: very fast and configurable SIP proxy Kamailio is a very fast and flexible SIP (RFC3261) diff --git a/pkg/kamailio/deb/squeeze/control b/pkg/kamailio/deb/squeeze/control index 85d0344..8449cc4 100644 --- a/pkg/kamailio/deb/squeeze/control +++ b/pkg/kamailio/deb/squeeze/control @@ -9,7 +9,7 @@ Homepage: http://www.kamailio.org/ Package: kamailio Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, adduser -Conflicts: kamailio-regex-modules, kamailio-dbg +Conflicts: kamailio-regex-modules Suggests: kamailio-mysql-modules, kamailio-postgres-modules, kamailio-unixodbc-modules, kamailio-tls-modules, kamailio-cpl-modules, kamailio-radius-modules, kamailio-presence-modules, kamailio-xml-modules, kamailio-perl-modules, kamailio-snmpstats-modules, kamailio-xmpp-modules, kamailio-carrierroute-modules, kamailio-berkeley-modules, kamailio-ldap-modules, kamailio-lua-modules, kamailio-python-modules, kamailio-dbg Description: very fast and configurable SIP proxy Kamailio is a very fast and flexible SIP (RFC3261) diff --git a/pkg/kamailio/deb/wheezy/control b/pkg/kamailio/deb/wheezy/control index 06f7f55..1dff762 100644 --- a/pkg/kamailio/deb/wheezy/control +++ b/pkg/kamailio/deb/wheezy/control @@ -9,7 +9,7 @@ Homepage: http://www.kamailio.org/ Package: kamailio Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, adduser -Conflicts: kamailio-regex-modules, kamailio-dbg +Conflicts: kamailio-regex-modules Suggests: kamailio-mysql-modules, kamailio-postgres-modules, kamailio-unixodbc-modules, kamailio-tls-modules, kamailio-cpl-modules, kamailio-radius-modules, kamailio-presence-modules, kamailio-xml-modules, kamailio-perl-modules, kamailio-snmpstats-modules, kamailio-xmpp-modules, kamailio-carrierroute-modules, kamailio-berkeley-modules, kamailio-ldap-modules, kamailio-lua-modules, kamailio-python-modules, kamailio-mono-modules, kamailio-dbg Description: very fast and configurable SIP proxy Kamailio is a very fast and flexible SIP (RFC3261)

11 years, 8 months

git:master: pkg/deb: Don't conflict with -dbg any more

by Jon Bonilla

Module: sip-router Branch: master Commit: e8c7708bed7081e74ee43370ab63031daac6fb8b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e8c7708… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Committer: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Mon Aug 27 11:35:50 2012 +0200 pkg/deb: Don't conflict with -dbg any more --- pkg/kamailio/deb/debian/control | 3 +-- pkg/kamailio/deb/lenny/control | 3 +-- pkg/kamailio/deb/lucid/control | 3 +-- pkg/kamailio/deb/precise/control | 3 +-- pkg/kamailio/deb/squeeze/control | 3 +-- pkg/kamailio/deb/wheezy/control | 3 +-- 6 files changed, 6 insertions(+), 12 deletions(-) diff --git a/pkg/kamailio/deb/debian/control b/pkg/kamailio/deb/debian/control index eb9b3e3..9b1eba5 100644 --- a/pkg/kamailio/deb/debian/control +++ b/pkg/kamailio/deb/debian/control @@ -47,8 +47,7 @@ Architecture: any Depends: adduser, ${misc:Depends}, ${shlibs:Depends} -Conflicts: kamailio-dbg, - kamailio-regex-modules +Conflicts: kamailio-regex-modules Suggests: kamailio-berkeley-modules, kamailio-carrierroute-modules, kamailio-cpl-modules, diff --git a/pkg/kamailio/deb/lenny/control b/pkg/kamailio/deb/lenny/control index 7c7490f..8c249e7 100644 --- a/pkg/kamailio/deb/lenny/control +++ b/pkg/kamailio/deb/lenny/control @@ -42,8 +42,7 @@ Architecture: any Depends: adduser, ${misc:Depends}, ${shlibs:Depends} -Conflicts: kamailio-dbg, - kamailio-regex-modules +Conflicts: kamailio-regex-modules Suggests: kamailio-berkeley-modules, kamailio-carrierroute-modules, kamailio-cpl-modules, diff --git a/pkg/kamailio/deb/lucid/control b/pkg/kamailio/deb/lucid/control index 8ad1536..6e14db3 100644 --- a/pkg/kamailio/deb/lucid/control +++ b/pkg/kamailio/deb/lucid/control @@ -43,8 +43,7 @@ Architecture: any Depends: adduser, ${misc:Depends}, ${shlibs:Depends} -Conflicts: kamailio-dbg, - kamailio-regex-modules +Conflicts: kamailio-regex-modules Suggests: kamailio-berkeley-modules, kamailio-carrierroute-modules, kamailio-cpl-modules, diff --git a/pkg/kamailio/deb/precise/control b/pkg/kamailio/deb/precise/control index 7775754..1a06a97 100644 --- a/pkg/kamailio/deb/precise/control +++ b/pkg/kamailio/deb/precise/control @@ -47,8 +47,7 @@ Architecture: any Depends: adduser, ${misc:Depends}, ${shlibs:Depends} -Conflicts: kamailio-dbg, - kamailio-regex-modules +Conflicts: kamailio-regex-modules Suggests: kamailio-berkeley-modules, kamailio-carrierroute-modules, kamailio-cpl-modules, diff --git a/pkg/kamailio/deb/squeeze/control b/pkg/kamailio/deb/squeeze/control index c56e38e..76e81e7 100644 --- a/pkg/kamailio/deb/squeeze/control +++ b/pkg/kamailio/deb/squeeze/control @@ -44,8 +44,7 @@ Architecture: any Depends: adduser, ${misc:Depends}, ${shlibs:Depends} -Conflicts: kamailio-dbg, - kamailio-regex-modules +Conflicts: kamailio-regex-modules Suggests: kamailio-berkeley-modules, kamailio-carrierroute-modules, kamailio-cpl-modules, diff --git a/pkg/kamailio/deb/wheezy/control b/pkg/kamailio/deb/wheezy/control index c7bdcf3..df9d83d 100644 --- a/pkg/kamailio/deb/wheezy/control +++ b/pkg/kamailio/deb/wheezy/control @@ -46,8 +46,7 @@ Architecture: any Depends: adduser, ${misc:Depends}, ${shlibs:Depends} -Conflicts: kamailio-dbg, - kamailio-regex-modules +Conflicts: kamailio-regex-modules Suggests: kamailio-berkeley-modules, kamailio-carrierroute-modules, kamailio-cpl-modules,

11 years, 8 months

backporting to 3.3 the md5 code and bits of kamailio.cfg

by Daniel-Constantin Mierla

Hello, just wanted to announce here the intention of backporting the patch sent by debian.org packagers for md5 code, to make it gpl compliant, respectively: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e6d912a… http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bcff862… Previously it was the code from rfc, now being replaced by another existing implementation in bsd. It is how debs packages in official debian distro are built, so it is safe. Anyhow, if someone feels inconvenient about it, let us know. It is not a new feature, not a bug in the code, just a gpl compliancy fix for debian distribution. Second I plan to backport the usage of add_contact_alias()/handle_ruri_alias() in default config file, instead of old fix_natted_contact(), which is not very rfc compliant. Ongoing installation will not be overwritten with a new config, but it is good for new people to start with the right solution. Anyone having comments, write here. Again, these are not really source code bug fixes nor new features, but they are fixing gpl-distributing and behaviour issues. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat

11 years, 8 months

git:master: db_cluster: more verbosity when building cluster structures

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: b53ca97379e1b4aeae80b794f23e25e9150a0e58 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b53ca97… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Aug 27 10:37:50 2012 +0200 db_cluster: more verbosity when building cluster structures --- modules_k/db_cluster/dbcl_data.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/modules_k/db_cluster/dbcl_data.c b/modules_k/db_cluster/dbcl_data.c index 94a3f1c..5ef3b63 100644 --- a/modules_k/db_cluster/dbcl_data.c +++ b/modules_k/db_cluster/dbcl_data.c @@ -262,6 +262,8 @@ int dbcl_cls_set_connections(dbcl_cls_t *cls, str *cons) cls->rlist[i].mode = s.s[1] | 32; cls->rlist[i].prio = i; cls->rlist[i].clist[cls->rlist[i].clen] = sc; + LM_DBG("added con-id [%.*s] to rlist[%d] at [%d]\n", + pit->name.len, pit->name.s, i, cls->rlist[i].clen); cls->rlist[i].clen++; } else { LM_WARN("too many read connections in cluster - con-id [%.*s]\n", @@ -289,6 +291,8 @@ int dbcl_cls_set_connections(dbcl_cls_t *cls, str *cons) cls->wlist[i].mode = s.s[3] | 32; cls->wlist[i].prio = i; cls->wlist[i].clist[cls->wlist[i].clen] = sc; + LM_DBG("added con-id [%.*s] to wlist[%d] at [%d]\n", + pit->name.len, pit->name.s, i, cls->wlist[i].clen); cls->wlist[i].clen++; } else { LM_WARN("too many write connections in cluster - con-id [%.*s]\n",

11 years, 8 months

[ openser-Feature Requests-1891148 ] protection of open fifo/ socket files against removing

by SourceForge.net

Feature Requests item #1891148, was opened at 2008-02-11 05:58 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1891148&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel Status: Open Resolution: None Priority: 5 Private: No Submitted By: Helmut Kuper (hekuper) Assigned to: Nobody/Anonymous (nobody) Summary: protection of open fifo/ socket files against removing Initial Comment: Hi, I found that starting a 2nd openser with same config as an already running openser on same machine using module mi_datagram leads to a deletion of the socket file of the already running openser process. This is very bad when u use openser as a frontend for sems for example. :( If this is a bug, maybe the check, whether there is an already running openser using same network resources, should be placed *befor* starting modules. Alternative modules should be able to handle those problematic scenarios ... My mi_datagram config is this: loadmodule "mi_datagram.so" modparam("mi_datagram", "socket_name", "/tmp/openser_ansagen_sock") modparam("mi_datagram", "children_count", 1) modparam("mi_datagram", "unix_socket_mode", 0660) modparam("mi_datagram", "unix_socket_group", "voip") modparam("mi_datagram", "unix_socket_user", "ruth") modparam("mi_datagram", "socket_timeout", 2000) regards Helmut ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2012-08-26 01:24 Message: Hey there this is kind of of off topic but I was wondering if blogs use WYSIWYG editors or if you have to manually code with HTML. I'm starting a blog soon but have no coding expertise so I wanted to get advice from someone with experience. Any help would be enormously appreciated! http://www.sunglasses4summer.net/ ---------------------------------------------------------------------- Comment By: Henning Westerholt (henningw) Date: 2008-07-08 06:47 Message: Logged In: YES user_id=337916 Originator: NO Hi all, the problem with checking the existence of the fifo/ socket is that the old file is not deleted during the shutdown. Even if we change this then the problem would be still present in the event of a server crash. As Helmut aggreed that this can be closed, i've moved this to the feature request section. The startup code in main.c could be modified to check for available network resources before doing the module initialization to achieve this functionality. Cheers, Henning ---------------------------------------------------------------------- Comment By: Ovidiu Sas (osas) Date: 2008-02-12 07:58 Message: Logged In: YES user_id=1395524 Originator: NO It happened to me too. I wanted to check the version of openser and instead of running 'openser -V' I ran 'openser -v' and my fifo file was gone. Maybe a quick fix would be to check the existence of the fifo file. If exists, exit with an error, if not, proceed as normal. Just my 2c. Regards, Ovidiu sas ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2008-02-12 07:53 Message: Logged In: NO Hi, well, I agree too. This is an operation error by admin. But it is annoying that it is so easy to destroy the media server. This will quit often occurs if you are using bash shell with command history combined with nervous fingers ;) ... I think that checking network resources in openser befor doing rest of configuration is safer. It should work allways, cause no second openser will user same address and port on same machine at same time. On the other Hand saving the PID of first openser in a PID should be an acceptable work around. So we can close this case if you want. regards Helmut ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2008-02-12 07:40 Message: Logged In: NO is it possible to delete a FIFO which is currently used? E.g by mistake I start openser a second time. If it deletes the FIFO then it may cause problems to the current running openser instance. klaus ---------------------------------------------------------------------- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2008-02-12 05:33 Message: Logged In: YES user_id=1275325 Originator: NO Hi Henning, I agree here - the fix should not be in openser, but rather in whatever scripts/admins are managing openser. From my point of view, this is a openser operation error. Regards, Bogdan ---------------------------------------------------------------------- Comment By: Henning Westerholt (henningw) Date: 2008-02-12 03:24 Message: Logged In: YES user_id=337916 Originator: NO I think this can be fixed by other means: Just add some checks to openserctl to not start openser two times, like the init script does (i think). This would be easier than to fix the OpenSER start process to not start at all (or fail just in the beginning) if another process is already running. Henning ---------------------------------------------------------------------- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2008-02-12 03:06 Message: Logged In: YES user_id=1275325 Originator: NO Hi Helmut, This is the normal/expected bahviour of the module - to avoid any security problems (using a fake or malicious already existing unixsocket) openser removes it first (if exists) and then creates its own with proper permissions and security restrictions. So, it is not a bug :). Regards, Bogdan ---------------------------------------------------------------------- Comment By: Helmut Kuper (hekuper) Date: 2008-02-11 06:53 Message: Logged In: YES user_id=1851349 Originator: YES Hi Bogdan, yes I use same socket file name for both opensers, cause both are using same config file. Befor we misunderstand: I don't want to run 2 opensers with same config on same machine!! I rather strumbled about that bug/problem, when I accidently started same openser without openserctl twice ---------------------------------------------------------------------- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2008-02-11 06:45 Message: Logged In: YES user_id=1275325 Originator: NO Hi Helmut, so you use the same socket_name for both openser's ?? Regards, Bogdan ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1891148&group_…

11 years, 8 months

← Newer
1
2
3
4
5
6
7
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2012