sr-dev July 2012

sr-dev@lists.kamailio.org

24 participants
172 discussions

git:master: parser/sdp: more suggestive debug message

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: faf7806b7488143f0637b9db896d849249eb059a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=faf7806… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 13 09:49:16 2012 +0200 parser/sdp: more suggestive debug message --- parser/sdp/sdp.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/parser/sdp/sdp.c b/parser/sdp/sdp.c index fbd2453..fb51f3f 100644 --- a/parser/sdp/sdp.c +++ b/parser/sdp/sdp.c @@ -717,9 +717,9 @@ int parse_sdp(struct sip_msg* _m) } res = parse_sdp_session(&body, 0, NULL, (sdp_info_t*)_m->body); if (res != 0) { - LM_DBG("free_sdp\n"); + LM_DBG("failed to parse sdp session - freeing sdp\n"); free_sdp((sdp_info_t**)(void*)&_m->body); - return res; + return res; } /* The whole body is SDP */ ((sdp_info_t*)_m->body)->raw_sdp.s = body.s;

11 years, 10 months

git:master: parser/sdp: prevent manipulation with freed structure

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: f529cdb8b818017c20b73ba5be89309745ea95c5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f529cdb… Author: Michal Karas <largon(a)largon.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 12 17:38:15 2012 +0200 parser/sdp: prevent manipulation with freed structure - FS#244 --- parser/sdp/sdp.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/parser/sdp/sdp.c b/parser/sdp/sdp.c index 0ba8e8f..fbd2453 100644 --- a/parser/sdp/sdp.c +++ b/parser/sdp/sdp.c @@ -719,6 +719,7 @@ int parse_sdp(struct sip_msg* _m) if (res != 0) { LM_DBG("free_sdp\n"); free_sdp((sdp_info_t**)(void*)&_m->body); + return res; } /* The whole body is SDP */ ((sdp_info_t*)_m->body)->raw_sdp.s = body.s;

11 years, 10 months

preparing release of v3.1.6

by Daniel-Constantin Mierla

Hello, later today I plan to package v3.1.6 as the last release in 3.1.x series. Based on our release policy to work on latest two stable branches, 3.1 got out of by release of 3.3.0. The branch 3.1 may still get patches, it is not a closed branch, but it is a matter of developers for willing to do that -- it is just not going to be packaged again in a numbered release, so people will have to use git branch. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Training, Seattle, USA, Sep 23-26, 2012 - http://asipto.com/u/katu Kamailio Practical Workshop, Netherlands, Sep 10-12, 2012 - http://asipto.com/u/kpw

11 years, 10 months

[tracker] Comment added: kamailio tls debug error

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#245 - kamailio tls debug error User who did this - Klaus Darilion (klaus3000) ---------- I also tried to connect with openssl and it works fine for me (Kamailio 3.3 on Debian Squeeze). This is my tls.cfg: [server:default] method = TLSv1 verify_certificate = no require_certificate = no private_key = /etc/certificates/labs.nic.at.key certificate = /etc/certificates/labs.nic.at.crt ca_list = /etc/certificates/terena-intermediate.pem [client:default] method = TLSv1 verify_certificate = no require_certificate = no private_key = /etc/certificates/labs.nic.at.key certificate = /etc/certificates/labs.nic.at.crt ca_list = /etc/certificates/terena-intermediate.pem ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=245#comment707 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 10 months

[tracker] Comment added: kamailio tls debug error

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#245 - kamailio tls debug error User who did this - Klaus Darilion (klaus3000) ---------- I have written a small howto: http://www.kamailio.org/wiki/testing_and_debugging_tls_connections ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=245#comment706 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 10 months

git:master: core: Removed unused enum ( crept in during WebSocket implementation)

by Peter Dunkley

Module: sip-router Branch: master Commit: e3cadfd261d2d4b88e288e893a1e6171b14f4218 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e3cadfd… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Jul 12 22:45:32 2012 +0100 core: Removed unused enum (crept in during WebSocket implementation) --- route_struct.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/route_struct.h b/route_struct.h index 9e9b5cb..b176b9c 100644 --- a/route_struct.h +++ b/route_struct.h @@ -136,8 +136,7 @@ enum _operand_subtype{ STRING_RVE_ST /* RVE converted to a string (fparam hack) */, RVE_FREE_FIXUP_ST /* (str)RVE fixed up by a reversable fixup */, FPARAM_DYN_ST /* temporary only (fparam hack) */, - CFG_GROUP_ST, - WEBSOCKET_ST + CFG_GROUP_ST }; typedef enum _expr_l_type expr_l_type;

11 years, 10 months

git:3.3: modules/sl: Fixed segmentation fault and corrected log messages

by Peter Dunkley

Module: sip-router Branch: 3.3 Commit: a897251aaa545c8726587412009f4906ff21e2aa URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a897251… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Jul 12 21:48:08 2012 +0100 modules/sl: Fixed segmentation fault and corrected log messages - Fixes by Hugh Waite @ Crocodile RCS (cherry picked from commit e78ff34f1ecfe9a60a52996126032ea04fb490ab) --- modules/sl/sl.c | 4 ++-- modules/sl/sl_funcs.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/sl/sl.c b/modules/sl/sl.c index 2ca7592..eedb953 100644 --- a/modules/sl/sl.c +++ b/modules/sl/sl.c @@ -209,7 +209,7 @@ static int w_sl_send_reply(struct sip_msg* msg, char* p1, char* p2) } if (get_str_fparam(&reason, msg, (fparam_t*)p2) < 0) { - reason = default_reason;; + reason = default_reason; } if(reason.s[reason.len-1]=='\0') { @@ -219,7 +219,7 @@ static int w_sl_send_reply(struct sip_msg* msg, char* p1, char* p2) if (r == NULL) r = default_reason.s; } ret = sl_send_reply(msg, code, r); - if (r!=reason.s) pkg_free(r); + if ((r!=reason.s) && (r!=default_reason.s)) pkg_free(r); return ret; } diff --git a/modules/sl/sl_funcs.c b/modules/sl/sl_funcs.c index 18d4217..388f79c 100644 --- a/modules/sl/sl_funcs.c +++ b/modules/sl/sl_funcs.c @@ -183,7 +183,7 @@ int sl_reply_helper(struct sip_msg *msg, int code, char *reason, str *tag) } if (!buf.s) { - DBG("DEBUG: sl_send_reply: response building failed\n"); + DBG("DEBUG: sl_reply_helper: response building failed\n"); goto error; }

11 years, 10 months

git:3.3: modules_k/registrar: Fixed some errors in module documentation

by Peter Dunkley

Module: sip-router Branch: 3.3 Commit: 6f47d8ac983cbbd616c7b5b941a8ec671f6e15e6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6f47d8a… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Jul 12 21:46:58 2012 +0100 modules_k/registrar: Fixed some errors in module documentation - Fix by Hugh Waite @ Crocodile RCS (cherry picked from commit 6d040935f31be0098a09f4621874268164f3926a) --- modules_k/registrar/README | 90 +++++++++++++------------- modules_k/registrar/doc/registrar_admin.xml | 6 +- 2 files changed, 48 insertions(+), 48 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=6f4…

11 years, 10 months

git:3.3: core: update printing of socket lists to show the advertised address if set for the socket

by Peter Dunkley

Module: sip-router Branch: 3.3 Commit: 7e412d720b1747fadac3e94c22d270877087b8a0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7e412d7… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Jul 12 21:44:45 2012 +0100 core: update printing of socket lists to show the advertised address if set for the socket - useful for diagnosing what is going on with advertised address - Enhancement added by Hugh Waite @ Crocodile RCS (cherry picked from commit 274969bcca2301c96dbbcc17c5b1d411073c8277) --- socket_info.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/socket_info.c b/socket_info.c index 1ccddfd..7c32a10 100644 --- a/socket_info.c +++ b/socket_info.c @@ -1998,10 +1998,13 @@ void print_all_socket_lists() si->name.s); if (!si->flags & SI_IS_IP) printf(" [%s]", si->address_str.s); - printf( ":%s%s%s\n", + printf( ":%s%s%s", si->port_no_str.s, si->flags & SI_IS_MCAST ? " mcast" : "", si->flags & SI_IS_MHOMED? " mhomed" : ""); + if (si->useinfo.name.s) + printf(" advertise %s", si->useinfo.name.s); + printf("\n"); } } }while((proto=next_proto(proto)));

11 years, 10 months

git:master: modules/ipops: Corrected is_in_subnet() exported function and added is_ip to module C API

by Peter Dunkley

Module: sip-router Branch: master Commit: 8ab4daa7f13a70f1fb77d7a98f11f7290a42c321 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8ab4daa… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Jul 12 21:50:00 2012 +0100 modules/ipops: Corrected is_in_subnet() exported function and added is_ip to module C API - Fixes and enhancements by Hugh Waite @ Crocodile RCS --- modules/ipops/api.c | 12 ++++++++++++ modules/ipops/api.h | 3 +++ modules/ipops/ipops_mod.c | 2 +- 3 files changed, 16 insertions(+), 1 deletions(-) diff --git a/modules/ipops/api.c b/modules/ipops/api.c index 8730be9..8f5a07c 100644 --- a/modules/ipops/api.c +++ b/modules/ipops/api.c @@ -120,6 +120,17 @@ int ipopsapi_ip_is_in_subnet(const str *const ip1, const str *const ip2) /** * */ +int ipopsapi_is_ip(const str * const ip) +{ + if (ip_parser_execute(ip->s, ip->len) != ip_type_error) + return 1; + else + return -1; +} + +/** + * + */ int bind_ipops(ipops_api_t* api) { if (!api) { @@ -128,6 +139,7 @@ int bind_ipops(ipops_api_t* api) } api->compare_ips = ipopsapi_compare_ips; api->ip_is_in_subnet = ipopsapi_ip_is_in_subnet; + api->is_ip = ipopsapi_is_ip; return 0; } diff --git a/modules/ipops/api.h b/modules/ipops/api.h index aa15dca..2a86649 100644 --- a/modules/ipops/api.h +++ b/modules/ipops/api.h @@ -36,12 +36,15 @@ int ipopsapi_compare_ips(const str *const ip1, const str *const ip2); typedef int (*ip_is_in_subnet_f)(const str *const, const str *const); int ipopsapi_ip_is_in_subnet(const str *const ip1, const str *const ip2); +typedef int (*is_ip_f)(const str * const ip); +int ipopsapi_is_ip(const str * const ip); /** * @brief IPOPS API structure */ typedef struct ipops_api { compare_ips_f compare_ips; ip_is_in_subnet_f ip_is_in_subnet; + is_ip_f is_ip; } ipops_api_t; typedef int (*bind_ipops_f)(ipops_api_t* api); diff --git a/modules/ipops/ipops_mod.c b/modules/ipops/ipops_mod.c index 402a8a4..164177b 100644 --- a/modules/ipops/ipops_mod.c +++ b/modules/ipops/ipops_mod.c @@ -108,7 +108,7 @@ static cmd_export_t cmds[] = REQUEST_ROUTE|FAILURE_ROUTE|ONREPLY_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE }, { "is_ip_rfc1918", (cmd_function)w_is_ip_rfc1918, 1, fixup_spve_null, 0, REQUEST_ROUTE|FAILURE_ROUTE|ONREPLY_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE }, - { "is_in_subnet", (cmd_function)w_ip_is_in_subnet, 2, fixup_spve_null, 0, + { "is_in_subnet", (cmd_function)w_ip_is_in_subnet, 2, fixup_spve_spve, 0, REQUEST_ROUTE|FAILURE_ROUTE|ONREPLY_ROUTE|BRANCH_ROUTE|LOCAL_ROUTE }, { "bind_ipops", (cmd_function)bind_ipops, 0, 0, 0, 0}, { 0, 0, 0, 0, 0, 0 }

11 years, 10 months

← Newer
1
...
6
7
8
9
10
11
12
...
18
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2012