sr-dev November 2012

sr-dev@lists.kamailio.org

28 participants
122 discussions

git:master: sdpops: internal function w_get_sdp renamed to w_get_sdp
by Daniel-Constantin Mierla 20 Nov '12

20 Nov '12

Module: sip-router Branch: master Commit: 6df74c2fb208c364b5d50e9d87f80120de93c945 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6df74c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 20 21:55:51 2012 +0100 sdpops: internal function w_get_sdp renamed to w_get_sdp - match the exported name pattern --- modules/sdpops/sdpops_mod.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c index 086d93c..745ca2b 100644 --- a/modules/sdpops/sdpops_mod.c +++ b/modules/sdpops/sdpops_mod.c @@ -50,7 +50,7 @@ static int w_sdp_with_codecs_by_id(sip_msg_t* msg, char* codec, char *bar); static int w_sdp_with_codecs_by_name(sip_msg_t* msg, char* codec, char *bar); static int w_sdp_remove_media(sip_msg_t* msg, char* media, char *bar); static int w_sdp_print(sip_msg_t* msg, char* level, char *bar); -static int w_get_sdp(sip_msg_t* msg, char *bar); +static int w_sdp_get(sip_msg_t* msg, char *bar); static int mod_init(void); @@ -79,7 +79,7 @@ static cmd_export_t cmds[] = { 1, fixup_spve_null, 0, ANY_ROUTE}, {"sdp_print", (cmd_function)w_sdp_print, 1, fixup_igp_null, 0, ANY_ROUTE}, - {"sdp_get", (cmd_function)w_get_sdp, + {"sdp_get", (cmd_function)w_sdp_get, 1, 0, 0, ANY_ROUTE}, {"bind_sdpops", (cmd_function)bind_sdpops, 1, 0, 0, 0}, @@ -1054,7 +1054,7 @@ static int w_sdp_print(sip_msg_t* msg, char* level, char *bar) /** * */ -static int w_get_sdp(sip_msg_t* msg, char *avp) +static int w_sdp_get(sip_msg_t* msg, char *avp) { sdp_info_t *sdp = NULL; int_str avp_val;

1 0

[tracker] Comment added: uacreg functionality: kamailio sending zeroes in header
by sip-router 20 Nov '12

20 Nov '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#254 - uacreg functionality: kamailio sending zeroes in header User who did this - Rus (Sfinx) ---------- My shame: it was bug in tcpdump-4.0, upgrading to tcpdump-4.3 show full packet ;) ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=254#comment752 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: uacreg functionality: kamailio sending zeroes in header
by sip-router 20 Nov '12

20 Nov '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#254 - uacreg functionality: kamailio sending zeroes in header User who did this - Daniel-Constantin Mierla (miconda) ---------- I just did a quick test and worked fine for me: <code> REGISTER sip:192.168.178.100 SIP/2.0. Via: SIP/2.0/UDP 127.0.0.1;branch=z9hG4bKc91d.d7e8f323.0. To: sip:1qaz@192.168.178.100. From: sip:1qaz@192.168.178.100;tag=533cb9e91f4b999cf76861cbb9ed54ed-1aa5. CSeq: 10 REGISTER. Call-ID: 40dfe6702b91e473-18933(a)127.0.0.1. Content-Length: 0. User-Agent: kamailio (3.4.0-dev5 (x86_64/darwin)). Contact: <sip:1qaz@127.0.0.1:5086>. Expires: 600. . </code> My record in uacreg is: <code> *************************** 1. row *************************** id: 1 l_uuid: 1qaz l_username: 1qaz l_domain: test.com r_username: 1qaz r_domain: 192.168.178.100 realm: test.com auth_username: 1qaz auth_password: 1qaz auth_proxy: sip:127.0.0.1:6080 expires: 600 </code> Can you set debug=4 in config, keep only one record in uacreg table and add the log messages here? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=254#comment751 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: AUTH minor documentation updates
by Olle E. Johansson 19 Nov '12

19 Nov '12

Module: sip-router Branch: master Commit: 15fdde4fa1d662228568cc92e375d94dd86f2578 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=15fdde4… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Mon Nov 19 15:53:17 2012 +0100 AUTH minor documentation updates --- modules/auth/README | 11 ++++++----- modules/auth/doc/params.xml | 12 ++++++------ 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/modules/auth/README b/modules/auth/README index fa90d51..a429a53 100644 --- a/modules/auth/README +++ b/modules/auth/README @@ -443,15 +443,16 @@ modparam("auth", "otn_in_flight_order", 23) # 8 Mb (1Mb memory) 1.3.10. secret (string) - Secret phrase used to calculate the nonce value. The default is to use - a random value generated from the random source in the core. + Secret phrase used to calculate the nonce value used to challenge the + client for authentication. If you use multiple servers in your installation, and would like to authenticate on the second server against the nonce generated at the first one its necessary to explicitly set the secret to the same value - on all servers. However, the use of a shared (and fixed) secret as - nonce is insecure, much better is to stay with the default. Any clients - should send the reply to the server that issued the request. + on all servers. However, as the use of a shared (and fixed) secret as + nonce is insecure, it is much better is to stay with the default. Any + clients should send the authenticated request to the server that issued + the challenge. Default value is randomly generated string. diff --git a/modules/auth/doc/params.xml b/modules/auth/doc/params.xml index 2fd35ba..f9c1f8a 100644 --- a/modules/auth/doc/params.xml +++ b/modules/auth/doc/params.xml @@ -548,15 +548,15 @@ modparam("auth", "otn_in_flight_order", 23) # 8 Mb (1Mb memory) <section id="auth.secret"> <title><varname>secret</varname> (string)</title> - <para>Secret phrase used to calculate the nonce value. - The default is to use a random value generated from the random source - in the core.</para> + <para>Secret phrase used to calculate the nonce value used to challenge + the client for authentication.</para> <para>If you use multiple servers in your installation, and would like to authenticate on the second server against the nonce generated at the first one its necessary to explicitly set the secret to the same value - on all servers. However, the use of a shared (and fixed) secret as - nonce is insecure, much better is to stay with the default. Any - clients should send the reply to the server that issued the request. + on all servers. However, as the use of a shared (and fixed) secret as + nonce is insecure, it is much better is to stay with the default. Any + clients should send the authenticated request to the server that + issued the challenge. </para> <para> Default value is randomly generated string.

1 0

git:master: auth Update documentation for the "secret" parameter
by Olle E. Johansson 19 Nov '12

19 Nov '12

Module: sip-router Branch: master Commit: eace40eb04ff038fce0f81dc1c08864e1e966e98 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=eace40e… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Mon Nov 19 15:44:54 2012 +0100 auth Update documentation for the "secret" parameter Thanks to Carsten Bock for finding this in the 1.5 documentation. --- modules/auth/README | 18 ++++++++++++++---- modules/auth/doc/params.xml | 10 ++++++++++ 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/modules/auth/README b/modules/auth/README index 607eae1..fa90d51 100644 --- a/modules/auth/README +++ b/modules/auth/README @@ -15,7 +15,7 @@ Daniel-Constantin Mierla asipto.com <miconda(a)gmail.com> - Copyright © 2002, 2003 FhG FOKUS + Copyright � 2002, 2003 FhG FOKUS __________________________________________________________________ 1.1. Overview @@ -443,6 +443,16 @@ modparam("auth", "otn_in_flight_order", 23) # 8 Mb (1Mb memory) 1.3.10. secret (string) + Secret phrase used to calculate the nonce value. The default is to use + a random value generated from the random source in the core. + + If you use multiple servers in your installation, and would like to + authenticate on the second server against the nonce generated at the + first one its necessary to explicitly set the secret to the same value + on all servers. However, the use of a shared (and fixed) secret as + nonce is insecure, much better is to stay with the default. Any clients + should send the reply to the server that issued the request. + Default value is randomly generated string. Example 10. Setting secret module parameter @@ -507,7 +517,7 @@ modparam("auth", "force_stateless_reply", 1) records (not all SIP clients support SRV lookup), a subdomain of the master domain can be defined for SIP purposes (like sip.mydomain.net pointing to same IP address as the SRV record for mydomain.net). By - ignoring the realm_prefix “sip.”, at authentication, sip.mydomain.net + ignoring the realm_prefix "sip.", at authentication, sip.mydomain.net will be equivalent to mydomain.net . Default value is empty string. @@ -571,7 +581,7 @@ if (has_credentials("myrealm")) { * realm - Realm is a opaque string that the user agent should present to the user so he can decide what username and password to use. Usually this is domain of the host the server is running on. - It must not be empty string “”. In case of REGISTER requests To + It must not be empty string "". In case of REGISTER requests To header field domain (e.g., variable $td) can be used (because this header field represents the user being registered), for all other messages From header field domain can be used (e.g., variable $fd). @@ -658,7 +668,7 @@ if (!auth_check("$fd", "subscriber", "1")) { * realm - Realm is a opaque string that the user agent should present to the user so he can decide what username and password to use. Usually this is domain of the host the server is running on. - It must not be empty string “”. In case of REGISTER requests To + It must not be empty string "". In case of REGISTER requests To header field domain (e.g., varibale $td) can be used (because this header field represents a user being registered), for all other messages From header field domain can be used (e.g., varibale $fd). diff --git a/modules/auth/doc/params.xml b/modules/auth/doc/params.xml index ab95963..2fd35ba 100644 --- a/modules/auth/doc/params.xml +++ b/modules/auth/doc/params.xml @@ -548,6 +548,16 @@ modparam("auth", "otn_in_flight_order", 23) # 8 Mb (1Mb memory) <section id="auth.secret"> <title><varname>secret</varname> (string)</title> + <para>Secret phrase used to calculate the nonce value. + The default is to use a random value generated from the random source + in the core.</para> + <para>If you use multiple servers in your installation, and would like to + authenticate on the second server against the nonce generated at the + first one its necessary to explicitly set the secret to the same value + on all servers. However, the use of a shared (and fixed) secret as + nonce is insecure, much better is to stay with the default. Any + clients should send the reply to the server that issued the request. + </para> <para> Default value is randomly generated string. </para>

1 0

git:master: Merge branch 'master' of ssh://git.sip-router.org/sip-router
by Olle E. Johansson 19 Nov '12

19 Nov '12

Module: sip-router Branch: master Commit: 139acd4a3ba4117d218c8ef4d95710dc15fb8bc7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=139acd4… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Mon Nov 19 15:45:38 2012 +0100 Merge branch 'master' of ssh://git.sip-router.org/sip-router * 'master' of ssh://git.sip-router.org/sip-router: core: handle '\r' as end of included file name pkg/kamailio/(centos|fedora): turned on MEMDBG for development builds ---

1 0

XMLRPC not compliant with standard
by Olle E. Johansson 19 Nov '12

19 Nov '12

Friends, I've been trying to play with the XMLRPC module in Kamailio. It turns out that the answers in some modules are not XML-rpc compliant, so my PHP based XMLrpc library only shows one part of the response. XMLrpc standards says that there has to be ONE and only ONE structure in a response. When running "htable.dump" I get one param struct per object. There should be a common structure encapsultating all the responses. It seems like the output of sercmd allows this, but XMLrpc does not. One quick fix would be to change the xmlrpc module and add an encapsulating structure. This would of course break a lot of clients. We could make it an option so that we're backwards compatible, like a "xmlrpccompliant" modparam. Another fix would be to change all the modules, but that would also change the SER RPC output, which would be a far bigger change. Anyone that has seen the same issues? Agree with a fix? /O

4 9

Corelog and debug
by Olle E. Johansson 19 Nov '12

19 Nov '12

Hi! I would like to silence the debugging from Kamailio while still have my own xlog("L_DBG", ""); being sent to syslog. The corelog config parameter seems to exist to limit what the kamailio server puts in syslog, while debug is valid for both core and my script logs. If I set corelog to -1 and debug to 3, I would expect to get no core L_DBG messages in syslog, but it is full with it... Is this because corelog is not fully implemented across Kamailio or are my assumptions wrong? The corelog documentation in the cookbook says that the corelog is used to print "some log messages". Would it be worth the effort to make this kamailio-wide? /O

2 2

[tracker] Comment added: uacreg functionality: kamailio sending zeroes in header
by sip-router 19 Nov '12

19 Nov '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#254 - uacreg functionality: kamailio sending zeroes in header User who did this - Rus (Sfinx) ---------- Sure, but I think this is standart parameters : Parameters : modparam("uac", "reg_db_url", SOME_MYSQL_DBURL) modparam("uac", "reg_timer_interval", 60) modparam("uac", "reg_contact_addr", "sip.server.com:5060") User Record : insert into uacreg (l_uuid, l_username, l_domain, r_username, r_domain, realm, auth_username, auth_password, auth_proxy, expires) values ('XXXXXXXX', 'line-XXXXXXXX', 'demo.host.com', 'XXXXXXXX', 'sip.server.com', 'sip.server.com', 'XXXXXXXX', 'some_secret', 'sip:sip.server.com', 60); ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=254#comment750 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: core: handle '\r' as end of included file name
by Daniel-Constantin Mierla 19 Nov '12

19 Nov '12

Module: sip-router Branch: master Commit: dc0bc9de9528e80cd8bc61201ce82db1a785baf4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dc0bc9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 19 10:45:41 2012 +0100 core: handle '\r' as end of included file name - reported by Pirjo Ahvenainen --- cfg.lex | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cfg.lex b/cfg.lex index b0f4733..d864d42 100644 --- a/cfg.lex +++ b/cfg.lex @@ -1341,7 +1341,7 @@ IMPORTFILE "import_file" <SELECT>. { unput(yytext[0]); state = INITIAL_S; BEGIN(INITIAL); } /* Rescan the token in INITIAL state */ <INCLF>[ \t]* /* eat the whitespace */ -<INCLF>[^ \t\n]+ { /* get the include file name */ +<INCLF>[^ \t\r\n]+ { /* get the include file name */ memset(&s_buf, 0, sizeof(s_buf)); addstr(&s_buf, yytext, yyleng); r = pp_subst_run(&s_buf.s); @@ -1355,7 +1355,7 @@ IMPORTFILE "import_file" } <IMPTF>[ \t]* /* eat the whitespace */ -<IMPTF>[^ \t\n]+ { /* get the import file name */ +<IMPTF>[^ \t\r\n]+ { /* get the import file name */ memset(&s_buf, 0, sizeof(s_buf)); addstr(&s_buf, yytext, yyleng); r = pp_subst_run(&s_buf.s);

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
13
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2012