sr-dev October 2012

sr-dev@lists.kamailio.org

31 participants
241 discussions

[tracker] Task closed: Kamailio version 3.1.2 crash when memory realloc
by sip-router 25 Oct '12

25 Oct '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#247 - Kamailio version 3.1.2 crash when memory realloc User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Reopen if the patch for free(0) didn't work. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=247 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: 3.1.2 memory crash
by sip-router 25 Oct '12

25 Oct '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#250 - 3.1.2 memory crash User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Reopen if the suggested patch didn't fix it. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=250 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Caching $hdr psuedo-variables causes a error when called from LUA
by sip-router 25 Oct '12

25 Oct '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#252 - Caching $hdr psuedo-variables causes a error when called from LUA User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Patch applied on master and 3.3 branches. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=252 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: sercmd: builds and installs as kamcmd when FLAVOUR=kamailio
by Daniel-Constantin Mierla 25 Oct '12

25 Oct '12

Module: sip-router Branch: master Commit: e7e131d5b5abec9440f0963375abd1940d65e3f4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e7e131d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Oct 24 00:05:13 2012 +0200 sercmd: builds and installs as kamcmd when FLAVOUR=kamailio - avoid packaging conflicts with ser (both packages attempt to install same file) --- utils/sercmd/Makefile | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/utils/sercmd/Makefile b/utils/sercmd/Makefile index 2cb406a..dacd064 100644 --- a/utils/sercmd/Makefile +++ b/utils/sercmd/Makefile @@ -4,8 +4,13 @@ include $(COREPATH)/Makefile.defs include $(COREPATH)/Makefile.targets auto_gen= -NAME=sercmd RELEASE=0.2 +UTIL_SRC_NAME=sercmd +ifeq ($(FLAVOUR),kamailio) + NAME=kamcmd +else + NAME=sercmd +endif readline_locations= /usr/include/readline/readline.h \ $(LOCALBASE)/include/readline/readline.h

2 4

git:3.3: core: use cloned value to parse pv name for caching
by Daniel-Constantin Mierla 25 Oct '12

25 Oct '12

Module: sip-router Branch: 3.3 Commit: 890f785bc05f137af624306f51874c17bef10d30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=890f785… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 25 09:25:17 2012 +0200 core: use cloned value to parse pv name for caching - patch by Hugh Waite (cherry picked from commit 22f9a675863f85d934afa5e7c09061c66497042b) --- pvapi.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pvapi.c b/pvapi.c index d1ebfe6..64878f2 100644 --- a/pvapi.c +++ b/pvapi.c @@ -272,17 +272,17 @@ pv_spec_t* pv_cache_add(str *name) LM_ERR("no more memory\n"); return NULL; } - memset(pvn, 0, sizeof(pv_item_t) + name->len + 1); - p = pv_parse_spec(name, &pvn->spec); + memset(pvn, 0, sizeof(pv_cache_t) + name->len + 1); + pvn->pvname.len = name->len; + pvn->pvname.s = (char*)pvn + sizeof(pv_cache_t); + memcpy(pvn->pvname.s, name->s, name->len); + p = pv_parse_spec(&pvn->pvname, &pvn->spec); if(p==NULL) { pkg_free(pvn); return NULL; } - pvn->pvname.len = name->len; - pvn->pvname.s = (char*)pvn + sizeof(pv_cache_t); - memcpy(pvn->pvname.s, name->s, name->len); pvn->pvid = pvid; pvn->next = _pv_cache[pvid%PV_CACHE_SIZE]; _pv_cache[pvid%PV_CACHE_SIZE] = pvn;

1 0

git:master: core: use cloned value to parse pv name for caching
by Daniel-Constantin Mierla 25 Oct '12

25 Oct '12

Module: sip-router Branch: master Commit: 22f9a675863f85d934afa5e7c09061c66497042b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=22f9a67… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Oct 25 09:25:17 2012 +0200 core: use cloned value to parse pv name for caching - patch by Hugh Waite --- pvapi.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pvapi.c b/pvapi.c index 209d835..b438362 100644 --- a/pvapi.c +++ b/pvapi.c @@ -272,17 +272,17 @@ pv_spec_t* pv_cache_add(str *name) LM_ERR("no more memory\n"); return NULL; } - memset(pvn, 0, sizeof(pv_item_t) + name->len + 1); - p = pv_parse_spec(name, &pvn->spec); + memset(pvn, 0, sizeof(pv_cache_t) + name->len + 1); + pvn->pvname.len = name->len; + pvn->pvname.s = (char*)pvn + sizeof(pv_cache_t); + memcpy(pvn->pvname.s, name->s, name->len); + p = pv_parse_spec(&pvn->pvname, &pvn->spec); if(p==NULL) { pkg_free(pvn); return NULL; } - pvn->pvname.len = name->len; - pvn->pvname.s = (char*)pvn + sizeof(pv_cache_t); - memcpy(pvn->pvname.s, name->s, name->len); pvn->pvid = pvid; pvn->next = _pv_cache[pvid%PV_CACHE_SIZE]; _pv_cache[pvid%PV_CACHE_SIZE] = pvn;

1 0

[tracker] Comment added: Caching $hdr psuedo-variables causes a error when called from LUA
by sip-router 24 Oct '12

24 Oct '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#252 - Caching $hdr psuedo-variables causes a error when called from LUA User who did this - Daniel-Constantin Mierla (miconda) ---------- The patch is good. Also, the memset issue you spot has to be added, it is not in the patch. You can go ahead and commit via Peter if you wish, or I can do it tomorrow morning. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=252#comment737 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Caching $hdr psuedo-variables causes a error when called from LUA (Attachment added)
by sip-router 24 Oct '12

24 Oct '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#252 - Caching $hdr psuedo-variables causes a error when called from LUA User who did this - Hugh Waite (hugh.waite) ---------- This is a diff of my suggested change. I know that the pv name string will be valid for the lifetime of the pv_cache_t structure, but I don't know if the pv_spec_t structure has the same lifespan. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=252#comment736 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Caching $hdr psuedo-variables causes a error when called from LUA
by sip-router 24 Oct '12

24 Oct '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#252 - Caching $hdr psuedo-variables causes a error when called from LUA User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you attach 'git diff'? it's easier to spot the changes. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=252#comment735 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: Caching $hdr psuedo-variables causes a error when called from LUA
by sip-router 24 Oct '12

24 Oct '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Hugh Waite (hugh.waite) Attached to Project - sip-router Summary - Caching $hdr psuedo-variables causes a error when called from LUA Task Type - Bug Report Category - Modules kamailio Status - Unconfirmed Assigned To - Operating System - All Severity - High Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - We have been using the sr.pv.get() LUA function to extract custom SIP headers, but this has inconsistant results. I have tracked this back to a bug in the pv module. However, I am not familiar enough with the pv_cache/pv_spec structure to know how to fix this. In modules_k/pv/pv_core.c:pv_parse_hdr_name() the name of a header to look up is parsed and stored in the pv_spec_t structure. If this is an 'unknown' header, the string pointer is stored in the sructure (line 2487). 2478 sp->pvp.pvn.type = PV_NAME_INTSTR; 2479 if (hdr.type!=HDR_OTHER_T && hdr.type!=HDR_ERROR_T) 2480 { 2481 LM_DBG("using hdr type (%d) instead of <%.*s>\n", 2482 hdr.type, in->len, in->s); 2483 sp->pvp.pvn.u.isname.type = 0; 2484 sp->pvp.pvn.u.isname.name.n = hdr.type; 2485 } else { 2486 sp->pvp.pvn.u.isname.type = AVP_NAME_STR; 2487 sp->pvp.pvn.u.isname.name.s = *in; <------- 2488 } 2489 return 0; 2490 error: 2491 return -1; 2492 } If this has been called from LUA (modules/app_lua/app_lua_sr.c:sr_lua_pv_get():895) this string is part of the lua environment which goes out of scope - causing a problem. 883 pvn.s = (char*)lua_tostring(L, -1); 884 if(pvn.s==NULL || env_L->msg==NULL) 885 return 0; 886 887 pvn.len = strlen(pvn.s); 888 LM_DBG("pv get: %s\n", pvn.s); 889 pl = pv_locate_name(&pvn); 890 if(pl != pvn.len) 891 { 892 LM_ERR("invalid pv [%s] (%d/%d)\n", pvn.s, pl, pvn.len); 893 return 0; 894 } 895 pvs = pv_cache_get(&pvn); <------------- Local variable passed in 896 if(pvs==NULL) 897 { 898 LM_ERR("cannot get pv spec for [%s]\n", pvn.s); 899 return 0; 900 } When the pv cache structure is created, memory is allocated to duplicate the PV name(pvapi.c:269). Is it safe to pass the newly allocated string into the parse_pv_spec function? For example: (this is modified from the trunk version) 257 pv_spec_t* pv_cache_add(str *name) 258 { 259 pv_cache_t *pvn; 260 unsigned int pvid; 261 char *p; 262 263 if(_pv_cache_set==0) 264 { 265 LM_DBG("PV cache not initialized, doing it now\n"); 266 pv_init_cache(); 267 } 268 pvid = get_hash1_raw(name->s, name->len); 269 pvn = (pv_cache_t*)pkg_malloc(sizeof(pv_cache_t) + name->len + 1); 270 if(pvn==0) 271 { 272 LM_ERR("no more memory\n"); 273 return NULL; 274 } 275 memset(pvn, 0, sizeof(pv_cache_t) + name->len + 1); <------- Note: There is a separate initialisation bug on this line. It uses sizeof(pv_item_t) in trunk! 276 pvn->pvname.len = name->len; 277 pvn->pvname.s = (char*)pvn + sizeof(pv_cache_t); 278 memcpy(pvn->pvname.s, name->s, name->len); 279 p = pv_parse_spec(&pvn->pvname, &pvn->spec); <------- Is this safe? 280 281 if(p==NULL) 282 { 283 pkg_free(pvn); 284 return NULL; 285 } 286 pvn->pvid = pvid; 287 pvn->next = _pv_cache[pvid%PV_CACHE_SIZE]; 288 _pv_cache[pvid%PV_CACHE_SIZE] = pvn; 289 290 LM_DBG("pvar [%.*s] added in cache\n", name->len, name->s); 291 return &pvn->spec; 292 } More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=252 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2012