sr-dev January 2012

sr-dev@lists.kamailio.org

25 participants
165 discussions

by Daniel-Constantin Mierla

Hello, the repositories with build RPMs done via OpenSUSE Build Services (OBS) were updated. Fedora 14 is no longer offered by OBS, instead I added support for Fedora 15 and 16. Also, there are now dedicated builds for RedHat 6 and OpenSUSE 12.1. Links to repos are provided at: * http://www.kamailio.org/wiki/packages/rpms Cheers, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com http://linkedin.com/in/miconda -- http://twitter.com/miconda

12 years, 11 months

unused vars in ser_stun.c

by Juha Heinanen

unused vars in ser_stun.c: ser_stun.c: In function ‘stun_add_address_attr’: ser_stun.c:771: warning: unused variable ‘i’ ser_stun.c:769: warning: unused variable ‘id’ -- juha

12 years, 11 months

some observations on kamailio

by Daniel Pocock

- suid code: I notice that the daemon drops perms before loading the TLS private key file. It would be better to load the file first, so that only root needs read access to the private key - does the current TLS module architecture support that? - comments on 1024 bit RSA: the docs recommend not to use key sizes > 1024. http://kamailio.org/docs/modules/devel/modules/tls.html#certificate However, this seems to be the opposite of what virtually all security experts are now saying: most people believe 2048 is bare minimum and 4096 is the better choice for new deployments where no legacy clients might exist - also related the above issue, the doc says `bytes', I think it means to say 1024 bits - is there a compelling reason to use hard-coded IP addresses for SIP config files? For all my apps that have special IP requirements, I always create dedicated DNS names for each of my virtual/interface IPs. Then I like to put that dedicated DNS name (rather than just the hostname) in the config file. The listen= directive in kamailio.cfg doesn't appear to support this though. - DB setup - I notice that the kamdbctl script expects to make databases and make tables in one step. It is not unusual for a security-conscious admin to deny DBA access from app servers (e.g. the server where kamailio is installed). Maybe kamdbctl needs an option to skip DB creation, and just do table creation? I found I could achieve this just by editing: /usr/lib/kamailio/kamctl/kamdbctl.mysql and commenting the `exit 1' line in this code: if [ $? -ne 0 ] ; then merr "Creating core database and grant privileges failed!" #exit 1 fi - an alternative solution might be to modify kamdbctl so that it just connects in read-only mode to make any checks, writes all the DDL statements to a file that the SIP admin can give to their DBA (or even if it is the same person, they may have a standalone MySQL box, and they don't want to install all of kamdbctl on that box)

12 years, 11 months

git:3.2: Makefile: merged options for gcc 4.5 and 4.6 in 4.5+

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: e0eedbe9d1753aecb58335d20baa8ee8d40d6b0d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e0eedbe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jan 28 11:30:22 2012 +0100 Makefile: merged options for gcc 4.5 and 4.6 in 4.5+ - they were the same (skip mtune parameter for x86_64) (cherry picked from commit 184187a6afe701b793529580fc0f01183eab21f2) --- Makefile.defs | 91 +++++++++++++++++++++++++-------------------------------- 1 files changed, 40 insertions(+), 51 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index dd3067f..011de38 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -293,11 +293,11 @@ ifneq (,$(findstring gcc, $(CC_LONGVER))) -e 's/3\.[4-9]/3.4/' \ -e 's/4\.[0-1]\..*/4.x/' \ -e 's/4\.[0-1]/4.x/' \ - -e 's/4\.[2-46-9]\..*/4.2+/' \ - -e 's/4\.[2-46-9]$$/4.2+/' \ - -e 's/4\.5\..*/4.5/' \ - -e 's/4\.5$$/4.5/') -ifeq (,$(strip $(filter-out 3.0 3.4 4.x 4.2+ 4.5,$(CC_SHORTVER)))) + -e 's/4\.[2-4]\..*/4.2+/' \ + -e 's/4\.[2-4]$$/4.2+/' \ + -e 's/4\.[5-9]\..*/4.5+/' \ + -e 's/4\.[5-9]$$/4.5+/') +ifeq (,$(strip $(filter-out 3.0 3.4 4.x 4.2+ 4.5+,$(CC_SHORTVER)))) # dependencies can be generated on-the-fly while compiling *.c CC_MKDEP_OPTS=-MMD -MP endif # 3.0 <= $(CC_SHORTVER) <= 4.x @@ -866,8 +866,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-g -O9 -funroll-loops -Wcast-align $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,athlon64) CFLAGS+=-m32 -minline-all-stringops \ -falign-loops \ @@ -916,7 +916,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc ifeq ($(CC_NAME), icc) @@ -941,19 +941,9 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-g -O9 -funroll-loops -Wcast-align $(PROFILE) - #if gcc 4.6 - # don't add '-mtune=$(CPU)' - gcc failure -ifeq ($(CC_SHORTVER), 4.6) -$(call set_if_empty,CPU,opteron) - CFLAGS+=-m64 -minline-all-stringops \ - -falign-loops \ - -ftree-vectorize \ - -fno-strict-overflow - LDFLAGS+=-m64 -else - #if gcc 4.5 + #if gcc 4.5+ # don't add '-mtune=$(CPU)' - gcc failure -ifeq ($(CC_SHORTVER), 4.5) +ifeq ($(CC_SHORTVER), 4.5+) $(call set_if_empty,CPU,opteron) CFLAGS+=-m64 -minline-all-stringops \ -falign-loops \ @@ -1012,8 +1002,7 @@ endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x endif # CC_SHORTVER, 4.2+ -endif # CC_SHORTVER, 4.5 -endif # CC_SHORTVER, 4.6 +endif # CC_SHORTVER, 4.5+ else # CC_NAME, gcc ifeq ($(CC_NAME), icc) @@ -1040,8 +1029,8 @@ ifeq ($(CC_NAME), gcc) CFLAGS=-g -O9 -funroll-loops $(PROFILE) \ #-Wcast-align \ #-Wmissing-prototypes - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,ultrasparc) #use 32bit for now CFLAGS+=-m64 -mcpu=ultrasparc \ @@ -1107,7 +1096,7 @@ endif #CC_SHORTVER, 2.9x endif #CC_SHORTVER, 3.0 endif #CC_SHORTVER, 3.4 endif #CC_SHORTVER, 4.x -endif #CC_SHORTVER, 4.5 or 4.2+ +endif #CC_SHORTVER, 4.5+ or 4.2+ else #CC_NAME, gcc ifeq ($(CC_NAME), suncc) @@ -1131,8 +1120,8 @@ ifeq ($(CC_NAME), gcc) CFLAGS=-g -O9 -funroll-loops $(PROFILE) \ #-Wcast-align \ #-Wmissing-prototypes - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,v8) #use 32bit for now CFLAGS+= -mtune=$(CPU) \ @@ -1173,7 +1162,7 @@ endif #CC_SHORTVER, 2.9x endif #CC_SHORTVER, 3.0 endif #CC_SHORTVER, 3.4 endif #CC_SHORTVER, 4.x -endif #CC_SHORTVER, 4.5 or 4.2+ +endif #CC_SHORTVER, 4.5+ or 4.2+ else #CC_NAME, gcc ifeq ($(CC_NAME), suncc) @@ -1194,8 +1183,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-O9 -funroll-loops -fsigned-char $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+= -ftree-vectorize -fno-strict-overflow # not supported on arm: -minline-all-stringops else @@ -1227,7 +1216,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1243,8 +1232,8 @@ ifeq ($(CC_NAME), gcc) #common stuff CFLAGS=-march=armv6 -O9 -funroll-loops -fsigned-char \ $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+= -ftree-vectorize -fno-strict-overflow else #if gcc 4.x+ @@ -1274,7 +1263,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1289,8 +1278,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-O9 -funroll-loops $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+=-march=r3000 -minline-all-stringops \ -ftree-vectorize -fno-strict-overflow else @@ -1321,7 +1310,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1336,8 +1325,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS= -mips2 -O9 -funroll-loops $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+=-minline-all-stringops -ftree-vectorize \ -fno-strict-overflow else @@ -1366,7 +1355,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1381,8 +1370,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS= -mips64 -O9 -funroll-loops $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+=-minline-all-stringops -ftree-vectorize \ -fno-strict-overflow else @@ -1411,7 +1400,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1427,7 +1416,7 @@ ifeq ($(CC_NAME), gcc) #common stuff CFLAGS= -O9 -funroll-loops $(PROFILE) #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+= -fno-strict-overflow # not supported: -minline-all-stringops else @@ -1457,7 +1446,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1472,8 +1461,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS= -O9 -funroll-loops -fsigned-char $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,powerpc) CFLAGS+=-ftree-vectorize \ -fno-strict-overflow \ @@ -1506,7 +1495,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1521,8 +1510,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS= -O9 -funroll-loops -fsigned-char $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,powerpc64) CFLAGS+=-ftree-vectorize \ -fno-strict-overflow \ @@ -1555,7 +1544,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers

12 years, 11 months

git:master: Makefile: merged options for gcc 4.5 and 4.6 in 4.5+

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 184187a6afe701b793529580fc0f01183eab21f2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=184187a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jan 28 11:30:22 2012 +0100 Makefile: merged options for gcc 4.5 and 4.6 in 4.5+ - they were the same (skip mtune parameter for x86_64) --- Makefile.defs | 91 +++++++++++++++++++++++++-------------------------------- 1 files changed, 40 insertions(+), 51 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index b737bd6..fcdc51a 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -293,11 +293,11 @@ ifneq (,$(findstring gcc, $(CC_LONGVER))) -e 's/3\.[4-9]/3.4/' \ -e 's/4\.[0-1]\..*/4.x/' \ -e 's/4\.[0-1]/4.x/' \ - -e 's/4\.[2-46-9]\..*/4.2+/' \ - -e 's/4\.[2-46-9]$$/4.2+/' \ - -e 's/4\.5\..*/4.5/' \ - -e 's/4\.5$$/4.5/') -ifeq (,$(strip $(filter-out 3.0 3.4 4.x 4.2+ 4.5,$(CC_SHORTVER)))) + -e 's/4\.[2-4]\..*/4.2+/' \ + -e 's/4\.[2-4]$$/4.2+/' \ + -e 's/4\.[5-9]\..*/4.5+/' \ + -e 's/4\.[5-9]$$/4.5+/') +ifeq (,$(strip $(filter-out 3.0 3.4 4.x 4.2+ 4.5+,$(CC_SHORTVER)))) # dependencies can be generated on-the-fly while compiling *.c CC_MKDEP_OPTS=-MMD -MP endif # 3.0 <= $(CC_SHORTVER) <= 4.x @@ -866,8 +866,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-g -O9 -funroll-loops -Wcast-align $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,athlon64) CFLAGS+=-m32 -minline-all-stringops \ -falign-loops \ @@ -916,7 +916,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc ifeq ($(CC_NAME), icc) @@ -941,19 +941,9 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-g -O9 -funroll-loops -Wcast-align $(PROFILE) - #if gcc 4.6 - # don't add '-mtune=$(CPU)' - gcc failure -ifeq ($(CC_SHORTVER), 4.6) -$(call set_if_empty,CPU,opteron) - CFLAGS+=-m64 -minline-all-stringops \ - -falign-loops \ - -ftree-vectorize \ - -fno-strict-overflow - LDFLAGS+=-m64 -else - #if gcc 4.5 + #if gcc 4.5+ # don't add '-mtune=$(CPU)' - gcc failure -ifeq ($(CC_SHORTVER), 4.5) +ifeq ($(CC_SHORTVER), 4.5+) $(call set_if_empty,CPU,opteron) CFLAGS+=-m64 -minline-all-stringops \ -falign-loops \ @@ -1012,8 +1002,7 @@ endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x endif # CC_SHORTVER, 4.2+ -endif # CC_SHORTVER, 4.5 -endif # CC_SHORTVER, 4.6 +endif # CC_SHORTVER, 4.5+ else # CC_NAME, gcc ifeq ($(CC_NAME), icc) @@ -1040,8 +1029,8 @@ ifeq ($(CC_NAME), gcc) CFLAGS=-g -O9 -funroll-loops $(PROFILE) \ #-Wcast-align \ #-Wmissing-prototypes - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,ultrasparc) #use 32bit for now CFLAGS+=-m64 -mcpu=ultrasparc \ @@ -1107,7 +1096,7 @@ endif #CC_SHORTVER, 2.9x endif #CC_SHORTVER, 3.0 endif #CC_SHORTVER, 3.4 endif #CC_SHORTVER, 4.x -endif #CC_SHORTVER, 4.5 or 4.2+ +endif #CC_SHORTVER, 4.5+ or 4.2+ else #CC_NAME, gcc ifeq ($(CC_NAME), suncc) @@ -1131,8 +1120,8 @@ ifeq ($(CC_NAME), gcc) CFLAGS=-g -O9 -funroll-loops $(PROFILE) \ #-Wcast-align \ #-Wmissing-prototypes - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,v8) #use 32bit for now CFLAGS+= -mtune=$(CPU) \ @@ -1173,7 +1162,7 @@ endif #CC_SHORTVER, 2.9x endif #CC_SHORTVER, 3.0 endif #CC_SHORTVER, 3.4 endif #CC_SHORTVER, 4.x -endif #CC_SHORTVER, 4.5 or 4.2+ +endif #CC_SHORTVER, 4.5+ or 4.2+ else #CC_NAME, gcc ifeq ($(CC_NAME), suncc) @@ -1194,8 +1183,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-O9 -funroll-loops -fsigned-char $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+= -ftree-vectorize -fno-strict-overflow # not supported on arm: -minline-all-stringops else @@ -1227,7 +1216,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1243,8 +1232,8 @@ ifeq ($(CC_NAME), gcc) #common stuff CFLAGS=-march=armv6 -O9 -funroll-loops -fsigned-char \ $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+= -ftree-vectorize -fno-strict-overflow else #if gcc 4.x+ @@ -1274,7 +1263,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1289,8 +1278,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-O9 -funroll-loops $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+=-march=r3000 -minline-all-stringops \ -ftree-vectorize -fno-strict-overflow else @@ -1321,7 +1310,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1336,8 +1325,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS= -mips2 -O9 -funroll-loops $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+=-minline-all-stringops -ftree-vectorize \ -fno-strict-overflow else @@ -1366,7 +1355,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1381,8 +1370,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS= -mips64 -O9 -funroll-loops $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+=-minline-all-stringops -ftree-vectorize \ -fno-strict-overflow else @@ -1411,7 +1400,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1427,7 +1416,7 @@ ifeq ($(CC_NAME), gcc) #common stuff CFLAGS= -O9 -funroll-loops $(PROFILE) #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+= -fno-strict-overflow # not supported: -minline-all-stringops else @@ -1457,7 +1446,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1472,8 +1461,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS= -O9 -funroll-loops -fsigned-char $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,powerpc) CFLAGS+=-ftree-vectorize \ -fno-strict-overflow \ @@ -1506,7 +1495,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers @@ -1521,8 +1510,8 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS= -O9 -funroll-loops -fsigned-char $(PROFILE) - #if gcc 4.5 or 4.2+ -ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER)))) + #if gcc 4.5+ or 4.2+ +ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,powerpc64) CFLAGS+=-ftree-vectorize \ -fno-strict-overflow \ @@ -1555,7 +1544,7 @@ endif # CC_SHORTVER, 2.9x endif # CC_SHORTVER, 3.0 endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x -endif # CC_SHORTVER, 4.5 or 4.2+ +endif # CC_SHORTVER, 4.5+ or 4.2+ else # CC_NAME, gcc #other compilers

12 years, 11 months

git:3.2: Makefile: skip mtune parameter for gcc 4.6 on x86_64

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: 1a155eb6641e640aceb62c293a7cb3bc76724db6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1a155eb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jan 28 10:24:51 2012 +0100 Makefile: skip mtune parameter for gcc 4.6 on x86_64 - it is redundant and throws error, at least on opensuse 12.1 (cherry picked from commit d97bf62975a1f9bbeb497145605879ab1fc4877f) --- Makefile.defs | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index d460731..dd3067f 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -941,6 +941,16 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-g -O9 -funroll-loops -Wcast-align $(PROFILE) + #if gcc 4.6 + # don't add '-mtune=$(CPU)' - gcc failure +ifeq ($(CC_SHORTVER), 4.6) +$(call set_if_empty,CPU,opteron) + CFLAGS+=-m64 -minline-all-stringops \ + -falign-loops \ + -ftree-vectorize \ + -fno-strict-overflow + LDFLAGS+=-m64 +else #if gcc 4.5 # don't add '-mtune=$(CPU)' - gcc failure ifeq ($(CC_SHORTVER), 4.5) @@ -1003,6 +1013,7 @@ endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x endif # CC_SHORTVER, 4.2+ endif # CC_SHORTVER, 4.5 +endif # CC_SHORTVER, 4.6 else # CC_NAME, gcc ifeq ($(CC_NAME), icc)

12 years, 11 months

git:master: Makefile: skip mtune parameter for gcc 4.6 on x86_64

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: d97bf62975a1f9bbeb497145605879ab1fc4877f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d97bf62… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jan 28 10:24:51 2012 +0100 Makefile: skip mtune parameter for gcc 4.6 on x86_64 - it is redundant and throws error, at least on opensuse 12.1 --- Makefile.defs | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index 0c7cde0..b737bd6 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -941,6 +941,16 @@ ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff CFLAGS=-g -O9 -funroll-loops -Wcast-align $(PROFILE) + #if gcc 4.6 + # don't add '-mtune=$(CPU)' - gcc failure +ifeq ($(CC_SHORTVER), 4.6) +$(call set_if_empty,CPU,opteron) + CFLAGS+=-m64 -minline-all-stringops \ + -falign-loops \ + -ftree-vectorize \ + -fno-strict-overflow + LDFLAGS+=-m64 +else #if gcc 4.5 # don't add '-mtune=$(CPU)' - gcc failure ifeq ($(CC_SHORTVER), 4.5) @@ -1003,6 +1013,7 @@ endif # CC_SHORTVER, 3.4 endif # CC_SHORTVER, 4.x endif # CC_SHORTVER, 4.2+ endif # CC_SHORTVER, 4.5 +endif # CC_SHORTVER, 4.6 else # CC_NAME, gcc ifeq ($(CC_NAME), icc)

12 years, 11 months

git:3.2: ctl: compile time option to use system memory allocator

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: 99221ad15446a92352a168b96ef013d1db6fb290 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=99221ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jan 12 09:18:31 2012 +0100 ctl: compile time option to use system memory allocator - flag in module Makefile: -DCTL_SYSTEM_MALLOC - turned on for the moment (cherry picked from commit 55a3671f99c31455d2d460ef81a0bc6dabd1c338) --- modules/ctl/Makefile | 2 + modules/ctl/binrpc_run.c | 43 ++++++++++++++++++----------------- modules/ctl/ctl.h | 44 ++++++++++++++++++++++++++++++++++++ modules/ctl/ctrl_socks.c | 20 +++++++++------- modules/ctl/fifo_server.c | 55 +++++++++++++++++++++++---------------------- modules/ctl/io_listener.c | 5 ++- 6 files changed, 110 insertions(+), 59 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=992…

12 years, 11 months

git:3.2: lib/kcore: set basic receive info for faked message

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: 881d3f0eee3228731dc3c272c2915e87391b5371 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=881d3f0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jan 11 18:40:57 2012 +0100 lib/kcore: set basic receive info for faked message - used UDP/IPv4, port 5060 and 127.0.0.1 for src and dst details (cherry picked from commit 62e5680c9dd4eccb0f177415b7624af832c87693) --- lib/kcore/faked_msg.c | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/lib/kcore/faked_msg.c b/lib/kcore/faked_msg.c index efaba59..824bc32 100644 --- a/lib/kcore/faked_msg.c +++ b/lib/kcore/faked_msg.c @@ -39,7 +39,7 @@ int faked_msg_init(void) /* init faked sip msg */ memcpy(_faked_sip_buf, FAKED_SIP_MSG, FAKED_SIP_MSG_LEN); _faked_sip_buf[FAKED_SIP_MSG_LEN] = '\0'; - + memset(&_faked_msg, 0, sizeof(struct sip_msg)); _faked_msg.buf=_faked_sip_buf; @@ -53,6 +53,17 @@ int faked_msg_init(void) LM_ERR("parse_msg failed\n"); return -1; } + + _faked_msg.rcv.proto = PROTO_UDP; + _faked_msg.rcv.src_port = 5060; + _faked_msg.rcv.src_ip.u.addr32[0] = 0x7f000001; + _faked_msg.rcv.src_ip.af = AF_INET; + _faked_msg.rcv.src_ip.len = 4; + _faked_msg.rcv.dst_port = 5060; + _faked_msg.rcv.dst_ip.u.addr32[0] = 0x7f000001; + _faked_msg.rcv.dst_ip.af = AF_INET; + _faked_msg.rcv.dst_ip.len = 4; + return 0; }

12 years, 11 months

git:3.2: acc_radius/misc_radius(k): use uint32_t type instead of UINT4

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.2 Commit: 7839b60069f6653d2e10829536dc25d931d9c7fd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7839b60… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jan 27 10:54:54 2012 -0500 acc_radius/misc_radius(k): use uint32_t type instead of UINT4 - UINT4 is not defined by freeradiusclient library - libradiusclient-ng typedefs anyhow UINT4 to uint32_t in radiusclient-ng.h (cherry picked from commit 5db228f1a47c8119aeba3731e0129459a6c1e8e4) --- modules_k/acc_radius/acc_radius_mod.c | 8 ++++---- modules_k/misc_radius/functions.c | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/modules_k/acc_radius/acc_radius_mod.c b/modules_k/acc_radius/acc_radius_mod.c index fdeb869..abfb69f 100644 --- a/modules_k/acc_radius/acc_radius_mod.c +++ b/modules_k/acc_radius/acc_radius_mod.c @@ -293,7 +293,7 @@ int acc_radius_init(acc_init_info_t *inf) return 0; } -static inline UINT4 rad_status( struct sip_msg *req, int code ) +static inline uint32_t rad_status( struct sip_msg *req, int code ) { str tag; unsigned int in_dialog_req = 0; @@ -324,7 +324,7 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) { int attr_cnt; VALUE_PAIR *send; - UINT4 av_type; + uint32_t av_type; int offset; int i; @@ -340,14 +340,14 @@ int acc_radius_send_request(struct sip_msg *req, acc_info_t *inf) av_type = rd_vals[RV_SIP_SESSION].v; /* session*/ ADD_RAD_AVPAIR( RA_SERVICE_TYPE, &av_type, -1); - av_type = (UINT4)inf->env->code; /* status=integer */ + av_type = (uint32_t)inf->env->code; /* status=integer */ ADD_RAD_AVPAIR( RA_SIP_RESPONSE_CODE, &av_type, -1); av_type = req->REQ_METHOD; /* method */ ADD_RAD_AVPAIR( RA_SIP_METHOD, &av_type, -1); /* unix time */ - av_type = (UINT4)inf->env->ts; + av_type = (uint32_t)inf->env->ts; ADD_RAD_AVPAIR( RA_TIME_STAMP, &av_type, -1); /* add extra also */ diff --git a/modules_k/misc_radius/functions.c b/modules_k/misc_radius/functions.c index 3bf6e7a..2a42024 100644 --- a/modules_k/misc_radius/functions.c +++ b/modules_k/misc_radius/functions.c @@ -164,7 +164,7 @@ int radius_load_caller_avps(struct sip_msg* _m, char* _caller, char* _s2) { str user; VALUE_PAIR *send, *received; - UINT4 service; + uint32_t service; static char msg[4096]; int extra_cnt, offset, i, res; @@ -245,7 +245,7 @@ int radius_load_callee_avps(struct sip_msg* _m, char* _callee, char* _s2) { str user; VALUE_PAIR *send, *received; - UINT4 service; + uint32_t service; static char msg[4096]; int extra_cnt, offset, i, res; @@ -328,7 +328,7 @@ int radius_is_user_in(struct sip_msg* _m, char* _user, char* _group) { str user, *group; VALUE_PAIR *send, *received; - UINT4 service; + uint32_t service; static char msg[4096]; int extra_cnt, offset, i, res; @@ -423,7 +423,7 @@ int radius_does_uri_user_host_exist(struct sip_msg* _m, str user, str host) { char* at, *user_host; VALUE_PAIR *send, *received; - UINT4 service; + uint32_t service; static char msg[4096]; int extra_cnt, offset, i, res; @@ -589,7 +589,7 @@ int radius_does_uri_user_exist(struct sip_msg* _m, str user) { static char msg[4096]; VALUE_PAIR *send, *received; - UINT4 service; + uint32_t service; int res, extra_cnt, offset, i; send = received = 0;

12 years, 11 months

← Newer
1
2
3
4
5
6
7
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2012