sr-dev September 2011

sr-dev@lists.kamailio.org

40 participants
298 discussions

compiler warning in master
by Juha Heinanen 05 Sep '11

05 Sep '11

this looks pretty serious to me: CC (cc) [L libsrdb1.so.1.0] db_ut.o db_ut.c: In function ‘db_str2time’: db_ut.c:186: warning: implicit declaration of function ‘strptime’ db_ut.c:186: warning: comparison between pointer and integer -- juha

3 5

git:master: lib/srdb1: remove comments on db_val2pv_spec() that resulted from merge error
by Alex Hermann 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: 77d6e6697d8918dfd528046f74a2c97ce4b62a00 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=77d6e66… Author: Alex Hermann <alex(a)speakup.nl> Committer: Alex Hermann <alex(a)speakup.nl> Date: Mon Sep 5 17:24:47 2011 +0200 lib/srdb1: remove comments on db_val2pv_spec() that resulted from merge error --- lib/srdb1/db_ut.h | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/lib/srdb1/db_ut.h b/lib/srdb1/db_ut.h index 790780f..7702753 100644 --- a/lib/srdb1/db_ut.h +++ b/lib/srdb1/db_ut.h @@ -209,9 +209,6 @@ int db_print_set(const db1_con_t* _c, char* _b, const int _l, /** * Convert db_val_t to pv_spec_t - * - * On success, when the PV type is string and longer than 0 chars, - * the string must be freed by the caller after use. * * \param msg sip msg structure * \param dbval database value

1 0

[tracker] Task closed: typo in parser/parse_param.c
by sip-router 05 Sep '11

05 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#147 - typo in parser/parse_param.c User who did this - Timo Reimann (tr) Reason for closing: Fixed Additional comments about closing: Fixed by Sven Knoblich (sven.knoblich(a)1und1.de) on 5.9.2011. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=147 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: modules_k/sqlops: fix memory leak with string memory in sql_xquery()
by Alex Hermann 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: 5105633118009caebf92a35bd23bf2f7cf53548b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5105633… Author: Alex Hermann <alex(a)speakup.nl> Committer: Alex Hermann <alex(a)speakup.nl> Date: Mon Sep 5 17:08:18 2011 +0200 modules_k/sqlops: fix memory leak with string memory in sql_xquery() --- modules_k/sqlops/sql_api.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules_k/sqlops/sql_api.c b/modules_k/sqlops/sql_api.c index d1a4f63..cc0f090 100644 --- a/modules_k/sqlops/sql_api.c +++ b/modules_k/sqlops/sql_api.c @@ -522,6 +522,8 @@ int sql_do_xquery(struct sip_msg *msg, sql_con_t *con, pv_elem_t *query, /* Add column to current row, under the column's name */ LM_DBG("Adding column: %.*s\n", RES_NAMES(db_res)[j]->len, RES_NAMES(db_res)[j]->s); xavp_add_value(RES_NAMES(db_res)[j], &val, &row); + if (val.type == SR_XTYPE_STR && val.v.s.len > 0) + pkg_free(val.v.s.s); } /* Add row to result xavp */ val.type = SR_XTYPE_XAVP;

1 0

git:master: lib/srdb1: Fix memory leak with string memory in db_val2pv_spec ()
by Alex Hermann 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: b4af74a164d521f7db21abb9257e33e6e82dc985 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b4af74a… Author: Alex Hermann <alex(a)speakup.nl> Committer: Alex Hermann <alex(a)speakup.nl> Date: Mon Sep 5 16:41:55 2011 +0200 lib/srdb1: Fix memory leak with string memory in db_val2pv_spec() --- lib/srdb1/db_ut.c | 7 ++++++- lib/srdb1/db_ut.h | 5 ++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/srdb1/db_ut.c b/lib/srdb1/db_ut.c index 0331896..babe0e7 100644 --- a/lib/srdb1/db_ut.c +++ b/lib/srdb1/db_ut.c @@ -491,10 +491,15 @@ int db_val2pv_spec(struct sip_msg* msg, db_val_t *dbval, pv_spec_t *pvs) if (pv_set_spec_value(msg, pvs, 0, &pv) != 0) { LM_ERR("Failed to add value to spec\n"); - if (pv.flags == PV_VAL_STR) + if (pv.flags == PV_VAL_STR && pv.rs.len > 0) pkg_free(pv.rs.s); return -1; } + /* free string memory */ + if (pv.flags == PV_VAL_STR && pv.rs.len > 0) { + pkg_free(pv.rs.s); + } + return 0; } diff --git a/lib/srdb1/db_ut.h b/lib/srdb1/db_ut.h index 9440467..790780f 100644 --- a/lib/srdb1/db_ut.h +++ b/lib/srdb1/db_ut.h @@ -208,7 +208,10 @@ int db_print_set(const db1_con_t* _c, char* _b, const int _l, /** - * Convert db_val to pv_spec_t + * Convert db_val_t to pv_spec_t + * + * On success, when the PV type is string and longer than 0 chars, + * the string must be freed by the caller after use. * * \param msg sip msg structure * \param dbval database value

1 0

git:master: srdb1: fix for undeclared INADDR_LOOPBACK on darwin os
by Daniel-Constantin Mierla 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: 123e831d69a69dbc97e7c2424ebc701b1c624924 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=123e831… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Sep 5 14:14:54 2011 +0200 srdb1: fix for undeclared INADDR_LOOPBACK on darwin os --- lib/srdb1/db_ut.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/srdb1/db_ut.c b/lib/srdb1/db_ut.c index 80aa4c7..0331896 100644 --- a/lib/srdb1/db_ut.c +++ b/lib/srdb1/db_ut.c @@ -31,6 +31,10 @@ */ +#ifdef __OS_darwin +#include "../../pvar.h" +#endif + /** * make strptime available * use 600 for 'Single UNIX Specification, Version 3' @@ -47,8 +51,12 @@ #include <time.h> -#undef _XOPEN_SOURCE -#undef _XOPEN_SOURCE_EXTENDED +#ifndef __OS_solaris + #undef _XOPEN_SOURCE + #undef _XOPEN_SOURCE_EXTENDED +#else + #undef _XOPEN_SOURCE_EXTENDED 1 /* solaris */ +#endif #include <limits.h> #include <errno.h>

1 0

git:3.1: core: fix typo in parser.
by Sven Knoblich 05 Sep '11

05 Sep '11

Module: sip-router Branch: 3.1 Commit: 5e827db17414a02902ee8899d762af9933baec66 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5e827db… Author: Sven Knoblich <sven.knoblich(a)1und1.de> Committer: Sven Knoblich <sven.knoblich(a)1und1.de> Date: Mon Sep 5 13:35:50 2011 +0200 core: fix typo in parser. - use correct function-name in log message of parse_param.c:parse_contact_class. (fixes flyspray-issue 147) (cherry picked from commit 21ff48876956bf1df67ace6651ea9782e297946b) --- parser/parse_param.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/parser/parse_param.c b/parser/parse_param.c index c68e237..90fe241 100644 --- a/parser/parse_param.c +++ b/parser/parse_param.c @@ -125,7 +125,7 @@ static inline void parse_contact_class(param_hooks_t* _h, param_t* _p) return; } if (!_h) { - LOG(L_CRIT, "BUG: parse_uri_class: NULL param hook pointer\n"); + LOG(L_CRIT, "BUG: parse_contact_class: NULL param hook pointer\n"); return; } switch(_p->name.s[0]) {

1 0

git:master: core: fix typo in parser.
by Sven Knoblich 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: 21ff48876956bf1df67ace6651ea9782e297946b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=21ff488… Author: Sven Knoblich <sven.knoblich(a)1und1.de> Committer: Sven Knoblich <sven.knoblich(a)1und1.de> Date: Mon Sep 5 13:35:50 2011 +0200 core: fix typo in parser. - use correct function-name in log message of parse_param.c:parse_contact_class. (fixes flyspray-issue 147) --- parser/parse_param.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/parser/parse_param.c b/parser/parse_param.c index 6e8f653..951d1d6 100644 --- a/parser/parse_param.c +++ b/parser/parse_param.c @@ -123,7 +123,7 @@ static inline void parse_contact_class(param_hooks_t* _h, param_t* _p) return; } if (!_h) { - LOG(L_CRIT, "BUG: parse_uri_class: NULL param hook pointer\n"); + LOG(L_CRIT, "BUG: parse_contact_class: NULL param hook pointer\n"); return; } switch(_p->name.s[0]) {

1 0

git:master: srdb1: fix compile warning related to strptime on linux
by Daniel-Constantin Mierla 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: 28af5617ff471e975dbfeea0e49112e9f0f607f8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=28af561… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Sep 5 13:44:06 2011 +0200 srdb1: fix compile warning related to strptime on linux --- lib/srdb1/db_ut.c | 28 ++++++++++++++++++++++++---- 1 files changed, 24 insertions(+), 4 deletions(-) diff --git a/lib/srdb1/db_ut.c b/lib/srdb1/db_ut.c index fbc037c..80aa4c7 100644 --- a/lib/srdb1/db_ut.c +++ b/lib/srdb1/db_ut.c @@ -30,17 +30,37 @@ * \ingroup db1 */ -#include "db_ut.h" -#include "../../mem/mem.h" -#include "../../dprint.h" -#include "../../pvar.h" +/** + * make strptime available + * use 600 for 'Single UNIX Specification, Version 3' + * _XOPEN_SOURCE creates conflict in swab definition in Solaris + */ +#ifndef __OS_solaris + #define _XOPEN_SOURCE 600 /* glibc2 on linux, bsd */ + #define _BSD_SOURCE 1 /* needed on linux to "fix" the effect + of the above define on + features.h/unistd.h syscall() */ +#else + #define _XOPEN_SOURCE_EXTENDED 1 /* solaris */ +#endif + +#include <time.h> + +#undef _XOPEN_SOURCE +#undef _XOPEN_SOURCE_EXTENDED + #include <limits.h> #include <errno.h> #include <stdio.h> #include <stdlib.h> #include <string.h> +#include "../../mem/mem.h" +#include "../../dprint.h" + +#include "db_ut.h" + inline int db_str2int(const char* _s, int* _v) {

1 0

10 Years SER - Awards
by Daniel-Constantin Mierla 05 Sep '11

05 Sep '11

Hello, a surprise part of 10 Years SER Conference was granting *special* awards to the people attending the event that had a major contribution in the management and development of SER/Kamailio to date. Most of them are well known in the community, but not all of them. Hope you like them, it proved to be a very entertaining moment. Here is the pdf with the awards: * http://asipto.com/u/48 The plan is to extend it with the other people in our community as ideas with award titles pop up. Cheers, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2011