sr-dev September 2011

sr-dev@lists.kamailio.org

40 participants
298 discussions

[tracker] Comment added: Not available AVP's values in reply route when pua_dialoginfo.so is added to config

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#150 - Not available AVP's values in reply route when pua_dialoginfo.so is added to config User who did this - Sebastian Zaprzalski (-sz-) ---------- I think it's not the same issue. I have a problem with access to AVP'a value in reply routes. The bug occurs in last stable verstion too. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=150#comment264 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 8 months

[tracker] Comment added: Not available AVP's values in reply route when pua_dialoginfo.so is added to config

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#150 - Not available AVP's values in reply route when pua_dialoginfo.so is added to config User who did this - Jasmin Schnatterbeck (jasmin) ---------- I had the same issue about 1 year ago: http://lists.sip-router.org/pipermail/sr-dev/2010-August/008502.html @Klaus: are flags AND avps fixed with that? It looks like flags only? Jasmin ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=150#comment263 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 8 months

[tracker] Comment added: Not available AVP's values in reply route when pua_dialoginfo.so is added to config

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#150 - Not available AVP's values in reply route when pua_dialoginfo.so is added to config User who did this - Klaus Darilion (klaus3000) ---------- IIRC this war reported and fixed: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=40a2852… Maybe it was forgotten to be backported. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=150#comment262 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 8 months

[tracker] Task opened: Not available AVP's values in reply route when pua_dialoginfo.so is added to config

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Sebastian Zaprzalski (-sz-) Attached to Project - sip-router Summary - Not available AVP's values in reply route when pua_dialoginfo.so is added to config Task Type - Bug Report Category - Core Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - Linux Severity - Medium Priority - Normal Reported Version - 3.1 Due in Version - Undecided Due Date - Undecided Details - Hi, I have a problem with access from reply-route to AVP's set in routes when pua_dialoginfo module is added to config file. For tests I have added log with AVP in reply-route and set value of this AVP in main route. When I remove pua_dialoginfo from config, I receive in logs: Sep 8 09:30:34 node00 /usr/sbin/kamailio[26096]: INFO: <script>: BOK: -=SZ=- TEST but when I add pua_dialoginfo, I receive: Sep 8 09:33:16 node00 /usr/sbin/kamailio[27156]: INFO: <script>: BOK: -=SZ=- <null> The log in config is: xlog("L_INFO", "BOK: -=SZ=- $avp(testwartosci)) \n"); The same bug is in version 3.0 and 3.1. Regards More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=150 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 8 months

[tracker] Assignee added: Not available AVP's values in reply route when pua_dialoginfo.so is added to config

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#150 - Not available AVP's values in reply route when pua_dialoginfo.so is added to config User who did this - Sebastian Zaprzalski (-sz-) http://sip-router.org/tracker/index.php?do=details&task_id=150 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 8 months

git:master: lib/srdb1/schema/pr_xcap.xml: made doc_uri size match XCAP_MAX_URI_SIZE

by Juha Heinanen

Module: sip-router Branch: master Commit: 5ecd7deddc7a6fb23f8d0bb530be3e68672c495d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5ecd7de… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Thu Sep 8 09:36:34 2011 +0300 lib/srdb1/schema/pr_xcap.xml: made doc_uri size match XCAP_MAX_URI_SIZE --- lib/srdb1/schema/entities.xml | 1 + lib/srdb1/schema/pr_xcap.xml | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/srdb1/schema/entities.xml b/lib/srdb1/schema/entities.xml index 0ad9a04..ff12ca0 100644 --- a/lib/srdb1/schema/entities.xml +++ b/lib/srdb1/schema/entities.xml @@ -2,6 +2,7 @@ <!ENTITY domain_len "64"> <!ENTITY realm_len "64"> <!ENTITY uri_len "128"> +<!ENTITY xcap_uri_len "255"> <!ENTITY id_len "64"> <!ENTITY table_id_len "10"> <!ENTITY hf_len "255"> diff --git a/lib/srdb1/schema/pr_xcap.xml b/lib/srdb1/schema/pr_xcap.xml index be7aa97..76baa4d 100644 --- a/lib/srdb1/schema/pr_xcap.xml +++ b/lib/srdb1/schema/pr_xcap.xml @@ -72,7 +72,7 @@ <column id="doc_uri"> <name>doc_uri</name> <type>string</type> - <size>&uri_len;</size> + <size>&xcap_uri_len;</size> <description>Document uri</description> </column>

12 years, 8 months

git:master: modules_k/nathelper: add_contact_alias adds <> s around contact URI

by Juha Heinanen

Module: sip-router Branch: master Commit: 3ff9594a30eff2d18e6ea0595c5f82f878eaca1c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3ff9594… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Nov 26 10:37:30 2010 +0200 modules_k/nathelper: add_contact_alias adds <>s around contact URI Make sure that Contact URI is surrounded by <> when adding ;alias parameter. Otherwise, ;alias parameter may be interpreted as header parameter, because the syntax seems to be ambiguous. (cherry picked from commit f5ef15fee0c3bf09adf2506effa0895f72af9034) --- modules_k/nathelper/nathelper.c | 69 +++++++++++++++++++++++++++++++------- 1 files changed, 56 insertions(+), 13 deletions(-) diff --git a/modules_k/nathelper/nathelper.c b/modules_k/nathelper/nathelper.c index 51c1086..52c5e5f 100644 --- a/modules_k/nathelper/nathelper.c +++ b/modules_k/nathelper/nathelper.c @@ -786,7 +786,7 @@ add_contact_alias_f(struct sip_msg* msg, char* str1, char* str2) struct lump *anchor; struct sip_uri uri; struct ip_addr *ip; - char *param, *at, *port, *start; + char *lt, *gt, *param, *at, *port, *start; /* Do nothing if Contact header does not exist */ if (!msg->contact) { @@ -816,25 +816,63 @@ add_contact_alias_f(struct sip_msg* msg, char* str1, char* str2) return 2; } - /* Add alias param */ + /* Check if function has been called already */ if ((c->uri.s < msg->buf) || (c->uri.s > (msg->buf + msg->len))) { LM_ERR("you can't call alias_contact twice, check your config!\n"); return -1; } + + /* Check if Contact URI needs to be enclosed in <>s */ + lt = gt = param = NULL; + at = memchr(msg->contact->body.s, '<', msg->contact->body.len); + if (at == NULL) { + lt = (char*)pkg_malloc(1); + if (!lt) { + LM_ERR("no pkg memory left for lt sign\n"); + goto err; + } + *lt = '<'; + anchor = anchor_lump(msg, msg->contact->body.s - msg->buf, 0, 0); + if (anchor == NULL) { + LM_ERR("anchor_lump for beginning of contact body failed\n"); + goto err; + } + if (insert_new_lump_before(anchor, lt, 1, 0) == 0) { + LM_ERR("insert_new_lump_before for \"<\" failed\n"); + goto err; + } + gt = (char*)pkg_malloc(1); + if (!gt) { + LM_ERR("no pkg memory left for gt sign\n"); + goto err; + } + *gt = '>'; + anchor = anchor_lump(msg, msg->contact->body.s + + msg->contact->body.len - msg->buf, 0, 0); + if (anchor == NULL) { + LM_ERR("anchor_lump for end of contact body failed\n"); + goto err; + } + if (insert_new_lump_before(anchor, gt, 1, 0) == 0) { + LM_ERR("insert_new_lump_before for \">\" failed\n"); + goto err; + } + } + + /* Create ;alias param */ param_len = SALIAS_LEN + IP6_MAX_STR_SIZE + 1 /* ~ */ + 5 /* port */ + 1 /* ~ */ + 1 /* proto */; param = (char*)pkg_malloc(param_len); if (!param) { LM_ERR("no pkg memory left for alias param\n"); - return -1; + goto err; } at = param; append_str(at, SALIAS, SALIAS_LEN); ip_len = ip_addr2sbuf(&(msg->rcv.src_ip), at, param_len - SALIAS_LEN); if (ip_len <= 0) { - pkg_free(param); LM_ERR("failed to copy source ip\n"); - return -1; + goto err; } at = at + ip_len; append_chr(at, '~'); @@ -842,9 +880,8 @@ add_contact_alias_f(struct sip_msg* msg, char* str1, char* str2) append_str(at, port, len); append_chr(at, '~'); if ((msg->rcv.proto < PROTO_UDP) || (msg->rcv.proto > PROTO_SCTP)) { - pkg_free(param); LM_ERR("invalid transport protocol\n"); - return -1; + goto err; } append_chr(at, msg->rcv.proto + '0'); param_len = at - param; @@ -854,18 +891,24 @@ add_contact_alias_f(struct sip_msg* msg, char* str1, char* str2) } else { start = uri.host.s + uri.host.len; } + + /* Add ;alias param */ anchor = anchor_lump(msg, start - msg->buf, 0, 0); if (anchor == NULL) { - pkg_free(param); - LM_ERR("anchor_lump failed\n"); - return -1; + LM_ERR("anchor_lump for ;alias param failed\n"); + goto err; } if (insert_new_lump_after(anchor, param, param_len, 0) == 0) { - LM_ERR("insert_new_lump_after failed\n"); - pkg_free(param); - return -1; + LM_ERR("insert_new_lump_after for ;alias param failed\n"); + goto err; } return 1; + + err: + if (lt) pkg_free(lt); + if (gt) pkg_free(gt); + if (param) pkg_free(param); + return -1; }

12 years, 8 months

Segfault if dispatcher cannot resolve hostnames

by Hugh Waite

Hello, We've discovered some crashes that occur if the dispatcher module cannot resolve hostnames during startup (and tries to shutdown). Patch attached for modules_k/dispatcher/dispatch.c Regards, Hugh -- -- Hugh Waite Senior Design Engineer Crocodile RCS Ltd.

12 years, 8 months

git:3.1: dispatcher(k): fix segfault if dispatcher cannot resolve hostnames

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.1 Commit: 66e3531def2e011aa640033a161c9a2fd6e4578c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=66e3531… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 7 13:23:07 2011 +0200 dispatcher(k): fix segfault if dispatcher cannot resolve hostnames - applies if the dispatcher module cannot resolve hostnames during startup (and tries to shutdown) - patch by Hugh Waite (cherry picked from commit cad2daebf295443f2318abbb608102bb99111948) --- modules_k/dispatcher/dispatch.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules_k/dispatcher/dispatch.c b/modules_k/dispatcher/dispatch.c index ba123bb..79bcc57 100644 --- a/modules_k/dispatcher/dispatch.c +++ b/modules_k/dispatcher/dispatch.c @@ -349,7 +349,6 @@ int add_dest2list(int id, str uri, int flags, int priority, str *attrs, if (he==0) { LM_ERR("could not resolve %.*s\n", puri.host.len, puri.host.s); - pkg_free(hn); goto err; } /* Free the hostname */ @@ -841,7 +840,8 @@ void destroy_list(int list_id) dest->uri.s = NULL; } } - shm_free(sp->dlist); + if (sp->dlist != NULL) + shm_free(sp->dlist); sp = sp->next; }

12 years, 8 months

git:master: dispatcher(k): fix segfault if dispatcher cannot resolve hostnames

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: cad2daebf295443f2318abbb608102bb99111948 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cad2dae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 7 13:23:07 2011 +0200 dispatcher(k): fix segfault if dispatcher cannot resolve hostnames - applies if the dispatcher module cannot resolve hostnames during startup (and tries to shutdown) - patch by Hugh Waite --- modules_k/dispatcher/dispatch.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules_k/dispatcher/dispatch.c b/modules_k/dispatcher/dispatch.c index 50df1fc..b4f2ee3 100644 --- a/modules_k/dispatcher/dispatch.c +++ b/modules_k/dispatcher/dispatch.c @@ -323,7 +323,6 @@ int add_dest2list(int id, str uri, int flags, int priority, str *attrs, if (he==0) { LM_ERR("could not resolve %.*s\n", puri.host.len, puri.host.s); - pkg_free(hn); goto err; } /* Free the hostname */ @@ -815,7 +814,8 @@ void destroy_list(int list_id) dest->uri.s = NULL; } } - shm_free(sp->dlist); + if (sp->dlist != NULL) + shm_free(sp->dlist); sp = sp->next; }

12 years, 8 months

← Newer
1
...
21
22
23
24
25
26
27
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2011