sr-dev September 2011

sr-dev@lists.kamailio.org

40 participants
298 discussions

[tracker] Task opened: Changing R-URI in dialog-info PUBLISH in event_route[tm:local-request]
by sip-router 21 Sep '11

21 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Sebastian Zaprzalski (-sz-) Attached to Project - sip-router Summary - Changing R-URI in dialog-info PUBLISH in event_route[tm:local-request] Task Type - Bug Report Category - Core Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - Linux Severity - Medium Priority - Normal Reported Version - 3.1 Due in Version - Undecided Due Date - Undecided Details - Issue occurs in v. 3.1.5. R-URI in locally generated PUBLISH request can't be changed in event_route[tm:local-reqest]. When you try to change R-URI, Kamailio logs shows changes, but it sends request with original R-URI (without change). I have tryed to use msg_apply_changes(), but it does not change anything. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=158 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Assignee added: Changing R-URI in dialog-info PUBLISH in event_route[tm:local-request]
by sip-router 21 Sep '11

21 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#158 - Changing R-URI in dialog-info PUBLISH in event_route[tm:local-request] User who did this - Sebastian Zaprzalski (-sz-) http://sip-router.org/tracker/index.php?do=details&task_id=158 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: add a couple of missing free_to_params (mem leaks)
by sip-router 20 Sep '11

20 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#156 - add a couple of missing free_to_params (mem leaks) User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Thanks, patch applied to GIT master branch for now. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=156 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: srdb1: return error code when DB URL is too long
by Daniel-Constantin Mierla 20 Sep '11

20 Sep '11

Module: sip-router Branch: master Commit: ffa448dc09f9e086af9d5089e3d6fcec5104a283 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ffa448d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 20 20:21:55 2011 +0200 srdb1: return error code when DB URL is too long --- lib/srdb1/db.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/srdb1/db.c b/lib/srdb1/db.c index b50b156..b8abefa 100644 --- a/lib/srdb1/db.c +++ b/lib/srdb1/db.c @@ -172,7 +172,7 @@ int db_bind_mod(const str* mod, db_func_t* mydbf) if (mod->len > MAX_URL_LENGTH) { LM_ERR("SQL URL too long\n"); - return 0; + return -1; } // add the prefix name = pkg_malloc(mod->len + 4);

1 0

git:master: pv/presence/pua: add a couple of missing free_to_params
by Daniel-Constantin Mierla 20 Sep '11

20 Sep '11

Module: sip-router Branch: master Commit: d3b4e5486e6cefce9c7aad53b29e3514b35cfde4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d3b4e54… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 20 20:08:16 2011 +0200 pv/presence/pua: add a couple of missing free_to_params - patch by Walter Doekes, closes FS#156 --- modules_k/presence/subscribe.c | 8 ++++---- modules_k/pua/hash.c | 17 ++++++++++------- modules_k/pua/send_subscribe.c | 6 +++--- modules_k/pua_bla/notify.c | 13 +++++-------- modules_k/pua_xmpp/simple2xmpp.c | 21 +++++++++++---------- modules_k/pv/pv_trans.c | 23 ++++++++++++----------- modules_k/rls/resource_notify.c | 19 ++++++++++--------- 7 files changed, 55 insertions(+), 52 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=d3b…

1 0

git:andrei/armv7: armv7: inform the assembler about thumb
by Andrei Pelinescu-Onciul 20 Sep '11

20 Sep '11

Module: sip-router Branch: andrei/armv7 Commit: 5b0b840ae1c82573af8cc84abed4a30f136e3bf8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5b0b840… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Sep 20 20:04:24 2011 +0200 armv7: inform the assembler about thumb In some toolchains, the assembler defaults to arm and gcc does not pass automatically the option for switching to the thumb mode, so we have to do it by hand. --- Makefile.defs | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index 5941e70..66b2975 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -1287,8 +1287,11 @@ ifeq ($(ARCH), arm7) # if gcc ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM - #common stuff + #common stuff + inform the assembler about THUMB + # (some assemblers default to ARM, see + # https://wiki.ubuntu.com/ARM/Thumb2) CFLAGS=-march=armv7-a -O9 -funroll-loops -fsigned-char \ + -Wa,-mimplicit-it=thumb \ $(PROFILE) #if gcc 4.5 or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5,$(CC_SHORTVER))))

1 0

git:master: lib/srdb1: fix conversion of longlong to string in db_val2pv_spec()
by Alex Hermann 20 Sep '11

20 Sep '11

Module: sip-router Branch: master Commit: fa71c181323448c934ac46ab9720e52783f62eb7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fa71c18… Author: Alex Hermann <alex(a)speakup.nl> Committer: Alex Hermann <alex(a)speakup.nl> Date: Tue Sep 20 17:51:33 2011 +0200 lib/srdb1: fix conversion of longlong to string in db_val2pv_spec() The length of the buffer was not set, resulting in random failures. --- lib/srdb1/db_ut.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/srdb1/db_ut.c b/lib/srdb1/db_ut.c index 840c861..18c9bf8 100644 --- a/lib/srdb1/db_ut.c +++ b/lib/srdb1/db_ut.c @@ -407,7 +407,8 @@ int db_print_set(const db1_con_t* _c, char* _b, const int _l, const db_key_t* _k int db_val2pv_spec(struct sip_msg* msg, db_val_t *dbval, pv_spec_t *pvs) { pv_value_t pv; - char ll_buf[21]; /* sign, 19 digits and \0 */ +#define LL_LEN 21 /* sign, 19 digits and \0 */ + static char ll_buf[LL_LEN]; if(dbval->nul) { @@ -446,6 +447,7 @@ int db_val2pv_spec(struct sip_msg* msg, db_val_t *dbval, pv_spec_t *pvs) case DB1_BIGINT: /* BIGINT is stored as string */ pv.flags = PV_VAL_STR; + pv.rs.len = LL_LEN; db_longlong2str(dbval->val.ll_val, ll_buf, &pv.rs.len); pv.rs.s = ll_buf; break;

1 0

[tracker] Comment added: add a couple of missing free_to_params (mem leaks)
by sip-router 20 Sep '11

20 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#156 - add a couple of missing free_to_params (mem leaks) User who did this - Walter Doekes (wdoekes) ---------- According to gcc -ansi it is: $ cat struct_init.c #include <assert.h> #include <stdio.h> struct test { char data[4]; unsigned number; void *pointer; }; int main() { struct test a = {0}; struct test b; struct test *p[2]; int i, j; p[0] = &a; p[1] = &b; for (i = 0; i < 2; ++i) { for (j = 0; j < sizeof(struct test); ++j) { if (((char*)p[i])[j] != 0) { assert(i != 0); printf("Byte %d in %d is 0x%hhx\n", j, i, ((char*)p[i])[j]); break; } } } return 0; } $ gcc -ansi struct_init.c $ ./a.out Byte 0 in 1 is 0xd8 ^-- we wanted garbage in 1, but not in 0, so it does what we expect This corresponds with what it says here: http://uw714doc.sco.com/en/SDK_cprog/_Initialization.html And indeed, if we remove the 0 and use only {}, we get the same result. If we go back further and look at this: http://flash-gordon.me.uk/ansi.c.txt We see: * "There shall be no more initializers in an initializer list than there are objects to be initialized." Ok, so there may be less. * " The initializer for a structure or union object that has automatic storage duration either shall be an initializer list as described below, or ..." Checking below: * " If there are fewer initializers in a list than there are members of an aggregate, the remainder of the aggregate shall be initialized implicitly the same as objects that have static storage duration." Ok. And we know that static storage duration objects are zeroed out. * "If an object that has static storage duration is not initialized explicitly, it is initialized implicitly as if every member that has arithmetic type were assigned 0 and every member that has pointer type were assigned a null pointer constant." I take it this answers the question. Regards, Walter Doekes ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=156#comment285 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: add a couple of missing free_to_params (mem leaks)
by sip-router 20 Sep '11

20 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#156 - add a couple of missing free_to_params (mem leaks) User who did this - Daniel-Constantin Mierla (miconda) ---------- Thanks for checking the corner cases and providing the patch. I am going to apply the patch, one thing to discuss though... It is related to the fact that you replaced some memset's to 0 with struct initialization to {0}. Is assignment of {0} to struct variables compatible with ansi c? Not sure when this short version of struct 0-padding initialization was standardized and we try to keep the sources clean for compilation with old C standard versions. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=156#comment284 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] User took ownership: add a couple of missing free_to_params (mem leaks)
by sip-router 20 Sep '11

20 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#156 - add a couple of missing free_to_params (mem leaks) More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=156 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2011