sr-dev August 2011

sr-dev@lists.kamailio.org

33 participants
292 discussions

ideas on dialog spiral distinction
by Jason Penton 25 Aug '11

25 Aug '11

Hi Guys, Have been playing around with the dialog module and spiralling and one thing I have noticed is that if you spiral and dont have detect_spirals enabled the dialog module will create 2 dialogs. This is great and 'expected' in this case. However, as it stands there is no way of distinguishing between the 2 dialogs. So for example, a BYE could come in from either 'side' of the spiral and the first dialog is matched - not necessarily the correct one. this is because the match is purely done on callid, from and to tags (if using RFC3261 matching). My initial thought is to have some sort of direction identifiers stored in the dialog structure itself. Then using Via and contact headers we can make a pretty good assumption as to which 'end' of the spiral and therefore choose the correct dialog in the match algorithm. some may say just enable spiral_detection. Actually, in some cases it is nice to be able to track a spiral in different dialogs, which most likely why the option to enable or disable spiral detection in the first place What are your thoughts?

6 17

Re: [sr-dev] [SR-Users] [regression] Message flags set in branch_route not saved into transaction
by Alex Hermann 25 Aug '11

25 Aug '11

On Monday 22 August 2011, Alex Hermann wrote: > It seems kamailio 3 does not save message flags set in branch route into > the transaction. In reply_route and failure_route the flag set in > branch_route is unset. In 1.4 this used to work. I would like to get that > behaviour back, is this possible? This patch seems to restore old functionality. Would this be ok to commit? diff --git a/modules/tm/t_fwd.c b/modules/tm/t_fwd.c index 30558ab..756e4b4 100644 --- a/modules/tm/t_fwd.c +++ b/modules/tm/t_fwd.c @@ -1510,6 +1510,8 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg , clear_branches(); setbflagsval(0, backup_bflags); + /* update flags, if changed in branch route */ + t->uas.request->flags = p_msg->flags; /* don't forget to clear all branches processed so far */ > Testscenario: > > route { > setflag(0); > > t_on_branch("1"); > t_on_reply("1"); > t_on_failure("1"); > > xlog("L_NOTICE", "[$rm] Request before relay: $mF"); > t_relay(); > } > > branch_route[1] { > xlog("L_NOTICE", "[$rm] Branch begin: $mF"); > setflag(8); > xlog("L_NOTICE", "[$rm] Branch end: $mF"); > } > > onreply_route[1] { > xlog("L_NOTICE", "[$rm] Reply ($rs) begin: $mF"); > setflag(4); > xlog("L_NOTICE", "[$rm] Reply end: $mF"); > } > > failure_route[1] { > xlog("L_NOTICE", "[$rm] Failure ($T_reply_code): $mF"); > } > > Log output on 3.x: > [INVITE] Request begin: 00000000 > [INVITE] Request before relay: 00000001 > [INVITE] Branch begin: 00000001 > [INVITE] Branch end: 00000101 > [INVITE] Reply (100) begin: 00000001 > [INVITE] Reply end: 00000011 > [INVITE] Failure (408): 00000011 > > Log output on 1.4: > [INVITE] Request begin: 00000000 > [INVITE] Request before relay: 00000001 > [INVITE] Branch begin: 00000001 > [INVITE] Branch end: 00000101 > [INVITE] Reply (100) begin: 00000101 > [INVITE] Reply end: 00000111 > [INVITE] Failure (408) begin: 00000111 -- Greetings, Alex Hermann

2 4

[tracker] Comment added: Gentoo ebuild/pkg (Attachment added)
by sip-router 24 Aug '11

24 Aug '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#134 - Gentoo ebuild/pkg User who did this - Claudio Furrer (caio) ---------- Hello, Here a new gentoo ebuild revision for sip-router v3.1.4. It includes the kamailio specific group of modules (module_group_k*). Example usage: USE="flavour_kamailio debug group_kstandard group_kmysql avpops carrierroute" emerge -pv sip-router Cheers, Claudio ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=134#comment252 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:3.1: modules_k/dialog: Add reference count to list of items returned
by Timo Reimann 23 Aug '11

23 Aug '11

Module: sip-router Branch: 3.1 Commit: e17caaf8354f8fefb1d9558347c18fc96b3a6011 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e17caaf… Author: Timo Reimann <timo.reimann(a)1und1.de> Committer: Timo Reimann <timo.reimann(a)1und1.de> Date: Tue Aug 23 15:36:45 2011 +0200 modules_k/dialog: Add reference count to list of items returned via RPC. (cherry picked from commit cf8e80cbe53380e628476edf0cff0e05b77e25f9) --- modules_k/dialog/dialog.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules_k/dialog/dialog.c b/modules_k/dialog/dialog.c index e581ca3..971de1e 100644 --- a/modules_k/dialog/dialog.c +++ b/modules_k/dialog/dialog.c @@ -1154,8 +1154,8 @@ static inline void internal_rpc_print_dlg(rpc_t *rpc, void *c, struct dlg_cell * { rpc_cb_ctx_t rpc_cb; - rpc->printf(c, "hash:%u:%u state:%u timestart:%u timeout:%u", - dlg->h_entry, dlg->h_id, dlg->state, dlg->start_ts, dlg->tl.timeout); + rpc->printf(c, "hash:%u:%u state:%u ref_count:%u timestart:%u timeout:%u", + dlg->h_entry, dlg->h_id, dlg->state, dlg->ref, dlg->start_ts, dlg->tl.timeout); rpc->printf(c, "\tcallid:%.*s from_tag:%.*s to_tag:%.*s", dlg->callid.len, dlg->callid.s, dlg->tag[DLG_CALLER_LEG].len, dlg->tag[DLG_CALLER_LEG].s,

1 0

git:master: modules_k/dialog: Add reference count to list of items returned
by Timo Reimann 23 Aug '11

23 Aug '11

Module: sip-router Branch: master Commit: cf8e80cbe53380e628476edf0cff0e05b77e25f9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cf8e80c… Author: Timo Reimann <timo.reimann(a)1und1.de> Committer: Timo Reimann <timo.reimann(a)1und1.de> Date: Tue Aug 23 15:36:45 2011 +0200 modules_k/dialog: Add reference count to list of items returned via RPC. --- modules_k/dialog/dialog.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules_k/dialog/dialog.c b/modules_k/dialog/dialog.c index 6711732..dc5cb87 100644 --- a/modules_k/dialog/dialog.c +++ b/modules_k/dialog/dialog.c @@ -1204,8 +1204,8 @@ static inline void internal_rpc_print_dlg(rpc_t *rpc, void *c, struct dlg_cell * { rpc_cb_ctx_t rpc_cb; - rpc->printf(c, "hash:%u:%u state:%u timestart:%u timeout:%u", - dlg->h_entry, dlg->h_id, dlg->state, dlg->start_ts, dlg->tl.timeout); + rpc->printf(c, "hash:%u:%u state:%u ref_count:%u timestart:%u timeout:%u", + dlg->h_entry, dlg->h_id, dlg->state, dlg->ref, dlg->start_ts, dlg->tl.timeout); rpc->printf(c, "\tcallid:%.*s from_tag:%.*s to_tag:%.*s", dlg->callid.len, dlg->callid.s, dlg->tag[DLG_CALLER_LEG].len, dlg->tag[DLG_CALLER_LEG].s,

1 0

Testing upcoming version 3.2.0
by Daniel-Constantin Mierla 23 Aug '11

23 Aug '11

Hello, for those looking to test v3.2.0 and need some instructions, for Kamailio flavour is a wiki page showing step-by-step installation: * http://www.kamailio.org/dokuwiki/doku.php/install:kamailio-devel-from-git Practically 3.2.0 is the current devel branch. Testing SER flavour the difference is just using FLAVOUR=ser when compiling the application. Developers as well as users are encouraged to add details about the new additions in v3.2.0 to wiki page: * http://sip-router.org/wiki/features/new-in-devel Also, please add instructions for migrating from 3.1.x to 3.2.0 to the wiki page: * http://sip-router.org/wiki/install/3.1.x-to-3.2.x Thanks, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

1 0

Development branch frozen for v3.2.0
by Daniel-Constantin Mierla 23 Aug '11

23 Aug '11

Hello, since several hours ago, the development of new features in master branch has been frozen, to allow proper testing for release of version 3.2.0. That means no new features should be committed to GIT master branch. Just before the release (expected in 1.5months) we will create a dedicate branch for 3.2.x series and master branch will be again open for new stuff. Meanwhile, developers can use personal branches to push code in the public space. GIT master branch will be used in this period for: - bug fixing - hammering of the new features in 3.2.0 - documentation improvements - merging of duplicated modules There are two good news for 3.2.0: - the number of the new features is very impressive. Besides the old squad, we gained many new developers lately, coming with interesting contributions, therefore I am sure you'll have lot of fun testing them - the core components (transport layers, asynchronous processing, timers, locking & memory managers, a.s.o.) were barely touched since 3.0, so this is the 3rd release in a row using the new scalable core framework. That shows the maturity and there will be no much to focus on them If you need assistance while trying some new features, feel free to email to sr-dev mailing list. Cheers, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

1 0

git:master: Makefile: version set to pre-release
by Daniel-Constantin Mierla 23 Aug '11

23 Aug '11

Module: sip-router Branch: master Commit: b7beb6024763a58fca28790be1bb2bfe9dd5e842 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b7beb60… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 23 14:15:38 2011 +0200 Makefile: version set to pre-release - development cycle for 3.2.0 ended --- Makefile.defs | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index 1cc4326..af34419 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -162,7 +162,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 3 PATCHLEVEL = 2 SUBLEVEL = 0 -EXTRAVERSION = -dev7 +EXTRAVERSION = -pre1 # memory debugger switcher # 0 - off (release mode)

1 0

Timer warning whenever PUA sends a request
by Peter Dunkley 23 Aug '11

23 Aug '11

Hello, I have noticed that I am seeing an warning whenever PUA sends a request. This wasn't happening during the testing I did for my recent PUA changes, but it is happening now. I believe the WARNING is caused by a timer being set with a time of 0 in the TM module, but I am not very familiar with that part of the code. If it is in the TM module I suspect it is a recent change made within the last couple of weeks. The warning I am seeing is: 14(6323) WARNING: <core> [timer_funcs.h:119]: WARNING: timer: add_timeout: 0 expire timer added Does anyone have any ideas? Thanks, Peter -- Peter Dunkley Technical Director Crocodile RCS Ltd

4 8

git:3.1: modules_k/auth_db: Fix error in docs.
by Timo Reimann 23 Aug '11

23 Aug '11

Module: sip-router Branch: 3.1 Commit: e57897b4b3f5c3bb535164dc7349f36538ea3d79 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e57897b… Author: Timo Reimann <timo.reimann(a)1und1.de> Committer: Timo Reimann <timo.reimann(a)1und1.de> Date: Tue Aug 23 11:05:59 2011 +0200 modules_k/auth_db: Fix error in docs. (cherry picked from commit d702484d2021cf132f48aa2fe3ed9f0984f028f1) --- modules_k/auth_db/doc/auth_db_admin.xml | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/auth_db/doc/auth_db_admin.xml b/modules_k/auth_db/doc/auth_db_admin.xml index f00e5ca..a49aa53 100644 --- a/modules_k/auth_db/doc/auth_db_admin.xml +++ b/modules_k/auth_db/doc/auth_db_admin.xml @@ -347,7 +347,7 @@ modparam("auth_db", "load_credentials", "$avp(i:123)=rpid;email_address") <title><function moreinfo="none">www_authorize</function> usage</title> <programlisting format="linespecific"> ... -if (www_authorize("kamailio.org", "subscriber")) { +if (!www_authorize("kamailio.org", "subscriber")) { www_challenge("kamailio.org", "1"); }; ...

1 0

← Newer
1
2
3
4
5
6
7
8
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2011