sr-dev July 2011

sr-dev@lists.kamailio.org

28 participants
198 discussions

git:master: kamdbctl: added pipelimit to the list of extra tables to create

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 0be9f5a4efeba2eb297a2e3286b9795f33f2dbe2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0be9f5a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jul 20 23:42:05 2011 +0200 kamdbctl: added pipelimit to the list of extra tables to create --- utils/kamctl/kamdbctl.base | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/kamctl/kamdbctl.base b/utils/kamctl/kamdbctl.base index acc7d4a..d0d6fd1 100644 --- a/utils/kamctl/kamdbctl.base +++ b/utils/kamctl/kamdbctl.base @@ -38,7 +38,7 @@ STANDARD_TABLES=${STANDARD_TABLES:-version acc dbaliases domain grp aliases silo dialog dispatcher dialplan} EXTRA_TABLES=${EXTRA_TABLES:-imc_members imc_rooms cpl sip_trace domainpolicy carrierroute carrier_name domain_name carrierfailureroute userblacklist - globalblacklist htable purplemap uacreg} + globalblacklist htable purplemap uacreg pl_pipes} PRESENCE_TABLES=${PRESENCE_TABLES:-presentity active_watchers watchers xcap pua rls_presentity rls_watchers} @@ -67,7 +67,7 @@ STANDARD_MODULES=${STANDARD_MODULES:-standard acc lcr domain group permissions speeddial avpops auth_db pdt dialog dispatcher dialplan} EXTRA_MODULES=${EXTRA_MODULES:-imc cpl siptrace domainpolicy carrierroute - userblacklist htable purple uac} + userblacklist htable purple uac pipelimit} ############################################################

12 years, 9 months

Re: [sr-dev] [SR-Users] issue tracking system

by Daniel-Constantin Mierla

Hello, some comments about all provided options so far: - google code tracker -- haven't use it at all, going to look a bit at it - github - maybe I missed some setting, but the issue tracker there seems to be to simplistic - no way to categorize in bugs or feature requests - jira - folks at SER used it in the past when we were two projects, reporting that it was rather buggy to keep using it -- maybe it was just the version purchased at that time (several years ago). I am not familiar with its administration at all - mantis - I have no experience with it to say pro/con opinions. Is the administration (upgrade, patching) easy enough? Does it support multi-projects on the same instance? - redmine - it is the one I use for various needs, therefore I have some experience with its administration. However, I cannot say that it is a thing I would like to take care of. It seems to be a bit heavy, I had to patch it (for some quite basic features such as different email address for different projects or the body of notification emails -- I have to say I am not that familiar with it and I may have missed some plugins/settings) For self installed app, at this time my preferences would be redmine, mantis, jira -- a big + to rise the rank in the order would come if there is going to be someone to commit for the maintenance of either one. Haven't made my mind for hosted options yet. More comments? Any other options? Thanks, Daniel On 7/19/11 8:18 PM, Jason Penton wrote: > +1 for Jira. If you have the resources to setup and manage JIRA then I > would suggest this too. We use and it is really very good > > On Tue, Jul 19, 2011 at 8:05 PM, Alex Balashov > <abalashov(a)evaristesys.com <mailto:abalashov@evaristesys.com>> wrote: > > We have been extremely happy with Mantis as a self-hosted > approach. It is easy to use, yet has the sophistication and > flexibility for a needed to manage a project of non-trivial size. > > On the other hand, Digium recently moved away from it in favour of > JIRA for issues.asterisk.org <http://issues.asterisk.org>. > > For fairly large projects like this one[1], I have always favoured > internal hosting of such systems in order to maintain maximum > control, use optional plugins, make customisations, etc. I think > that would make the most sense for the SR/Kamailio community. > > -- Alex > > [1] It's not nearly as large as say, the Linux kernel, but it's > bigger than 99% of open-source which, after all, consists largely > of projects done by one person or a few people at most. > -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

12 years, 9 months

git:master: core: small doxygen fix, synchronize a few function definitions with declarations

by Henning Westerholt

Module: sip-router Branch: master Commit: d949f97e5b3707100a7dfc8422ece0f19bcc163c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d949f97… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Wed Jul 20 22:49:21 2011 +0200 core: small doxygen fix, synchronize a few function definitions with declarations --- mem/f_malloc.h | 28 ++++++++++++++-------------- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/mem/f_malloc.h b/mem/f_malloc.h index 2246ee1..bd18bd9 100644 --- a/mem/f_malloc.h +++ b/mem/f_malloc.h @@ -114,10 +114,10 @@ struct fm_frag_lnk{ * \see mem_info */ struct fm_block{ - unsigned long size; /* total size */ + unsigned long size; /** total size */ #if defined(DBG_F_MALLOC) || defined(MALLOC_STATS) - unsigned long used; /* alloc'ed size*/ - unsigned long real_used; /* used+malloc overhead*/ + unsigned long used; /** allocated size*/ + unsigned long real_used; /** used + malloc overhead */ unsigned long max_real_used; #endif @@ -146,10 +146,10 @@ struct fm_block* fm_malloc_init(char* address, unsigned long size); * \return address of allocated memory */ #ifdef DBG_F_MALLOC -void* fm_malloc(struct fm_block*, unsigned long size, +void* fm_malloc(struct fm_block* qm, unsigned long size, const char* file, const char* func, unsigned int line); #else -void* fm_malloc(struct fm_block*, unsigned long size); +void* fm_malloc(struct fm_block* qm, unsigned long size); #endif @@ -161,10 +161,10 @@ void* fm_malloc(struct fm_block*, unsigned long size); * \param p freed memory */ #ifdef DBG_F_MALLOC -void fm_free(struct fm_block*, void* p, const char* file, const char* func, +void fm_free(struct fm_block* qm, void* p, const char* file, const char* func, unsigned int line); #else -void fm_free(struct fm_block*, void* p); +void fm_free(struct fm_block* qm, void* p); #endif @@ -178,10 +178,10 @@ void fm_free(struct fm_block*, void* p); * \return reallocated memory block */ #ifdef DBG_F_MALLOC -void* fm_realloc(struct fm_block*, void* p, unsigned long size, +void* fm_realloc(struct fm_block* qm, void* p, unsigned long size, const char* file, const char* func, unsigned int line); #else -void* fm_realloc(struct fm_block*, void* p, unsigned long size); +void* fm_realloc(struct fm_block* qm, void* p, unsigned long size); #endif @@ -189,7 +189,7 @@ void* fm_realloc(struct fm_block*, void* p, unsigned long size); * \brief Report internal memory manager status * \param qm memory block */ -void fm_status(struct fm_block*); +void fm_status(struct fm_block* qm); /** @@ -200,7 +200,7 @@ void fm_status(struct fm_block*); * \param qm memory block * \param memory information */ -void fm_info(struct fm_block*, struct mem_info*); +void fm_info(struct fm_block* qm, struct mem_info* info); /** @@ -209,7 +209,7 @@ void fm_info(struct fm_block*, struct mem_info*); * \return Returns how much free memory is available, on error (not compiled * with bookkeeping code) returns (unsigned long)(-1) */ -unsigned long fm_available(struct fm_block*); +unsigned long fm_available(struct fm_block* qm); /** @@ -217,9 +217,9 @@ unsigned long fm_available(struct fm_block*); * \param qm memory block */ #ifdef DBG_F_MALLOC -void fm_sums(struct fm_block*); +void fm_sums(struct fm_block* qm); #else -#define fm_sums(v) do{}while(0) +#define fm_sums(qm) do{}while(0) #endif /* DBG_F_MALLOC */ #endif

12 years, 9 months

git:master: core: remove commented out ROUNDUP macro (2002) and big_hash_idx() (2007)

by Henning Westerholt

Module: sip-router Branch: master Commit: 683a4899a992b42d60cc0d45bd10ff197d85dd39 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=683a489… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Wed Jul 20 21:34:14 2011 +0200 core: remove commented out ROUNDUP macro (2002) and big_hash_idx() (2007) --- mem/f_malloc.c | 19 ------------------- mem/q_malloc.c | 5 ----- 2 files changed, 0 insertions(+), 24 deletions(-) diff --git a/mem/f_malloc.c b/mem/f_malloc.c index 3b4cc9f..9eec13e 100644 --- a/mem/f_malloc.c +++ b/mem/f_malloc.c @@ -81,11 +81,6 @@ #define ROUNDUP(s) (((s)+(ROUNDTO-1))&ROUNDTO_MASK) #define ROUNDDOWN(s) ((s)&ROUNDTO_MASK) -/* - #define ROUNDUP(s) (((s)%ROUNDTO)?((s)+ROUNDTO)/ROUNDTO*ROUNDTO:(s)) - #define ROUNDDOWN(s) (((s)%ROUNDTO)?((s)-ROUNDTO)/ROUNDTO*ROUNDTO:(s)) -*/ - /* finds the hash value for s, s=ROUNDTO multiple*/ @@ -169,21 +164,7 @@ inline static int fm_bmp_first_set(struct fm_block* qm, int start) /* computes hash number for big buckets*/ -#if 0 -inline static unsigned long big_hash_idx(unsigned long s) -{ - unsigned long idx; - /* s is rounded => s = k*2^n (ROUNDTO=2^n) - * index= i such that 2^(i+1) > s >= 2^i - * - * => index = number of the first non null bit in s*/ - idx=sizeof(long)*8-1; - for (; !(s&(1UL<<(sizeof(long)*8-1))) ; s<<=1, idx--); - return idx; -} -#else #define big_hash_idx(s) ((unsigned long)bit_scan_reverse((unsigned long)(s))) -#endif #ifdef DBG_F_MALLOC diff --git a/mem/q_malloc.c b/mem/q_malloc.c index 88a287c..895cbfc 100644 --- a/mem/q_malloc.c +++ b/mem/q_malloc.c @@ -83,11 +83,6 @@ #define ROUNDUP(s) (((s)+(ROUNDTO-1))&ROUNDTO_MASK) #define ROUNDDOWN(s) ((s)&ROUNDTO_MASK) -/* -#define ROUNDUP(s) (((s)%ROUNDTO)?((s)+ROUNDTO)/ROUNDTO*ROUNDTO:(s)) -#define ROUNDDOWN(s) (((s)%ROUNDTO)?((s)-ROUNDTO)/ROUNDTO*ROUNDTO:(s)) -*/ - /* finds the hash value for s, s=ROUNDTO multiple*/

12 years, 9 months

git:master: core: doxygen documentation for F_MALLOC memory manager

by Henning Westerholt

Module: sip-router Branch: master Commit: c20927f7867163efa7d800bd0e7fee65e5980dcb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c20927f… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Wed Jul 20 22:36:41 2011 +0200 core: doxygen documentation for F_MALLOC memory manager --- mem/f_malloc.c | 112 ++++++++++++++++++++++++++++++++++++++++++++----------- mem/f_malloc.h | 84 +++++++++++++++++++++++++++++++++++------ 2 files changed, 160 insertions(+), 36 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=c20…

12 years, 9 months

git:master: fixed issue regarding caching presentity information when in DB_ONLY mode

by Marius Ovidiu Bucur

Module: sip-router Branch: master Commit: a3d6d80d1805109b6340cd7182323ef9ad9c11d4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a3d6d80… Author: Marius Bucur <marius(a)marius-bucur.ro> Committer: Marius Bucur <marius(a)marius-bucur.ro> Date: Wed Jul 20 20:27:51 2011 +0300 fixed issue regarding caching presentity information when in DB_ONLY mode --- modules_k/presence/notify.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/modules_k/presence/notify.c b/modules_k/presence/notify.c index da4ea8d..4f1ca18 100644 --- a/modules_k/presence/notify.c +++ b/modules_k/presence/notify.c @@ -637,7 +637,12 @@ str* get_p_notify_body(str pres_uri, pres_ev_t* event, str* etag, LM_ERR("while parsing uri\n"); return NULL; } - + + /* if in db_only mode, get the presentity information from database - skip htable search */ + if(dbmode == DB_ONLY) + { + goto db_query; + } /* search in hash table if any record exists */ hash_code= core_hash(&pres_uri, NULL, phtable_size); if(search_phtable(&pres_uri, event->evp->type, hash_code)== NULL)

12 years, 9 months

git:master: Add new db option and improve connect mechanism.

by Andreas Granig

Module: sip-router Branch: master Commit: 2cbd47c4f9a16ef869efd7830e48a419b3cc1020 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2cbd47c… Author: Andreas Granig <agranig(a)sipwise.com> Committer: Andreas Granig <agranig(a)sipwise.com> Date: Wed Jul 20 15:54:21 2011 +0200 Add new db option and improve connect mechanism. Add "db" option to "server" parameter to select the redis db number. Set 1 sec timeout when connecting to redis server. Perform "PING" to verify newly created redis connection. --- modules/ndb_redis/README | 6 ++-- modules/ndb_redis/doc/ndb_redis_admin.xml | 6 ++-- modules/ndb_redis/redis_client.c | 41 ++++++++++++++++++++++------- 3 files changed, 37 insertions(+), 16 deletions(-) diff --git a/modules/ndb_redis/README b/modules/ndb_redis/README index 37409c4..8dc695d 100644 --- a/modules/ndb_redis/README +++ b/modules/ndb_redis/README @@ -87,15 +87,15 @@ Chapter 1. Admin Guide Specify the details to connect to REDIS server. It takes a list of attribute=value separated by semicolon, the attributes can be name, - addr and port. Name is a genric identifier to be used with module + addr, port and db. Name is a generic identifier to be used with module functions. addr and port are the IP address and the port to connect to - REDIS server. + REDIS server. db is the DB number to use (defaults to 0 if not specified). Default value is NULL. Example 1.1. Set server parameter ... -modparam("ndb_redis", "server", "name=srvN;addr=127.0.0.1;port=6379") +modparam("ndb_redis", "server", "name=srvN;addr=127.0.0.1;port=6379;db=1") ... 4. Exported Functions diff --git a/modules/ndb_redis/doc/ndb_redis_admin.xml b/modules/ndb_redis/doc/ndb_redis_admin.xml index a9609a2..4e2db66 100644 --- a/modules/ndb_redis/doc/ndb_redis_admin.xml +++ b/modules/ndb_redis/doc/ndb_redis_admin.xml @@ -64,9 +64,9 @@ <para> Specify the details to connect to REDIS server. It takes a list of attribute=value separated by semicolon, the attributes can be - name, addr and port. Name is a genric identifier to be used with + name, addr, port and db. Name is a generic identifier to be used with module functions. addr and port are the IP address and the port to - connect to REDIS server. + connect to REDIS server. db is the DB number to use (defaults to 0 if not specified). </para> <para> <emphasis> @@ -77,7 +77,7 @@ <title>Set <varname>server</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("ndb_redis", "server", "name=srvN;addr=127.0.0.1;port=6379") +modparam("ndb_redis", "server", "name=srvN;addr=127.0.0.1;port=6379;db=1") ... </programlisting> </example> diff --git a/modules/ndb_redis/redis_client.c b/modules/ndb_redis/redis_client.c index 37c67f7..6a91019 100644 --- a/modules/ndb_redis/redis_client.c +++ b/modules/ndb_redis/redis_client.c @@ -34,6 +34,8 @@ #include "redis_client.h" +#define redisCommandNR(a...) (int)({ void *__tmp; __tmp = redisCommand(a); if (__tmp) freeReplyObject(__tmp); __tmp ? 0 : -1;}) + static redisc_server_t *_redisc_srv_list=NULL; static redisc_reply_t *_redisc_rpl_list=NULL; @@ -44,9 +46,13 @@ static redisc_reply_t *_redisc_rpl_list=NULL; int redisc_init(void) { char *addr; - unsigned int port; + unsigned int port, db; redisc_server_t *rsrv=NULL; param_t *pit = NULL; + struct timeval tv; + + tv.tv_sec = 1; + tv.tv_usec = 0; if(_redisc_srv_list==NULL) { @@ -58,6 +64,7 @@ int redisc_init(void) { addr = "127.0.0.1"; port = 6379; + db = 0; for (pit = rsrv->attrs; pit; pit=pit->next) { if(pit->name.len==4 && strncmp(pit->name.s, "addr", 4)==0) { @@ -66,19 +73,33 @@ int redisc_init(void) } else if(pit->name.len==4 && strncmp(pit->name.s, "port", 4)==0) { if(!str2int(&pit->body, &port)) port = 6379; + } else if(pit->name.len==2 && strncmp(pit->name.s, "db", 2)==0) { + if(!str2int(&pit->body, &db)) + db = 0; } } - rsrv->ctxRedis = redisConnect(addr, port); - if (rsrv->ctxRedis->err) { - LM_ERR("failed to connect to redis server [%.*s]: %s\n", - rsrv->sname->len, rsrv->sname->s, rsrv->ctxRedis->errstr); - return -1; - } else { - LM_DBG("connected to redis server [%.*s] (%s:%d)\n", - rsrv->sname->len, rsrv->sname->s, addr, port); - } + rsrv->ctxRedis = redisConnectWithTimeout(addr, port, tv); + if(!rsrv->ctxRedis) + goto err; + if (rsrv->ctxRedis->err) + goto err2; + if (redisCommandNR(rsrv->ctxRedis, "PING")) + goto err2; + if (redisCommandNR(rsrv->ctxRedis, "SELECT %i", db)) + goto err2; + } + return 0; + +err2: + LM_ERR("error communicating with redis server [%.*s] (%s:%d/%d): %s\n", + rsrv->sname->len, rsrv->sname->s, addr, port, db, rsrv->ctxRedis->errstr); + return -1; +err: + LM_ERR("failed to connect to redis server [%.*s] (%s:%d/%d)\n", + rsrv->sname->len, rsrv->sname->s, addr, port, db); + return -1; } /**

12 years, 9 months

Re: [sr-dev] [SR-Users] issue tracking system

by Daniel-Constantin Mierla

Btw, anyone has any experience/feedback with BugGenie? http://www.thebuggenie.com/ Just found it and at least it looks pretty. However, does not seem well documented on the web site, neither big community around (based on a quick look). Thanks, Daniel On 7/20/11 2:32 AM, Alex Balashov wrote: > We use RT as a ticketing system too. It's great for that. But I don't think it's suitable as a bug tracking or project management database for software development per se, and that's not what it was intended for. > > -- > Alex Balashov - Principal > Evariste Systems LLC > 260 Peachtree Street NW > Suite 2200 > Atlanta, GA 30303 > Tel: +1-678-954-0670 > Fax: +1-404-961-1892 > Web: http://www.evaristesys.com/ > > On Jul 19, 2011, at 5:25 PM, Nathan Angelacos<nangel(a)nothome.org> wrote: > >> On 07/19/2011 01:07 PM, Daniel-Constantin Mierla wrote: >> >>> More comments? Any other options? >> Other options: >> >> Request Tracker (rt) http://requesttracker.wikia.com/wiki/HomePage - a number of telcos in USA use rt for their ticket system >> >> >> Comments: >> >> its 10% of the technology, 90% of how committed the team is to using it. >> >> Whatever the most-active contributors want to use is going to be most successful. >> >> >> _______________________________________________ >> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list >> sr-users(a)lists.sip-router.org >> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users > _______________________________________________ > SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list > sr-users(a)lists.sip-router.org > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

12 years, 9 months

Project conference in Berlin, Sep 02, 2011

by Daniel-Constantin Mierla

Hello, the details for organizing the 10 years SER conference in Berlin were settled. After the initial announcement the interest was quite high, by now we have a good number of attendees and speakers. We are still open for new speakers, with the target of showing use cases of Kamailio or SER. The event will be hosted by FhG Fokus institute, where SER project was started. It will be a day full of presentations, followed by an evening social networking event. We hope to be able to provide the evening event for free to everyone attending, for that reason we look for sponsorships - if you are interested to sponsor, contact us and we will provide more details about available options. Registration is now open for attendees. Note that the number of seats is limited, don't wait for the last minute to register. More details, including the registration form can be accessed on the event's web page: * http://sip-router.org/10-years-ser/ Looking forward to meeting you in Berlin, enjoy a great summer till then, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

12 years, 9 months

issue tracking system

by Daniel-Constantin Mierla

Hello, sightly off-topic and cc-ed to users mailing lists, but hopefully there will be people giving valuable feedback based on their experience. When we started the integration of source code for kamailio and ser, we went for FlySpray as issue tracking system (aka bug tracker). The project seems to be dead, nothing happened to it for long time, no updates and there are warnings using latest php versions, that may result in malfunctionality or no-functionality with future versions. Therefore maybe it is the time to make a decision, rather soon than later, but this time we should look a bit more carefully to available options, to avoid ending up (in short time) to the same issue. I see two major options: A) going to use a source code hosting portal for bug traker (like sourceforge, berlios, github, a.s.o.) B) going to use an existing software to be installed on our server and managed by us I tend to go for A) as the maintenance of the software will not be done by us. I do not know which would be the best choice to go for. Of course, we should consider possible down times (like it happened in the past) or slow connection to their servers. B) will give us full control, but then it is about the time to maintain it (upgrades, security patches, a.s.o.). More than that, it is about selecting the right software to go with. Since SEMS code is now hosted in GIT repo of sip-router.org, maybe the tracker can be used by them as well, eventually by future related projects hosted in our git. Opinions? Thanks, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

12 years, 9 months

← Newer
1
...
7
8
9
10
11
12
13
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2011