sr-dev May 2011

sr-dev@lists.kamailio.org

28 participants
166 discussions

git:master: geoip: also include URL in docs
by Henning Westerholt 16 May '11

16 May '11

Module: sip-router Branch: master Commit: 4d777c5100927edc1bd99ef429625eaf552f8d23 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4d777c5… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon May 16 18:21:09 2011 +0200 geoip: also include URL in docs --- modules/geoip/README | 14 +++++++------- modules/geoip/doc/geoip_admin.xml | 6 ++++-- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/modules/geoip/README b/modules/geoip/README index 595b5df..d52e8e1 100644 --- a/modules/geoip/README +++ b/modules/geoip/README @@ -75,12 +75,12 @@ Chapter 1. Admin Guide identifying the physical location with which an IP host address is associated on a relatively granular level. - This database itself can be obtained on a free or commercial basis - here. The library that interfaces with the Max Mind API, as well as - scripts to automate downloading of the on-disk version of the - open-source database is also packaged by the Debian Linux distribution - and its derivatives as libgeoip, and probably by other distributions as - well. + This database itself can be obtained on a free or commercial basis from + http://www.maxmind.com/app/ip-location. The library that interfaces + with the Max Mind API, as well as scripts to automate downloading of + the on-disk version of the open-source database is also packaged by the + Debian Linux distribution and its derivatives as libgeoip, and probably + by other distributions as well. Debian Linux squeeze includes already a database as dependency, but as this contain the wrong data, it will not work correctly with the @@ -88,7 +88,7 @@ Chapter 1. Admin Guide will not work with the GeoIP Country Edition. In newer Debian Linux releases the package geoip-database-contrib should contain the necessary database. You can download the Lite edition of the DB from - here. + http://www.maxmind.com/app/geolitecity. This module exports a new class of pseudo-variables - $gip(pvc=>key) - to enable access to the results of a query to the database. diff --git a/modules/geoip/doc/geoip_admin.xml b/modules/geoip/doc/geoip_admin.xml index f1df9ca..e34b5cd 100644 --- a/modules/geoip/doc/geoip_admin.xml +++ b/modules/geoip/doc/geoip_admin.xml @@ -28,7 +28,8 @@ </para> <para> This database itself can be obtained on a free or commercial basis - <ulink url="http://www.maxmind.com/app/ip-location">here</ulink>. The + from <ulink url="http://www.maxmind.com/app/ip-location"> + http://www.maxmind.com/app/ip-location</ulink>. The library that interfaces with the Max Mind API, as well as scripts to automate downloading of the on-disk version of the open-source database is also packaged by the Debian Linux distribution and @@ -42,7 +43,8 @@ and will not work with the <emphasis>GeoIP Country Edition</emphasis>. In newer Debian Linux releases the package <emphasis>geoip-database-contrib</emphasis> should contain the necessary database. You can download the Lite edition - of the DB from <ulink url="http://www.maxmind.com/app/geolitecity">here</ulink>. + of the DB from <ulink url="http://www.maxmind.com/app/geolitecity"> + http://www.maxmind.com/app/geolitecity</ulink>. </para> <para> This module exports a new class of pseudo-variables -

1 0

git:3.1: geoip: extend docs after discussion with Francesco Castellano
by Henning Westerholt 16 May '11

16 May '11

Module: sip-router Branch: 3.1 Commit: 5c6f5de622ccb873701119f1e3f6e1559d56aa84 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5c6f5de… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon May 16 15:48:53 2011 +0200 geoip: extend docs after discussion with Francesco Castellano (cherry picked from commit b280f89b3ac4f97c3cad1487961509bae893f656) --- modules/geoip/README | 8 ++++++++ modules/geoip/doc/geoip_admin.xml | 11 ++++++++++- 2 files changed, 18 insertions(+), 1 deletions(-) diff --git a/modules/geoip/README b/modules/geoip/README index 11c8c73..40bb01b 100644 --- a/modules/geoip/README +++ b/modules/geoip/README @@ -75,6 +75,14 @@ Chapter 1. Admin Guide and its derivatives as libgeoip, and probably by other distributions as well. + Debian Linux squeeze includes already a database as dependency, but as + this contain the wrong data, it will not work correctly with the + module. More acurate, the module expect the GeoIP City Edition, and + will not work with the GeoIP Country Edition. In newer Debian Linux + releases the package geoip-database-contrib should contain the + necessary database. You can download the Lite edition of the DB from + here. + This module exports a new class of pseudo-variables - $gip(pvc=>key) - to enable access to the results of a query to the database. diff --git a/modules/geoip/doc/geoip_admin.xml b/modules/geoip/doc/geoip_admin.xml index b8c9f17..f1df9ca 100644 --- a/modules/geoip/doc/geoip_admin.xml +++ b/modules/geoip/doc/geoip_admin.xml @@ -28,7 +28,7 @@ </para> <para> This database itself can be obtained on a free or commercial basis - <ulink url="http://www.maxmind.com/app/ip-location">here</ulink>. The + <ulink url="http://www.maxmind.com/app/ip-location">here</ulink>. The library that interfaces with the Max Mind API, as well as scripts to automate downloading of the on-disk version of the open-source database is also packaged by the Debian Linux distribution and @@ -36,6 +36,15 @@ other distributions as well. </para> <para> + Debian Linux squeeze includes already a database as dependency, but as + this contain the wrong data, it will not work correctly with the module. + More acurate, the module expect the <emphasis>GeoIP City Edition</emphasis>, + and will not work with the <emphasis>GeoIP Country Edition</emphasis>. In + newer Debian Linux releases the package <emphasis>geoip-database-contrib</emphasis> + should contain the necessary database. You can download the Lite edition + of the DB from <ulink url="http://www.maxmind.com/app/geolitecity">here</ulink>. + </para> + <para> This module exports a new class of pseudo-variables - $gip(pvc=>key) - to enable access to the results of a query to the database.

1 0

[tracker] Task opened: DBTEXT
by sip-router 16 May '11

16 May '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Pavel Segec (palo73) Attached to Project - sip-router Summary - DBTEXT Task Type - Improvement Category - Module Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - 3.1 Due in Version - Undecided Due Date - Undecided Details - Hello, I've tried DBTEXT module as another simple database with Kamailio 3.1 , I've found following problems. 1) after creating required dbtext files using kamdbctl create, it created version file with mistakes. The version file contain bad line id(int,auto) lcr_id(int) gw_name(string) grp_id(int) ip_addr(string) hostname(string,null) port(int,null) uri_scheme(int,null) transport(int,null) strip(int,null) tag(string,null) weight(int,null) flags(int) defunct(int,null) and id(int,auto) lcr_id(int) prefix(string,null) from_uri(string,null) grp_id(int) priority(int) 2) using kamctl create reports pointer to some old Openser directory is_user: user counter=/usr/share/kamailio/dbtext/openser is not a directory INFO: user 'palo' already exists 3) after creating symbolic link with ln -s /etc/kamailio/dbtext/ /usr/share/kamailio/dbtext/openser kamctl utility during user adding require an email address for a new user kamctl add jano jano database engine 'DBTEXT' loaded Control engine 'FIFO' loaded is_user: user counter=0 check_db_alias: alias counter=0 email_address cannot be empty or null ERROR: introducing the new user 'jano' to the database failed but when address is included, there is another error about bad command syntax pstest:/etc/kamailio/dbtext# kamctl add jano jano jano@jano database engine 'DBTEXT' loaded Control engine 'FIFO' loaded -- command 'add|passwd|rm' - manage subscribers add <username> <password> .......... add a new subscriber (*) passwd <username> <passwd> ......... change user's password (*) rm <username> ...................... delete a user (*) More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=132 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

mqueue fix to make mq_fetch() return false if queue empty
by Alex Balashov 16 May '11

16 May '11

I am curious as to why sip-router master commit e6fa8ae004f5d487e1c64471bf282931e4b9e901 has not been included in the 3.1 branch, given that it was made in early October. I have been waiting for it to be included in releases for quite a long time. Thanks! -- Alex Balashov - Principal Evariste Systems LLC 260 Peachtree Street NW Suite 2200 Atlanta, GA 30303 Tel: +1-678-954-0670 Fax: +1-404-961-1892 Web: http://www.evaristesys.com/

3 2

git:3.1: mqueue: return false if queue is empty
by Daniel-Constantin Mierla 16 May '11

16 May '11

Module: sip-router Branch: 3.1 Commit: 203e6d078015e47ecf25a160653ace1d3745807c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=203e6d0… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Oct 11 12:20:24 2010 +0200 mqueue: return false if queue is empty - return code -2 - reported by Alex Balashov (cherry picked from commit e6fa8ae004f5d487e1c64471bf282931e4b9e901) --- modules/mqueue/README | 11 +++++++---- modules/mqueue/doc/mqueue_admin.xml | 8 ++++++-- modules/mqueue/mqueue_api.c | 22 +++++++++++++--------- modules/mqueue/mqueue_mod.c | 7 +++++-- 4 files changed, 31 insertions(+), 17 deletions(-) diff --git a/modules/mqueue/README b/modules/mqueue/README index 4c439a4..f876b2a 100644 --- a/modules/mqueue/README +++ b/modules/mqueue/README @@ -10,7 +10,7 @@ Elena-Ramona Modroiu <ramona(a)asipto.com> - Copyright � 2010 Elena-Ramona Modroiu (asipto.com) + Copyright © 2010 Elena-Ramona Modroiu (asipto.com) __________________________________________________________________ Table of Contents @@ -94,7 +94,7 @@ Chapter 1. Admin Guide Definition of memory queue - Default value is "none". + Default value is “none”. Value must be a list of parameters: attr=value;... The attribute 'name' is mandatory, defining the name of the queue. Optional attribute 'size' @@ -128,8 +128,11 @@ mq_add("myq", "$rU", "call from $fU"); 4.2. mq_fetch(queue) - Take oldest item from que and fill $mqk(queue) and $mqv(queue) pseudo - variables. Return true on success. + Take oldest item from queue and fill $mqk(queue) and $mqv(queue) pseudo + variables. + + Return: true on success (1); false on failure (-1) or no item fetched + (-2). Example 1.3. mq_fetch usage ... diff --git a/modules/mqueue/doc/mqueue_admin.xml b/modules/mqueue/doc/mqueue_admin.xml index e02ca38..d1b924a 100644 --- a/modules/mqueue/doc/mqueue_admin.xml +++ b/modules/mqueue/doc/mqueue_admin.xml @@ -118,8 +118,12 @@ mq_add("myq", "$rU", "call from $fU"); <function moreinfo="none">mq_fetch(queue)</function> </title> <para> - Take oldest item from que and fill $mqk(queue) and $mqv(queue) pseudo - variables. Return true on success. + Take oldest item from queue and fill $mqk(queue) and + $mqv(queue) pseudo variables. + </para> + <para> + Return: true on success (1); false on failure (-1) or + no item fetched (-2). </para> <example> <title><function>mq_fetch</function> usage</title> diff --git a/modules/mqueue/mqueue_api.c b/modules/mqueue/mqueue_api.c index f75f23a..6007ef0 100644 --- a/modules/mqueue/mqueue_api.c +++ b/modules/mqueue/mqueue_api.c @@ -254,17 +254,21 @@ int mq_head_fetch(str *name) return -1; lock_get(&mh->lock); - if(mh->ifirst!=NULL) + if(mh->ifirst==NULL) { - mp->item = mh->ifirst; - mh->ifirst = mh->ifirst->next; - if(mh->ifirst==NULL) { - mh->ilast = NULL; - } else { - mh->ifirst->prev = NULL; - } - mh->csize--; + /* empty queue */ + lock_release(&mh->lock); + return -2; + } + + mp->item = mh->ifirst; + mh->ifirst = mh->ifirst->next; + if(mh->ifirst==NULL) { + mh->ilast = NULL; + } else { + mh->ifirst->prev = NULL; } + mh->csize--; lock_release(&mh->lock); return 0; diff --git a/modules/mqueue/mqueue_mod.c b/modules/mqueue/mqueue_mod.c index 922f02e..5a74f58 100644 --- a/modules/mqueue/mqueue_mod.c +++ b/modules/mqueue/mqueue_mod.c @@ -109,8 +109,11 @@ static void mod_destroy(void) static int w_mq_fetch(struct sip_msg* msg, char* mq, char* str2) { - if(mq_head_fetch((str*)mq)<0) - return -1; + int ret; + + ret = mq_head_fetch((str*)mq); + if(ret<0) + return ret; return 1; }

1 0

git:master: tm: add warning about t_newtran behaviour ( pointed out from Iñaki
by Henning Westerholt 16 May '11

16 May '11

Module: sip-router Branch: master Commit: 9f27cb55a1b4def4f393def6170430cbf70e6615 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9f27cb5… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon May 16 15:22:15 2011 +0200 tm: add warning about t_newtran behaviour (pointed out from Iñaki --- modules/tm/README | 5 +++++ modules/tm/doc/functions.xml | 6 ++++++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/modules/tm/README b/modules/tm/README index 4e535bc..bf44793 100644 --- a/modules/tm/README +++ b/modules/tm/README @@ -1342,6 +1342,11 @@ t_relay(); the only way a script can add a new transaction in an atomic way. Typically, it is used to deploy a UAS. +Warning + + Please note that the changes on the request that are made after this + function call will not be saved into transaction! + Example 46. t_newtran usage ... if (t_newtran()) { diff --git a/modules/tm/doc/functions.xml b/modules/tm/doc/functions.xml index 6de270a..683a7d8 100644 --- a/modules/tm/doc/functions.xml +++ b/modules/tm/doc/functions.xml @@ -268,6 +268,12 @@ t_relay(); is the only way a script can add a new transaction in an atomic way. Typically, it is used to deploy a UAS. </para> + <warning> + <para> + Please note that the changes on the request that are made after this + function call will not be saved into transaction! + </para> + </warning> <example> <title><function>t_newtran</function> usage</title> <programlisting>

1 0

build fail on ARM
by kasip＠elektromaniak.wz.cz 16 May '11

16 May '11

Hi! I once sent this message as a non-member and it was probably never looked on. I tried to compile kamailio on ARM A9 (omap4430) natively and failed with these errors CC (gcc) [kamailio] atomic_ops.o ./tmp/ccm1k5em.s: Assembler messages: /tmp/ccm1k5em.s:35: Error: selected processor does not support Thumb mode `swp r4,r8,[r6]' /tmp/ccm1k5em.s:46: Error: selected processor does not support Thumb mode `swp r4,r8,[r6]' /tmp/ccm1k5em.s:191: Error: selected processor does not support Thumb mode `swp r4,r9,[r7]' /tmp/ccm1k5em.s:204: Error: selected processor does not support Thumb mode `swp r4,r9,[r7]' make: *** [atomic_ops.o] Error 1 ALTERNATIVELY I have found openser 1.3.2-3 in debian lenny for armel achitecture. Is this version secure enough? (I mean - has no some remote code execution / db corruption bugs which are fixed in current kamailio version?) I don't care about call authenticity or bookkeeping or protecting the uplink (because there is none) If it only lacks features, then it would be enough. Thanks for reply. MMlosh

3 4

[tracker] Task opened: nathelper path support with registrar on private network.
by sip-router 16 May '11

16 May '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Bruce McAlister (asgaroth) Attached to Project - sip-router Summary - nathelper path support with registrar on private network. Task Type - Bug Report Category - Core Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - Linux Severity - Low Priority - Normal Reported Version - 3.1 Due in Version - Undecided Due Date - Undecided Details - Hi I have a multihomed proxy that has one nic facing the "internet" and one nic on a private network segment. I then have a registrar server sitting only on the private segment. All registration requests are sent to the proxy to be dealt with. I would like to enable nat ping support on the registrar server. When I do this the nathelper module is unable to contact the end device. I have enabled path support on the registrar, the proxy sends on the path information and the registrar module successfully saves this information to the database. When the nathelper module tries to ping a device it is not using the path information to send the INFO/OPTIONS message out via the correct path. On the proxy, I execute the following route for registration requests: route[REGISTRAR] { if (is_method("REGISTER")) { add_path_received(); if(!ds_select_dst("2", "1")) { sl_send_reply("500", "No destination available"); exit; } t_on_failure("DEST_INTERNAL"); if(!t_relay()) { sl_reply_error(); } exit; } } on the registrar I have the following route defined: route { if (is_method("REGISTER")) { ### ### Register Requests Only ### if (from_uri==myself) { if (!www_authorize("$td", "subscriber")) { www_challenge("$td", "0"); exit; }; if ($au!=$tU) { sl_send_reply("403","Forbidden auth ID"); exit; }; consume_credentials(); setbflag(NAT_BFLAG); if (!save("location","0x4")) { sl_reply_error(); exit; } } }; exit; } I can see the "Path" header being set on the proxy and then sent to the registrar. That appears to be working normally. It's only when I enable nat pinging that I receive the following error in the logs: ERROR: <core> [udp_server.c:586]: ERROR: udp_send: sendto(sock,0xf31a22,4,0,151.42.41.67:5062,16): Network is unreachable(101) ERROR: nathelper [nathelper.c:1722]: udp_send failed This makes sense to me as the registrar is on a private network. However, I would have assumed that the nathelper module would have used the path information to build the destination address to send the INFO/OPTIONS message to. Is this expected behaviour or a bug/configuration issue of sorts? The proxy is running version: kamailio 3.1.3 (i386/linux) 41e576 The registrar is running version: kamailio 3.1.3 (i386/linux) 41e576 Please let me know if you need any more information from me. Thanks More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=131 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Assignee added: nathelper path support with registrar on private network.
by sip-router 16 May '11

16 May '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#131 - nathelper path support with registrar on private network. User who did this - Bruce McAlister (asgaroth) http://sip-router.org/tracker/index.php?do=details&task_id=131 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

How does SR match ACK for 3456]XX replied statelessly?
by Iñaki Baz Castillo 16 May '11

16 May '11

Hi, an INVITE arrives to SR and the config script just executes: sl_reply("404", "Bye Bye"); exit; So no server transaction has been created. But when the ACK arrives it's correctly absorbed by SR transport layer (as it doesn't arrive to the script logic). My question is: how does SR match such ACK? was some timer started to match and absorv the ACK? Thanks a lot. -- Iñaki Baz Castillo <ibc(a)aliax.net>

3 6

← Newer
1
...
8
9
10
11
12
13
14
...
17
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2011