sr-dev December 2011

sr-dev@lists.kamailio.org

32 participants
230 discussions

[tracker] Comment added: Crash if t_release() is executed after t_relay_to(), when this last returns -1

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#184 - Crash if t_release() is executed after t_relay_to(), when this last returns -1 User who did this - Daniel-Constantin Mierla (miconda) ---------- So the problem was using it from failure_route, when the transaction was actually created and added in internal timers during request_route. t_release() is intended only for request_route, probably you have it in a route[x] block. I committed a patch to make sure t_release() is executed only from request_route block (GIT#bb2e2477cbcd14ad5a4a7203ad6b59d5a705e555). ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=184#comment449 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

git:master: tm: safety check to be sure t_release() is executed in request_route

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: bb2e2477cbcd14ad5a4a7203ad6b59d5a705e555 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bb2e247… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 2 11:55:28 2011 +0100 tm: safety check to be sure t_release() is executed in request_route - t_release() is intended for request_route block, but can be executed from other types of root routing block via subroute, causing a crash - the fix ensures the root routing block is request_route - reported by Jose Luis Millan, closes FS#184 --- modules/tm/tm.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/modules/tm/tm.c b/modules/tm/tm.c index 5e06470..20167bb 100644 --- a/modules/tm/tm.c +++ b/modules/tm/tm.c @@ -1286,6 +1286,12 @@ inline static int w_t_release(struct sip_msg* msg, char* str, char* str2) struct cell *t; int ret; + if(get_route_type()!=REQUEST_ROUTE) + { + LM_INFO("invalid usage - not in request route\n"); + return -1; + } + if (t_check( msg , 0 )==-1) return -1; t=get_t(); if ( t && t!=T_UNDEFINED ) {

13 years

[tracker] Comment added: textopsx:msg_apply_changes() can corrupt incoming TCP message buffer (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#185 - textopsx:msg_apply_changes() can corrupt incoming TCP message buffer User who did this - Daniel-Constantin Mierla (miconda) ---------- I was thinking to a similar approach, but linking msg->buf to a buffer stored in textops. There are couple of aspects that needed to be checked, that's why I haven't gone for it yet. Pretty much any time sip_msg_t structure is changed, TM module needs to be updated as it does cloning of the structure in shared memory. Your patch should at least reset the tmp_buf field for the shared memory clone to be sure nobody will access it from different process or after was freed. I am attaching a variant of the patch I thought of. I am considering also adding an internal flag to mark that the buffer was changed. The patch will keep the new buffer longer, till the next msg_apply_changes() -- it can be improved with a pre-script callback or checking the internal flag. The advantage is no need to change the sip_msg_t structure and check tm cloning. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=185#comment448 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: textopsx:msg_apply_changes() can corrupt incoming TCP message buffer (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#185 - textopsx:msg_apply_changes() can corrupt incoming TCP message buffer User who did this - Hugh Waite (hugh.waite) ---------- This was an urgent issue for us, so I have implemented a fix which is attached. This fix stores the pkg memory allocated in msg_apply_changes in the sip_msg structure and frees it when the sip_msg is freed. The sip_msg data is parsed from this temporary buffer and the main buffer is left untouched, so subsequent message parsing can continue. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=185#comment447 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Brandon Armstead (CRYY2010) ---------- So far so good - :). ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment446 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: Crash if t_release() is executed after t_relay_to(), when this last returns -1 (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#184 - Crash if t_release() is executed after t_relay_to(), when this last returns -1 User who did this - Jose Luis Millan Villegasº (jmillan) ---------- The crash happens when the execution of the block is done in failure_route, being the domain of the Request-URI represented by a hostname. It doesn't crash if the Request-URI is represented by an IP address. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=184#comment445 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

git:master: core: Solaris fix for using libcurl

by Jason Penton

Module: sip-router Branch: master Commit: 577585de0a63737157e88d18007807f8f55f7904 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=577585d… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Fri Dec 2 08:41:29 2011 +0200 core: Solaris fix for using libcurl - Require this fix on solaris for any dynamic loading of modules that use libcurl. See comment above fix for more details --- sr_module.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/sr_module.c b/sr_module.c index 7b0d85d..853c7a2 100644 --- a/sr_module.c +++ b/sr_module.c @@ -76,6 +76,13 @@ struct sr_module* modules=0; +/*We need to define this symbol on Solaris becuase libcurl relies on libnspr which looks for this symbol. + If it is not defined, dynamic module loading (dlsym) fails */ +#ifdef __OS_solaris + int nspr_use_zone_allocator = 0; +#endif + + #ifdef STATIC_EXEC extern struct module_exports exec_exports; #endif

13 years

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Jasmin Schnatterbeck (jasmin) ---------- another thing: "dlg_get_msg_dialog" calls "pre_match_parse" so I got LM_ERROR "failed to get From header" for each request without from tag (unfortunately many UAs still send sip msgs without from tag). So another suggestion (just for logging purposes) ... in "pre_match_parse": if (parse_from_header(req)<0 || get_from(req)->tag_value.len==0) { LM_ERR("failed to get From header\n"); return -1; } to: if (parse_from_header(req)<0 ) { LM_ERR("failed to get From header\n"); return -1; } if (get_from(req)->tag_value.len==0) { LM_DBG("no From tag found - request without From tag?\n"); return -1; } Jasmin ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment444 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Brandon Armstead (CRYY2010) ---------- Appears to be working!!! I'll follow up later this evening with a full update. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment443 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Brandon Armstead (CRYY2010) ---------- @Daniel - I appear to have missed the pointer pass of &dir to get_dlg. I've recompiled -- will update you in a few minutes if its crashing still. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment442 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2011