sr-dev August 2010

sr-dev@lists.kamailio.org

26 participants
346 discussions

git:sr_3.0: io_wait: kqueue: use the entire array during too many errors fallback

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: e4d53ae023d3b50702c635beb521e313431cff66 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e4d53ae… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Jul 8 15:18:52 2010 +0200 io_wait: kqueue: use the entire array during too many errors fallback Minor fix/optimization: if there are too many errors in the changelist and the kevent() call has to be retried, use the entire array (don't rely on the current watched fd number which will be smaller then the array real size, since commit 996826). (only kqueue using systems are affected by this fix: *bsd and darwin) (cherry picked from commit a9cdfc2938ca73d6ba40f5896c6a8930c2e73f85) --- io_wait.h | 105 +++++++++++++++++++++++++++++++------------------------------ 1 files changed, 53 insertions(+), 52 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e4d…

13 years, 10 months

git:sr_3.0: io_wait: kqueue: handle ENOENT and more robust error handling

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: 4cfd8e1d074e9bb76b20ca3b5722f4a02dd29f15 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4cfd8e1… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Sat Jun 19 00:44:24 2010 +0200 io_wait: kqueue: handle ENOENT and more robust error handling - handle also ENOENT (along EBADF) when kevent fails due to errors in the changelist. ENOENT can be returned in the following valid scenario: fd scheduled for delayed removal from the watched fd list, fd closed (which automatically removes the fd from the kqueue watched list), new opened fd which gets the same number, delayed changes applied (kevent()). - treat all the other kevent errors or EV_ERRORs in a similar way but log them (at BUG() level). - return POLLERR|POLLHUP for EV_EOF with a non-null fflags. (only kqueue, meaning *bsd and darwin are affected by this fix) (cherry picked from commit 8966d0a1787152fa64d1f78321ee539116bd448a) --- io_wait.h | 92 +++++++++++++++++++++++++++++++++++++------------------------ 1 files changed, 56 insertions(+), 36 deletions(-) diff --git a/io_wait.h b/io_wait.h index b110b6b..c28f53d 100644 --- a/io_wait.h +++ b/io_wait.h @@ -259,34 +259,33 @@ static inline int kq_ev_change(io_wait_h* h, int fd, int filter, int flag, again: n=kevent(h->kq_fd, h->kq_changes, h->kq_nchanges, 0, 0, &tspec); if (unlikely(n == -1)){ - if (likely(errno == EBADF)) { + if (unlikely(errno == EINTR)) goto again; + else { + /* for a detailed explanation of what follows see + io_wait_loop_kqueue EV_ERROR case */ + if (unlikely(!(errno == EBADF || errno == ENOENT))) + BUG("kq_ev_change: kevent flush changes failed" + " (unexpected error): %s [%d]\n", + strerror(errno), errno); + /* ignore error even if it's not a EBADF/ENOENT */ /* one of the file descriptors is bad, probably already closed => try to apply changes one-by-one */ for (r = 0; r < h->kq_nchanges; r++) { retry2: n = kevent(h->kq_fd, &h->kq_changes[r], 1, 0, 0, &tspec); if (n==-1) { - if (errno == EBADF) - continue; /* skip over it */ - if (errno == EINTR) + if (unlikely(errno == EINTR)) goto retry2; - LOG(L_ERR, "ERROR: io_watch_add: kevent flush changes" - " failed: %s [%d]\n", - strerror(errno), errno); - /* shift the array */ - memmove(&h->kq_changes[0], &h->kq_changes[r+1], - sizeof(h->kq_changes[0])* - (h->kq_nchanges-r-1)); - h->kq_nchanges-=(r+1); - return -1; + /* for a detailed explanation of what follows see + io_wait_loop_kqueue EV_ERROR case */ + if (unlikely(!(errno == EBADF || errno == ENOENT))) + BUG("kq_ev_change: kevent flush changes failed:" + " (unexpected error) %s [%d] (%d/%d)\n", + strerror(errno), errno, + r, h->kq_nchanges); + continue; /* skip over it */ } } - } else if (errno == EINTR) goto again; - else { - LOG(L_ERR, "ERROR: io_watch_add: kevent flush changes" - " failed: %s [%d]\n", strerror(errno), errno); - h->kq_nchanges=0; /* reset changes array */ - return -1; } } h->kq_nchanges=0; /* changes array is empty */ @@ -1118,17 +1117,18 @@ again: n=kevent(h->kq_fd, h->kq_changes, apply_changes, h->kq_array, h->fd_no, &tspec); if (unlikely(n==-1)){ - if (errno==EINTR) goto again; /* signal, ignore it */ - else if (errno==EBADF) { + if (unlikely(errno==EINTR)) goto again; /* signal, ignore it */ + else { + /* for a detailed explanation of what follows see below + the EV_ERROR case */ + if (unlikely(!(errno==EBADF || errno==ENOENT))) + BUG("io_wait_loop_kqueue: kevent: unexpected error" + " %s [%d]\n", strerror(errno), errno); /* some of the FDs in kq_changes are bad (already closed) and there is not enough space in kq_array to return all of them back */ apply_changes = h->fd_no; goto again; - }else{ - LOG(L_ERR, "ERROR: io_wait_loop_kqueue: kevent:" - " %s [%d]\n", strerror(errno), errno); - goto error; } } /* remove applied changes */ @@ -1148,14 +1148,13 @@ again: r, n, h->kq_array[r].ident, (long)h->kq_array[r].udata, h->kq_array[r].flags); #endif - if (unlikely((h->kq_array[r].flags & EV_ERROR) && - (h->kq_array[r].data == EBADF || - h->kq_array[r].udata == 0))){ + if (unlikely((h->kq_array[r].flags & EV_ERROR) || + h->kq_array[r].udata == 0)){ /* error in changes: we ignore it if it has to do with a bad fd or update==0. It can be caused by trying to remove an already closed fd: race between adding something to the - changes array, close() and applying the changes. - E.g. for ser tcp: tcp_main sends a fd to child fore reading + changes array, close() and applying the changes (EBADF). + E.g. for ser tcp: tcp_main sends a fd to child for reading => deletes it from the watched fds => the changes array will contain an EV_DELETE for it. Before the changes are applied (they are at the end of the main io_wait loop, @@ -1163,6 +1162,16 @@ again: to tcp_main by a sender (send fail) is processed and causes the fd to be closed. When the changes are applied => error for the EV_DELETE attempt of a closed fd. + Something similar can happen when a fd is scheduled + for removal, is close()'ed before being removed and + re-opened(a new sock. get the same fd). When the + watched fd changes will be applied the fd will be valid + (so no EBADF), but it's not already watch => ENOENT. + We report a BUG for the other errors (there's nothing + constructive we can do if we get an error we don't know + how to handle), but apart from that we ignore it in the + idea that it is better apply the rest of the changes, + rather then dropping all of them. */ /* example EV_ERROR for trying to delete a read watched fd, @@ -1176,9 +1185,12 @@ again: udata = 0x0 } */ - if (h->kq_array[r].data != EBADF) - LOG(L_INFO, "INFO: io_wait_loop_kqueue: kevent error on " - "fd %ld: %s [%ld]\n", (long)h->kq_array[r].ident, + if (h->kq_array[r].data != EBADF && + h->kq_array[r].data != ENOENT) + BUG("io_wait_loop_kqueue: kevent unexpected error on " + "fd %ld udata %lx: %s [%ld]\n", + (long)h->kq_array[r].ident, + (long)h->kq_array[r].udata, strerror(h->kq_array[r].data), (long)h->kq_array[r].data); }else{ @@ -1186,20 +1198,28 @@ again: if (likely(h->kq_array[r].filter==EVFILT_READ)){ revents=POLLIN | (((int)!(h->kq_array[r].flags & EV_EOF)-1)&POLLHUP) | - (((int)!(h->kq_array[r].flags & EV_ERROR)-1)&POLLERR); + (((int)!((h->kq_array[r].flags & EV_EOF) && + h->kq_array[r].fflags != 0) - 1)&POLLERR); while(fm->type && (fm->events & revents) && (handle_io(fm, revents, -1)>0) && repeat); }else if (h->kq_array[r].filter==EVFILT_WRITE){ revents=POLLOUT | (((int)!(h->kq_array[r].flags & EV_EOF)-1)&POLLHUP) | - (((int)!(h->kq_array[r].flags & EV_ERROR)-1)&POLLERR); + (((int)!((h->kq_array[r].flags & EV_EOF) && + h->kq_array[r].fflags != 0) - 1)&POLLERR); while(fm->type && (fm->events & revents) && (handle_io(fm, revents, -1)>0) && repeat); + }else{ + BUG("io_wait_loop_kqueue: unknown filter: kqueue: event " + "%d/%d: fd=%d, filter=%d, flags=0x%x, fflags=0x%x," + " data=%lx, udata=%lx\n", + r, n, h->kq_array[r].ident, h->kq_array[r].filter, + h->kq_array[r].flags, h->kq_array[r].fflags, + (long)h->kq_array[r].data, (long)h->kq_array[r].udata); } } } } while(unlikely(orig_changes)); -error: return n; } #endif

13 years, 10 months

git:sr_3.0: io_wait: don't update FD watched status on error

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: 311b29d5e73720050f2bc56c36432b2eb45bbe83 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=311b29d… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Jun 18 09:48:21 2010 +0200 io_wait: don't update FD watched status on error If the syscall to change the events or delete a watched FD fails, don't update/delete the FD status in fd_hash. For /dev/poll if a change fails when re-adding the FD, delete it from the hash (in the /dev/poll case to change the events a FD is watched for one has to remove it and re-add it with the new events). The syscalls should never fail in an un-handled way, but in the unlikely event that it happens this change will make the code more robust. (cherry picked from commit 2d8cd170ab867ab15296b30f0b784abe1adc1bca) --- io_wait.h | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/io_wait.h b/io_wait.h index 93f1426..01df1e6 100644 --- a/io_wait.h +++ b/io_wait.h @@ -627,7 +627,6 @@ inline static int io_watch_del(io_wait_h* h, int fd, int idx, int flags) goto error; } events=e->events; - unhash_fd_map(e); switch(h->poll_method){ case POLL_POLL: @@ -647,7 +646,6 @@ inline static int io_watch_del(io_wait_h* h, int fd, int idx, int flags) #endif #ifdef HAVE_SIGIO_RT case POLL_SIGIO_RT: - fix_fd_array; /* the O_ASYNC flag must be reset all the time, the fd * can be changed only if O_ASYNC is reset (if not and * the fd is a duplicate, you will get signals from the dup. fd @@ -667,6 +665,7 @@ inline static int io_watch_del(io_wait_h* h, int fd, int idx, int flags) " failed: %s [%d]\n", strerror(errno), errno); goto error; } + fix_fd_array; /* only on success */ break; #endif #ifdef HAVE_EPOLL @@ -737,6 +736,7 @@ again_devpoll: h->poll_method); goto error; } + unhash_fd_map(e); /* only on success */ h->fd_no--; return 0; error: @@ -808,14 +808,14 @@ inline static int io_watch_chg(io_wait_h* h, int fd, short events, int idx ) add_events=events & ~e->events; del_events=e->events & ~events; - e->events=events; switch(h->poll_method){ case POLL_POLL: + fd_array_chg(events #ifdef POLLRDHUP - /* listen to POLLRDHUP by default (if POLLIN) */ - events|=((int)!(events & POLLIN) - 1) & POLLRDHUP; + /* listen to POLLRDHUP by default (if POLLIN) */ + | (((int)!(events & POLLIN) - 1) & POLLRDHUP) #endif /* POLLRDHUP */ - fd_array_chg(events); + ); break; #ifdef HAVE_SELECT case POLL_SELECT: @@ -921,6 +921,8 @@ again_devpoll2: LOG(L_ERR, "ERROR: io_watch_chg: re-adding fd to " "/dev/poll failed: %s [%d]\n", strerror(errno), errno); + /* error re-adding the fd => mark it as removed/unhash */ + unhash_fd_map(e); goto error; } break; @@ -931,6 +933,7 @@ again_devpoll2: h->poll_method); goto error; } + e->events=events; /* only on success */ return 0; error: return -1;

13 years, 10 months

git:sr_3.0: io_wait: fix kqueue and too many errors in changelist

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: ef1e1b4af1e96ee46c08400acd05abbc43a51738 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ef1e1b4… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Jun 17 18:43:14 2010 +0200 io_wait: fix kqueue and too many errors in changelist kevent() tries to return errors in the changelist back in the supplied eventlist array. However if this is not large enough, the whole kevent() syscall will fail. Now if kevent() fails with EBADF the call will be retried with a smaller set of changes, until the entire original changelist is applied. Fixes also kq_ev_change() flush mode: on error it will try to apply the changes one-by-one. (this affects only systems that have kqueue: *bsd and darwin) (cherry picked from commit b0bd3201826ee693d6f96c6e336477b9d9db7c32) --- io_wait.h | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 55 insertions(+), 7 deletions(-) diff --git a/io_wait.h b/io_wait.h index 44ef60c..93f1426 100644 --- a/io_wait.h +++ b/io_wait.h @@ -247,6 +247,7 @@ static inline int kq_ev_change(io_wait_h* h, int fd, int filter, int flag, void* data) { int n; + int r; struct timespec tspec; if (h->kq_nchanges>=h->kq_changes_size){ @@ -257,11 +258,36 @@ static inline int kq_ev_change(io_wait_h* h, int fd, int filter, int flag, tspec.tv_nsec=0; again: n=kevent(h->kq_fd, h->kq_changes, h->kq_nchanges, 0, 0, &tspec); - if (n==-1){ - if (errno==EINTR) goto again; - LOG(L_ERR, "ERROR: io_watch_add: kevent flush changes " + if (unlikely(n == -1)){ + if (likely(errno == EBADF)) { + /* one of the file descriptors is bad, probably already + closed => try to apply changes one-by-one */ + for (r = 0; r < h->kq_nchanges; r++) { +retry2: + n = kevent(h->kq_fd, &h->kq_changes[r], 1, 0, 0, &tspec); + if (n==-1) { + if (errno == EBADF) + continue; /* skip over it */ + if (errno == EINTR) + goto retry2; + LOG(L_ERR, "ERROR: io_watch_add: kevent flush changes" + " failed: %s [%d]\n", + strerror(errno), errno); + /* shift the array */ + memmove(&h->kq_changes[0], &h->kq_changes[r+1], + sizeof(h->kq_changes[0])* + (h->kq_nchanges-r-1)); + h->kq_nchanges-=(r+1); + return -1; + } + } + } else if (errno == EINTR) goto again; + else { + LOG(L_ERR, "ERROR: io_watch_add: kevent flush changes" " failed: %s [%d]\n", strerror(errno), errno); - return -1; + h->kq_nchanges=0; /* reset changes array */ + return -1; + } } h->kq_nchanges=0; /* changes array is empty */ } @@ -1076,22 +1102,43 @@ inline static int io_wait_loop_kqueue(io_wait_h* h, int t, int repeat) int n, r; struct timespec tspec; struct fd_map* fm; + int orig_changes; + int apply_changes; int revents; tspec.tv_sec=t; tspec.tv_nsec=0; + orig_changes=h->kq_nchanges; + apply_changes=orig_changes; + do { again: - n=kevent(h->kq_fd, h->kq_changes, h->kq_nchanges, h->kq_array, + n=kevent(h->kq_fd, h->kq_changes, apply_changes, h->kq_array, h->fd_no, &tspec); if (unlikely(n==-1)){ if (errno==EINTR) goto again; /* signal, ignore it */ - else{ + else if (errno==EBADF) { + /* some of the FDs in kq_changes are bad (already closed) + and there is not enough space in kq_array to return all + of them back */ + apply_changes = h->fd_no; + goto again; + }else{ LOG(L_ERR, "ERROR: io_wait_loop_kqueue: kevent:" " %s [%d]\n", strerror(errno), errno); goto error; } } - h->kq_nchanges=0; /* reset changes array */ + /* remove applied changes */ + h->kq_nchanges -= apply_changes; + if (unlikely(apply_changes < orig_changes)) { + orig_changes -= apply_changes; + memmove(&h->kq_changes[0], &h->kq_changes[apply_changes], + sizeof(h->kq_changes[0])*h->kq_nchanges); + apply_changes = orig_changes<h->fd_no ? orig_changes : h->fd_no; + } else { + orig_changes = 0; + apply_changes = 0; + } for (r=0; r<n; r++){ #ifdef EXTRA_DEBUG DBG("DBG: kqueue: event %d/%d: fd=%d, udata=%lx, flags=0x%x\n", @@ -1148,6 +1195,7 @@ again: } } } + } while(unlikely(orig_changes)); error: return n; }

13 years, 10 months

git:sr_3.0: io_wait: fix: check for EV_ERROR for kqueue()

by Andrei Pelinescu-Onciul

Module: sip-router Branch: sr_3.0 Commit: ea37f13d610fdab887a256960e4a056dfca45f4a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ea37f13… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Jun 17 16:15:10 2010 +0200 io_wait: fix: check for EV_ERROR for kqueue() Re-enabled and enhanced the check for EV_ERROR when using kqueue (*bsd). This is needed to workaround errors reported by kqueue when trying to delete (EV_DELETE) an already closed FD (this can happen in the tcp code, where we try to avoid applying immediately changes in the set of watched FDs and instead collect them and apply them after all the current kqueue events are processed => in some corner case situations it's possible to try to delete the FD from kqueue after the fd was close()'ed). This fix will ignore EV_ERROR with data == EBADF. All the other errors will result in a POLLERR flag for the callback. It fixes crashes with *bsd under tcp stress tests (lots of very short lived connections). (cherry picked from commit 05c080a53f88babad6729f79015f555f53fdf957) --- io_wait.h | 55 ++++++++++++++++++++++++++++++++++++++++--------------- 1 files changed, 40 insertions(+), 15 deletions(-) diff --git a/io_wait.h b/io_wait.h index 0557c00..44ef60c 100644 --- a/io_wait.h +++ b/io_wait.h @@ -45,6 +45,7 @@ * 2007-11-29 support for write (POLLOUT); added io_watch_chg() (andrei) * 2008-02-04 POLLRDHUP & EPOLLRDHUP support (automatically enabled if POLLIN * is set) (andrei) + * 2010-06-17 re-enabled & enhanced the EV_ERROR for kqueue (andrei) */ @@ -1097,31 +1098,55 @@ again: r, n, h->kq_array[r].ident, (long)h->kq_array[r].udata, h->kq_array[r].flags); #endif -#if 0 - if (unlikely(h->kq_array[r].flags & EV_ERROR)){ - /* error in changes: we ignore it, it can be caused by - trying to remove an already closed fd: race between - adding something to the changes array, close() and - applying the changes */ - LOG(L_INFO, "INFO: io_wait_loop_kqueue: kevent error on " - "fd %ld: %s [%ld]\n", h->kq_array[r].ident, + if (unlikely((h->kq_array[r].flags & EV_ERROR) && + (h->kq_array[r].data == EBADF || + h->kq_array[r].udata == 0))){ + /* error in changes: we ignore it if it has to do with a + bad fd or update==0. It can be caused by trying to remove an + already closed fd: race between adding something to the + changes array, close() and applying the changes. + E.g. for ser tcp: tcp_main sends a fd to child fore reading + => deletes it from the watched fds => the changes array + will contain an EV_DELETE for it. Before the changes + are applied (they are at the end of the main io_wait loop, + after all the fd events were processed), a CON_ERR sent + to tcp_main by a sender (send fail) is processed and causes + the fd to be closed. When the changes are applied => + error for the EV_DELETE attempt of a closed fd. + */ + /* + example EV_ERROR for trying to delete a read watched fd, + that was already closed: + { + ident = 63, [fd] + filter = -1, [EVFILT_READ] + flags = 16384, [EV_ERROR] + fflags = 0, + data = 9, [errno = EBADF] + udata = 0x0 + } + */ + if (h->kq_array[r].data != EBADF) + LOG(L_INFO, "INFO: io_wait_loop_kqueue: kevent error on " + "fd %ld: %s [%ld]\n", (long)h->kq_array[r].ident, strerror(h->kq_array[r].data), (long)h->kq_array[r].data); - }else{ -#endif + }else{ fm=(struct fd_map*)h->kq_array[r].udata; if (likely(h->kq_array[r].filter==EVFILT_READ)){ - revents=POLLIN | - (((int)!(h->kq_array[r].flags & EV_EOF)-1)&POLLHUP); + revents=POLLIN | + (((int)!(h->kq_array[r].flags & EV_EOF)-1)&POLLHUP) | + (((int)!(h->kq_array[r].flags & EV_ERROR)-1)&POLLERR); while(fm->type && (fm->events & revents) && (handle_io(fm, revents, -1)>0) && repeat); }else if (h->kq_array[r].filter==EVFILT_WRITE){ - revents=POLLOUT | - (((int)!(h->kq_array[r].flags & EV_EOF)-1)&POLLHUP); + revents=POLLOUT | + (((int)!(h->kq_array[r].flags & EV_EOF)-1)&POLLHUP) | + (((int)!(h->kq_array[r].flags & EV_ERROR)-1)&POLLERR); while(fm->type && (fm->events & revents) && (handle_io(fm, revents, -1)>0) && repeat); } - /*} */ + } } error: return n;

13 years, 10 months

git:carstenbock/rtpproxy: The Timeout socket must be sent with Update after session confirmation.

by Carsten Bock

Module: sip-router Branch: carstenbock/rtpproxy Commit: d16d34b1ed18e572705f1c1a8b3113f274e618b3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d16d34b… Author: Carsten Bock <lists(a)bock.info> Committer: Carsten Bock <lists(a)bock.info> Date: Thu Aug 19 15:33:30 2010 +0200 The Timeout socket must be sent with Update after session confirmation. --- modules_k/rtpproxy/rtpproxy.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/modules_k/rtpproxy/rtpproxy.c b/modules_k/rtpproxy/rtpproxy.c index 1e26b61..e2d7e55 100644 --- a/modules_k/rtpproxy/rtpproxy.c +++ b/modules_k/rtpproxy/rtpproxy.c @@ -407,7 +407,7 @@ static param_export_t params[] = { {"rtpproxy_disable_tout", INT_PARAM, &rtpproxy_disable_tout }, {"rtpproxy_retr", INT_PARAM, &rtpproxy_retr }, {"rtpproxy_tout", INT_PARAM, &rtpproxy_tout }, - {"timeout_socket_str", STR_PARAM, &timeout_socket_str.s }, + {"timeout_socket", STR_PARAM, &timeout_socket_str.s }, {0, 0, 0} }; @@ -2173,12 +2173,12 @@ force_rtp_proxy(struct sip_msg* msg, char* str1, char* str2, int offer) } if (to_tag.len > 0) { iovec_param_count = 18; - } else { - iovec_param_count = 14; if (timeout_socket_str.len > 0) { - iovec_param_count = 16; - STR2IOVEC(timeout_socket_str, v[15]); + iovec_param_count = 20; + STR2IOVEC(timeout_socket_str, v[19]); } + } else { + iovec_param_count = 14; } cp = send_rtpp_command(node, v, iovec_param_count);

13 years, 10 months

preparing kamailio 3.0.3

by Daniel-Constantin Mierla

Hello, I am planning to release minor version 3.0.3 by beginning of next week. Please commit there what you think it needs to be fixed for this release. Thanks, Daniel -- Daniel-Constantin Mierla http://www.asipto.com/

13 years, 10 months

New commits on branch sr_3.0

by Andrei Pelinescu-Onciul

URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0451e20… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Wed Aug 18 13:45:37 2010 +0200 pdbt: fix two bugs in debian packaging (cherry picked from commit cd71125fcdb434d50f6e7b5d208d260ebc49fca6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7465ebf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Aug 12 17:14:38 2010 +0200 presence(k): copy evs_subs_handl to presence event list - patch by Nikita Kozlov, closes FS#82 (cherry picked from commit 9216a2ffa4c6ffd4bdd387530cad359f75acf0d7) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=40d2b9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 23:29:43 2010 +0200 presence_dialoginfo(k): don't exeed array size in error case - error handling could get to the size of array as index, resulting in out of bounds operation - patch by Marius-Ovidiu Bucur (cherry picked from commit 48f3159cdcc9ef06114a6d8f853687dc1338a8f0) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9cf04be… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 23:26:35 2010 +0200 presence(k): set properly db updated flag - patch by Marius-Ovidiu Bucur (cherry picked from commit b31c53abf1c3bafafb59d3fa6456135f1da6e6c9) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=264af2a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 20:25:52 2010 +0200 pua(k): use the outbound proxy on updates - patch by Alex Hermann, SF#3035780 (cherry picked from commit f39cb1976978f0860d41a05ed181e45e14c88c58) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fee4f03… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 20:15:13 2010 +0200 pv: fixed tobody.params transformation - len was wrong when having quoted parameters - patch by Alex Hermann, closes SF#3035382 (cherry picked from commit 6cc5f8ec90db48483d644430bc2628356833fc1e) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=12945f6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 20:07:45 2010 +0200 core: fix parsing quoted paramers in To header - fix off-by-one bug for quoted parameter values in parse_to - patch by Alex Hermann, SF#3035382 (cherry picked from commit 8593bc83c748835c6132eaa678064a2466316ae7) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f394c9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 30 19:40:50 2010 +0200 registrar(k): reset local contact holder - when an UA fetches the bindings for a user and the user isn't registered, properly return an empty contact. - closes SF#3035778, patch by Alex Hermann (cherry picked from commit 776d941bef2e97089493a896bf0b57607078c52d) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ef9135e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Jul 24 08:44:56 2010 +0200 sl(k): removed not needed var (cherry picked from commit 52e256540d8d2e6aa17256887fb9ff17580af3f8) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0a5bee9… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Thu Aug 5 18:17:01 2010 +0200 modules_k/dialog: Remove trailing whitespace. (cherry picked from commit 3ed75d129730ffe30fb3c1d5f8fa7870c9b5516a) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5391968… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Thu Aug 5 18:12:17 2010 +0200 modules_k/dialog: Provide new fix to prevent "unable to find dialog" WARN messages caused by accessing a dialog in the "deleted" state (often happens with simultaneous BYE requests when both UAs hang up at the same time). This commit uses a different approach where a "deleted" flag is set in get_dlg() and lookup_dlg() which callers may evaluate. Callers who only care about existing dialogs can ignore the flag by passing a NULL argument. The commit "replaces" 9b7f25d7 and follows up 0723496c. (cherry picked from commit d1693b2c64dfc44f0271bdd1c38315578ebe7135) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9e947a1… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Thu Aug 5 17:23:34 2010 +0200 modules_k/dialog: Revert "Prevent 'unable to find dialog' WARN messages caused by accessing a dialog in the "deleted" state". The approach chosen was incomplete as it requires extending checks of return values for all calls to get_dlg() and lookup_dlg() against POINTER_CLOSED_MARKER. Otherwise, it may lead to server crashes when code mistakes POINTER_CLOSED_MARKER for an existing dialog. However, having to check against two return values requires a lot of logic changes. Therefore, a better approach will be taken in a follow-up commit. This reverts commit 9b7f25d7196e41cbcc77c1d6e316cb1a8664ed81. (cherry picked from commit 0723496c037d8e22210861d6a0e9041351097f63) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=54ae4e8… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Thu Aug 5 11:31:02 2010 +0300 modules:carrierroute Better handling of fclose (cherry picked from commit b5ef768bcabf905d455ca26225c55f858cbe4c48) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=17e5609… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Thu Aug 5 11:02:14 2010 +0300 modules/carrierroute: Prevent resource leak in case of error the 2 FILE* opened in file mode where not properly closed on all code paths (cherry picked from commit 821a4322a0902b827add7913705f72d5e50176b5) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ebe2908… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Aug 2 17:26:20 2010 +0300 modules/tm: Fixed memory leak related to several tm function exports Mk_proxy() call allocates a new proxy_t* structure. The free_proxy() call does not free this structure, it frees only the content. Another pkg_free is necessary in this case. (cherry picked from commit 2ae7c6779188e053aa6d1cbd891c428ccc2b63fa) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5a5a830… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Thu Jul 29 19:09:51 2010 +0200 modules_k/sst: Setting AVPs from integer values requires the PV_TYPE_INT flag to be set. (cherry picked from commit 61c4a93486fd3d215efb8d045c7415d752d3f057) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2a15477… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Thu Jul 29 18:42:27 2010 +0200 reg(k): only store path if indicated by the configuration (cherry picked from commit 1ede271e9b669b2f335858edb47dd260f0d28ad2) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f37b2f9… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Tue Jul 27 18:51:07 2010 +0200 auth_db(k): proper initialization for the default column (cherry picked from commit 42a27402b74d44eebd702bcd5b5afa598205b520) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=997bf8f… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Tue Jul 27 14:37:06 2010 +0200 modules_k/dialog: Prevent "unable to find dialog" WARN messages caused by accessing a dialog in the "deleted" state (often happens with simultaneous BYE requests when both UAs hang up at the same time). - Move POINTER_CLOSED_MARKER from dlg_cb.c into dlg_hash.h for common usage. - in lookup_dlg() and internal_get_dlg(), return POINTER_CLOSED_MARKER when dialog is found but in the DLG_STATE_DELETED state. - in dlg_onroute(), abort request processing if dialog is found to be in the "deleted" state. (cherry picked from commit 9b7f25d7196e41cbcc77c1d6e316cb1a8664ed81) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=78f24f7… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Tue Jul 27 14:06:11 2010 +0200 modules_k/dialog: Move comment regarding dialog-destroying unreference operation to proper new location. (cherry picked from commit 191cc1d6437a252516d76c6249aa701a5b39b4e4) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9e01faf… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon Jul 26 19:02:04 2010 +0200 Revert "db_postgres(old API) FS#77: fix BLOBs with postgres" This reverts commit a6141a32738b8610c70ba7e0a88c0d79561cb7a6. (cherry picked from commit c3964dbca625de202db16ae6a4f9ea91128ccb48) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a3ba989… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Mon Jul 26 17:39:18 2010 +0300 modules_k/presence and modules_k/rls Fixed parse_to() usage In case of error parse_to returns a pointer to the last parsed character. This is not a strict error check, as several other modules provide a relaxed way of parsing To header (the uri is still parseable even if the TO headers are not). (cherry picked from commit 53c179bb3042bb767c43cd1a87a2cb8ab0ea92b7) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=10c1756… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Fri Jul 23 13:51:11 2010 +0200 dialog(k): also update README after doc change (cherry picked from commit 3fe08c96578a49fb70af11dd869de9572057afcd) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=45725d2… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Fri Jul 23 11:32:25 2010 +0300 modules_k/pv : Fixed a bug in pv transformation (tobody transformation), that caused a segmentation fault. The bug was caused by a incorrect error handling of the parse_to() method (defined in parser/parse_to.c). The function returns a char* (pointer to the last character parsed), in case of error it updates an error status. On incorrect to params, a segmentation fault happened after some time.(Because of a double pkg_free). (cherry picked from commit e7096bf24310b71623520a3b963ddc50c111827c) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e53d567… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Wed Jul 21 16:19:06 2010 +0200 modules_k/dialog (doc update): Be specific on the fact that only confirmed dialogs can be terminated by means of "dlg_end_dlg". (cherry picked from commit 03e20458bc83a8d918c2ea17c3f46a073ce7cdd8) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5fd5c35… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 16 17:22:05 2010 +0200 dispatcher: doc updated to reflect PV parameter options - ds_select_dst() can take PVs as parameters (cherry picked from commit f3d351355852c7df6582bcd7939ee3855168a60a) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6a270ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 16 17:19:48 2010 +0200 tm: use warn to print message if load_tm is not found - in case of sl trying to import tm api for stateful reply, is not an error if tm is not found - modules importing tm api print error message if the function returns error code and they need the tm (cherry picked from commit 5a25609343f5697e6ebcf8f49e589b992a8af72e) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=aa2eec1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 15 13:48:21 2010 +0200 core: print line for include_file errors - easier to localize the error, reported by Raul Alexis Betancor Santana (cherry picked from commit 2b680bde0605cbc1cb4840105fafc83a2a235ec5) (cherry picked from commit d9a4c3b4aefeb87f62b06dd2bd55f23bdb804b43) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ec91266… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 8 12:34:40 2010 +0200 tmx: use TM api function to get tm table - fix missing symbol for mode=debug, reported by Santiago Gimeno (cherry picked from commit fb39052ff574c133c74f1f0a1c8d5f43b5bc93be) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=32ad357… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 8 12:32:45 2010 +0200 tm: export function to get access to tm table - to fix missing symbol in tmx for mode=debug, reported by Santiago Gimeno (cherry picked from commit 181f81b2458ee04241b36c65ac1d95f38003250d) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=87e30e8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jul 5 10:36:58 2010 +0200 core: typos in comments (cherry picked from commit 39ac6a5c0a7833ad0c29ae7711f37b92c5c81e95) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6d6e8ee… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 2 18:21:10 2010 +0200 tm: TMCB_RESPONSE_READY executes by its own - removed the define of it to TMCB_RESPONSE_OUT - now this callback is executed before writing reply to network (cherry picked from commit f1c35c13252d3160334e9b3f56094404f06009ba) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=945fb41… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 21:03:36 2010 +0200 msilo(k): updated readme file - documented the new parameter add_contact - readme file regenerated (cherry picked from commit 9d8c55287ea9ac93440d762c511afe531c629552) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bc5707b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 20:56:23 2010 +0200 msilo(k): parameter to control contact header - add_contact parameter controls whether contact header is added to msilo generated messages - default is off (no contact added, as per RFC3428), reported by Juha Heinanen (cherry picked from commit 8ffb09ce908088af89e70a5acd87a318baf5a029) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=15d098d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 19:19:17 2010 +0200 pdb: avoid child re-init - for mi cmd when used over xmlrpc module (cherry picked from commit bc34a82fbf5bd903cc50cb34c73afb7b685603a7) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6466180… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 19:08:04 2010 +0200 presence_xml: avoid re-init of db handler - safety check for usage of xmlrpc module for mi cmds (cherry picked from commit 098deec785ab7c4e927104e83fc84b6c1b347719) (cherry picked from commit b4b903e1df57d290b2fcf3b7463b863ad402e15c) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f2e4496… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 19:07:18 2010 +0200 presence: avoid re-init of db handler - safety check for usage of xmlrpc for mi cmds (cherry picked from commit 8a1d985743fe6ec544a215b8ddb6e54adbb024d9) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c495bdf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 19:00:51 2010 +0200 kex: check if uptime value was initialized (cherry picked from commit 7537d27782b185a20d32b08f7bcb30557bb3b7ff) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=22aedb6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:57:09 2010 +0200 userblacklist: avoid double child initialization - safety check for cases when xmlrpc module is used to run mi commands (cherry picked from commit 3f2ca85f4254746240177830e85a87b81d8cfd85) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ed8cd79… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:43:54 2010 +0200 usrloc(k): avoid re-initialization of db handler - can happen if mi commands are used over rpc interface via xmlrpc module (cherry picked from commit 8948fe654b83217979b2d2154934a973aefa9ae3) (cherry picked from commit 705a61b1b9f03c11c10b266f6743124afaf40ea4) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=aa35a29… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:35:27 2010 +0200 domain(k): safety check for db handler initialization - avoid double initialization of db handler when using xmlrpc module for mi commands (cherry picked from commit c65fc04ff83c6304d5889f3426b3b96b5ac7ee69) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e8c4886… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:31:14 2010 +0200 drouting: check if db connection is initialized - applied for the case of mi reload command (cherry picked from commit 76266ca085d05be949ddc34df513de6810c5d65f) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=deedf6f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:22:15 2010 +0200 htable: close db connection in case of mi cmd errors - in some error cases while processing mi reload command, db connection was left open (cherry picked from commit e723b2b24a87599d538b652ee60c862f769f8036) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=595d71f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:15:33 2010 +0200 pdt(k): safety check for db handler initialization - there can be two attepts to initialize if xmlrpc module is loaded (cherry picked from commit 2e8d469de4253444d61cb186395d40c0fd492fe6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dafd395… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 18:13:54 2010 +0200 mi_rpc: initialize mi cmds for sip workers - xmlrpc module re-uses sip workers to process xmlrpc request which can execute mi commands, therefore is need to initialize mi cmds as for a mi process - initialization is done only when xmlrpc module is loaded (cherry picked from commit b2b2a82d497ee37428abab933f4862255bc5c4a1) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1bd3fa9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 17:40:20 2010 +0200 permissions(k): safety check for db_handle - avoid double initialization of trusted ops db handler (cherry picked from commit df2d92a1f0698e0d108ec080de5fc3673d332209) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1bb2261… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 12:10:34 2010 +0200 permissions(k): reverted incomplete fix for mi cmd - the mi command execution via rpc is fixed by initialization of mi commands done now by mi_rpc module (cherry picked from commit a92bb2ee265c6d7f44d3fe848725b458c441b207) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=44c8572… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 12:08:42 2010 +0200 mi_rpc: call MI init child functions - MI init child functions called for RPC processes - fix for several MI commands that can be executed now via RPC and they needed to do specific initialization for each process - reported by Juha Heinanen (cherry picked from commit af18dae034cf8836f1627929f189983ca6010428) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fd74c78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 1 12:04:52 2010 +0200 kmi: allow multiple initializations of mi child - safety check to detect if mi child was initialized - protect against multiple initializations that can occure due to usage from MI or RPC processes (cherry picked from commit 4047fc33053898d17498104b849dae9e45bee1e6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7bfcbcb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Jun 29 19:48:59 2010 +0200 core: safety check for free contact - patch by Sebastian Z., checking if the content is null before freeing it (cherry picked from commit 7aed7d72c98a8228e9687773c3bab20d8934251a) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=33b02f1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Jun 1 23:02:14 2010 +0200 presence_xml: fixed log message (cherry picked from commit 134edd5fcdfffcf18299f0673a1ecb65bd8b3241) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=47c0f96… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Mon Jun 28 10:50:05 2010 +0200 modules_k/dialog: Delay dialog deletion to absorb late in-dialog requests - When a dialog's state transitions to DLG_STATE_DELETED, register a tm callback for TMCB_DESTROY to absorb late in-dialog requests (no more "unable to find dialog for <REQUEST TYPE>" log messages). - On callback, unreference and, in consequence, destroy the dialog. (cherry picked from commit 3537c2d8c27617023cb9f9a569435483748fef1f) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9a223c7… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Mon Jul 5 17:52:12 2010 +0200 Increase failed_dlgs when a non-2xx final response has been received only. (cherry picked from commit dd9681ce5f6602c888d847a283eaaf637318994d) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9a650c5… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Tue Jul 13 14:46:54 2010 +0200 Fix minor typo (cherry picked from commit d4c63b7f3e7be5a2a86c929d013f19d6c8cbb4eb) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=565b659… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Tue Jul 13 13:21:40 2010 +0200 modules/dialog: Do not send BYE request for non-confirmed dialogs (not supported). (cherry picked from commit 4a84c8c410ce45d9e5443eb52ac4c79e47ab5f3c) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c780337… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Wed Jul 7 12:39:58 2010 +0300 Fixed a memory leak on shm memory, caused by the dtrie implementation. dtrie_destroy and dtrie_clear could leak 10 * sizeof(void*) for each node in the trie. Mainly affected carrierroute and userblacklist modules (cherry picked from commit 5c5cc3df5301e86ee78d79f52aa917e0f67f37e8) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=893d9fa… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Wed Jun 30 18:25:55 2010 +0200 Do not consider in-early-dialog BYE requests to be bogus. (cherry picked from commit 8bf53ec54beab825794b8345cce7fdb41c783809) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=62e4a6b… Author: Juha Heinanen <jh(a)tutpro.com> Date: Wed Jun 30 17:15:37 2010 +0300 modules_k/msilo: do not include Contact header in msilo generated messages (cherry picked from commit 37940ea09b861b18994c4243abf8c6d8e711a2ef) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=481cdc8… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Tue Jun 29 18:11:58 2010 +0200 db_postgres(old API) FS#77: fix BLOBs with postgres fix BLOBs with postgres, also add a null-termination as the other SQL databases in order to be able to work with the presence modules (cherry picked from commit 2e56720769913c55cacc83fe3a31f44f072e7590) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3013511… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Tue Jun 29 12:26:30 2010 +0200 auc(k): fix error in authentification: Digest should be compared case insensitive (cherry picked from commit 3f5909fd3ca55aa43148d81a8874eaeaeaf91968) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=82931de… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Thu Jun 24 18:39:49 2010 +0200 modules_k/dialog: Fix timer reset and improve timeout value logging - Fix a bug that caused dialog timeout values to be refreshed only when a custom timeout was provided by the user via AVP. - Do not log failure to get timeout from AVP when in fact no AVP was used. - Add missing newline character. (cherry picked from commit 3d1d941dde7a2b4a764dcfc9939501e5ddf83f04) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=af3586d… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Thu Jun 24 15:50:52 2010 +0200 Correct typo in comment referring to other file. (cherry picked from commit 927351a2c4bd222db8a58b877a5fb018fdce2d00) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=43331dc… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Thu Jun 24 15:01:13 2010 +0200 modules_k/dialog: Reduce log verbosity for list traversal of expired dialogs. - Change logging of start/previous/next pointers from WARN to DBG when traversing the list of expired dialogs. (cherry picked from commit a5f03adcad92993e170be1d2a5dbb879b4777347) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9208ca4… Author: Timo Reimann <timo.reimann(a)1und1.de> Date: Wed Jun 23 15:39:21 2010 +0200 Do not consider in-early-dialog requests to be bogus. (cherry picked from commit cbbc5eff256565a3eae29a9353bbb4e3064640bb) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6d82a1f… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Wed Jun 16 14:11:48 2010 +0300 Always set data payload to NULL, thus avoiding problems when root node had data associated with it Credits for the patch go to Henning Westerholt. (cherry picked from commit f05a578613ca1c9cc15e27cc01c5573e1cf0b888) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fe5f4eb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun May 30 11:03:22 2010 +0200 db_berkeley: get rid of compile warnings (cherry picked from commit 8b506f7d9b8eba682d180e458b0e2a278053d29a) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4e491cc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun May 30 11:34:47 2010 +0200 srdb1: updated entities.xml path in db schema (cherry picked from commit 387e7ec22e736d1ce51f5c12d9f4e8533ead8512) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=11064eb… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Sun Jun 6 13:26:31 2010 +0200 *PKG Debian - Mantainer header changed to $me (cherry picked from commit 3224810f6fc75b0f7a498e8bfe3947c0e05bc98f) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=019bd70… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Wed Jun 2 00:49:56 2010 +0200 PKG Debian: More version support - debian-squeeze added. Purple excluded from the compile list. Seems that purple module does not work with libpurple 2.7+ - ubuntu-lucid added Universe has to be enabled in sources.list for radius and memcached module dependency matching (cherry picked from commit 64db1af36c67e7ecb5bc3451f94a11b69edc1fa6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1fa239a… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Tue Jun 1 23:31:14 2010 +0200 PKG Debian version dependant changes - debian-lenny is erased and symlinks now to debian - debian-etch is recreated from debian. This provides consistency to all debian* folders - Berkeley and purple modules excluded in debian-etch to avoid dependency problems (cherry picked from commit aa2526dce7e5fcade57f577de5d701c990705cee) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f3bf155… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Sat May 29 22:13:26 2010 +0200 pkg Changes to debian/control - Dependency changes to match lenny and squeeze at least. This will allow to drop debian-lenny folder in the future. - Added "Replaces" to kamailio-*-modules since the name of the modules has changed since kamailio-1.5 and the upgrade would not work properly. - VCS lines erased since the pointed to wrong URLs and we do not have a 3.0.2 tag to point. - Added "Conflicts" to erase old packages that do not exist in this version and could cause upgrade not to work properly. (cherry picked from commit e0eeace9b3c0c90d390bba63dee6d161c3f34d40) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=80a1c90… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Fri May 28 22:27:42 2010 +0200 pkg: update debian changelog version for kamailio - Updated kamailio version to 3.0.2.99. This will allow development builds to update the stable branch and will be clear that it's an unreleased version. This will change just before releasing 3.0.3 and then change again to 3.0.3.99 (cherry picked from commit 754e46dd87756c0aef7046c143ff090d76299159) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7197863… Author: Jon Bonilla <manwe(a)aholab.ehu.es> Date: Fri May 28 21:44:39 2010 +0200 pkg: Update debian changelog files - Update kamailio version to 3.0.2 for debian-etch and debian-lenny builds. (cherry picked from commit db3dc3f305409ad34dcf985c5dc63bddd4dd9e1b) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=86cf155… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu May 27 10:29:24 2010 +0200 centos spec: version set to 3.0.2 (cherry picked from commit e5560029f04058642bebb09a1a1b7df699c5f80b) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f863e0b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu May 27 10:28:16 2010 +0200 debian: updated changelog for 3.0.2 (cherry picked from commit a2dbcec4278631ec78944098e7b407cebd682e92) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=58783eb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Apr 15 11:20:52 2010 +0200 pkg(k): extended rules for mysql depends - closes FS#65, reported by Jon Bonilla (cherry picked from commit edfbfab6590381872dbd0f9ea89b496cb1c911d6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ab87fe7… Author: Ovidiu Sas <osas(a)voipembedded.com> Date: Wed Mar 31 14:05:51 2010 -0400 pkg: updated kamailio spec file for CentOS - updated kamailio spec file for CentOS along with default and init scripts. (cherry picked from commit 0acd8963f76a4854e101210db17854ca8062ff61) (cherry picked from commit 48015a8e471ecadfb571fa94daa7300992fe6674) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0e84b2a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Mar 8 23:12:39 2010 +0100 - changelog updated (cherry picked from commit 679736aed2719cacbc328cf4561b6e2562feb9fb) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c86c624… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jan 11 18:37:10 2010 +0100 pkg: set version to 3.0.0 in debian changelog (cherry picked from commit 6d1e9f74d658942a0a5714ae452a6231e5f831e6)

13 years, 10 months

git:carstenbock/rtpproxy: Tiny typo.

by Carsten Bock

Module: sip-router Branch: carstenbock/rtpproxy Commit: 449cde48834574b069d930842d406ac709083654 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=449cde4… Author: Carsten Bock <lists(a)bock.info> Committer: Carsten Bock <lists(a)bock.info> Date: Wed Aug 18 22:57:37 2010 +0200 Tiny typo. --- modules_k/rtpproxy/rtpproxy.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/rtpproxy/rtpproxy.c b/modules_k/rtpproxy/rtpproxy.c index 732369e..1e26b61 100644 --- a/modules_k/rtpproxy/rtpproxy.c +++ b/modules_k/rtpproxy/rtpproxy.c @@ -1814,7 +1814,7 @@ force_rtp_proxy(struct sip_msg* msg, char* str1, char* str2, int offer) {" ", 1}, /* separator */ {NULL, 0}, /* to_tag */ {";", 1}, /* separator */ - {NULL, 0} /* medianum */ + {NULL, 0}, /* medianum */ {" ", 1}, /* separator */ {NULL, 0}, /* Timeout-Socket */ };

13 years, 10 months

git:carstenbock/rtpproxy: Merge branch 'master' into rtpproxy

by Carsten Bock

Module: sip-router Branch: carstenbock/rtpproxy Commit: fdebd2b7a11dfb31d243b433f8fc5a389b6167a8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fdebd2b… Author: Carsten Bock <lists(a)bock.info> Committer: Carsten Bock <lists(a)bock.info> Date: Wed Aug 18 22:44:53 2010 +0200 Merge branch 'master' into rtpproxy * master: modules*: add k stats. includes where needed kstats: cleanup - move type defs. to separate file modules_k/*: add missing lib/kmi/mi.h include mi: cleanup - move type defs. to separate file ---

13 years, 10 months

← Newer
1
...
12
13
14
15
16
17
18
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2010