sr-dev May 2010

sr-dev@lists.kamailio.org

18 participants
140 discussions

[tracker] Task opened: DB_DELETED flag is not checked in www_authenticate function of auth module
by sip-router 06 May '10

06 May '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Karel Kozlik (karel) Attached to Project - sip-router Summary - DB_DELETED flag is not checked in www_authenticate function of auth module Task Type - Bug Report Category - Modules ser Status - Assigned Assigned To - Jan Janak Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - www_authenticate function does not check that DB_DELETED (0x80) flag is not set during authentification. DB_DELETED flag was originaly introduced to allow undelete user accounts from serweb. Bellow are records from credentials table for one user of the iptel.org service. SER probably matches the first records althought it is marked as "deleted" in the flags column. The third record should be the correct one. <code> mysql> select * from credentials where auth_username="alfredo" and realm="pironti.eu"; +---------------+------------+----------+-------+----------------------------------+----------------------------------+--------------------------------------+--------------------------------------+ | auth_username | realm | password | flags | ha1 | ha1b | uid | did | +---------------+------------+----------+-------+----------------------------------+----------------------------------+--------------------------------------+--------------------------------------+ | alfredo | pironti.eu | xxxxxxx | 161 | a930bf80e205557d7c4e5befd0a653b4 | e61384ab574c33726de666d5812c327e | 1f6b1cee-b33d-ae69-12b4-00005980d2c3 | 60dfb669-6f42-66a9-db3a-00000cd77eb8 | | alfredo | pironti.eu | xxxxxxx | 161 | bdd93ccc42635bd249c77d21d558f8d8 | 31d0fafb66bdb6d2fdd7768db4a56871 | 097c64dc-b14b-bca9-9b42-0000640d5c1e | 6a74351b-ae9f-aac9-a283-00007c6ea1ef | | alfredo | pironti.eu | xxxxxxx | 33 | bdd93ccc42635bd249c77d21d558f8d8 | 31d0fafb66bdb6d2fdd7768db4a56871 | 6944740b-143e-ea48-da9e-0000523ba8a5 | 72076238-4c73-ae28-9ac2-000018c9e3a8 | +---------------+------------+----------+-------+----------------------------------+----------------------------------+--------------------------------------+--------------------------------------+ 3 rows in set (0.00 sec) </code> bug is also reported in iptel.org sip-service bugtracker: https://bugtracker.iptel.org/view.php?id=38 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=71 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Assignee added: DB_DELETED flag is not checked in www_authenticate function of auth module
by sip-router 06 May '10

06 May '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#71 - DB_DELETED flag is not checked in www_authenticate function of auth module User who did this - Karel Kozlik (karel) http://sip-router.org/tracker/index.php?do=details&task_id=71 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

SF.net SVN: openser:[6004] branches/1.5/modules/carrierroute/cr_func.c
by Marius Zbihlei 06 May '10

06 May '10

Revision: 6004 http://openser.svn.sourceforge.net/openser/?rev=6004&view=rev Author: mariuszbihlei Date: 2010-05-06 12:42:15 +0000 (Thu, 06 May 2010) Log Message: ----------- Fixed a bug in carrirroute module that might cause a crash if the routing prob was larger than the number of available routes.(backported from git) Modified Paths: -------------- branches/1.5/modules/carrierroute/cr_func.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

route names
by Juha Heinanen 05 May '10

05 May '10

i tried to define route route [+358] { ... } but got syntax error. is there a good reason why + is not allowed in name of route? -- juha

4 7

git:kamailio_3.0: core: cfg parser: allow negative numbers in modparams
by Daniel-Constantin Mierla 05 May '10

05 May '10

Module: sip-router Branch: kamailio_3.0 Commit: befd91050bf16c725076f31f71d8c083aaf482e7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=befd910… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Mar 19 14:47:46 2010 +0100 core: cfg parser: allow negative numbers in modparams (cherry picked from commit d4b2eee2e4f0e5a1fe4b5ea17d78d51a6fab70c7) --- cfg.y | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cfg.y b/cfg.y index 60ce707..7492b7e 100644 --- a/cfg.y +++ b/cfg.y @@ -1604,7 +1604,7 @@ module_stm: yyerror("Can't set module parameter"); } } - | MODPARAM LPAREN STRING COMMA STRING COMMA NUMBER RPAREN { + | MODPARAM LPAREN STRING COMMA STRING COMMA intno RPAREN { #ifdef SHM_MEM if (!shm_initialized() && init_shm()<0) { yyerror("Can't initialize shared memory");

1 0

git:kamailio_3.0: core:sr_module. c increased number of pre-allocated static buffers in get_str_fparam()
by Marius Zbihlei 04 May '10

04 May '10

Module: sip-router Branch: kamailio_3.0 Commit: 4fd1e775f701d79d1d7f5e75bd7ff621739914b5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4fd1e77… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Tue May 4 17:06:47 2010 +0300 core:sr_module.c increased number of pre-allocated static buffers in get_str_fparam() Increased the number from 3 to 6 as more are needed by modules like carrierroute when avp's are used as function parameters (Bug reported by Ole Kaas) --- sr_module.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sr_module.c b/sr_module.c index d5dc322..351d7fa 100644 --- a/sr_module.c +++ b/sr_module.c @@ -1415,7 +1415,7 @@ int fixup_str_2(void** param, int param_no) #define PV_PRINT_BUF_SIZE 1024 -#define PV_PRINT_BUF_NO 3 +#define PV_PRINT_BUF_NO 6 /** Get the function parameter value as string. * @return 0 - Success * -1 - Cannot get value

1 0

git:master: core:sr_module. c increased number of pre-allocated static buffers in get_str_fparam()
by Marius Zbihlei 04 May '10

04 May '10

Module: sip-router Branch: master Commit: 5fe218c1ba48eeb4f1cecc0e26c4545972bc10a2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5fe218c… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Tue May 4 17:06:47 2010 +0300 core:sr_module.c increased number of pre-allocated static buffers in get_str_fparam() Increased the number from 3 to 6 as more are needed by modules like carrierroute when avp's are used as function parameters (Bug reported by Ole Kaas) --- sr_module.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sr_module.c b/sr_module.c index dabbda9..23f014f 100644 --- a/sr_module.c +++ b/sr_module.c @@ -1419,7 +1419,7 @@ int fixup_str_2(void** param, int param_no) #define PV_PRINT_BUF_SIZE 1024 -#define PV_PRINT_BUF_NO 3 +#define PV_PRINT_BUF_NO 6 /** Get the function parameter value as string. * @return 0 - Success * -1 - Cannot get value

1 0

git:master: mtree: fixed len check for dbtable attribute
by Daniel-Constantin Mierla 04 May '10

04 May '10

Module: sip-router Branch: master Commit: 5783e4dd98313f8a617cc1a0562ddba94be05904 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5783e4d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue May 4 14:19:06 2010 +0200 mtree: fixed len check for dbtable attribute --- modules/mtree/mtree.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/mtree/mtree.c b/modules/mtree/mtree.c index 54f82da..51d355a 100644 --- a/modules/mtree/mtree.c +++ b/modules/mtree/mtree.c @@ -624,7 +624,7 @@ int mt_table_spec(char* val) } else if(pit->name.len==4 && strncasecmp(pit->name.s, "type", 4)==0) { str2sint(&pit->body, &tmp.type); - } else if(pit->name.len==8 + } else if(pit->name.len==7 && strncasecmp(pit->name.s, "dbtable", 7)==0) { tmp.dbtable = pit->body; }

1 0

git:master: Modules:carrierroute: Fixed a bug in carrirroute module that might cause a crash if the routing prob was larger than the number of available routes .
by Marius Zbihlei 04 May '10

04 May '10

Module: sip-router Branch: master Commit: 2095981e8bc7f25c39099c72468b61cf9a5dca59 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2095981… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Tue May 4 13:10:03 2010 +0300 Modules:carrierroute: Fixed a bug in carrirroute module that might cause a crash if the routing prob was larger than the number of available routes. The problem was caused by a missing else --- modules/carrierroute/cr_func.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/carrierroute/cr_func.c b/modules/carrierroute/cr_func.c index a09866c..382df16 100644 --- a/modules/carrierroute/cr_func.c +++ b/modules/carrierroute/cr_func.c @@ -249,7 +249,7 @@ static struct route_rule * get_rule_by_hash(const struct route_flags * rf, LM_WARN("too large desired hash, taking highest\n"); act_hash = rf->rules[rf->rule_num - 1]; } - act_hash = rf->rules[prob - 1]; + else act_hash = rf->rules[prob - 1]; if (!act_hash->status) { if (act_hash->backup && act_hash->backup->rr) {

1 0

Problem with number of buffers in get_str_fparam()
by marius zbihlei 04 May '10

04 May '10

Hello The function get_str_fparam() returns a pointer to one of the 3 allocated static buffers. This might cause some havoc (especially in carrierroute module - bug reported by Ole Kass on sr-users list). I plan to increase the number of buffers from 3 to 6. (each buffers is 1 kB in size). If everybody is OK with this, I would like to commit to master and kamailio_3.0 (I consider this a bug) this afternoon... Cheers Marius

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2010