sr-dev July 2009

sr-dev@lists.kamailio.org

35 participants
328 discussions

[ openser-Bugs-2819457 ] dialog module. BYE with bad Cseq.

by SourceForge.net

Bugs item #2819457, was opened at 2009-07-10 10:47 Message generated for change (Comment added) made by baron76 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandr Dubovikov (baron76) Assigned to: Nobody/Anonymous (nobody) Summary: dialog module. BYE with bad Cseq. Initial Comment: the dialog module in timeout BYE request send thru tm_module Cseq number from INVITE. dlg_req_within.c: function: dlg_t * build_dlg_t(struct dlg_cell * cell, int dir){ line: td->loc_seq.value = loc_seq; if before final 200 OK, we will recieve PRACK/200 (new Cseq) , the dialog module will send bad Cseq number (loc_seq + 1); Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3) - ---------- timeout ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- Quickly Solution: td->loc_seq.value = loc_seq + 100; ---------------------------------------------------------------------- >Comment By: Alexandr Dubovikov (baron76) Date: 2009-07-10 10:50 Message: oops: Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3 PRACK) - <---- 200 OK ( Cseq: 1 INVITE) - ---------- timeout dialog ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_…

15 years, 6 months

[ openser-Bugs-2819457 ] dialog module. BYE with bad Cseq.

by SourceForge.net

Bugs item #2819457, was opened at 2009-07-10 10:47 Message generated for change (Tracker Item Submitted) made by baron76 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexandr Dubovikov (baron76) Assigned to: Nobody/Anonymous (nobody) Summary: dialog module. BYE with bad Cseq. Initial Comment: the dialog module in timeout BYE request send thru tm_module Cseq number from INVITE. dlg_req_within.c: function: dlg_t * build_dlg_t(struct dlg_cell * cell, int dir){ line: td->loc_seq.value = loc_seq; if before final 200 OK, we will recieve PRACK/200 (new Cseq) , the dialog module will send bad Cseq number (loc_seq + 1); Scenario: ----INVITE ( Cseq: 1) -> <--- 183 ( Cseq: 1) ---- ---- PRACK ( Cseq: 3) -> <---- 200 OK ( Cseq: 3) - ---------- timeout ----> ---- BYE ( Cseq: 2) -> <------ 503 (Bad CSeq number) ------- Quickly Solution: td->loc_seq.value = loc_seq + 100; ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2819457&group_…

15 years, 6 months

git:master: tm: enabbled TMCB_ONSEND

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: bce53e2a14c07203e5914fdb41ca887765a28799 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bce53e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 10 00:17:54 2009 +0200 tm: enabbled TMCB_ONSEND - used by siptrace module --- modules/tm/t_hooks.h | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/modules/tm/t_hooks.h b/modules/tm/t_hooks.h index 998ace1..d593a67 100644 --- a/modules/tm/t_hooks.h +++ b/modules/tm/t_hooks.h @@ -48,9 +48,7 @@ /* if defined support for ONSEND callbacks will be added and * the tmcb_params structure will get some additional members */ -/* #define TMCB_ONSEND -*/ #ifdef TMCB_ONSEND #include "../../ip_addr.h" /* dest_info */ #endif

15 years, 6 months

git:master: siptrace: removed trailing whitespaces

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: cd0ce113e857289f2b0e964a43abfa57ac3be707 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd0ce11… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 10 00:23:58 2009 +0200 siptrace: removed trailing whitespaces - makes git happy, avoiding warning messages --- modules_k/siptrace/siptrace.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules_k/siptrace/siptrace.c b/modules_k/siptrace/siptrace.c index cfd5245..a9044b8 100644 --- a/modules_k/siptrace/siptrace.c +++ b/modules_k/siptrace/siptrace.c @@ -1097,8 +1097,8 @@ static struct mi_root* sip_trace_mi(struct mi_root* cmd_tree, void* param ) *trace_on_flag = 1; return init_mi_tree( 200, MI_SSTR(MI_OK)); } else if ( node->value.len==3 && (node->value.s[0]=='o' - || node->value.s[0]=='O') - && (node->value.s[1]=='f'|| node->value.s[1]=='F') + || node->value.s[0]=='O') + && (node->value.s[1]=='f'|| node->value.s[1]=='F') && (node->value.s[2]=='f'|| node->value.s[2]=='F')) { *trace_on_flag = 0; return init_mi_tree( 200, MI_SSTR(MI_OK));

15 years, 6 months

git:master: siptrace: module facelift

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 94393b2da7e7922458653d8fa7f413a673383de1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=94393b2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jul 10 00:18:42 2009 +0200 siptrace: module facelift - better structured traced data - more modularity to avoid duplicity --- modules_k/siptrace/siptrace.c | 1079 +++++++++++++++-------------------------- 1 files changed, 403 insertions(+), 676 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=943…

15 years, 6 months

git:master: debian: various fixes and cleanups

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 53413e1f7ba0388fcaf7b2ed24e25067785f16ed URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=53413e1… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Jul 9 21:51:03 2009 +0200 debian: various fixes and cleanups - fixed duplicate libraries - fixed wrong config install path - added a ser-db-modules package containing db dependent modules - debian rules major cleanup --- pkg/debian/changelog | 10 ++++ pkg/debian/control | 29 +++++++---- pkg/debian/rules | 131 +++++++++++++++++++++++++++++++++----------------- 3 files changed, 114 insertions(+), 56 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=534…

15 years, 6 months

git:master: makefile: fix group_include

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 2af7504fe4be356b59a53f7cb65311f433d107f3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2af7504… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Jul 9 21:47:26 2009 +0200 makefile: fix group_include fix recently introduced group_include bug --- Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1dcdb85..581a907 100644 --- a/Makefile +++ b/Makefile @@ -222,8 +222,8 @@ override exclude_modules+= CVS $(skip_modules) # Test for the groups and add to include_modules ifneq (,$(group_include)) -override include_modules+=$(foreach grp, $(group_include), \ - $(module_group_$(grp)) ) +$(eval override include_modules+= $(foreach grp, $(group_include), \ + $(module_group_$(grp)) )) endif # first 2 lines are excluded because of the experimental or incomplete

15 years, 6 months

git:master: siptrace(k): some updates to work with sip-router core

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: de9ef971f95fbc086eb68be63864934ae8d608b2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=de9ef97… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 9 19:05:16 2009 +0200 siptrace(k): some updates to work with sip-router core - module not completely ready - prepared to enable sip_trace() in onsend route to be able to store stateless forwarded messages --- modules_k/siptrace/siptrace.c | 191 +++++++++++++++++++---------------------- 1 files changed, 89 insertions(+), 102 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=de9…

15 years, 6 months

git:master: nat_traversal(k): module compiles with sip-router core

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: d908ca84a6a6d0216ae53486f71221a21cfd53ae URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d908ca8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 9 17:18:13 2009 +0200 nat_traversal(k): module compiles with sip-router core --- modules_k/nat_traversal/nat_traversal.c | 41 ++++++++++++++++++++++--------- 1 files changed, 29 insertions(+), 12 deletions(-) diff --git a/modules_k/nat_traversal/nat_traversal.c b/modules_k/nat_traversal/nat_traversal.c index 26aa93c..119c592 100644 --- a/modules_k/nat_traversal/nat_traversal.c +++ b/modules_k/nat_traversal/nat_traversal.c @@ -43,6 +43,7 @@ #include "../../data_lump.h" #include "../../mod_fix.h" #include "../../script_cb.h" +#include "../../timer_proc.h" #include "../../parser/msg_parser.h" #include "../../parser/parse_from.h" #include "../../parser/parse_uri.h" @@ -185,6 +186,7 @@ static Bool test_private_via(struct sip_msg *msg); static INLINE char* shm_strdup(char *source); static int mod_init(void); +static int child_init(int rank); static void mod_destroy(void); static int preprocess_request(struct sip_msg *msg, unsigned int flags, void *param); static int reply_filter(struct sip_msg *reply); @@ -275,7 +277,7 @@ struct module_exports exports = { mod_init, // module init function (before fork. kids will inherit) reply_filter, // reply processing function mod_destroy, // destroy function - 0 // child init function + child_init // child init function }; @@ -1496,7 +1498,7 @@ send_keepalive(NAT_Contact *contact) static char *from_ip = from + sizeof(FROM_PREFIX) - 1; static struct socket_info *last_socket = NULL; struct hostent* hostent; - union sockaddr_union to; + struct dest_info dst; int nat_port, len; str nat_ip; @@ -1537,14 +1539,17 @@ send_keepalive(NAT_Contact *contact) return; } + init_dest_info(&dst); //nat_ip.s = strchr(contact->uri, ':') + 1; nat_ip.s = &contact->uri[4]; // skip over "sip:" ptr = strchr(nat_ip.s, ':'); nat_ip.len = ptr - nat_ip.s; nat_port = strtol(ptr+1, NULL, 10); - hostent = sip_resolvehost(&nat_ip, NULL, NULL, False, NULL); - hostent2su(&to, hostent, 0, nat_port); - udp_send(contact->socket, buffer, len, &to); + hostent = sip_resolvehost(&nat_ip, NULL, NULL); + hostent2su(&dst.to, hostent, 0, nat_port); + dst.proto=PROTO_UDP; + dst.send_sock=contact->socket; + udp_send(&dst, buffer, len); } @@ -1665,7 +1670,7 @@ restore_keepalive_state(void) if (now > rtime && now > stime) continue; // expired entry - if (parse_phostport(socket, strlen(socket), &host.s, &host.len, &port, &proto) < 0) + if (parse_phostport(socket, &host.s, &host.len, &port, &proto) < 0) continue; sock = grep_sock_info(&host, (unsigned short)port, (unsigned short)proto); @@ -1698,6 +1703,7 @@ mod_init(void) { register_slcb_t register_sl_callback; int *param; + modparam_t type; if (keepalive_interval <= 0) { LM_NOTICE("keepalive functionality is disabled from the configuration\n"); @@ -1727,14 +1733,16 @@ mod_init(void) have_dlg_api = True; // load dlg_flag and default_timeout parameters from the dialog module - param = find_param_export("dialog", "dlg_flag", INT_PARAM); + param = find_param_export(find_module_by_name("dialog"), + "dlg_flag", INT_PARAM, &type); if (!param) { LM_ERR("cannot find dlg_flag parameter in the dialog module\n"); return -1; } dialog_flag = *param; - param = find_param_export("dialog", "default_timeout", INT_PARAM); + param = find_param_export(find_module_by_name("dialog"), + "default_timeout", INT_PARAM, &type); if (!param) { LM_ERR("cannot find default_timeout parameter in the dialog module\n"); return -1; @@ -1788,14 +1796,23 @@ mod_init(void) LM_NOTICE("using 10 seconds for keepalive_interval\n"); keepalive_interval = 10; } - if (register_timer_process(keepalive_timer, NULL, 1, TIMER_PROC_INIT_FLAG) < 0) { - LM_ERR("failed to register keepalive timer process\n"); - return -1; - } + register_procs(1); return 0; } +static int +child_init(int rank) +{ + if (rank==PROC_MAIN) { + if(fork_dummy_timer(PROC_TIMER, "TIMER NT", 1 /*socks flag*/, + keepalive_timer, NULL, 1 /*sec*/)<0) { + LM_ERR("failed to register keepalive timer process\n"); + return -1; + } + } + return 0; +} static void mod_destroy(void)

15 years, 6 months

git:master: core: temporary sip_msg flags reserved for K moved to end of bitmask

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 8d26ed40d5646b410928ce44d85201a6b57a5ebb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8d26ed4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 9 16:47:49 2009 +0200 core: temporary sip_msg flags reserved for K moved to end of bitmask - respective modules updated --- modules/mediaproxy/mediaproxy.c | 2 +- modules_k/acc/acc.h | 2 +- modules_k/nat_traversal/nat_traversal.c | 3 +++ parser/msg_parser.h | 7 +++++-- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/modules/mediaproxy/mediaproxy.c b/modules/mediaproxy/mediaproxy.c index 37e0353..acedf5b 100644 --- a/modules/mediaproxy/mediaproxy.c +++ b/modules/mediaproxy/mediaproxy.c @@ -60,7 +60,7 @@ MODULE_VERSION #endif /* WARNING: Keep this aligned with parser/msg_parser.h! */ -#define FL_USE_MEDIA_PROXY (1<<12) +#define FL_USE_MEDIA_PROXY (1<<30) #define SIGNALING_IP_AVP_SPEC "$avp(s:signaling_ip)" #define MEDIA_RELAY_AVP_SPEC "$avp(s:media_relay)" diff --git a/modules_k/acc/acc.h b/modules_k/acc/acc.h index 576de17..e03dad4 100644 --- a/modules_k/acc/acc.h +++ b/modules_k/acc/acc.h @@ -79,7 +79,7 @@ * projects. The value of the flag must be kept synchronized with other flags * defined in parser/msg_parser.h! */ -#define FL_REQ_UPSTREAM (1<<11) +#define FL_REQ_UPSTREAM (1<<29) void acc_log_init(void); int acc_log_request( struct sip_msg *req); diff --git a/modules_k/nat_traversal/nat_traversal.c b/modules_k/nat_traversal/nat_traversal.c index d2b3d05..26aa93c 100644 --- a/modules_k/nat_traversal/nat_traversal.c +++ b/modules_k/nat_traversal/nat_traversal.c @@ -63,6 +63,9 @@ MODULE_VERSION #endif +/* WARNING: Keep this aligned with parser/msg_parser.h! */ +#define FL_DO_KEEPALIVE (1<<31) + #define HASH_SIZE 512 diff --git a/parser/msg_parser.h b/parser/msg_parser.h index ece6b18..a811b61 100644 --- a/parser/msg_parser.h +++ b/parser/msg_parser.h @@ -110,12 +110,15 @@ enum request_method { #define FL_MTU_TLS_FB (1 << 9) #define FL_MTU_SCTP_FB (1 << 10) -/* WARNING: Value (1 << 11) is temporarily reserved for use in kamailio acc +/* WARNING: Value (1 << 29) is temporarily reserved for use in kamailio acc * module (flag FL_REQ_UPSTREAM)! */ -/* WARNING: Value (1 << 12) is temporarily reserved for use in kamailio +/* WARNING: Value (1 << 30) is temporarily reserved for use in kamailio * media proxy module (flag FL_USE_MEDIA_PROXY)! */ +/* WARNING: Value (1 << 31) is temporarily reserved for use in kamailio + * nat_traversal module (flag FL_DO_KEEPALIVE)! */ + #define FL_MTU_FB_MASK (FL_MTU_TCP_FB|FL_MTU_TLS_FB|FL_MTU_SCTP_FB)

15 years, 6 months

← Newer
1
...
16
17
18
19
20
21
22
...
33
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2009