sr-dev June 2009

sr-dev@lists.kamailio.org

33 participants
284 discussions

[ openser-Bugs-2813924 ] nathelper crash
by SourceForge.net 30 Jun '09

30 Jun '09

Bugs item #2813924, was opened at 2009-06-29 14:55 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2813924&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Marcus Hunger (marcushunger) Assigned to: Nobody/Anonymous (nobody) Summary: nathelper crash Initial Comment: publishing very long payload-type to the rtp-proxy overflows a buffer. see nathelper.c +2758. v[1].iov_len must be smaller than sizeof(opts) ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-06-30 12:06 Message: Did you meant '&&' operator instead of ',' in for condition? Otherwise: warning: left-hand operand of comma expression has no effect ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2813924&group_…

1 0

SF.net SVN: openser:[5884] branches/1.5/modules/nathelper/nhelpr_funcs.c
by Daniel-Constantin Mierla 30 Jun '09

30 Jun '09

Revision: 5884 http://openser.svn.sourceforge.net/openser/?rev=5884&view=rev Author: miconda Date: 2009-06-30 08:51:22 +0000 (Tue, 30 Jun 2009) Log Message: ----------- - fixed support for multipart body - use some sdp parser helper functions - credits to Pascal Maugeri for testing Modified Paths: -------------- branches/1.5/modules/nathelper/nhelpr_funcs.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

build problems in ser's TLS module
by Klaus Darilion 29 Jun '09

29 Jun '09

make[1]: Entering directory `/home/darilion/software/siprouter/sip-router/modules_s/tls' gcc -fPIC -DPIC -g -O9 -funroll-loops -Wcast-align -minline-all-stringops -falign-loops -ftree-vectorize -mtune=athlon64 -Wall -DNAME='"ser"' -DVERSION='"2.99.0-dev01-serk"' -DARCH='"i386"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 4.3.2"' -D__CPU_i386 -D__OS_linux -DSER_VER=2099000 -DCFG_DIR='"/usr/local/etc/ser/"' -DPKG_MALLOC -DSHM_MEM -DSHM_MMAP -DDNS_IP_HACK -DUSE_IPV6 -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLACKLIST -DUSE_NAPTR -DDBG_QM_MALLOC -DUSE_TLS -DTLS_HOOKS -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKARROUND -DUSE_FUTEX -DHAVE_SELECT -I/usr/local/ssl/include -DSER_MOD_INTERFACE -DMOD_NAME='"tls"' -c tls_config.c -o tls_config.o In file included from tls_config.c:36: tls_util.h:68: error: conflicting types for 'shm_str_dup' ../../ut.h:639: error: previous definition of 'shm_str_dup' was here make[1]: *** [tls_config.o] Error 1 make[1]: Leaving directory `/home/darilion/software/siprouter/sip-router/modules_s/tls' make: *** [modules_s] Error 1 regards klaus

1 0

git:master: xmlrpc(s): support for the "*" modifier
by Andrei Pelinescu-Onciul 29 Jun '09

29 Jun '09

Module: sip-router Branch: master Commit: 6c6e272929fe211467f894fd7bcdcb2dc1327552 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6c6e272… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Mon Jun 29 20:50:47 2009 +0200 xmlrpc(s): support for the "*" modifier rpc_scan supports now the "*" modifier for marking optional parameters. --- modules_s/xmlrpc/xmlrpc.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/modules_s/xmlrpc/xmlrpc.c b/modules_s/xmlrpc/xmlrpc.c index 94dbbd1..4ca7ab2 100644 --- a/modules_s/xmlrpc/xmlrpc.c +++ b/modules_s/xmlrpc/xmlrpc.c @@ -1187,18 +1187,24 @@ static int rpc_scan(rpc_ctx_t* ctx, char* fmt, ...) xmlNodePtr value; struct xmlrpc_reply* reply; struct rpc_struct* p; - + int modifiers; va_list ap; reply = &ctx->reply; fmt_len = strlen(fmt); va_start(ap, fmt); + modifiers=0; read = 0; while(*fmt) { if (!ctx->act_param) goto error; value = ctx->act_param->xmlChildrenNode; switch(*fmt) { + case '*': /* start of optional parameters */ + modifiers++; + /* no other action needed, for xmlrpc params are treated as + optionals anyway */ + break; case 'b': /* Bool */ case 't': /* Date and time */ case 'd': /* Integer */ @@ -1245,11 +1251,11 @@ static int rpc_scan(rpc_ctx_t* ctx, char* fmt, ...) fmt++; } va_end(ap); - return read; + return read-modifiers; error: va_end(ap); - return -read; + return -(read-modifiers); } #define RPC_BUF_SIZE 1024

1 0

git:master: rpc doc: added "*" and some minor fixes
by Andrei Pelinescu-Onciul 29 Jun '09

29 Jun '09

Module: sip-router Branch: master Commit: 32c1a13ef4b1395cb891289af9b854f5686178d2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=32c1a13… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Mon Jun 29 20:30:44 2009 +0200 rpc doc: added "*" and some minor fixes - documented the newly introduced "*" modifier for optional parameters. - fixed return value description for rpc->scan and rpc->struct_scan (these function always return the number of parameters read on success and - number of parameters read so far on failure and not 0/-1). - changed ctl and xmlrpc links to point to the auto-generated html files on sip-router.org/docbook/. - re-generated ser_rpc.txt --- doc/rpc/ser_rpc.txt | 64 ++++++++++++++++++++++++++++----------- doc/rpc/ser_rpc.xml | 82 +++++++++++++++++++++++++++++++++++++------------- 2 files changed, 106 insertions(+), 40 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=32c…

1 0

git:master: ctl: fix rpc_scan return when "*" is used
by Andrei Pelinescu-Onciul 29 Jun '09

29 Jun '09

Module: sip-router Branch: master Commit: eb367fc968ca3e9644e3fdfaf25ff13d776c4777 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=eb367fc… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Mon Jun 29 20:46:47 2009 +0200 ctl: fix rpc_scan return when "*" is used - the rpc_scan function (both for binrpc and fifo) did return the wrong number of parameters when the newly introduced "*" modifier was used. - for binrpcs, "*" switches to "nofault" mode only if the error is E_BINRPC_MORE_DATA or E_BINRPC_EOP (meaning no more data to read parameters from). All the other errors will generate faults, even with "*" in the format strings (e.g. parameter type mismatch, invalid value a.s.o.). --- modules_s/ctl/binrpc_run.c | 9 ++++++--- modules_s/ctl/fifo_server.c | 7 +++++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/modules_s/ctl/binrpc_run.c b/modules_s/ctl/binrpc_run.c index fa371ef..0fac504 100644 --- a/modules_s/ctl/binrpc_run.c +++ b/modules_s/ctl/binrpc_run.c @@ -594,14 +594,17 @@ static int rpc_scan(struct binrpc_ctx* ctx, char* fmt, ...) int err; char* orig_fmt; int nofault; + int modifiers; va_start(ap, fmt); orig_fmt=fmt; nofault = 0; + modifiers=0; for (;*fmt; fmt++){ switch(*fmt){ case '*': /* start of optional parameters */ nofault = 1; + modifiers++; break; case 'b': /* bool */ case 't': /* time */ @@ -652,9 +655,9 @@ static int rpc_scan(struct binrpc_ctx* ctx, char* fmt, ...) ctx->in.record_no++; } va_end(ap); - return (int)(fmt-orig_fmt); + return (int)(fmt-orig_fmt)-modifiers; error_read: - if(nofault==0) + if(nofault==0 || ((err!=E_BINRPC_MORE_DATA) && (err!=E_BINRPC_EOP))) rpc_fault(ctx, 400, "error at parameter %d: expected %s type but" " %s", ctx->in.record_no, rpc_type_name(v.type), binrpc_error(err)); @@ -675,7 +678,7 @@ error_inv_param: *fmt); error_ret: va_end(ap); - return -(int)(fmt-orig_fmt); + return -((int)(fmt-orig_fmt)-modifiers); } diff --git a/modules_s/ctl/fifo_server.c b/modules_s/ctl/fifo_server.c index 9ad267a..a701765 100644 --- a/modules_s/ctl/fifo_server.c +++ b/modules_s/ctl/fifo_server.c @@ -1347,12 +1347,14 @@ static int rpc_scan(rpc_ctx_t* ctx, char* fmt, ...) int read; str line; int nofault; + int modifiers; va_list ap; va_start(ap, fmt); nofault = 0; read = 0; + modifiers=0; while(*fmt) { if (read_line(&line.s, &line.len, &ctx->read_h) < 0) { va_end(ap); @@ -1363,6 +1365,7 @@ static int rpc_scan(rpc_ctx_t* ctx, char* fmt, ...) switch(*fmt) { case '*': /* start of optional parameters */ nofault = 1; + modifiers++; break; case 'b': /* Bool */ case 't': /* Date and time */ @@ -1429,11 +1432,11 @@ static int rpc_scan(rpc_ctx_t* ctx, char* fmt, ...) read++; } va_end(ap); - return read; + return read-modifiers; error: va_end(ap); - return -read; + return -(read-modifiers); }

1 0

Re: [sr-dev] [Kamailio-Users] new feature: fine access to xml documents
by Daniel-Constantin Mierla 29 Jun '09

29 Jun '09

On 06/25/2009 04:13 PM, Klaus Darilion wrote: > > > Iñaki Baz Castillo schrieb: >> El Jueves, 25 de Junio de 2009, Daniel-Constantin Mierla escribió: >>> Probably not very clear in my first email, but you can change the xml >>> content: >>> >>> $xml(a=>xpath:/presence/mynode) = "123"; >> >> When reading, which is the result if the node doesn't exist? empty >> string? >> If a=>xpath:/presence/mynode gets 123 (an integer) can it be used in >> math operation as integer? or is it a string? >> >> >>> Note that if you assigned the sip message body to $xml(name=>doc), body >>> does not get changed, the operations are done on a replica. >> >> So modifications in the body must be done in the proxy before >> forwarding the request to the presence server, or doing a spiral if >> the presence server is integrated in the proxy, right? > > Hi Daniel! > > In sip-router there is functionality to apply lumps before sending (it > is used for SIP-Identity). Maybe this could be exported to script and > can be executed manually to triggering reconstruction of the message, > e.g. for processing the modified message in the presence module. it does not work now directly on msg body, but your approach can get life using set_body() from textops. Applying lumps would be good to add as experimental function in config, to see how much it affects the rest. Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com/

1 0

[ openser-Bugs-2814137 ] force_rtp_proxy bug
by SourceForge.net 29 Jun '09

29 Jun '09

Bugs item #2814137, was opened at 2009-06-29 20:29 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2814137&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Marcus Hunger (marcushunger) Assigned to: Nobody/Anonymous (nobody) Summary: force_rtp_proxy bug Initial Comment: force_rtp_proxy seems to handle re-invite wrong, resulting in one-way-audio. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-06-29 21:19 Message: When is this happening? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2814137&group_…

1 0

[ openser-Bugs-2814137 ] force_rtp_proxy bug
by SourceForge.net 29 Jun '09

29 Jun '09

Bugs item #2814137, was opened at 2009-06-29 19:29 Message generated for change (Tracker Item Submitted) made by marcushunger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2814137&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Marcus Hunger (marcushunger) Assigned to: Nobody/Anonymous (nobody) Summary: force_rtp_proxy bug Initial Comment: force_rtp_proxy seems to handle re-invite wrong, resulting in one-way-audio. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2814137&group_…

1 0

build problems: error: mi_mem.h: No such file or directory
by Klaus Darilion 29 Jun '09

29 Jun '09

Hi! I have set excluded modules to "" to try building everything. No I got this error: make[2]: Entering directory `/home/darilion/software/siprouter/sip-router/sip-router/lib/kmi' tree.c:38:20: error: mi_mem.h: No such file or directory Is there something missing? regards klaus

2 1

← Newer
1
2
3
4
5
6
7
8
...
29
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2009