sr-dev April 2009

sr-dev@lists.kamailio.org

13 participants
230 discussions

git:master: tls (common):Revert "Replace TCP_BUF_SIZE with a cfg_get(..)."

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: dcf7195d5dc28097f88b0e6841aa7c805244c22b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dcf7195… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Thu Apr 23 13:09:40 2009 +0200 tls (common):Revert "Replace TCP_BUF_SIZE with a cfg_get(..)." This reverts commit 29b0138a7ce09cab1024e25ac457cb8915a973da. (bad fix) --- modules/tls/tls_server.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/modules/tls/tls_server.c b/modules/tls/tls_server.c index 6795dec..32d8b28 100644 --- a/modules/tls/tls_server.c +++ b/modules/tls/tls_server.c @@ -45,7 +45,6 @@ #include "../../timer.h" #include "../../globals.h" #include "../../pt.h" -#include "../../tcp_options.h" #include "tls_init.h" #include "tls_domain.h" @@ -814,7 +813,7 @@ int tls_h_read(struct tcp_connection * c) SSL* ssl; r = &c->req; - bytes_free = cfg_get(tcp, tcp_cfg, rd_buf_size) - (int)(r->pos - r->buf); + bytes_free = TCP_BUF_SIZE - (int)(r->pos - r->buf); if (bytes_free == 0) { ERR("Buffer overrun, dropping\n");

15 years, 8 months

[Fwd: [Kamailio-Devel] race condition]

by Klaus Darilion

Hi guys! In Kamilio we had (have?) the problem described here. Maybe the problem still applies to ser-tm too, then it needs this fix too. regards klaus -------- Original-Nachricht -------- Betreff: [Kamailio-Devel] race condition Datum: Thu, 23 Apr 2009 10:34:26 +0200 Von: Zappasodi Daniele <Daniele.Zappasodi(a)seltatel.it> An: <devel(a)lists.kamailio.org> Referenzen: <mailman.9.1240394401.8388.devel(a)lists.kamailio.org> Hello, I have a problem with a race condition with the reply and retransmission. Sometimes Openser (I'm still working with 1.3.x version) ignores the provisional reply and tears down the call after the fr_timer. This happens only in a particulary conditions: I have a short value for fr_timer (5 sec); the reply arrives very fast (I have gateway and proxy on the same box). In this situation can happen that a child sends the INVITE (SEND_BUFFER in t_forward_nonack) and it is suspended by the scheduler before it can execute start_retr. Another child get the reply. When the first child executes start_retr it sends immediately a retransmission for the INVITE and after 5 seconds (the fr_timer) it tears down the call with CANCEL, because it ignores the reply. I know that this is a very improbable condition (even if I encountered it), but if you want to fix it, it should be easy to solve: in t_forward_nonack, before start_retr, it should be tested if another child has already received a reply. Something like this (t_fwd.c on head): @@ -719,7 +719,10 @@ -p_msg->REQ_METHOD); } - start_retr( &t->uac[i].request ); + if(p_msg->REQ_METHOD==METHOD_INVITE && t->uac[i].last_received>=100) + LM_DBG("Last received %d\n",t->uac[i].last_received); + else + start_retr( &t->uac[i].request ); set_kr(REQ_FWDED); } }

15 years, 8 months

git:master: Merge branch 'master' of ssh://ramona@git.sip-router.org/ sip-router

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 61fad306dab7aef72a1a7b976e33054fa17964dd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=61fad30… Author: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Committer: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Date: Thu Apr 23 14:22:37 2009 +0300 Merge branch 'master' of ssh://ramona@git.sip-router.org/sip-router * 'master' of ssh://ramona@git.sip-router.org/sip-router: tls: don't start if tcp is in async mode tls: fixed missing TCP_BUF_SIZE ---

15 years, 8 months

git:master: sst(k): register exported statistics from mod_init

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 9ce2960f2b76372eae40813b0be640c6f3fbd7da URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9ce2960… Author: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Committer: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Date: Thu Apr 23 14:19:03 2009 +0300 sst(k): register exported statistics from mod_init - k statistics API is now in kcore library, SR core doesn't register stats from module_exports --- modules_k/sst/sst.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/modules_k/sst/sst.c b/modules_k/sst/sst.c index 6545ae3..33a6d60 100644 --- a/modules_k/sst/sst.c +++ b/modules_k/sst/sst.c @@ -159,6 +159,18 @@ static int mod_init(void) exports.stats = 0; } +#ifdef STATISTICS + /* register statistics */ + if (sst_enable_stats!=0) + { + if (register_module_stats( exports.name, mod_stats)!=0 ) { + LM_ERR("failed to register core statistics\n"); + return -1; + } + } +#endif + + if (sst_flag == -1) { LM_ERR("no sst flag set!!\n"); return -1;

15 years, 8 months

git:master: sl(k): register exported statistics from mod_init

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 5019d45b6713fdfb1ab96509e0673782d889415a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5019d45… Author: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Committer: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Date: Thu Apr 23 14:17:01 2009 +0300 sl(k): register exported statistics from mod_init - k statistics API is now in kcore library, SR core doesn't register stats from module_exports --- modules_k/sl/sl.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/modules_k/sl/sl.c b/modules_k/sl/sl.c index eb7c93f..293246c 100644 --- a/modules_k/sl/sl.c +++ b/modules_k/sl/sl.c @@ -154,6 +154,17 @@ static int mod_init(void) if (sl_enable_stats==0) exports.stats = 0; +#ifdef STATISTICS + /* register statistics */ + if (sl_enable_stats!=0) + { + if (register_module_stats( exports.name, mod_stats)!=0 ) { + LM_ERR("failed to register core statistics\n"); + return -1; + } + } +#endif + /* filter all ACKs before script */ if (register_script_cb(sl_filter_ACK, PRE_SCRIPT_CB|REQ_TYPE_CB, 0 )!=0) { LM_ERR("register_script_cb failed\n");

15 years, 8 months

git:master: usrloc(k): register exported statistics from mod_init

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 29494fc266fc36959e0ef560e3d05bd4e827d644 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=29494fc… Author: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Committer: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Date: Thu Apr 23 14:00:08 2009 +0300 usrloc(k): register exported statistics from mod_init - k statistics API is now in kcore library, SR core doesn't register stats from module_exports --- modules_k/usrloc/ul_mod.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules_k/usrloc/ul_mod.c b/modules_k/usrloc/ul_mod.c index 8e6e1c2..ff82b73 100644 --- a/modules_k/usrloc/ul_mod.c +++ b/modules_k/usrloc/ul_mod.c @@ -214,6 +214,14 @@ struct module_exports exports = { */ static int mod_init(void) { +#ifdef STATISTICS + /* register statistics */ + if (register_module_stats( exports.name, mod_stats)!=0 ) { + LM_ERR("failed to register core statistics\n"); + return -1; + } +#endif + if(register_mi_mod(exports.name, mi_cmds)!=0) { LM_ERR("failed to register MI commands\n");

15 years, 8 months

git:master: registrar(k): register exported statistics from mod_init

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 93154d273d234a2958a364faa8fcfe546daf5c28 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=93154d2… Author: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Committer: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Date: Thu Apr 23 13:50:34 2009 +0300 registrar(k): register exported statistics from mod_init - k statistics API is now in kcore library, SR core doesn't register stats from module_exports --- modules_k/registrar/reg_mod.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/modules_k/registrar/reg_mod.c b/modules_k/registrar/reg_mod.c index 5986867..f80d901 100644 --- a/modules_k/registrar/reg_mod.c +++ b/modules_k/registrar/reg_mod.c @@ -249,6 +249,15 @@ static int mod_init(void) str s; bind_usrloc_t bind_usrloc; + +#ifdef STATISTICS + /* register statistics */ + if (register_module_stats( exports.name, mod_stats)!=0 ) { + LM_ERR("failed to register core statistics\n"); + return -1; + } +#endif + /* load the SL API */ if (load_sl_api(&slb)!=0) { LM_ERR("can't load SL API\n");

15 years, 8 months

git:master: siptrace(k): register exported statistics from mod_init

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 51c1fe92ea71db3e418e146fe48fe9c93f18181f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=51c1fe9… Author: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Committer: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Date: Thu Apr 23 13:53:31 2009 +0300 siptrace(k): register exported statistics from mod_init - k statistics API is now in kcore library, SR core doesn't register stats from module_exports --- modules_k/siptrace/siptrace.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules_k/siptrace/siptrace.c b/modules_k/siptrace/siptrace.c index c7c9e8a..421f6b5 100644 --- a/modules_k/siptrace/siptrace.c +++ b/modules_k/siptrace/siptrace.c @@ -190,6 +190,14 @@ static int mod_init(void) { pv_spec_t avp_spec; +#ifdef STATISTICS + /* register statistics */ + if (register_module_stats( exports.name, siptrace_stats)!=0 ) { + LM_ERR("failed to register core statistics\n"); + return -1; + } +#endif + if(register_mi_mod(exports.name, mi_cmds)!=0) { LM_ERR("failed to register MI commands\n");

15 years, 8 months

git:master: dialog(k): register exported statistics from mod_init

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 3fc1c9220318757a31ba073aed6e68bea977623f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3fc1c92… Author: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Committer: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Date: Thu Apr 23 13:42:51 2009 +0300 dialog(k): register exported statistics from mod_init - k statistics API is now in kcore library, SR core doesn't register stats from module_exports --- modules_k/dialog/dialog.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/modules_k/dialog/dialog.c b/modules_k/dialog/dialog.c index d3c9b3a..1e6c5de 100644 --- a/modules_k/dialog/dialog.c +++ b/modules_k/dialog/dialog.c @@ -362,6 +362,15 @@ static int mod_init(void) { unsigned int n; + +#ifdef STATISTICS + /* register statistics */ + if (register_module_stats( exports.name, mod_stats)!=0 ) { + LM_ERR("failed to register core statistics\n"); + return -1; + } +#endif + if(register_mi_mod(exports.name, mi_cmds)!=0) { LM_ERR("failed to register MI commands\n");

15 years, 8 months

git:master: imc(k): register exported statistics from mod_init

by Elena-Ramona Modroiu

Module: sip-router Branch: master Commit: 755c3f6dc84a664321ad34eeedc55a5b27fd23ce URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=755c3f6… Author: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Committer: Elena-Ramona Modroiu <ramona(a)rosdev.ro> Date: Thu Apr 23 13:36:52 2009 +0300 imc(k): register exported statistics from mod_init - k statistics API is now in kcore library, SR core doesn't register stats from module_exports --- modules_k/imc/imc.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules_k/imc/imc.c b/modules_k/imc/imc.c index d7354ac..687733f 100644 --- a/modules_k/imc/imc.c +++ b/modules_k/imc/imc.c @@ -336,6 +336,14 @@ error: static int mod_init(void) { +#ifdef STATISTICS + /* register statistics */ + if (register_module_stats( exports.name, imc_stats)!=0 ) { + LM_ERR("failed to register core statistics\n"); + return -1; + } +#endif + if(register_mi_mod(exports.name, mi_cmds)!=0) { LM_ERR("failed to register MI commands\n");

15 years, 8 months

← Newer
1
...
6
7
8
9
10
11
12
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2009