sr-dev October 2009

sr-dev@lists.kamailio.org

30 participants
468 discussions

[ openser-Bugs-2818273 ] crash when Content-length too big

by SourceForge.net

Bugs item #2818273, was opened at 2009-07-08 02:28 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2818273&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: crash when Content-length too big Initial Comment: Recently we encountered some crashes of kamailio 1.5.0 caused by messages with too big value of Content-length (more than 30000). When the parser in nathelper.c looks for old and new port it sometimes finds occurences after the real end of the message. Then the sanity check in del_lump() in data_lump.c finds that either offset or offset+len is greater than msg->len and calls abort(). ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2009-10-05 09:54 Message: This should be fixed in 1.5.2 and latest svn, have you tried the latest 1.5 svn branch? ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-08 18:17 Message: 'kamailio -V' says 'kamailio 1.5.0-notls (x86_64/linux)' ---------------------------------------------------------------------- Comment By: Klaus Darilion (klaus_darilion) Date: 2009-07-08 11:38 Message: Which excat version are you using? There were some bugfixes recently. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2818273&group_…

14 years, 6 months

[ openser-Bugs-2826540 ] Presence DB save fails after one failure

by SourceForge.net

Bugs item #2826540, was opened at 2009-07-24 17:52 Message generated for change (Comment added) made by sathiyapriyanm You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2826540&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Presence DB save fails after one failure Initial Comment: After one record has failed to insert/update into the database, remaining records aren't tried. The attached patch tries to insert/update the remaining records in the hashtable after a failure. This patch surfaced bug #2824350 which led to a lot of failures due to duplicate keys. ---------------------------------------------------------------------- Comment By: sathiyapriyan m (sathiyapriyanm) Date: 2009-10-05 10:38 Message: How to Repeat or Check the Error? Kindly explain the situation. I have tried in may ways it works fine in the version 1.5.2. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2826540&group_…

14 years, 6 months

SNMPstats module

by Olle E. Johansson

SNMPstats currently lives in modules_k. As we've got an OID for Kamailio.org it's time to update the module. 1. Change the OID - maybe with a config option if people depend on the old 2. Change file names on all files starting with "openser". I don't see why we need a name tag in these file names. Anyone else? openserObjects.h could very well be snmpObjects.h 3. Update all MIBS so that we don't use the openser namespace or OID. I would suggest that we change all "openser" tags to "siprouter" to enable this module to move in to core at some point. Changing MIBs to have "kamailio" in all names doesn't seem very long term for me. Any comments? I can start playing with this and upload patches to the tracker, but would like some consensus on the road map before I proceed. /O

14 years, 6 months

radiusclient-ng not available from berlios

by jh＠tutpro.com

radiusclient-ng used to be available from http://developer.berlios.de/projects/radiusclient-ng that site has not responded at least during the last two days, when i have tried. is berlios still supposed to exist? if not, does anyone know where the latest radiuslient-ng (i think version 0.5.6) would be available? -- juha

14 years, 6 months

[ openser-Bugs-2822344 ] Branch route has wrong ruri or missing headers

by SourceForge.net

Bugs item #2822344, was opened at 2009-07-16 11:06 Message generated for change (Comment added) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2822344&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: ver 1.4.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Branch route has wrong ruri or missing headers Initial Comment: The scenario: In branch route, I rewrite the ruri and add an additional header. When the destination fails and DNS-based failover takes place, the branch route is called again. For this second branch, the ruri is not the same as the ruri at t_relay time. Also the extra header is missing. So this bug could be either: - The ruri and rest of variables/packet for each branch should be the same as the ruri at t_relay time or - The header added in the first branch route should also be present for the second branch (in the case of DNS-based failover) I would either expect the ruri and all other variables and headers to be exactly the same as at t_relay time for each branch, or (for DNS-based failover ONLY) the packet sent to a failover destination to be exactly the same as the first branch (including any added headers / from replacement, etc.) Not a mix of both. Before t_relay: $rU = "*1234567890" t_relay("0x03"); my branch route: xlog("L_NOTICE", "Branch: <$ru> via <$du>\n"); if (is_method("INVITE") and $(rU{s.substr,0,3}) == "*12") { strip(3); append_hf("X-Test: 12\r\n"); } The log: Jul 15 09:14:38 Branch: <sip:*1234567890@test.domain;transport=udp> via <<null>> Jul 15 09:14:38 Reply Status: 503 Service Unavailable Jul 15 09:14:38 Branch: <sip:234567890@test.domain;transport=udp> via <<null>> Jul 15 09:14:38 Reply Status: 100 Trying ---------------------------------------------------------------------- >Comment By: Alex Hermann (axlh) Date: 2009-09-04 17:03 Message: And when there is no response at all from th destination, resulting in a local generated 408, the behaviour is even different. Then branch route isn't called at all, but the packet headed for the failover host is different from the original as it misses any headers added in the branch route. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2822344&group_…

14 years, 6 months

git:master: * modules_k/permissions: fixed checking of db connection

by Juha Heinanen

Module: sip-router Branch: master Commit: b7a06e40596e98f7c44d7166fe72845fde3106e4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b7a06e4… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Oct 2 16:37:17 2009 +0300 * modules_k/permissions: fixed checking of db connection - In allow_trusted(), check existence of db connection only when in non-caching mode. --- modules_k/permissions/trusted.c | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/modules_k/permissions/trusted.c b/modules_k/permissions/trusted.c index aba3822..d7a2a71 100644 --- a/modules_k/permissions/trusted.c +++ b/modules_k/permissions/trusted.c @@ -403,13 +403,14 @@ int allow_trusted(struct sip_msg* msg, char *src_ip, int proto) db_key_t keys[1]; db_val_t vals[1]; db_key_t cols[3]; - - if (db_handle == 0) { - LM_ERR("no connection to database\n"); - return -1; - } if (db_mode == DISABLE_CACHE) { + + if (db_handle == 0) { + LM_ERR("no connection to database\n"); + return -1; + } + keys[0] = &source_col; cols[0] = &proto_col; cols[1] = &from_col;

14 years, 6 months

DB Error using allow_trusted after upgrade

by hans＠onsmail.nl

Hi, I just upgraded my kamailio (1.5) to the latest version, but after restarting kamailio the calling of allow_trusted() is failing with the following error: "ERROR:permissions:allow_trusted: no connection to database". Permissions module is using 'db_mode 1' I noticed there has been a change in the permissions/trusted.c code so i'm wondering if this is the cause of this problem ? Kind regards Hans version: kamailio 1.5.2-notls (i386/linux) flags: STATISTICS, USE_IPV6, USE_TCP, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, PKG_SIZE 4194304 poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. svnrevision: 2:5928M @(#) $Id: main.c 5608 2009-02-13 16:48:17Z henningw $ main.c compiled on 10:58:26 Oct 2 2009 with gcc 4.1.2

14 years, 6 months

SF.net SVN: openser:[5929] branches/1.5/modules/permissions/trusted.c

by Juha Heinanen

Revision: 5929 http://openser.svn.sourceforge.net/openser/?rev=5929&view=rev Author: juhe Date: 2009-10-02 10:11:58 +0000 (Fri, 02 Oct 2009) Log Message: ----------- * Test existence of db_handle only when in non-caching mode. Modified Paths: -------------- branches/1.5/modules/permissions/trusted.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 6 months

git:master: modules_k/permissions: fixed handling of db connection

by Juha Heinanen

Module: sip-router Branch: master Commit: f26601329fd510bff08f684b3e445cc0c4a9995b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f266013… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Oct 2 12:00:58 2009 +0300 modules_k/permissions: fixed handling of db connection * Do not close db connection if query fails. * Check that db connection exists before making a query --- modules_k/permissions/trusted.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/modules_k/permissions/trusted.c b/modules_k/permissions/trusted.c index 889a3d2..aba3822 100644 --- a/modules_k/permissions/trusted.c +++ b/modules_k/permissions/trusted.c @@ -404,9 +404,9 @@ int allow_trusted(struct sip_msg* msg, char *src_ip, int proto) db_val_t vals[1]; db_key_t cols[3]; - if (!db_url.s) { - LM_ERR("db_url parameter has not been set\n"); - return -1; + if (db_handle == 0) { + LM_ERR("no connection to database\n"); + return -1; } if (db_mode == DISABLE_CACHE) { @@ -427,7 +427,6 @@ int allow_trusted(struct sip_msg* msg, char *src_ip, int proto) if (perm_dbf.query(db_handle, keys, 0, vals, cols, 1, 3, 0, &res) < 0){ LM_ERR("failed to query database\n"); - perm_dbf.close(db_handle); return -1; }

14 years, 6 months

SF.net SVN: openser:[5928] branches/1.5/modules/permissions/trusted.c

by Juha Heinanen

Revision: 5928 http://openser.svn.sourceforge.net/openser/?rev=5928&view=rev Author: juhe Date: 2009-10-02 04:51:57 +0000 (Fri, 02 Oct 2009) Log Message: ----------- * Check that db connection exists before trying to make query. * Do not close db connection if db query fails. Modified Paths: -------------- branches/1.5/modules/permissions/trusted.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 6 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2009