sr-dev October 2009

sr-dev@lists.kamailio.org

30 participants
468 discussions

git:sr_3.0: tm: fix branches clearing lumps
by Andrei Pelinescu-Onciul 30 Oct '09

30 Oct '09

Module: sip-router Branch: sr_3.0 Commit: 6a55e42edd0cf0ac82b2099a74b4896fdc801145 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6a55e42… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Oct 30 15:19:42 2009 +0100 tm: fix branches clearing lumps - fix bug introduced in 610cb93 --- modules/tm/t_fwd.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/modules/tm/t_fwd.c b/modules/tm/t_fwd.c index c917e2f..e4df337 100644 --- a/modules/tm/t_fwd.c +++ b/modules/tm/t_fwd.c @@ -232,8 +232,6 @@ static int prepare_new_uac( struct cell *t, struct sip_msg *i_req, #endif add_rm_backup = i_req->add_rm; body_lumps_backup = i_req->body_lumps; - i_req->add_rm=0; - i_req->body_lumps=0; if (unlikely(i_req->add_rm)){ i_req->add_rm = dup_lump_list(i_req->add_rm); if (unlikely(i_req->add_rm==0)){

2 1

lots of trouble with latest sr
by jh＠tutpro.com 30 Oct '09

30 Oct '09

i have started to get those "could not find corresponding listening socket" all the time. also, looks like the previous proxy-authorization pv problem that i wrongly reported is due to remove_hf("Proxy-Authorization"); having no effect, i.e., the header is included in outgoing request even when i make the above call to remove it. i added some debug in my script that verified that the above call is done and still the original p-a header shows up in outgoing request. i don't know what to do next because looks like nothing that i try works. -- juha

2 2

git:kamailio_3.0: Merge remote branch 'origin/sr_3.0' into kamailio_3.0
by Daniel-Constantin Mierla 30 Oct '09

30 Oct '09

Module: sip-router Branch: kamailio_3.0 Commit: 39ce77440b5d72a8a197ca06ff579371134bcacf URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=39ce774… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Oct 30 15:01:41 2009 +0100 Merge remote branch 'origin/sr_3.0' into kamailio_3.0 * origin/sr_3.0: fix typo in location flags settings Rewritten this small helper function When string was in the form of 0=on\n\0 this function caused a segmentation fault(canaries where overwritten). Removed unused var (added last commit) Fixed avpops avp_db_store as before no state was used and it caused to loop endessly. Declared pua_send_publish ,as it was only defined (extern) Fixed tm_load import (It would be advisable to use tm_load_api instead ) Fixed include guard Added kmi module to linkage (because of ../../modules_k/xcap_client/xcap_client.so: undefined symbol: register_mi_mod ) Fixed carrierroute module exports. Fixed userblacklist exported function If the user parameter is "<null>" (e.g a empty username in the request URI), do not copy this value to the rewritten uri. lib/srdb1/schema/gw.xml: index changes modules/lcr: bug fixes htable(k): fix non-init act. ctx in event route execution tm: fix/support changing r-uris and path in branch routes Conflicts: .gitignore Makefile Makefile.defs Makefile.dirs cfg.lex cfg.y etc/kamailio.cfg events.c events.h forward.c lib/srdb1/schema/gw.xml modules/avpops/avpops_impl.c modules/carrierroute/carrierroute.c modules/carrierroute/cr_func.c modules/carrierroute/cr_func.h modules/lcr/README modules/lcr/doc/lcr_admin.xml modules/lcr/lcr_mod.c modules/lcr/lcr_rpc.c modules/tm/h_table.c modules/tm/h_table.h modules/tm/t_fwd.c modules/tm/t_fwd.h modules/tm/t_hooks.c modules/tm/t_reply.c modules/tm/uac.c modules/utils/conf.c modules_k/htable/htable.c modules_k/kex/core_stats.c modules_k/pua_dialoginfo/pua_dialoginfo.c modules_k/pua_usrloc/pua_usrloc.c modules_k/pua_usrloc/pua_usrloc.h modules_k/pua_xmpp/pua_xmpp.c modules_k/pv/pv.c modules_k/pv/pv_branch.c modules_k/pv/pv_branch.h modules_k/userblacklist/userblacklist.c modules_k/xcap_client/Makefile modules_s/domain/domain_mod.c modules_s/registrar/save.c parser/msg_parser.c parser/parse_uri.c receive.c utils/kamctl/Makefile ---

2 2

git:kamailio_3.0: sanity modules in now in modules/
by Daniel-Constantin Mierla 30 Oct '09

30 Oct '09

Module: sip-router Branch: kamailio_3.0 Commit: 393027b94e52b46131b141cbf5019c0efab3d29f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=393027b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Oct 30 15:05:00 2009 +0100 sanity modules in now in modules/ --- modules_k/sanity/Makefile | 16 - modules_k/sanity/README | 196 -------- modules_k/sanity/doc/Makefile | 4 - modules_k/sanity/doc/sanity.xml | 41 -- modules_k/sanity/doc/sanity_admin.xml | 271 ---------- modules_k/sanity/mod_sanity.c | 221 -------- modules_k/sanity/mod_sanity.h | 85 ---- modules_k/sanity/sanity.c | 749 ---------------------------- modules_k/sanity/sanity.h | 79 --- modules_s/sanity/Makefile | 16 - modules_s/sanity/README | 158 ------ modules_s/sanity/doc/Makefile | 4 - modules_s/sanity/doc/functions.xml | 79 --- modules_s/sanity/doc/params.xml | 74 --- modules_s/sanity/doc/sanity.xml | 144 ------ modules_s/sanity/mod_sanity.c | 223 --------- modules_s/sanity/mod_sanity.h | 90 ---- modules_s/sanity/sanity.c | 887 --------------------------------- modules_s/sanity/sanity.h | 84 --- 19 files changed, 0 insertions(+), 3421 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=393…

1 0

tcp problems exists also in older version of sr
by jh＠tutpro.com 30 Oct '09

30 Oct '09

i thought that tcp problem (using wrong ip address) appeared only in latest sr code, but now i saw it also in older version. to repeat, register twinkle using tcp from behind nat. call twinkle from another sip phone that is using udp. twinkle receives 200 ok, but never the ack. sr cannot forward ack to twinkle and reports: Oct 30 10:36:56 localhost /usr/sbin/sip-proxy[3911]: WARNING: <core> [tcp_main.c:1200]: WARNING: tcp_do_connect 192.168.0.169:5074: could not find corresponding listening socket for 192.X.Y.2, using default... Oct 30 10:36:57 localhost /usr/sbin/sip-proxy[3924]: INFO: Routing in-dialog BYE from <sip:foo.bar@bar.com> to <sip:jh_bar_com@192.168.0.169:5074;transport=tcp>Oct 30 10:37:01 localhost /usr/sbin/sip-proxy[4023]: ERROR: <core> [tcp_main.c:3747]: connect 192.168.0.169:5074 failed (timeout) where 192.X.Y.2 is NONE of the addresses sr is listening at, but ip of eth0 interface. this is a very serious show stopper. -- juha

2 3

how to pull a version of a date?
by jh＠tutpro.com 30 Oct '09

30 Oct '09

is there a way to pull a version of sr_3.0 as it was at a certain date? i would like to get one before the latest branch route commits that made things worse. -- juha

3 3

looks like usrloc flags don't work either
by jh＠tutpro.com 30 Oct '09

30 Oct '09

i have twinkle registered from behind nat and when i check in location table my nat flag modparam("usrloc", "nat_bflag", 1) is set, i.e. flag column of twinkle contact in location table has value 2. but when i check after lookup(): lookup("location"); switch ($rc) { case 1: if (isbflagset(1)) { xlog("L_INFO", "Branch Flag 1 is set\n"); }; nothing gets printed to syslog. i have not changed any of this config code since k. is this a compatibility issue or a bug? -- juha

3 16

Commit requirements
by Olle E. Johansson 30 Oct '09

30 Oct '09

"the code must compile on all the arhitectures (this currently includes linux, freebsd, netbsd, openbsd, solaris >= 8; x86, ultrasparc, strongarm; gcc 2.95, 3.x, icc, sun cc >=5.3)." How is this tested? Do all developers have access to all these platforms? Do we have a buildbot that automatically runs these tests? Just curious. /O

3 3

git:kamailio_3.0: throw error if parameters to module functions are int
by Daniel-Constantin Mierla 30 Oct '09

30 Oct '09

Module: sip-router Branch: kamailio_3.0 Commit: eb687b701730b48dffbd49a99103c64c0c3294da URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=eb687b7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Oct 30 13:22:27 2009 +0100 throw error if parameters to module functions are int --- cfg.y | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/cfg.y b/cfg.y index 585edf5..9b4c0d1 100644 --- a/cfg.y +++ b/cfg.y @@ -3087,7 +3087,8 @@ func_params: | func_params error { yyerror("call params error\n"); } ; func_param: - intno { + intno { +#if 0 if (mod_func_action->val[1].u.number < MAX_ACTIONS-2) { mod_func_action->val[mod_func_action->val[1].u.number+2].type = NUMBER_ST; @@ -3097,6 +3098,9 @@ func_param: } else { yyerror("Too many arguments\n"); } +#else + yyerror("Function parameter with integer value not allowed\n"); +#endif } | STRING { if (mod_func_action->val[1].u.number < MAX_ACTIONS-2) {

1 0

git:kamailio_3.0: added kamailio in ingnore list
by Daniel-Constantin Mierla 30 Oct '09

30 Oct '09

Module: sip-router Branch: kamailio_3.0 Commit: cadda4680f475fa991a5ed98606a2ccde6b200da URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cadda46… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Oct 30 13:04:42 2009 +0100 added kamailio in ingnore list --- .gitignore | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index b34dbbd..c4a7075 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ modules.lst *.d # ignore binary files and objects ser +kamailio *.so *.so.* *.o

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2009