sr-dev March 2009

sr-dev@lists.kamailio.org

14 participants
188 discussions

by Iñaki Baz Castillo

Hi, Kamailio uses the following syntax for =~ operator: if ( $rU =~ "^2[0-9]{2}$" ) { Reading the SR commits, it seems that SR will support regular expressions in 'switch' stament: switch ($rU) { case 200: # INTEGER [...] case "alice": # STRING [...] case /2[0-9]{2}/: # REGULAR EXPRESSION [...] } If the above is correct, it requires two different syntax for a regular expression: a) =~ "^2[0-9]{2}$" b) case /2[0-9]{2}/: Wouldn't make sense to have an unique syntax for regular expressions? IMHO the best one is: /2[0-9]{2}/ so =~ would use: if ( $rU =~ /^2[0-9]{2}$/ ) { Opinions? Regards. -- Iñaki Baz Castillo <ibc(a)aliax.net>

15 years, 1 month

PATCH: add parsing support for "mixed" content type

by Ovidiu Sas

Patch attached for parsing "mixed" content type. Regards, Ovidiu Sas

15 years, 1 month

git:master: Support for mixed content type.

by Jan Janak

Module: sip-router Branch: master Commit: 44a06042caaf45156862e71e654c781cd5b9332c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=44a0604… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Jan Janak <jan(a)iptel.org> Date: Tue Mar 24 15:14:53 2009 +0100 Support for mixed content type. This patch extendes the content type parser and adds support for content type mixed. Signed-off-by: Jan Janak <jan(a)iptel.org> --- parser/parse_content.c | 10 +++++++--- parser/parse_content.h | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/parser/parse_content.c b/parser/parse_content.c index 985c13b..6e3c5bc 100644 --- a/parser/parse_content.c +++ b/parser/parse_content.c @@ -193,7 +193,7 @@ static type_node_t subtype_tree[] = { {'i',SUBTYPE_UNKNOWN,1,-1}, {'d',SUBTYPE_UNKNOWN,1,-1}, {'f',SUBTYPE_XML_MSRTC_PIDF,0,-1}, - {'e',SUBTYPE_UNKNOWN,1,-1}, /* 94 */ + {'e',SUBTYPE_UNKNOWN,1,107}, /* 94 */ {'x',SUBTYPE_UNKNOWN,1,-1}, {'t',SUBTYPE_UNKNOWN,1,-1}, {'e',SUBTYPE_UNKNOWN,1,-1}, @@ -206,8 +206,12 @@ static type_node_t subtype_tree[] = { {'o',SUBTYPE_UNKNOWN,1,-1}, {'d',SUBTYPE_UNKNOWN,1,-1}, {'y',SUBTYPE_EXTERNAL_BODY,0,-1}, - - }; + {'m',SUBTYPE_UNKNOWN,1,-1}, /* 107 */ + {'i',SUBTYPE_UNKNOWN,1,-1}, + {'x',SUBTYPE_UNKNOWN,1,-1}, + {'e',SUBTYPE_UNKNOWN,1,-1}, + {'d',SUBTYPE_MIXED,0,-1}, +}; diff --git a/parser/parse_content.h b/parser/parse_content.h index c2b1a9f..0bc08ff 100644 --- a/parser/parse_content.h +++ b/parser/parse_content.h @@ -62,6 +62,7 @@ struct mime_type { #define SUBTYPE_EXTERNAL_BODY 11 #define SUBTYPE_XML_MSRTC_PIDF 12 #define SUBTYPE_CPIM_PIDFXML 13 +#define SUBTYPE_MIXED 14 #define SUBTYPE_ALL 0xfe #define SUBTYPE_UNKNOWN 0xff

15 years, 1 month

avp naming

by Daniel-Constantin Mierla

Hello, working to integrate the PV module I reached the AVPs and after a short analyze I wonder (and ask you) whether you should drop the naming scheme we have in Kamailio (integer id and string name) and stick to string names all the time. ser seems to use mostly that although looks like support for ID is still there, but I cannot see how they can be used with the naming scheme in config (e.g., is it possible to have $f.i:34 in config to refer to avp with id 34?). The benefits I see: - complexity in dealing with integer id or string name - avp name aliases removed Note that even for string-named AVPs there is an integer id computed and used in comparisons to speed up. Jan in an email some time ago mentioned that no performance penalty could be observed. I pasted most of the content of Jan's email about ser avps at: http://sip-router.org/wiki/devel/avps-ser Looking at the code where there are lot of IF name is string or integer, I wonder if really worth the complexity. Today we have lot of other variables for quick and shared-memory operations ($var(...), $shv(...), $sht(...), $dbr(...) and latest $mct(...)), avps not being anymore used for everywhere. Drawback is the naming scheme backward compatibility. We can treat "i:20" simply as string or throw error at startup (I prefer the second because is cleaner in long time). Opinions? Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com

15 years, 1 month

[PATCH 01/10] Fix header files of acc module

by Jan Janak

This commit fixes paths to various header files included by the module: * DB API headers are now included from libsrdb1 * libkcore/km_ut.h included in files where functions from kamailio/ut.h are used * Included flags.h for flag setters and getters * Included local_route.h from libkcore intead of the top level directory --- modules/acc/acc.c | 3 ++- modules/acc/acc_extra.c | 1 + modules/acc/acc_logic.c | 2 ++ modules/acc/acc_mod.c | 2 +- 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/modules/acc/acc.c b/modules/acc/acc.c index b84c49d..3f43685 100644 --- a/modules/acc/acc.c +++ b/modules/acc/acc.c @@ -50,7 +50,8 @@ #include "../../error.h" #include "../../mem/mem.h" #include "../../usr_avp.h" -#include "../../db/db.h" +#include "../../lib/srdb1/db.h" +#include "../../lib/kcore/km_ut.h" #include "../../parser/hf.h" #include "../../parser/msg_parser.h" #include "../../parser/parse_from.h" diff --git a/modules/acc/acc_extra.c b/modules/acc/acc_extra.c index cf2d92c..1e0e06e 100644 --- a/modules/acc/acc_extra.c +++ b/modules/acc/acc_extra.c @@ -48,6 +48,7 @@ #include "../../ut.h" #include "../../usr_avp.h" #include "../../mem/mem.h" +#include "../../lib/kcore/km_ut.h" #include "acc_extra.h" #define EQUAL '=' diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 6654d40..59e4440 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -43,6 +43,8 @@ #include "../../parser/parse_content.h" #include "../tm/tm_load.h" #include "../rr/api.h" +#include "../../lib/kcore/km_ut.h" +#include "../../flags.h" #include "acc.h" #include "acc_mod.h" #include "acc_logic.h" diff --git a/modules/acc/acc_mod.c b/modules/acc/acc_mod.c index ea881d9..7e234e6 100644 --- a/modules/acc/acc_mod.c +++ b/modules/acc/acc_mod.c @@ -63,7 +63,7 @@ #include <string.h> #include "../../sr_module.h" -#include "../../local_route.h" +#include "../../lib/kcore/local_route.h" #include "../../dprint.h" #include "../../mem/mem.h" #include "../tm/tm_load.h" -- 1.5.6.5

15 years, 1 month

PATCH: support for PRACK and UPDATE methods

by Ovidiu Sas

Here's a small patch that will add support for PRACK and UPDATE parsing. Some modules in k require this. Regards, Ovidiu Sas $ git diff diff --git a/parser/msg_parser.h b/parser/msg_parser.h index 48790c9..d1c6324 100644 --- a/parser/msg_parser.h +++ b/parser/msg_parser.h @@ -79,7 +79,8 @@ enum request_method { METHOD_UNDEF=0, METHOD_INVITE=1, METHOD_CANCEL=2, METHOD_ACK=4, METHOD_BYE=8, METHOD_INFO=16, METHOD_REGISTER=32, METHOD_SUBSCRIBE=64, METHOD_NOTIFY=128, METHOD_MESSAGE=256, METHOD_OPTIONS=512, - METHOD_OTHER=1024 }; + METHOD_PRACK=1024, METHOD_UPDATE=2048, + METHOD_OTHER=4096 }; #define FL_FORCE_RPORT (1 << 0) /* force rport */ #define FL_FORCE_ACTIVE (1 << 1) /* force active SDP */ diff --git a/parser/parse_fline.c b/parser/parse_fline.c index e234835..81b235f 100644 --- a/parser/parse_fline.c +++ b/parser/parse_fline.c @@ -125,6 +125,8 @@ char* parse_first_line(char* buffer, unsigned int len, struct msg_start * fl) else IFISMETHOD( NOTIFY, 'N') else IFISMETHOD( MESSAGE, 'M') else IFISMETHOD( OPTIONS, 'O') + else IFISMETHOD( PRACK, 'P') + else IFISMETHOD( UPDATE, 'U') /* if you want to add another method XXX, include METHOD_XXX in H-file (this is the value which you will take later in processing and define XXX_LEN as length of method name; diff --git a/parser/parse_fline.h b/parser/parse_fline.h index f8b3e06..aae71a4 100644 --- a/parser/parse_fline.h +++ b/parser/parse_fline.h @@ -60,6 +60,8 @@ #define NOTIFY_LEN 6 #define MESSAGE_LEN 7 #define OPTIONS_LEN 7 +#define PRACK_LEN 5 +#define UPDATE_LEN 6 struct msg_start { int type; /* Type of the Message - Request/Response */

15 years, 1 month

git:master: Teach the parser recognize PRACK and UPDATE methods

by Jan Janak

Module: sip-router Branch: master Commit: 74ca8909a3b2ffd7a26a3cb10b0422f2cccd17d7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=74ca890… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Jan Janak <jan(a)iptel.org> Date: Mon Mar 23 20:09:40 2009 +0100 Teach the parser recognize PRACK and UPDATE methods Signed-off-by: Jan Janak <jan(a)iptel.org> --- parser/msg_parser.h | 2 +- parser/parse_fline.c | 2 ++ parser/parse_fline.h | 2 ++ 3 files changed, 5 insertions(+), 1 deletions(-) diff --git a/parser/msg_parser.h b/parser/msg_parser.h index 624c2ab..af85f21 100644 --- a/parser/msg_parser.h +++ b/parser/msg_parser.h @@ -79,7 +79,7 @@ enum request_method { METHOD_UNDEF=0, METHOD_INVITE=1, METHOD_CANCEL=2, METHOD_ACK=4, METHOD_BYE=8, METHOD_INFO=16, METHOD_REGISTER=32, METHOD_SUBSCRIBE=64, METHOD_NOTIFY=128, METHOD_MESSAGE=256, METHOD_OPTIONS=512, - METHOD_OTHER=1024 }; + METHOD_PRACK=1024, METHOD_UPDATE=2048, METHOD_OTHER=4096 }; #define FL_FORCE_RPORT (1 << 0) /* force rport */ #define FL_FORCE_ACTIVE (1 << 1) /* force active SDP */ diff --git a/parser/parse_fline.c b/parser/parse_fline.c index e234835..81b235f 100644 --- a/parser/parse_fline.c +++ b/parser/parse_fline.c @@ -125,6 +125,8 @@ char* parse_first_line(char* buffer, unsigned int len, struct msg_start * fl) else IFISMETHOD( NOTIFY, 'N') else IFISMETHOD( MESSAGE, 'M') else IFISMETHOD( OPTIONS, 'O') + else IFISMETHOD( PRACK, 'P') + else IFISMETHOD( UPDATE, 'U') /* if you want to add another method XXX, include METHOD_XXX in H-file (this is the value which you will take later in processing and define XXX_LEN as length of method name; diff --git a/parser/parse_fline.h b/parser/parse_fline.h index f8b3e06..aae71a4 100644 --- a/parser/parse_fline.h +++ b/parser/parse_fline.h @@ -60,6 +60,8 @@ #define NOTIFY_LEN 6 #define MESSAGE_LEN 7 #define OPTIONS_LEN 7 +#define PRACK_LEN 5 +#define UPDATE_LEN 6 struct msg_start { int type; /* Type of the Message - Request/Response */

15 years, 1 month

git:master: Kamailio compatiblity: Added pointer to a free function to tm callbacks

by Jan Janak

Module: sip-router Branch: master Commit: 657f117b853f8a33677ad0f4ffb482e6e25296fc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=657f117… Author: Jan Janak <jan(a)iptel.org> Committer: Jan Janak <jan(a)iptel.org> Date: Mon Mar 23 15:04:41 2009 +0100 Kamailio compatiblity: Added pointer to a free function to tm callbacks This patch adds a new pointer to the tm_callback structure. The parameter contains pointer to a function which, if not NULL, will be called to dispose the callback parameter when it is not needed anymore. This is useful if the parameter given ti a transaction callback is a complex data structure of it is stored on the heap and the memory needs to be free when the corresponding transaction is being destroyed. Patch contributed by Ovidiu Sas. --- modules/tm/dlg.c | 2 +- modules/tm/h_table.c | 3 +++ modules/tm/t_hooks.c | 9 ++++++--- modules/tm/t_hooks.h | 13 ++++++++++--- modules/tm/uac.c | 3 ++- 5 files changed, 22 insertions(+), 8 deletions(-) diff --git a/modules/tm/dlg.c b/modules/tm/dlg.c index 1daab19..10429a9 100644 --- a/modules/tm/dlg.c +++ b/modules/tm/dlg.c @@ -126,7 +126,7 @@ int register_dlg_tmcb(int types, dlg_t* dlg, transaction_cb f, void* param) LOG(L_CRIT, "BUG: tm: register_dlg_tmcb: null callback function"); return E_BUG; } - return insert_tmcb(&dlg->dlg_callbacks, types, f, param); + return insert_tmcb(&dlg->dlg_callbacks, types, f, param, NULL); } diff --git a/modules/tm/h_table.c b/modules/tm/h_table.c index 6b38496..11fb1a8 100644 --- a/modules/tm/h_table.c +++ b/modules/tm/h_table.c @@ -141,6 +141,9 @@ void free_cell( struct cell* dead_cell ) for( cbs=(struct tm_callback*)dead_cell->tmcb_hl.first ; cbs ; ) { cbs_tmp = cbs; cbs = cbs->next; + if (cbs_tmp->release) { + cbs_tmp->release(cbs_tmp->param); + } shm_free_unsafe( cbs_tmp ); } diff --git a/modules/tm/t_hooks.c b/modules/tm/t_hooks.c index 788172a..6e149ea 100644 --- a/modules/tm/t_hooks.c +++ b/modules/tm/t_hooks.c @@ -117,7 +117,8 @@ void destroy_tmcb_lists() /* lockless insert: should be always safe */ int insert_tmcb(struct tmcb_head_list *cb_list, int types, - transaction_cb f, void *param ) + transaction_cb f, void *param, + release_tmcb_param rel_func) { struct tm_callback *cbp; struct tm_callback *old; @@ -133,6 +134,7 @@ int insert_tmcb(struct tmcb_head_list *cb_list, int types, /* ... and fill it up */ cbp->callback = f; cbp->param = param; + cbp->release = rel_func; cbp->types = types; cbp->id=0; old=(struct tm_callback*)cb_list->first; @@ -164,7 +166,8 @@ int insert_tmcb(struct tmcb_head_list *cb_list, int types, * from mod_init (before forking!). */ int register_tmcb( struct sip_msg* p_msg, struct cell *t, int types, - transaction_cb f, void *param ) + transaction_cb f, void *param, + release_tmcb_param rel_func) { //struct cell* t; struct tmcb_head_list *cb_list; @@ -217,7 +220,7 @@ int register_tmcb( struct sip_msg* p_msg, struct cell *t, int types, cb_list = &(t->tmcb_hl); } - return insert_tmcb( cb_list, types, f, param ); + return insert_tmcb( cb_list, types, f, param, rel_func ); } diff --git a/modules/tm/t_hooks.h b/modules/tm/t_hooks.h index 38721fb..b396737 100644 --- a/modules/tm/t_hooks.h +++ b/modules/tm/t_hooks.h @@ -385,9 +385,12 @@ do{ \ /* callback function prototype */ typedef void (transaction_cb) (struct cell* t, int type, struct tmcb_params*); +/*! \brief function to release the callback param */ +typedef void (release_tmcb_param) (void* param); /* register callback function prototype */ typedef int (*register_tmcb_f)(struct sip_msg* p_msg, struct cell *t, - int cb_types, transaction_cb f, void *param); + int cb_types, transaction_cb f, void *param, + release_tmcb_param func); struct tm_callback { @@ -395,6 +398,8 @@ struct tm_callback { int types; /* types of events that trigger the callback*/ transaction_cb* callback; /* callback function */ void *param; /* param to be passed to callback function */ + release_tmcb_param* release; /**< Function to release the callback param + * when the callback is deleted */ struct tm_callback* next; }; @@ -423,11 +428,13 @@ void destroy_tmcb_lists(); /* register a callback for several types of events */ int register_tmcb( struct sip_msg* p_msg, struct cell *t, int types, - transaction_cb f, void *param ); + transaction_cb f, void *param, + release_tmcb_param rel_func); /* inserts a callback into the a callback list */ int insert_tmcb(struct tmcb_head_list *cb_list, int types, - transaction_cb f, void *param ); + transaction_cb f, void *param, + release_tmcb_param rel_func); /* run all transaction callbacks for an event type */ void run_trans_callbacks( int type , struct cell *trans, diff --git a/modules/tm/uac.c b/modules/tm/uac.c index 50089c0..6dfd0fc 100644 --- a/modules/tm/uac.c +++ b/modules/tm/uac.c @@ -319,7 +319,8 @@ static inline int t_uac_prepare(uac_req_t *uac_r, /* Register the callbacks after everything is successful and nothing can fail. Otherwise the callback parameter would be freed twise, once from TMCB_DESTROY, and again because of the negative return code. */ - if(uac_r->cb && insert_tmcb(&(new_cell->tmcb_hl), uac_r->cb_flags, *(uac_r->cb), uac_r->cbp)!=1){ + if(uac_r->cb && insert_tmcb(&(new_cell->tmcb_hl), uac_r->cb_flags, + *(uac_r->cb), uac_r->cbp, NULL)!=1){ ret=E_OUT_OF_MEM; LOG(L_ERR, "t_uac: short of tmcb shmem\n"); goto error1;

15 years, 1 month

git:master: Kamailio compatiblity: Added pointer to a free function to tm callbacks

by Jan Janak

Module: sip-router Branch: master Commit: f971c09ff103cfe61bbf8bf930905432ca528b95 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f971c09… Author: Jan Janak <jan(a)iptel.org> Committer: Jan Janak <jan(a)iptel.org> Date: Mon Mar 23 15:04:41 2009 +0100 Kamailio compatiblity: Added pointer to a free function to tm callbacks This patch adds a new pointer to the tm_callback structure. The parameter contains pointer to a function which, if not NULL, will be called to dispose the callback parameter when it is not needed anymore. This is useful if the parameter given ti a transaction callback is a complex data structure of it is stored on the heap and the memory needs to be free when the corresponding transaction is being destroyed. Patch contributed by Ovidiu Sas. --- modules/tm/h_table.c | 3 +++ modules/tm/t_hooks.c | 9 ++++++--- modules/tm/t_hooks.h | 13 ++++++++++--- modules/tm/uac.c | 3 ++- 4 files changed, 21 insertions(+), 7 deletions(-) diff --git a/modules/tm/h_table.c b/modules/tm/h_table.c index 6b38496..11fb1a8 100644 --- a/modules/tm/h_table.c +++ b/modules/tm/h_table.c @@ -141,6 +141,9 @@ void free_cell( struct cell* dead_cell ) for( cbs=(struct tm_callback*)dead_cell->tmcb_hl.first ; cbs ; ) { cbs_tmp = cbs; cbs = cbs->next; + if (cbs_tmp->release) { + cbs_tmp->release(cbs_tmp->param); + } shm_free_unsafe( cbs_tmp ); } diff --git a/modules/tm/t_hooks.c b/modules/tm/t_hooks.c index 788172a..6e149ea 100644 --- a/modules/tm/t_hooks.c +++ b/modules/tm/t_hooks.c @@ -117,7 +117,8 @@ void destroy_tmcb_lists() /* lockless insert: should be always safe */ int insert_tmcb(struct tmcb_head_list *cb_list, int types, - transaction_cb f, void *param ) + transaction_cb f, void *param, + release_tmcb_param rel_func) { struct tm_callback *cbp; struct tm_callback *old; @@ -133,6 +134,7 @@ int insert_tmcb(struct tmcb_head_list *cb_list, int types, /* ... and fill it up */ cbp->callback = f; cbp->param = param; + cbp->release = rel_func; cbp->types = types; cbp->id=0; old=(struct tm_callback*)cb_list->first; @@ -164,7 +166,8 @@ int insert_tmcb(struct tmcb_head_list *cb_list, int types, * from mod_init (before forking!). */ int register_tmcb( struct sip_msg* p_msg, struct cell *t, int types, - transaction_cb f, void *param ) + transaction_cb f, void *param, + release_tmcb_param rel_func) { //struct cell* t; struct tmcb_head_list *cb_list; @@ -217,7 +220,7 @@ int register_tmcb( struct sip_msg* p_msg, struct cell *t, int types, cb_list = &(t->tmcb_hl); } - return insert_tmcb( cb_list, types, f, param ); + return insert_tmcb( cb_list, types, f, param, rel_func ); } diff --git a/modules/tm/t_hooks.h b/modules/tm/t_hooks.h index 38721fb..b396737 100644 --- a/modules/tm/t_hooks.h +++ b/modules/tm/t_hooks.h @@ -385,9 +385,12 @@ do{ \ /* callback function prototype */ typedef void (transaction_cb) (struct cell* t, int type, struct tmcb_params*); +/*! \brief function to release the callback param */ +typedef void (release_tmcb_param) (void* param); /* register callback function prototype */ typedef int (*register_tmcb_f)(struct sip_msg* p_msg, struct cell *t, - int cb_types, transaction_cb f, void *param); + int cb_types, transaction_cb f, void *param, + release_tmcb_param func); struct tm_callback { @@ -395,6 +398,8 @@ struct tm_callback { int types; /* types of events that trigger the callback*/ transaction_cb* callback; /* callback function */ void *param; /* param to be passed to callback function */ + release_tmcb_param* release; /**< Function to release the callback param + * when the callback is deleted */ struct tm_callback* next; }; @@ -423,11 +428,13 @@ void destroy_tmcb_lists(); /* register a callback for several types of events */ int register_tmcb( struct sip_msg* p_msg, struct cell *t, int types, - transaction_cb f, void *param ); + transaction_cb f, void *param, + release_tmcb_param rel_func); /* inserts a callback into the a callback list */ int insert_tmcb(struct tmcb_head_list *cb_list, int types, - transaction_cb f, void *param ); + transaction_cb f, void *param, + release_tmcb_param rel_func); /* run all transaction callbacks for an event type */ void run_trans_callbacks( int type , struct cell *trans, diff --git a/modules/tm/uac.c b/modules/tm/uac.c index 50089c0..6dfd0fc 100644 --- a/modules/tm/uac.c +++ b/modules/tm/uac.c @@ -319,7 +319,8 @@ static inline int t_uac_prepare(uac_req_t *uac_r, /* Register the callbacks after everything is successful and nothing can fail. Otherwise the callback parameter would be freed twise, once from TMCB_DESTROY, and again because of the negative return code. */ - if(uac_r->cb && insert_tmcb(&(new_cell->tmcb_hl), uac_r->cb_flags, *(uac_r->cb), uac_r->cbp)!=1){ + if(uac_r->cb && insert_tmcb(&(new_cell->tmcb_hl), uac_r->cb_flags, + *(uac_r->cb), uac_r->cbp, NULL)!=1){ ret=E_OUT_OF_MEM; LOG(L_ERR, "t_uac: short of tmcb shmem\n"); goto error1;

15 years, 1 month

git:janakj/kcore: Use next_sibling_hdr to obtain next header with same type

by Jan Janak

Module: sip-router Branch: janakj/kcore Commit: fc75032e611db1d6611a0c7806a15d6a16dd9967 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fc75032… Author: Jan Janak <jan(a)iptel.org> Committer: Jan Janak <jan(a)iptel.org> Date: Mon Mar 23 13:48:29 2009 +0100 Use next_sibling_hdr to obtain next header with same type --- lib/kcore/parser_helpers.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/lib/kcore/parser_helpers.c b/lib/kcore/parser_helpers.c index fbfc5a0..e769160 100644 --- a/lib/kcore/parser_helpers.c +++ b/lib/kcore/parser_helpers.c @@ -112,10 +112,7 @@ int print_rr_body(struct hdr_field *iroute, str *oroute, int order, p = p->next; } - for(iroute = iroute->next; iroute; iroute = iroute->next) { - if (iroute->type == HDR_ROUTE_T) break; - } -/* iroute = iroute->sibling; */ + iroute = next_sibling_hdr(iroute); } for(i=0;i<n;i++){

15 years, 1 month

← Newer
1
2
3
4
5
6
7
8
9
...
19
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2009