sr-dev December 2008

sr-dev@lists.kamailio.org

11 participants
70 discussions

by Daniel-Constantin Mierla

Hello, I couldn't get the message with a final decision regarding the library naming scheme. Andrei used libsr_xyz at some point, I also like this one. Henning committed directly lib/trie in his branch. I will look soon to make the library out of mi, thinking of: libsr_kmi or libsr_mi, depending or not whether we want to mark the origin. So, two things to decide: - do we stick to libsr_ as prefix to all new libraries included in srouter? - do we want to mark the origin of the library? Short term, might be good as pattern to know what is required for k version of the module. This can be fixed with good documentation. Long term the name might look strange. Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com

15 years, 4 months

AVPs

by Daniel-Constantin Mierla

Hello, I think we need to decide about AVPs. Although not deeply investigated, ser seems to have couple of AVPs lists. In kamailio/openser it is one list. Can a ser developer describe a bit the AVP implementation as it is now there? In openser/kamailio we have more or less same architecture as for ser 0.9.6 with couple extensions, but I will detail here so we can have full picture: - avps are kept in shared memory - they are bound to each sip message and moved to transaction if that message create a transaction - avp can have two types of names - integer id, referred as $avp(i:number) - string id, referred as $avp(s:string) - there can be aliases for avp names, defined as "alias=[is]:id", so the script writer can use $avp(alias) - a value of an avp can be either integer or string - not related to avp core part, but important to mention here -- tm, controlled by a parameter, can make the avps from transaction (request) available to onreply_route. Also, just to have in mind, for the future we got into discussion: - moving from linked list to a structure that allows faster search (e.g., hash table) as number of used avps can be big some times - adding support for structure-like values (the value to be another list of (name,value) pairs). A typical use case is serial forking, where one needs to store data in avps. If for one destination an avp is missing, things get screwed. Example: $avp(uri) = {A, B, C} $avp(RPID) = {X, not needed, Y} Internally will look like: $avp(uri) = {A, B, C} $avp(RPID) = {X, Y} So actually, Y will be used for destination B. Workarounds are possible, or course, but maybe we can do it nicer. so it will be like: $avp(dst) = {{u=A,r=Y}, {u=B},{u=C,r=Y}} A possibility to specify the access is $avp(d:dst=>u) Finally, as pointed in another email, it is about making possible to hold "value null" (a mark/flag) and differentiate that from "undefined" (not existing). Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com

15 years, 4 months

git:ser_core_cvs: doc: tcp tunning update

by Andrei Pelinescu-Onciul

Module: sip-router Branch: ser_core_cvs Commit: 67e3e42ea4ad48ec225233a32e0c8c36fdba7bc4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=67e3e42… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Dec 16 14:30:48 2008 +0000 doc: tcp tunning update - update with epoll tunning for kernels >= 2.6.27.8 Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> --- doc/tcp_tunning.txt | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/doc/tcp_tunning.txt b/doc/tcp_tunning.txt index 975e793..b383a42 100644 --- a/doc/tcp_tunning.txt +++ b/doc/tcp_tunning.txt @@ -55,6 +55,10 @@ fs.file-max - maximum number of fds that will be allocated 1.5 other sysctl that might affect tcp connection rate or the maximum number of open connections +fs.epoll.max_user_instances - maximum number of devices - per user (2.6.27.8+) +fs.epoll.max_user_watches - maximum number of "watched" fds - per user + (2.6.27.8+) + iptables - remove the ip_conntrack module (it limits the maximum tcp connections, adds extra overhead (slow)). It's probably better to remove all the iptables modules.

15 years, 4 months

git:ser_core_cvs: core: fix build on Darwin

by Andrei Pelinescu-Onciul

Module: sip-router Branch: ser_core_cvs Commit: 8a2ca52622339af82946df172a3300d0b38297d7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8a2ca52… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Dec 16 14:34:04 2008 +0000 core: fix build on Darwin Author: Alfred Heggestad <aeh(a)db.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> --- ip_addr.c | 2 +- ip_addr.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ip_addr.c b/ip_addr.c index e17a69d..3efdeb9 100644 --- a/ip_addr.c +++ b/ip_addr.c @@ -190,7 +190,7 @@ int is_mcast(struct ip_addr* ip) return IN_MULTICAST(htonl(ip->u.addr32[0])); #ifdef USE_IPV6 } else if (ip->af==AF_INET6){ - return IN6_IS_ADDR_MULTICAST(&ip->u.addr32[0]); + return IN6_IS_ADDR_MULTICAST((struct in6_addr*)ip->u.addr32); #endif /* USE_IPV6 */ } else { LOG(L_ERR, "ERROR: is_mcast: Unsupported protocol family\n"); diff --git a/ip_addr.h b/ip_addr.h index 6849a87..fdaf6f3 100644 --- a/ip_addr.h +++ b/ip_addr.h @@ -242,7 +242,7 @@ inline static int ip_addr_loopback(struct ip_addr* ip) return ip->u.addr32[0]==htonl(INADDR_LOOPBACK); #ifdef USE_IPV6 else if (ip->af==AF_INET6) - return IN6_IS_ADDR_LOOPBACK(&ip->u.addr32[0]); + return IN6_IS_ADDR_LOOPBACK((struct in6_addr*)ip->u.addr32); #endif /* USE_IPV6 */ return 0; }

15 years, 4 months

git:ser_core_cvs: dns: fix build warnings when compiling without ipv6

by Andrei Pelinescu-Onciul

Module: sip-router Branch: ser_core_cvs Commit: 476e1991ab3daaf66d2053cebcb8f00967fe5633 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=476e199… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Dec 16 14:35:55 2008 +0000 dns: fix build warnings when compiling without ipv6 Author: Vance Shipley <vances(a)motivity.ca> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> --- resolve.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/resolve.h b/resolve.h index 76f3903..4b702ec 100644 --- a/resolve.h +++ b/resolve.h @@ -337,9 +337,11 @@ static inline struct hostent* _resolvehost(char* name) { static struct hostent* he=0; #ifdef HAVE_GETIPNODEBYNAME +#ifdef USE_IPV6 int err; static struct hostent* he2=0; #endif +#endif #ifndef DNS_IP_HACK #ifdef USE_IPV6 int len;

15 years, 4 months

git:ser_core_cvs: tcp: fix for async write

by Andrei Pelinescu-Onciul

Module: sip-router Branch: ser_core_cvs Commit: 74c6d2807c6ecf59f8efad22cfddfd27e4fadfc2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=74c6d28… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Dec 12 23:02:45 2008 +0000 tcp: fix for async write - fixed bug in _wbufq_add() which caused packet corruption when multiple packets with size < default buffer size where queued. Reported-by: Vaclav Kubart, vaclav.kubart at iptel org Tested-by: Vaclav Kubart, vaclav.kubart at iptel org --- tcp_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcp_main.c b/tcp_main.c index e26685a..6a6e27a 100644 --- a/tcp_main.c +++ b/tcp_main.c @@ -648,7 +648,7 @@ inline static int _wbufq_add(struct tcp_connection* c, char* data, last_free=wb->b_size; } crt_size=MIN_unsigned(last_free, size); - memcpy(wb->buf, data, crt_size); + memcpy(wb->buf+q->last_used, data, crt_size); q->last_used+=crt_size; size-=crt_size; data+=crt_size;

15 years, 4 months

git:ser_core_cvs: sctp: SO_REUSEADDR on the sctp sockets

by Andrei Pelinescu-Onciul

Module: sip-router Branch: ser_core_cvs Commit: 235631a00531fd84d8ddb3ba72ed815b22ea647e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=235631a… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Dec 12 23:25:39 2008 +0000 sctp: SO_REUSEADDR on the sctp sockets Reported-by: Michal Matyska, michal.matyska at iptel org --- sctp_server.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/sctp_server.c b/sctp_server.c index 4a30954..7ac8444 100644 --- a/sctp_server.c +++ b/sctp_server.c @@ -216,6 +216,15 @@ static int sctp_init_sock_opt_common(int s) } } + /* set reuseaddr */ + if (setsockopt(s, SOL_SOCKET, SO_REUSEADDR, + (void*)&optval, sizeof(optval))==-1){ + LOG(L_ERR, "ERROR: sctp_init_sock_opt_common: setsockopt:" + " SO_REUSEADDR (%d): %s\n", optval, strerror(errno)); + /* continue, non-critical */ + } + + /* disable fragments interleave (SCTP_FRAGMENT_INTERLEAVE) -- * we don't want partial delivery, so fragment interleave must be off too */

15 years, 4 months

git:ser_core_cvs: another switch where PROTO_SCTP was missing - added case

by Andrei Pelinescu-Onciul

Module: sip-router Branch: ser_core_cvs Commit: e4c9fe9a983a8825a342ed085565a9fc15abeeea URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e4c9fe9… Author: Michal Matyska <michal.matyska(a)iptel.org> Committer: Michal Matyska <michal.matyska(a)iptel.org> Date: Thu Dec 11 19:12:41 2008 +0000 another switch where PROTO_SCTP was missing - added case --- dns_cache.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dns_cache.c b/dns_cache.c index 14598e0..9a53fe4 100644 --- a/dns_cache.c +++ b/dns_cache.c @@ -3014,6 +3014,12 @@ inline static int dns_srv_sip_resolve(struct dns_srv_handle* h, str* name, tmp[SRV_TLS_PREFIX_LEN + name->len] = '\0'; len=SRV_TLS_PREFIX_LEN + name->len; break; + case PROTO_SCTP: + memcpy(tmp, SRV_SCTP_PREFIX, SRV_SCTP_PREFIX_LEN); + memcpy(tmp+SRV_SCTP_PREFIX_LEN, name->s, name->len); + tmp[SRV_SCTP_PREFIX_LEN + name->len] = '\0'; + len=SRV_SCTP_PREFIX_LEN + name->len; + break; default: LOG(L_CRIT, "BUG: sip_resolvehost: " "unknown proto %d\n", (int)srv_proto);

15 years, 4 months

git:ser_core_cvs: sctp protocol decoded in RPC dst_blacklist.view

by Andrei Pelinescu-Onciul

Module: sip-router Branch: ser_core_cvs Commit: 1acade4541c8665f11800677f0ffe9ebf8608194 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1acade4… Author: Michal Matyska <michal.matyska(a)iptel.org> Committer: Michal Matyska <michal.matyska(a)iptel.org> Date: Tue Dec 9 14:09:22 2008 +0000 sctp protocol decoded in RPC dst_blacklist.view so it does not show unknown protocol anymore --- dst_blacklist.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dst_blacklist.c b/dst_blacklist.c index 3464517..bb6e35e 100644 --- a/dst_blacklist.c +++ b/dst_blacklist.c @@ -879,6 +879,8 @@ static char* get_proto_name(unsigned char proto) return "tcp"; case PROTO_TLS: return "tls"; + case PROTO_SCTP: + return "sctp"; default: return "unknown"; }

15 years, 4 months

git:ser_core_cvs: update RPM spec file

by Andrei Pelinescu-Onciul

Module: sip-router Branch: ser_core_cvs Commit: c30d78cac2aa90f706c0c61f8551795cb877693c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c30d78c… Author: Alfred E. Heggestad <aeh(a)db.org> Committer: Alfred E. Heggestad <aeh(a)db.org> Date: Sat Dec 6 21:49:27 2008 +0000 update RPM spec file --- pkg/rpm/ser.spec-4.1 | 28 ++++++++++++++++++++-------- 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/pkg/rpm/ser.spec-4.1 b/pkg/rpm/ser.spec-4.1 index 833afcd..83e26a8 100644 --- a/pkg/rpm/ser.spec-4.1 +++ b/pkg/rpm/ser.spec-4.1 @@ -1,8 +1,8 @@ %define name ser %define ver 2.1.0 -%define rel 1 +%define rel dev23b -%define EXCLUDED_MODULES mysql jabber auth_radius group_radius uri_radius postgres snmp cpl cpl-c extcmd +%define EXCLUDED_MODULES mysql jabber auth_radius group_radius uri_radius postgres snmp cpl cpl-c extcmd ldap %define MYSQL_MODULES mysql %define JABBER_MODULES jabber %define RADIUS_MODULES auth_radius group_radius uri_radius @@ -69,7 +69,7 @@ The ser-jabber package contains a sip to jabber message translator. %setup -n %{name}-%{ver}-%{rel} %build -make all skip_modules="%EXCLUDED_MODULES" cfg-target=/%{_sysconfdir}/ser/ +make all include_modules="tls" skip_modules="%EXCLUDED_MODULES" cfg-target=/%{_sysconfdir}/ser/ make modules modules="modules/%MYSQL_MODULES" cfg-target=/%{_sysconfdir}/ser/ make modules modules="modules/%JABBER_MODULES" cfg-target=/%{_sysconfdir}/ser/ make modules modules="%RADIUS_MOD_PATH" cfg-target=/%{_sysconfdir}/ser/ @@ -78,7 +78,7 @@ make modules modules="%RADIUS_MOD_PATH" cfg-target=/%{_sysconfdir}/ser/ %install [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf "$RPM_BUILD_ROOT" -make install skip_modules="%EXCLUDED_MODULES" \ +make install include_modules="tls" skip_modules="%EXCLUDED_MODULES" \ basedir=$RPM_BUILD_ROOT \ prefix=/usr \ cfg-prefix=$RPM_BUILD_ROOT \ @@ -137,18 +137,21 @@ fi %doc %{_docdir}/ser/INSTALL %doc %{_docdir}/ser/README %doc %{_docdir}/ser/README-MODULES +%doc %{_docdir}/ser/README.acc_syslog %doc %{_docdir}/ser/README.auth %doc %{_docdir}/ser/README.auth_db %doc %{_docdir}/ser/README.avp %doc %{_docdir}/ser/README.avp_db -%doc %{_docdir}/ser/README.avpops -%doc %{_docdir}/ser/README.dbtext +%doc %{_docdir}/ser/README.cfg_db %doc %{_docdir}/ser/README.db_ops %doc %{_docdir}/ser/README.dispatcher %doc %{_docdir}/ser/README.diversion %doc %{_docdir}/ser/README.domain %doc %{_docdir}/ser/README.enum +%doc %{_docdir}/ser/README.eval %doc %{_docdir}/ser/README.exec +%doc %{_docdir}/ser/README.flatstore +%doc %{_docdir}/ser/README.gflags %doc %{_docdir}/ser/README.lcr %doc %{_docdir}/ser/README.maxfwd %doc %{_docdir}/ser/README.msilo @@ -161,11 +164,13 @@ fi %doc %{_docdir}/ser/README.ratelimit %doc %{_docdir}/ser/README.registrar %doc %{_docdir}/ser/README.rr +%doc %{_docdir}/ser/README.sanity %doc %{_docdir}/ser/README.sl %doc %{_docdir}/ser/README.sms %doc %{_docdir}/ser/README.speeddial %doc %{_docdir}/ser/README.textops %doc %{_docdir}/ser/README.timer +%doc %{_docdir}/ser/README.tls %doc %{_docdir}/ser/README.tm %doc %{_docdir}/ser/README.uac %doc %{_docdir}/ser/README.uri @@ -178,21 +183,26 @@ fi %config %{_sysconfdir}/rc.d/init.d/* %dir %{_libdir}/ser +%{_libdir}/ser/libser_cds.so +%{_libdir}/ser/libser_cds.so.0 +%{_libdir}/ser/libser_cds.so.0.1 %dir %{_libdir}/ser/modules %{_libdir}/ser/modules/acc_db.so %{_libdir}/ser/modules/acc_syslog.so %{_libdir}/ser/modules/auth.so %{_libdir}/ser/modules/auth_db.so %{_libdir}/ser/modules/avp.so -%{_libdir}/ser/modules/avpops.so %{_libdir}/ser/modules/avp_db.so +%{_libdir}/ser/modules/blst.so +%{_libdir}/ser/modules/cfg_db.so +%{_libdir}/ser/modules/cfg_rpc.so %{_libdir}/ser/modules/ctl.so %{_libdir}/ser/modules/db_ops.so -%{_libdir}/ser/modules/dbtext.so %{_libdir}/ser/modules/dispatcher.so %{_libdir}/ser/modules/diversion.so %{_libdir}/ser/modules/domain.so %{_libdir}/ser/modules/enum.so +%{_libdir}/ser/modules/eval.so %{_libdir}/ser/modules/exec.so %{_libdir}/ser/modules/fifo.so %{_libdir}/ser/modules/flatstore.so @@ -216,6 +226,7 @@ fi %{_libdir}/ser/modules/speeddial.so %{_libdir}/ser/modules/textops.so %{_libdir}/ser/modules/timer.so +%{_libdir}/ser/modules/tls.so %{_libdir}/ser/modules/tm.so %{_libdir}/ser/modules/uac.so %{_libdir}/ser/modules/uri.so @@ -237,6 +248,7 @@ fi %{_libdir}/ser/modules/mysql.so %{_sbindir}/ser_mysql.sh +/usr/share/ser/*.sql %files jabber %defattr(-,root,root)

15 years, 4 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2008