[sr-dev] [kamailio/kamailio] Extend get pcontact (#2426)

[Henning Westerholt]

@henningw commented on this pull request.



> @@ -76,6 +76,7 @@ extern usrloc_api_t ul;
 extern struct tm_binds tmb;
 
 #define IPSEC_SEND_FORCE_SOCKET		0x01 /* if set - set send force socket for request messages */
+#define IPSEC_REVERSE_SEARCH		0x02 /* if set - start seraching from the last element */

small spelling issue - searching

> @@ -196,10 +196,24 @@ static inline int update_contacts(struct sip_msg *req,struct sip_msg *rpl, udoma
 							ci.searchflag = SEARCH_RECEIVED;
 						}
 					}
-				} 
+				} else {
+					char* srcip = NULL;
+					if((srcip = pkg_malloc(50)) == NULL) {

It is necessary to allocate new pkg memory here? The save_pending function just uses a char[50] array for a somewhat similar logic. Just wondered. :-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2426#pullrequestreview-462728452
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20200806/8c79bbad/attachment.htm>