<p></p>
<p><b>@henningw</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2426#discussion_r466570187">src/modules/ims_ipsec_pcscf/cmd.c</a>:</p>
<pre style='color:#555'>> @@ -76,6 +76,7 @@ extern usrloc_api_t ul;
 extern struct tm_binds tmb;
 
 #define IPSEC_SEND_FORCE_SOCKET                0x01 /* if set - set send force socket for request messages */
+#define IPSEC_REVERSE_SEARCH           0x02 /* if set - start seraching from the last element */
</pre>
<p>small spelling issue - searching</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2426#discussion_r466571622">src/modules/ims_registrar_pcscf/save.c</a>:</p>
<pre style='color:#555'>> @@ -196,10 +196,24 @@ static inline int update_contacts(struct sip_msg *req,struct sip_msg *rpl, udoma
                                                        ci.searchflag = SEARCH_RECEIVED;
                                                }
                                        }
-                               } 
+                               } else {
+                                       char* srcip = NULL;
+                                       if((srcip = pkg_malloc(50)) == NULL) {
</pre>
<p>It is necessary to allocate new pkg memory here? The save_pending function just uses a char[50] array for a somewhat similar logic. Just wondered. :-)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2426#pullrequestreview-462728452">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZIQP6CRHFIEULGH2YTR7LRZBANCNFSM4PTIPNLA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZKIKRRFZ2RPFMXFJ6TR7LRZBA5CNFSM4PTIPNLKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODOKK2BA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2426#pullrequestreview-462728452",
"url": "https://github.com/kamailio/kamailio/pull/2426#pullrequestreview-462728452",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>