[OpenSER-Devel] location issues

[Daniel-Constantin Mierla]

On 06/26/08 16:35, Juha Heinanen wrote:
> Daniel-Constantin Mierla writes:
>
>  > - when use_domain is 1 - if '@' is missing from AoR, consider all the 
>  > time to be just the domain, accept to load records with empty
>  > username
>
> i personally don't have a situation where userpart could be empty.
> reading usrloc documentation, i get impression that the module does not
> support the case where userpart is missing, because if use_domain = 1,
> then ALSO domain part is used to identify the user.
>   
I thought the same, but the code reveals something else. AoR in 
registrar module is returned with only domain part when user part is 
missing. As there were many people working with this module, I don't 
remember if it is of some use for someone there, or is just an omission 
of checking if username exists.
>  > A question will be, what happens if a registration is for a domain and 
>  > use_domain=0? Discard the registration request? I don't recall now why 
>  > and when registrations for domains were included, but they might be
>  > useful.
>
> if use_domain=0 and there is no userpart, then there is nothing to
> identify the user, i.e., the registration is not valid.
>   
I agree, so, unless is someone considering otherwise, I will restrict 
that all location records to have user name.

Cheers,
Daniel

> -- juha
>   

-- 
Daniel-Constantin Mierla
http://www.asipto.com