[OpenSER-Devel] location issues

[Klaus Darilion]

Is it useful to have an AoR without username? Maybe AoRs without 
username should be rejected always.

regards
klaus

Daniel-Constantin Mierla schrieb:
> Hello,
> 
> there seems to be an incoherence in dealing with the AoR for location 
> records in conjunction with use_domain 1.
> 
> The save() from registrar function build the aor only from domain part 
> if the user part is missing. However, when loading the records, usrloc 
> module discards the records with empty username or use_domain=1 and 
> empty domain. Moreover, the DB update and delete functions from usrloc 
> expect all the time an @ in AoR when use_domain=1, doing no safe check, 
> causing crashes. DB insert considers the AoR to be the domain when 
> use_domain=1 and there is no @ in AoR.
> 
> I believe the right way to go now is:
> - when use_domain is 1 - if '@' is missing from AoR, consider all the 
> time to be just the domain, accept to load records with empty username
> 
> A question will be, what happens if a registration is for a domain and 
> use_domain=0? Discard the registration request? I don't recall now why 
> and when registrations for domains were included, but they might be useful.
> 
> Any comments?
> 
> Cheers,
> Daniel
>