[OpenSER-Devel] discussion: issues with local_route

[Dan Pascu]

On Tuesday 24 June 2008, Daniel-Constantin Mierla wrote:
> For me it is clear a major internal architecture change as none of my
> (and I spotted same for other parts) code was written with nested
> contexts in mind. I am not going now over all code to make a report,
> just because some code was released in the last minute without
> considering the impact on the rest of the application -- does not pay
> the effort.
>
> I presented sustainable examples and reasons, those might be all or
> there might be lot more  - see dset.{c,h} all that code is not designed
> for nested contexts, time-related PVs have different results, a.s.o.
> Simply I don't have that time to prepare release and re-thinks code
> considered stable for ages.
>
> Again, it is no time for me to check and test all the code I wrote in 8
> years, ...

Nobody asked you to review 8 years of code, though the irony is that you 
said you'd do that yourself when you opened the issue and proposed the 
unfreeze. Anyway, what I asked was to provide one example where the 
local_route breaks functionality in such a way that it cannot be fixed 
without rethinking the design and certainly not during the 1 month bug 
fix period before the release. I figured that since you say that the 
local_route is such a big architectural change with so much impact over 
all code, it wouldn't be hard to find one good example why local_route 
should be disabled in 1.4. Then I would have supported your proposal. But 
so far I've only seen buzzwords about architecture and design, and a few 
examples with bugs that are easy to fix.

Frankly I do not think you make your case if you keep repeating that we 
have big problems, yet you do not provide a clear example that will prove 
beyond any reasonable doubt that claim. All the examples you point back 
to have been since rebutted or have simple fixes.

For me it's obvious at this point that you have a horse to beat and you 
won't stop until it's dead, which makes dialog and working on the issue 
very difficult.

-- 
Dan