[Devel] check_route_param doesn't find all params

[Bogdan-Andrei Iancu]

Hi Juha,

I just committed the change - the leading ";" in including in the 
parameters string. Do you find useful if I export an internal function 
that finds and returns the value of a parameter by actually parsing the 
parameters  string (separates them)? the value may be returned into an 
AVP maybe....

regards,
bogdan


Bogdan-Andrei Iancu wrote:

> Hi Juha,
>
> maybe the best the way to go is to include the first ";" into the 
> param string.... I chose to have only one regexp for all params from 
> two reasons:
>    1) avoid extra C code for parsing/splitting the params and apply 
> regexp matching for each param
>    2) more than one param may be check in the same time.
>
> if there are any other suggestions, please go ahead....
>
> regards,
> bogdan
>
> Juha Heinanen wrote:
>
>> Juha Heinanen writes:
>>
>> > that is the first route param 'pm was NOT found.  i'll start to 
>> read the
>> > code.  perhaps the first ; is skipped.
>>
>> yes, it looks like parse_uri skips the first ";" and puts the rest in
>> params field.  so in my example case params becomes "pm;n1;lr".
>>
>> i don't feel comfortable with regexp matching of check_route_param,
>> because if i omit ";" from ";pm", there is no guarantee that string "pm"
>> doesn't appear as part of some other route param or its value (for
>> example tag value that i don't have any control of).  it would be safer
>> if regexp would match only a single param, not all params as a single
>> string.
>>
>> it would be ok for me to omit regexp matching all together and just
>> match for an exact param name possibly optionally followed by an exact
>> param value.
>>
>> i can live with the current behavior too, but need to be very careful
>> with my checks.
>>
>> -- juha
>>
>> _______________________________________________
>> Devel mailing list
>> Devel at openser.org
>> http://openser.org/cgi-bin/mailman/listinfo/devel
>>
>>  
>>
>
>