[Kamailio-Users] adding a new event package

[Aymeric Moizard]

Hi again,

On Tue, 24 Nov 2009, Daniel-Constantin Mierla wrote:

> Hello,
>
> On 23.11.2009 13:38 Uhr, Aymeric Moizard wrote:
>> 
>> I'm experimenting some modification in kamailio to
>> add support for a new "SIP event package". Unfortunalty,
>> it seems the parser of kamailio and its presence module
>> both are limited to accept:
>> 
>> #define EVENT_OTHER          0
>> #define EVENT_PRESENCE       1
>> #define EVENT_PRESENCE_WINFO 2
>> #define EVENT_SIP_PROFILE    3
>> #define EVENT_XCAP_CHANGE    4
>> #define EVENT_DIALOG         5
>> #define EVENT_MWI            6
>> #define EVENT_DIALOG_SLA     7
>> 
>> If any other module define support for a new event package,
>> the presence module will not accept the subscription and
>> reject it with 489 because it is considered an EVENT_OTHER.
>> 
>> I'm working with 1.5.x branch. Would that be different in
>> newer core?
> it is the same architecture of the presence server implementation, just the 
> event parser from core is slightly different.
>
>> 
>> If I propose to write a patch, would you consider it?
> yes, that would be good. At this time I see you sent already one, I will 
> check.
>> What alternative do I have to add unknown event package
>> as module without modifying the core? Did I missed any
>> key?
>
> The event id is used to identify the records in db, you should take care of 
> that. Probably is better to change it to the string version as it is not a 
> big improvement now, or at least allow easy extensibility without hardcoding 
> values.

Which table from the database are you talking about? In presentity as well 
as watchers, I can see that the "event" is a string.

Have you checked my patch?

Aymeric MOIZARD / ANTISIP
amsip - http://www.antisip.com
osip2 - http://www.osip.org
eXosip2 - http://savannah.nongnu.org/projects/exosip/


> Cheers,
> Daniel
>
>> 
>> Regards,
>> Aymeric MOIZARD / ANTISIP
>> amsip - http://www.antisip.com
>> osip2 - http://www.osip.org
>> eXosip2 - http://savannah.nongnu.org/projects/exosip/
>> 
>> 
>> _______________________________________________
>> Kamailio (OpenSER) - Users mailing list
>> Users at lists.kamailio.org
>> http://lists.kamailio.org/cgi-bin/mailman/listinfo/users
>> http://lists.openser-project.org/cgi-bin/mailman/listinfo/users
>
> -- 
> Daniel-Constantin Mierla
> * http://www.asipto.com/
>
>