[SR-Users] consume_credentials not working on PRACK?

[Daniel-Constantin Mierla]

Hello,

likely the commit was done due to:

  - https://lists.kamailio.org/pipermail/sr-dev/2013-April/019470.html

However, apparently, even not common practice, PRACK can be challenged
for authentication.

Cheers,
Daniel

On 31.10.22 16:13, Henning Westerholt wrote:
> Hello,
>
> this was actually changed some years ago to be like this:
>
>
> commit 2a77ed2bdc9341ecf7d7200e420a1f49e4e9b6ab
> Author: Daniel-Constantin Mierla <miconda at gmail.com>
> Date:   Sun Apr 14 10:11:29 2013 +0200
>
>     auth: skip processing of PRACK in consume_credentials()
>
> The issue probably was that the module logs an error if there are no credentials in the message.
>
> This could be improved e.g. by a pull-request. For now you could just use the remove_hf(..) function.
>
> Cheers,
>
> Henning
>
> -- 
> Henning Westerholt – https://skalatan.de/blog/
> Kamailio services – https://gilawa.com
>
> -----Original Message-----
> From: Benoit Panizzon <benoit.panizzon at imp.ch> 
> Sent: Monday, October 31, 2022 3:50 PM
> To: Henning Westerholt <hw at gilawa.com>
> Cc: Kamailio (SER) - Users Mailing List <sr-users at lists.kamailio.org>
> Subject: Re: [SR-Users] consume_credentials not working on PRACK?
>
> Hi Henning
>
>> Maybe the PRACK is not a new request, but an in-dialog request and therefore is not handled from the code quoted below.
> It is handled:
>
>                 if(!is_method("REGISTER|PUBLISH")) {
>                         consume_credentials();
>                         xlog("L_INFO", "$cfg(route): $rm creds: Mmmmmmh!\n");
>                 }
>
> Log:
>
> [...] 3 PRACK]<script>: AUTH: Authentication successful!
> [...] 3 PRACK]<script>: AUTH: PRACK creds: Mmmmmmh!
>
> Mit freundlichen Grüssen
>
> -Benoît Panizzon-
> -- 
> I m p r o W a r e   A G    -    Leiter Commerce Kunden
> ______________________________________________________
>
> Zurlindenstrasse 29             Tel  +41 61 826 93 00
> CH-4133 Pratteln                Fax  +41 61 826 93 01
> Schweiz                         Web  http://www.imp.ch
> ______________________________________________________
> __________________________________________________________
> Kamailio - Users Mailing List - Non Commercial Discussions
> sr-users at lists.kamailio.org
> Important: keep the mailing list in the recipients, do not reply only to the sender!
> Edit mailing list options or unsubscribe:
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users

-- 
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Online
  Nov 7-10, 2022 (Europe Timezone)
  * https://www.asipto.com/sw/kamailio-advanced-training-online/