[SR-Users] Local messages are malformed in Kamailio 4.4.X

[Daniel-Constantin Mierla]

Hello,

if you haven't changed the tm parameters that refer to reparsing
outgoing requests for building local hop-by-hop messages, then you
should not be affected by the issue reported by Helio Okuyama. The
function that needs to be patched should not used with default values of
tm parameters -- that's the reason I asked Helio to see if those
parameters were changed, to be sure it is no other case when the
function is used with default tm parameters.

Cheers,
Daniel


On 01/12/2016 11:31, Sergey Basov wrote:
> Hello.
>
> I make test, currently on kamailio 4.4.0, but as I see in git - tm
> module does not changes from that time.
> I have normal line termination.
> See a dump in attach.
> in that dump 10.56.41.33 and 10.56.42.33 is the my mhomed kamailio.
> --
> Best regards,
> Sergey Basov                     e-mail: sergey.v.basov at gmail.com
>
> tel: (+38067) 403-62-54
>
>
> 2016-12-01 10:52 GMT+02:00 Daniel-Constantin Mierla <miconda at gmail.com>:
>> Hello,
>>
>> have you set modparams for tm module related to reparsing the invite or on
>> dns failover?
>>
>> The build_local() should be used only in some specific cases and want to be
>> sure it doesn't get executed somehow when it shouldn't be.
>>
>> Cheers,
>> Daniel
>>
>>
>> On 30/11/2016 16:40, Helio Okuyama wrote:
>>
>> Local messages are malformed in Kamailio 4.4.X. For example after receiving
>> an error response (603) to an INVITE message, the ACK is generated with
>> header Max-Forwards concatenated to header CSeq and double CRLF, which is
>> wrong.
>>
>> Via: SIP/2.0/TLS
>> 173.16.10.61:5061;branch=z9hG4bKc782.5b960c7c48a4363a0126963daa797eb0.0;i=7
>> From: "22861"<sip:22861 at 173.16.10.61;transport=tls>;tag=snl_OIPEOzJUNy
>> Call-ID: 61b500a71b510a1Pj61qq1k9dPW
>> To: <sip:551138174108 at 174.16.4.108:5061;transport=tls>;tag=435012226
>> CSeq: 2351 ACKMax-Forwards: 70
>>
>> User-Agent:...
>>
>>
>> The fix for that seems to be just the order of append_str in function
>> build_local() from tm\t_msgbuilder.c.
>>
>> append_str( p, method, method_len );
>> + append_str( p, CRLF, CRLF_LEN );
>> append_str( p, MAXFWD_HEADER, MAXFWD_HEADER_LEN );
>> - append_str( p, CRLF, CRLF_LEN );
>>
>>
>>
>> _______________________________________________
>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
>> sr-users at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
>>
>>
>> --
>> Daniel-Constantin Mierla
>> http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
>> Kamailio Advanced Training, Berlin, Nov 28-30, 2016 - http://www.asipto.com
>>
>>
>> _______________________________________________
>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
>> sr-users at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
>>

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Training, Berlin, Nov 28-30, 2016 - http://www.asipto.com