[SR-Users] why is rtpenengine-delete deleting the whole call?

[Juha Heinanen]

Richard Fuchs writes:

> I have a prospective fix in a separate branch:
> https://github.com/sipwise/rtpengine/tree/rfuchs/delete-branch
> 
> Can you please test it to see if it works for your use case, then I'll 
> merge into master.

Richard,

I had chance to test this branch and it worked as I expected.  With
earlier version these two offers:

... call-id": "2abe9a5db43054dc", "via-branch": "z9hG4bK1b77.e8d0221e5eb3296ab02b6572ffbb5b71.1", "received-from": [ "IP4", "127.0.0.1" ], "from-tag": "9f7bfa64b244d4c9", "command": "offer" }

... "call-id": "2abe9a5db43054dc", "via-branch": "z9hG4bK1b77.e8d0221e5eb3296ab02b6572ffbb5b71.0", "received-from": [ "IP4", "127.0.0.1" ], "from-tag": "9f7bfa64b244d4c9", "command": "offer" }

followed by delete

Dec  3 12:17:53 lohi rtpengine[6019]: [2abe9a5db43054dc] Dump for 'delete' from 127.0.0.1:41419: { "call-id": "2abe9a5db43054dc", "via-branch": "z9hG4bK1b77.e8d0221e5eb3296ab02b6572ffbb5b71.1", "received-from": [ "IP4", "127.0.0.1" ], "from-tag": "9f7bfa64b244d4c9", "command": "delete" }

resulted in this:

Dec  3 12:17:53 lohi rtpengine[6019]: [2abe9a5db43054dc] Scheduling deletion of call branch '9f7bfa64b244d4c9' in 30 seconds

Using the above branch, these two offers

... "call-id": "d07e00c875f64161", "via-branch": "z9hG4bKe298.e03e6127f4e4ac3a82a67f02c6453239.1", "received-from": [ "IP4", "127.0.0.1" ], "from-tag": "74e83539b18d115a", "command": "offer" }

... "call-id": "d07e00c875f64161", "via-branch": "z9hG4bKe298.e03e6127f4e4ac3a82a67f02c6453239.0", "received-from": [ "IP4", "127.0.0.1" ], "from-tag": "74e83539b18d115a", "command": "offer" }

followed by delete:

Dec  3 12:20:44 lohi rtpengine[10306]: [d07e00c875f64161] Dump for 'delete' from 127.0.0.1:51239: { "call-id": "d07e00c875f64161", "via-branch": "z9hG4bKe298.e03e6127f4e4ac3a82a67f02c6453239.1", "received-from": [ "IP4", "127.0.0.1" ], "from-tag": "74e83539b18d115a", "command": "delete" }

results in this:

Dec  3 12:20:44 lohi rtpengine[10306]: [d07e00c875f64161] Scheduling deletion of call branch '' (via-branch 'z9hG4bKe298.e03e6127f4e4ac3a82a67f02c6453239.1') in 30 seconds

i.e., only one branch will be deleted.

Looks like I in parallel forking cases need to use the extra param to
set the branch value.

Thanks,

-- Juha