[SR-Users] Dialog module - db_fetch_rows

[jay binks]

Further to this, I have created a pull request that I think should behave
better.

https://github.com/kamailio/kamailio/pull/295

On 24 August 2015 at 10:06, jay binks <jaybinks at gmail.com> wrote:

> Hey All,
>
> Im just after someone else thoughts on if this is a bug.
>
> After reading :
> http://kamailio.org/docs/modules/3.3.x/modules_k/dialog.html#idp148408
> Im lead to understand that setting *modparam("dialog", "db_fetch_rows",
> 0)*
> should instruct the dialog module to write dialogs to the DB, but not
> bother loading them on startup.   This sounds like what I'm after.
>
> However ever time I set the value to 0, dialogs are still loaded from the
> DB.
>
> a quick dig in the source takes me to the function
>
> select_entire_dialog_table in dlg_db_handler.c
> this chunk of code does not appear to properly implement " if
> fetch_num_rows == 0 then do nothing "
>
> Im after a couple of things from you guys.
>
> a) validation that my understanding of what SHOULD happen is correct
> b) possibly validating that I'm not crazy, and this is actually a bug :)
>
> --
> Sincerely
>
> Jay
>



-- 
Sincerely

Jay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-users/attachments/20150824/2393810c/attachment.html>