[SR-Users] BUG? - Dialog module timeout BYE is not ok.

Sun Nov 10 20:20:23 CET 2013

Hello,

We successful upgraded Kamailio from 3.3 to 4.0.4 and get the problem with
BYE dialog timeout as was in 3.0.1 

Daniel committed a set of patches, that solved the problem (please, see
below in previous mails).

But these patches are not a part of 4.0.4, why?

4e4b1339bfd3a832f5feeb1d2a2380c7455ec82b

57ed79b9d45c29d37c405c3fa582c1d1011a2315
f22dcd559c739dd99275cd2444cf481d458d2fab
ff890a4eee1888ed3e1e080a18bd72124ab99690
aefea5477dc7878d5e818628e04ddcb088fd2858

Thank you,

Julia 

  _____  

From: Daniel-Constantin Mierla [mailto:miconda at gmail.com] 
Sent: Monday, April 29, 2013 3:11 PM
To: Julia; 'Kamailio (SER) - Users Mailing List'
Cc: 'Uri Shacked'
Subject: Re: [SR-Users] BUG? - Dialog module timeout BYE is not ok.

Hello,

there are few follow up patches that you need to get, here are the commits
id:

57ed79b9d45c29d37c405c3fa582c1d1011a2315
f22dcd559c739dd99275cd2444cf481d458d2fab
ff890a4eee1888ed3e1e080a18bd72124ab99690
aefea5477dc7878d5e818628e04ddcb088fd2858

Cheers,
Daniel

On 4/29/13 11:31 AM, Julia wrote:

Thank you,

The patch solves the problem with dlgtimeout BYE (also for chain of proxy
servers), but causes a new one.

Now, OPTIONs from dispatcher module sent with angle brackets, but 200 OK
(received with same format) are ignored by kamailio.

ERROR: dispatcher [dispatch.c:2373]: Setting the state failed
(<sip:xxxxxxxxxxxxxxxx) .

BR,

Julia

  _____  

From: sr-users-bounces at lists.sip-router.org
[mailto:sr-users-bounces at lists.sip-router.org] On Behalf Of
Daniel-Constantin Mierla
Sent: Thursday, April 25, 2013 4:24 PM
To: Uri Shacked
Cc: Kamailio (SER) - Users Mailing List
Subject: Re: [SR-Users] BUG? - Dialog module timeout BYE is not ok.

Here is the link to the patch:

http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blobdiff;f=modul
es/tm/t_msgbuilder.c;h=b5ff3094af2594e62a050ccc56768ad9237eb633;hp=aa0144c84
43760c9e81ee121ef907be812fa9da8;hb=4e4b1339bfd3a832f5feeb1d2a2380c7455ec82b;
hpb=744a8d317b894a1360e3441a9e69ac9190a1745b

You have to add the lines starting with '+' in t_msgbuilder.c -- there are
six.

Not sure it really works replacing the entire file, it is safe to apply the
patch.

Cheers,
Daniel

On 4/25/13 3:17 PM, Uri Shacked wrote:

I have no internet access from my kamailio servers.

where can i download it and install?

or just download the t_msgbuilder.c and reinstall 3.3.2 ?

On Thu, Apr 25, 2013 at 3:55 PM, Daniel-Constantin Mierla
<miconda at gmail.com> wrote:

Hello,

I committed a patch to add angle brackets around From/To URI for local
generated requests. Here is the link to commit:

-
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4e4b1339
bfd3a832f5feeb1d2a2380c7455ec82b

No time to test it, so give it a try. If you are using 4.0 (even 3.3) should
work by just cherry-picking. Let me know if works fine.

Depending on feedback will be part of 4.0.1 (out in few hours), or let to be
backported for 4.0.2.

Cheers,
Daniel 

On 4/25/13 2:23 PM, Uri Shacked wrote:

Hi,

As i wrote, when the BYE is "normal" not generated form dlg_timeout. srv2
that forwards it, does it OK.

The TO/From headers in my scenario are the same as the initial request in
both servers (there are 2 legs for each call (incoming and outgoing), on
each leg i use the same initial headers.Ii hope i was more clear now.

Thanks,

Uri

On Thu, Apr 25, 2013 at 2:50 PM, Klaus Darilion
<klaus.mailinglists at pernau.at> wrote:

IMO the timeout-triggered BYE should have identical From/To headers as the
initial request - otherwise it may cause issues with clients that are
strict, or rely on identical headers (like in your setup).

regards
Klaus 

On 25.04.2013 13 <tel:25.04.2013%2013> :30, Uri Shacked wrote:

Hi,

Following this issue, and the issue "BYE dialog timeout bad syntax" from
Julia.

I have 2 kamailio servers. srv1 creates a dlg_timeout BYE and sends it
to srv2 that forwards the BYE to the next sip server (some other server...).

I can definitely see that the BYE that is being forward is malformed.
The TO header info is not complete (the port section for example).

When a "normal" bye is received from srv1 (not dlg_timeout) all works fine.

One thing that i do in this scenario, on srv2 i use uac_replace() on the
TO header. So, it is OK that the final destination is different (i do
translations).

I attached the BYE from both servers.

Any ideas?

Thanks,

Uri

You probably meant the To and From headers, I'm guessing. Yeah, as long
as there is no display name component, URIs in headers like that don't
have to go in <>s. The way Kamailio sends it is grammatically valid, per
RFC 3261. The user agents are at fault for not understanding it
correctly. Alex Balashov <abalashov at evaristesys.com

<http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users>> wrote:
 >/"BYE headers"? Which headers? />//>/Uri Shacked <ushacked at
gmail.com
<http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users>> wrote:
/>//>>/Hi, />>//>>/I think there is a bug with the BYE that is sent to
the caller and />>/callee />>/when dialog timeout happends. />>//>>/The
BYE headers are sent with no "<" or ">". />>/So, some sip singaling
points decline the BYE. />>//>>/BR, />>/Uri
/>>//>>//>>/----------------------------------------------------------------
--------
/>>//>>/_______________________________________________ />>/SIP Express
Router (SER) and Kamailio (OpenSER) - sr-users mailing />/list
/>>/sr-users at lists.sip-router.org
<http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users>
/>>/http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
/>//>/-- />/Sent from my mobile, and thus lacking in the refinement one
might />/expect from a fully-fledged keyboard. />//>/Alex Balashov -
Principal />/Evariste Systems LLC />/235 E Ponce de Leon Ave />/Suite
106 />/Decatur, GA 30030 />/United States />/Tel: +1-678-954-0670
<tel:%2B1-678-954-0670> 
/>/Web: http://www.evaristesys.com/, http://www.alexbalashov.com/
/>//>/_______________________________________________ />/SIP Express
Router (SER) and Kamailio (OpenSER) - sr-users mailing list />/sr-users
at lists.sip-router.org
<http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users>
/>/http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users / -- 

Sent from my Nexus 10, with all the figments of autocorrect that might
imply. Alex Balashov - Principal Evariste Systems LLC 235 E Ponce de
Leon Ave Suite 106 Decatur, GA 30030 United States Tel: +1-678-954-0670
<tel:%2B1-678-954-0670> 
Web: http://www.evaristesys.com/, http://www.alexbalashov.com/
-------------- next part -------------- An HTML attachment was
scrubbed... URL:
<http://lists.sip-router.org/pipermail/sr-users/attachments/20130422/0c75272
2/attachment.html>

_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list

sr-users at lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users

_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users at lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda <http://twitter.com/#%21/miconda>  -
http://www.linkedin.com/in/miconda

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda <http://twitter.com/#%21/miconda>  -
http://www.linkedin.com/in/miconda

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Training, San Francisco, USA - June 24016, 2013
  * http://asipto.com/u/katu *
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-users/attachments/20131110/9c606299/attachment-0001.html>