[SR-Users] sdpops and dynamic codec ids

[Juha Heinanen]

Daniel-Constantin Mierla writes:

> I committed on master branch the code for support of dynamic codecs ids:
> 
> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=511dc62e6a6ca74324f42b66a23bd9d80b377252
> 
> I tested and seemed ok, but could try many options, so if you can give 
> it a try as well would be good before backporting. I may be offline due 
> to traveling, so if all ok and you need it in 3.2 quickly, feel free to 
> cherry pick it to stable branch.

daniel,

i gave it a try and got crash when sdp_keep_codecs_by_name() was called
on subscribe request that didn't contain body.

-- juha

(gdb) where
#0  get_sdp_session_sdp (sdp=0x0, session_num=0) at parser/sdp/sdp.c:260
#1  0xb6e0424d in sdpops_sdp_get_ids_by_name (sdp=0x0, cname=0xbf9ea0f0, 
    cid=0xbf9ea0e8) at sdpops_data.c:154
#2  0xb6e0450f in sdpops_build_ids_list (sdp=0x0, names=0xbf9ea1a8, 
    ids=0xbf9ea158) at sdpops_data.c:213
#3  0xb6e064ba in sdp_keep_codecs_by_name (msg=0xb7426920, codecs=0xbf9ea1a8)
    at sdpops_mod.c:494
#4  0xb6e066b4 in w_sdp_keep_codecs_by_name (msg=0xb7426920, 
    codecs=0xb75b0860 "@\215(\267 ", bar=0x0) at sdpops_mod.c:523
#5  0x0805b309 in do_action (h=0xbf9ea478, a=0xb7289ce0, msg=0xb7426920)
    at action.c:1122
#6  0x08062016 in run_actions (h=0xbf9ea478, a=0xb7287bd0, msg=0xb7426920)
    at action.c:1610
#7  0x080622c4 in run_top_route (a=0xb7287bd0, msg=0xb7426920, c=0x0)
    at action.c:1683
#8  0x080b5785 in receive_msg (
    buf=0xb49fb770 "SUBSCRIBE sip:test at test.fi SIP/2.0\r\nVia: SIP/2.0/TCP 192.98.102.10:5074;rport;branch=z9hG4bKwgssaikv\r\nMax-Forwards: 69\r\nTo: <sip:test at test.fi>\r\nFrom: \"Juha Heinanen\" <sip:jh at test.fi>;tag=hdatd\r\nCall-I"..., len=422, rcv_info=0xb49fb5c4) at receive.c:206
#9  0x0811c47a in tcp_read_req (con=0xb49fb5b0, bytes_read=0xbf9ea738, 
    read_flags=0xbf9ea734) at tcp_read.c:978
#10 0x0811df68 in handle_io (fm=<value optimized out>, 
    events=<value optimized out>, idx=<value optimized out>)
    at tcp_read.c:1150
#11 0x0811f881 in io_wait_loop_epoll (unix_sock=39) at io_wait.h:1092
#12 tcp_receive_loop (unix_sock=39) at tcp_read.c:1319
#13 0x080fa747 in tcp_init_children () at tcp_main.c:4827
#14 0x08093b57 in main_loop () at main.c:1697
#15 0x080950ae in main (argc=17, argv=0xbf9eaac4) at main.c:2508