[SR-Users] sdpops and dynamic codec ids

[Daniel-Constantin Mierla]

Hello,

I committed on master branch the code for support of dynamic codecs ids:

http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=511dc62e6a6ca74324f42b66a23bd9d80b377252

I tested and seemed ok, but could try many options, so if you can give 
it a try as well would be good before backporting. I may be offline due 
to traveling, so if all ok and you need it in 3.2 quickly, feel free to 
cherry pick it to stable branch.

Thanks,
Daniel


On 10/22/11 8:25 PM, Daniel-Constantin Mierla wrote:
> Hello,
>
> Right now is working only for non-dynamic codecs ids, indeed. There 
> was a bug in the sdp parser that prevented implementing it in the 
> first place, but when I fixed that before the 3.2.0 release, I forgot 
> about this one. I will try to add it asap.
>
> Cheers,
> Daniel
>
> On 10/22/11 3:20 PM, Juha Heinanen wrote:
>> i made call sdp_keep_codecs_by_name("PCMU,PCMA,speex"); on an invite
>> request and it didn't keep speex although it was in the sdp:
>>
>>          Session Description Protocol
>>              Session Description Protocol Version (v): 0
>>              Owner/Creator, Session Id (o): sems 1 1 IN IP4 
>> 192.98.102.10
>>              Session Name (s): sems
>>              Connection Information (c): IN IP4 192.98.102.10
>>              Time Description, active time (t): 0 0
>>              Media Description, name and address (m): audio 40000 
>> RTP/AVP 101 102 8 0 3 2 9 96 97 98 99 100
>>              Media Attribute (a): rtpmap:101 iLBC/8000
>>              Media Attribute (a): rtpmap:102 speex/8000
>>              Media Attribute (a): rtpmap:8 PCMA/8000
>>              Media Attribute (a): rtpmap:0 PCMU/8000
>>              Media Attribute (a): rtpmap:3 GSM/8000
>>              Media Attribute (a): rtpmap:2 G721/8000
>>              Media Attribute (a): rtpmap:9 g722/8000
>>              Media Attribute (a): rtpmap:96 telephone-event/8000
>>              Media Attribute (a): rtpmap:97 G726-32/8000
>>              Media Attribute (a): rtpmap:98 G726-24/8000
>>              Media Attribute (a): rtpmap:99 G726-40/8000
>>              Media Attribute (a): rtpmap:100 G726-16/8000
>>
>> it is so that sdpops module does not support codecs, whose ids are
>> dynamic, but only codecs with static ids?
>>
>> -- juha
>>
>> _______________________________________________
>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
>> sr-users at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
>

-- 
Daniel-Constantin Mierla -- http://www.asipto.com
Kamailio Advanced Training, Dec 5-8, Berlin: http://asipto.com/u/kat
http://linkedin.com/in/miconda -- http://twitter.com/miconda