[Users] lcr: load_gws(): from_uri to large

[Papadopoulos Georgios]

Hi Juha,

Exactly this is my point, 128 should work and 129 should fail,
especially since all related char buffers are allocated properly with
size [MAX_FROM_URI_LEN+1]

I think that the bug is here:
    if (from_uri.len < MAX_FROM_URI_LEN) {
        strncpy(from_uri_str, from_uri.s, from_uri.len);
        from_uri_str[from_uri.len] = '\0';
    } else {
        LOG(L_ERR, "load_gws(): from_uri to large\n");
        return -1;
    }

It should be 
    if (from_uri.len <= MAX_FROM_URI_LEN) 
 
George


> -----Original Message-----
> From: Juha Heinanen [mailto:jh at tutpro.com] 
> Sent: Monday, May 07, 2007 5:44 PM
> To: Papadopoulos Georgios
> Cc: users at openser.org
> Subject: [Users] lcr: load_gws(): from_uri to large
> 
> Papadopoulos Georgios writes:
> 
>  > I get the following error from lcr module  > load_gws(): 
> from_uri to large  > This happens when the rpid is exactly 
> 128 characters long. If I make it  > 127 long it works fine. 
> This is on the 1.1.x branch. Has anyone else  > noticed this?
> 
> MAX_FROM_URI_LEN constant is defined as
> 
>  >  #define MAX_FROM_URI_LEN 128
> 
> i can change that to 256.
> 
> -- juha
> 

Disclaimer
The information in this e-mail and any attachments is confidential. It is intended solely for the attention and use of the named addressee(s). If you are not the intended recipient, or person responsible for delivering this information to the intended recipient, please notify the sender immediately. Unless you are the intended recipient or his/her representative you are not authorized to, and must not, read, copy, distribute, use or retain this message or any part of it. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses.