[Serusers] Patch for RTPProxy (original C version) to support RTCP

[Maxim Sobolev]

I've crafted patch to support RTCP in addition to RTP, please test and 
let me know if it works or not. This should solve the problem with X-Lite.

http://www.portaone.com/~sobomax/rtpproxy.rtcp.diff

Thanks!

-Maxim

Klaus Darilion wrote:

> Short summary:
> 
> Maxim's rtpproxy and x-light causes problems as x-light sends RTCP
> messages which will result in ICMP error messages as rtpproxy doesn't
> support RTCP. This causes x-light to create a new RTP session (new ssrc,
> seq-nr) and produces choppy sound.
> 
> Solutions:
> 1. use Adrians RTP proxy as it supports RTCP
> 2. extend Maxims rtpproxy to support RTCP
> 
> 3. THE EASIEST SOLUTION: Update X-light to version build 1095. This
> version ignores ICMP errors and works fine (on my PC)!
> 
> regards,
> Klaus
> 
> PS: nevertheless build 1095 (as 1088) is IMO buggy as it doesn't
> register to my default proxy, but to all other configured proxies. Any
> solutions?
> 
> 
>>-----Original Message-----
>>From: Maxim Sobolev [mailto:sobomax at portaone.com] 
>>Sent: Wednesday, December 10, 2003 5:56 PM
>>To: Ricardo Villa
>>Cc: Klaus Darilion; Jan Janak; Adrian Georgescu; serusers at lists.iptel.org
>>Subject: Re: [Serusers] Re: Xten-RTPProxy choppy audio
>>
>>
>>Ok, I see, probably it tries to send a RTCP packet, which is OK by 
>>itself, but handles resulting ICMP in a strange way. I'll extend RTP 
>>proxy to make it relaying RTCP traffic as well (I am having 
>>it on a TODO 
>>list for a quite some time now), which should fix this problem.
>>
>>Thank you for the debugging!
>>
>>In the meantime, disabling RTCP in X-Ten should solve the problem.
>>
>>-Maxim
>>
>>Ricardo Villa wrote:
>>
>>
>>>I can confirm this too.  Just tried it in our lab with the 
>>
>>exact same
>>
>>>results as Klaus.  (Instead of Budgetone I used ATA186).
>>>
>>>X-Lite build 1084
>>>
>>>1.  ATA186 Calls Xten.
>>>2.  Xten hears choppy audio every 5 seconds or so.
>>>3.  RTP Stream from ATA to Xten is perfect and conserves 
>>
>>the same SSRC
>>
>>>4.  RTP Stream from Xten to ATA switches to a new SSRC 
>>
>>every few seconds.
>>
>>>It is clear to me that there is a bug in Xten software.  Before Xten
>>>switches to a new SSRC it attempts to send an RTP packet to 
>>
>>the wrong RTP
>>
>>>Port (it tries to the actual port +1).   SER server sends 
>>
>>back "ICMP Port
>>
>>>Unreacheable (Obviously)" and Xten restarts RTP Stream on a 
>>
>>new SSRC.
>>
>>>I did not see any problem with Maxims RTPProxy.
>>>
>>>Regards,
>>>Ricardo
>>>
>>>----- Original Message ----- 
>>>From: "Klaus Darilion" <darilion at ict.tuwien.ac.at>
>>>To: "Jan Janak" <janak at fokus.fraunhofer.de>; "Adrian Georgescu"
>>><ag at ag-projects.com>
>>>Cc: <serusers at lists.iptel.org>; "Ricardo Villa" <ricvil at epm.net.co>
>>>Sent: Wednesday, December 10, 2003 11:07 AM
>>>Subject: RE: [Serusers] Re: Xten-RTPProxy choppy audio
>>>
>>>
>>>I can reproduce the choppy audio
>>>setup:
>>>budgetone-100 <----> ser+rtpproxy(version from today) on 
>>
>>redhat 9 (or 8,
>>
>>>not sure) <------>x-lite build 1088 on win xp
>>>
>>>the choppy sound occours every 5 seconds, in both directions.
>>>RTP-analysis:
>>>RTP stream from budgetone to x-lite (via rtpproxy) is fine 
>>
>>(no jitter,
>>
>>>no loss)
>>>RTP stream from x-lite to budgetone (via rtpproxy): very 
>>
>>strange: x-lite
>>
>>>switches to a new SSRC (and seq-nr. start at 0 again) every 
>>
>>5 seconds.
>>
>>>so, in my opinion: rtpproxy works fine, x-lite is guilty. 
>>
>>but why does
>>
>>>this happen only if the rtp proxy is involved? ...further 
>>
>>investigations
>>
>>>are planned...
>>>
>>>Klaus
>>>
>>>
>>>
>>>>-----Original Message-----
>>>>From: Jan Janak [mailto:janak at fokus.fraunhofer.de]
>>>>Sent: Wednesday, December 10, 2003 4:09 PM
>>>>To: Adrian Georgescu
>>>>Cc: serusers at lists.iptel.org; Ricardo Villa
>>>>Subject: Re: [Serusers] Re: Xten-RTPProxy choppy audio
>>>>
>>>>
>>>>Well, we can generate the traces locally, but I haven't 
>>
>>encounter the
>>
>>>>problem you describe so it makes no sense.
>>>>
>>>>You wrote you are able to reproduce the problem, in that 
>>
>>case I would
>>
>>>>like to ask you to generate the traces that show the problem
>>>>so we could
>>>>analyze and fix it.
>>>>
>>>>Also please tell us on what OS does this happen ? (I mean the
>>>>OS the proxy
>>>>is running on).
>>>>
>>>>Another question, what is the license of your RTP proxy ? I
>>>>didn't find
>>>>any licensing info in the sources. Will the sources be available ?
>>>>
>>>>Jan.
>>>>
>>>>On 10-12 16:04, Adrian Georgescu wrote:
>>>>
>>>>
>>>>>On Wednesday, Dec 10, 2003, at 15:48 Europe/Amsterdam,
>>>>
>>>>Ricardo Villa
>>>>
>>>>
>>>>>wrote:
>>>>>
>>>>>
>>>>>
>>>>>>Adrian,
>>>>>>
>>>>>>Do you have an Etheral trace trace of such a call (using G711)?
>>>>>
>>>>>I guess  ethereal traces can be generated with ethereal program and
>>>>>decoded locally on your servers if you want to isolate this.
>>>>>
>>>>>
>>>>>
>>>>>>I can
>>>>>>decode it and produce an audio file for all to examine.
>>>>
>>>>This way we
>>>>
>>>>
>>>>>>can get
>>>>>>to the bottom of this.
>>>>>>Thanks,
>>>>>>Ricardo
>>>>>
>>>>>_______________________________________________
>>>>>Serusers mailing list
>>>>>serusers at lists.iptel.org
>>>>>http://lists.iptel.org/mailman/listinfo/serusers
>>>>
>>>>_______________________________________________
>>>>Serusers mailing list
>>>>serusers at lists.iptel.org
>>>>http://lists.iptel.org/mailman/listinfo/serusers
>>>>
>>>>
>>>
>>>
>>>
>>>
>>>
>>>_______________________________________________
>>>Serusers mailing list
>>>serusers at lists.iptel.org
>>>http://lists.iptel.org/mailman/listinfo/serusers
>>>
>>>
>>>
>>
>>
>>
> 
> 
>