[sr-dev] [kamailio/kamailio] stirshaken: Properly handle intermediary/chain certificates when caching certificates (PR #3289)

mrtrev notifications at github.com
Wed Nov 30 22:50:51 CET 2022


stirshaken: Properly handle intermediary/chain certificates when caching certificates
- requires patch to libstirshaken (https://github.com/signalwire/libstirshaken/pull/124) to do anything
- if patched version of libstirshaken detected, uses new methods to store all intermediary certs
- unrelated minor logging tweaks

<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->

The guts of this PR have been submitted to the libstirshaken side based on the suggestions of my previous PR.  I didn't mean to close it but since I hadn't created a branch, it got closed when I updated my repo.  Original PR is https://github.com/kamailio/kamailio/pull/3175

I've been running this in production for a day and it seems to be performing the same as my previous attempt.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3289

-- Commit Summary --

  * stirshaken: Properly handle intermediary/chain certificates when caching certificates

-- File Changes --

    M src/modules/stirshaken/stirshaken_mod.c (24)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3289.patch
https://github.com/kamailio/kamailio/pull/3289.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3289
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3289 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20221130/b497226a/attachment.htm>


More information about the sr-dev mailing list