<p dir="auto">stirshaken: Properly handle intermediary/chain certificates when caching certificates</p>
<ul dir="auto">
<li>requires patch to libstirshaken (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1469285582" data-permission-text="Title is private" data-url="https://github.com/signalwire/libstirshaken/issues/124" data-hovercard-type="pull_request" data-hovercard-url="/signalwire/libstirshaken/pull/124/hovercard" href="https://github.com/signalwire/libstirshaken/pull/124">signalwire/libstirshaken#124</a>) to do anything</li>
<li>if patched version of libstirshaken detected, uses new methods to store all intermediary certs</li>
<li>unrelated minor logging tweaks</li>
</ul>
<h4 dir="auto">Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code class="notranslate">doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4 dir="auto">Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4 dir="auto">Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4 dir="auto">Description</h4>
<p dir="auto">The guts of this PR have been submitted to the libstirshaken side based on the suggestions of my previous PR. I didn't mean to close it but since I hadn't created a branch, it got closed when I updated my repo. Original PR is <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1292169576" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/3175" data-hovercard-type="pull_request" data-hovercard-url="/kamailio/kamailio/pull/3175/hovercard" href="https://github.com/kamailio/kamailio/pull/3175">#3175</a></p>
<p dir="auto">I've been running this in production for a day and it seems to be performing the same as my previous attempt.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/3289'>https://github.com/kamailio/kamailio/pull/3289</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/kamailio/kamailio/pull/3289/commits/e3d43e3d20cc973b6df3a2636cdcbf1a2410917b" class="commit-link">e3d43e3</a> stirshaken: Properly handle intermediary/chain certificates when caching certificates</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/kamailio/kamailio/pull/3289/files">1 file</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3289/files#diff-e2bdb676bbb1456de7002f2a41ae0cc631b2c4724e7c9f54eb3f6106a5972cb2">src/modules/stirshaken/stirshaken_mod.c</a>
(24)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/3289.patch'>https://github.com/kamailio/kamailio/pull/3289.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/3289.diff'>https://github.com/kamailio/kamailio/pull/3289.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3289">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZJ6SSWK2XKF7KANN6DWK7D3XANCNFSM6AAAAAASQDBAAY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZKKY7AM2MHKZHHXNULWK7D3XA5CNFSM6AAAAAASQDBAA2WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFPITIGA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3289</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3289",
"url": "https://github.com/kamailio/kamailio/pull/3289",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>