[sr-dev] [kamailio/kamailio] pv_headers: fix possible mem. overflow issue and wrong size string (PR #3095)

[Tomohare]

@Tomohare commented on this pull request.



>  
 	if (result == NULL || t == NULL)
 	{
 		PKG_MEM_ERROR;
 		goto clean;
 	}
 
-	snprintf(result, elements->len - toRemove->len, "%*s", elements->len - toRemove->len, "");
-	snprintf(t, elements->len+1, "%s", elements->s);
+	memset(result, 32, elements->len - toRemove->len);

Yes, here this is strange. No need of this line entirely.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3095#discussion_r861896135
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3095/review/957877493 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20220429/b00cc0ab/attachment.htm>