<p></p>
<p><b>@Tomohare</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/kamailio/kamailio/pull/3095#discussion_r861896135">src/modules/pv_headers/pvh_func.c</a>:</p>
<pre style='color:#555'>>
if (result == NULL || t == NULL)
{
PKG_MEM_ERROR;
goto clean;
}
- snprintf(result, elements->len - toRemove->len, "%*s", elements->len - toRemove->len, "");
- snprintf(t, elements->len+1, "%s", elements->s);
+ memset(result, 32, elements->len - toRemove->len);
</pre>
<p dir="auto">Yes, here this is strange. No need of this line entirely.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3095#discussion_r861896135">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZMGLGW6BXRUC4GKYWLVHP3L5ANCNFSM5URXK77Q">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZKOBE2AWQNT7QPUZ7TVHP3L5A5CNFSM5URXK772YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHEMAZ5I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3095/review/957877493</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3095#discussion_r861896135",
"url": "https://github.com/kamailio/kamailio/pull/3095#discussion_r861896135",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>