[sr-dev] [kamailio/kamailio] sipt: added one function and 8 pseudo-variables (#2841)

[MikhailKalashnikov]

@MikhailKalashnikov commented on this pull request.



> @@ -102,10 +115,30 @@ static sipt_header_map_t sipt_header_mapping[] =
 		{{"CHARGE_INDICATOR", 1}, 
 			{NULL, 0}
 		}},
-        {"REDIRECTION_INFO", ISUP_PARM_REDIRECTION_INFO, 
-                {{NULL, 0}}  },
-        {"REDIRECTION_NUMBER", ISUP_PARM_REDIRECTION_NUMBER, 
-            		{{"NATURE_OF_ADDRESS", 1}, 
+	{"REDIRECTION_INFO", ISUP_PARM_DIVERSION_INFORMATION,

This existing "REDIRECTION_INFO" actually gets information from diversion info (ISUP_PARM_DIVERSION_INFORMATION) and not from redirection info header (ISUP_PARM_REDIRECTION_INFO).
So this old name is incorrect. It would be better to rename the old "REDIRECTION_INFO" to "DIVERSION_INFO". 
But it will break existing behavior. If someone uses this old "REDIRECTION_INFO" he will get wrong results.
So I did not change existing behavior, only corrected documentation of "REDIRECTION_INFO"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2841#discussion_r705987598
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210910/5ea301cd/attachment.htm>