<p></p>
<p><b>@MikhailKalashnikov</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/kamailio/kamailio/pull/2841#discussion_r705987598">src/modules/sipt/sipt.c</a>:</p>
<pre style='color:#555'>> @@ -102,10 +115,30 @@ static sipt_header_map_t sipt_header_mapping[] =
{{"CHARGE_INDICATOR", 1},
{NULL, 0}
}},
- {"REDIRECTION_INFO", ISUP_PARM_REDIRECTION_INFO,
- {{NULL, 0}} },
- {"REDIRECTION_NUMBER", ISUP_PARM_REDIRECTION_NUMBER,
- {{"NATURE_OF_ADDRESS", 1},
+ {"REDIRECTION_INFO", ISUP_PARM_DIVERSION_INFORMATION,
</pre>
<p>This existing "REDIRECTION_INFO" actually gets information from diversion info (ISUP_PARM_DIVERSION_INFORMATION) and not from redirection info header (ISUP_PARM_REDIRECTION_INFO).<br>
So this old name is incorrect. It would be better to rename the old "REDIRECTION_INFO" to "DIVERSION_INFO".<br>
But it will break existing behavior. If someone uses this old "REDIRECTION_INFO" he will get wrong results.<br>
So I did not change existing behavior, only corrected documentation of "REDIRECTION_INFO"</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2841#discussion_r705987598">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZM4EHFVZZLGAG7Q6HLUBG47DANCNFSM5DIVV5TQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABO7UZI6J5YRP4S5L74MERDUBG47DA5CNFSM5DIVV5T2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFTC4O4A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2841#discussion_r705987598",
"url": "https://github.com/kamailio/kamailio/pull/2841#discussion_r705987598",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>