[sr-dev] [kamailio/kamailio] time: add support for time64 libc (PR #2894)

micmac1 notifications at github.com
Wed Oct 27 23:50:36 CEST 2021


> Maybe to make it shorter a bit, the `TIME_T_INT_FMT` can be renamed to
> `TIME_T_FMT` if does not conflict with an existing macro, I don't see
> a reason to have INT inside the name because it is about the format
> for printing a `time_t` value.
>
> This rename can be done later, after merging this PR.

Hello Daniel,

Thanks for the feedback. I can change the definition name if you want,
no problem.

Currently I'm finding out the hard way (with another software) that
fixing the new warnings may not be enough, the application may still not
work right on 32 bit computers. I didn't run-test kamailio yet, so it
may be OK or maybe it's not. But the commit message "promise" ("add
support for time64 libc") may be promising too much :) We'll see.

Kind regards,
Seb


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2894#issuecomment-953337483
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20211027/6149e6d0/attachment-0001.htm>


More information about the sr-dev mailing list