[sr-dev] [kamailio/kamailio] acc: increase extra and cdr variables (PR #2891)

Daniel-Constantin Mierla notifications at github.com
Wed Oct 27 13:29:28 CEST 2021


@miconda commented on this pull request.



> @@ -61,9 +60,9 @@ extern struct acc_extra *db_extra;
 /* arrays used to collect the values before being
  * pushed to the storage backend (whatever used)
  * (3 = datetime + max 2 from time_mode) */
-static str val_arr[ACC_CORE_LEN+MAX_ACC_EXTRA+MAX_ACC_LEG+3];
-static int int_arr[ACC_CORE_LEN+MAX_ACC_EXTRA+MAX_ACC_LEG+3];
-static char type_arr[ACC_CORE_LEN+MAX_ACC_EXTRA+MAX_ACC_LEG+3];
+str *val_arr;
+int *int_arr;
+char *type_arr;
 

These pointers must be initialized to `NULL` so mod_destroy() does not end up crashing if mod_init() is not executed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2891#pullrequestreview-790505646
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20211027/4e0929b0/attachment-0001.htm>


More information about the sr-dev mailing list