<p></p>
<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2891#discussion_r737370336">src/modules/acc/acc.c</a>:</p>
<pre style='color:#555'>> @@ -61,9 +60,9 @@ extern struct acc_extra *db_extra;
 /* arrays used to collect the values before being
  * pushed to the storage backend (whatever used)
  * (3 = datetime + max 2 from time_mode) */
-static str val_arr[ACC_CORE_LEN+MAX_ACC_EXTRA+MAX_ACC_LEG+3];
-static int int_arr[ACC_CORE_LEN+MAX_ACC_EXTRA+MAX_ACC_LEG+3];
-static char type_arr[ACC_CORE_LEN+MAX_ACC_EXTRA+MAX_ACC_LEG+3];
+str *val_arr;
+int *int_arr;
+char *type_arr;
 
</pre>
<p>These pointers must be initialized to <code>NULL</code> so mod_destroy() does not end up crashing if mod_init() is not executed.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2891#pullrequestreview-790505646">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKBQPSYJDNDE7I5A5LUI7WCRANCNFSM5GNRVCXA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABO7UZMO7QASDGWJZEPA44LUI7WCRA5CNFSM5GNRVCXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOF4PCRLQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2891#pullrequestreview-790505646",
"url": "https://github.com/kamailio/kamailio/pull/2891#pullrequestreview-790505646",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>