[sr-dev] [kamailio/kamailio] TSILO / TM. Lookup and branch creating by contact (location record). (PR #2931)

Henning Westerholt notifications at github.com
Sat Nov 13 21:48:53 CET 2021


Thank you for the pull request. Just one comment for the tm extension - this is really a lot of duplicated and non-trivial code for this particular function, which doubles maintenance tasks for bug fixes etc.. I assume the difference between the two functions (t_append_branch, t_append_branch_by_contact) is rather small? I would suggest move the common parts to one new function, and then call it from the old and the new one.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2931#issuecomment-968133824
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20211113/9daa349b/attachment.htm>


More information about the sr-dev mailing list