[sr-dev] [kamailio/kamailio] Fix ip parsing in ipops (#2695)

Nathan notifications at github.com
Mon Mar 29 00:17:04 CEST 2021


#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #2645

#### Description
For #2645, a patch was pushed in 47b45b60a037808a675f7d52dd5b2ee80bfe0868, but this code does not correctly check the return value of `str2ip6buf` and `str2ipbuf`.

As described in the comments on both methods, they return zero *for success*.

This MR should be backported to 5.4 as well.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2695

-- Commit Summary --

  * Fix ip parsing in ipops

-- File Changes --

    M src/modules/ipops/ipops_mod.c (4)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2695.patch
https://github.com/kamailio/kamailio/pull/2695.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2695
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20210328/4e9e04f9/attachment-0001.htm>


More information about the sr-dev mailing list